Re: [Outreachy kernel] [PATCH 1/3] staging: mt7621-mmc: remove unnecessary braces from 'if' statements

[Vaishali Thakkar <vthakkar1994@gmail.com>]

On Wed, Oct 3, 2018 at 1:47 AM Vaishali Thakkar <vthakkar1994@gmail.com> wrote:
>
> On Wed, Oct 3, 2018 at 1:35 AM Himanshu Jha <himanshujha199640@gmail.com> wrote:
> >
> > > > Hi, I choose the CONFIG_PCI option, it did solve the undefined symbols,
> > > but the file still does not compile starting with the error:
> > >
> > > drivers/staging/mt7621-pci/pci-mt7621.c:496:27: error: ‘port’ undeclared
> > > (first use in this function); did you mean ‘ror8’?
> > >   list_for_each_entry_safe(port, tmp, &pcie->ports, list) {
> > >
> > > I saw that in other usages of list_for_each_entry_safe, the first parameter
> > > is a local variable.
> >
> > Correct! Both port & tmp should be a local variable of the same object
> > type.
> >
> > > > > Then in run "make menuconfig" again and under "Device Drivers -> staging
> > > > > drivers" I chose "MediaTek MT7621 PCI Controller"
> > > > > Hoping it will solve it , but it didn't.
> > > > >
> > > > > The files I prepared the patchset for did compile ok , is it important
> > > > that
> > > > > all files will compile?
> > > >
> > > > I think for these changes just use that .config supplied by the distro
> > > > at /boot/config-*
> > > >
> > > > But IIRC `make allyesconfig` should be used(not sure though..)
> > > >
> > >
> > > But I compile on ubuntu on x86 and I want to compile to a specific mips SoC.
> > > I tried it anyway and it did not compile the file  I prepared the patch for
> > > (drivers/staging/mt7621-mmc/sd.c)
> >
> > Cool!
> > You found a bug while cross-compiling for MIPS which would not
> > show up on x86.
> >
> > Btw, the Cc list should contain developers who might give you
> > a better feedback. Therefore, use `get_maintainer` to list all
> > those people.
>
> Hi Himanshu,
>
> For Outreachy applicants, we usually do not advice to use 'get_maintainer.pl'
> when it comes to sending cleanup patches and contributions to staging drivers
> [unless driver specific maintainers have asked for that].

Sorry Himanshu, I missed that it's been changed in the process for applicants.
So, now driver maintainers need to be cc'ed and need to opt out if they don't
want patches coming from Outreachy mailing list. Sorry about the earlier
correction.

Dafna,

Himanshu is right. We have this text in the tutorial:

"News This year, we ask that you send all patches to the appropriate
staging driver maintainers, as well as to the outreachy mailing list. See
Submit a patch for more information. For IIO patches, be sure to send them
to linux-iio@vger.kernel.org"

> >
> > --
> > Himanshu Jha
> > Undergraduate Student
> > Department of Electronics & Communication
> > Guru Tegh Bahadur Institute of Technology
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20181002200507.GA26645%40himanshu-Vostro-3559.
> > For more options, visit https://groups.google.com/d/optout.
>
>
>
> --
> Vaishali
> http://vaishalithakkar.in/



-- 
Vaishali
http://vaishalithakkar.in/