All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julia Lawall <julia.lawall@lip6.fr>
To: Dafna Hirschfeld <dafna3@gmail.com>
Cc: Himanshu Jha <himanshujha199640@gmail.com>,
	gregkh@linuxfoundation.org,  outreachy-kernel@googlegroups.com,
	hdegoede@redhat.com, john@phrozen.org
Subject: Re: [Outreachy kernel] [PATCH 1/3] staging: mt7621-mmc: remove unnecessary braces from 'if' statements
Date: Wed, 3 Oct 2018 21:00:44 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.21.1810032100040.2527@hadrien> (raw)
In-Reply-To: <CAJ1myNRF+1S=epCMJxUa1YrdPK4p80CiPn2FDdqw5mnwTq+mQA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1697 bytes --]



On Wed, 3 Oct 2018, Dafna Hirschfeld wrote:

>
>
> On Wed, Oct 3, 2018 at 7:06 AM Julia Lawall <julia.lawall@lip6.fr> wrote:
>       > > Then in run "make menuconfig" again and under "Device
>       Drivers -> staging
>       > > drivers" I chose "MediaTek MT7621 PCI Controller"
>       > > Hoping it will solve it , but it didn't.
>       > >
>       > > The files I prepared the patchset for did compile ok , is it
>       important that
>       > > all files will compile?
>       >
>       > I think for these changes just use that .config supplied by
>       the distro
>       > at /boot/config-*
>       >
>       > But IIRC `make allyesconfig` should be used(not sure though..)
>
>       Dafna,
>
>       It is important that the driver continues to compile.
>
> Hi,
> Fixing the compilation error in drivers/staging/mt7621-pci/pci-mt7621.c is
> not triveal,
> It is not clear what type `port` and `tmp` should be.

pcie has a type.  I think it is possible to figure it out from there.  YOu
can also see how port is used, for confirmation.

julia

>  
> Dafna
>
>       Make allyesconfig is often a good option.
>
>       julia
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/CAJ1myNRF%2B1S%3DepCMJxU
> a1YrdPK4p80CiPn2FDdqw5mnwTq%2BmQA%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
>

  reply	other threads:[~2018-10-03 19:01 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-30 19:04 [PATCH 0/3] *** Cleanup patches for mt7621-mmc staging driver *** Dafna Hirschfeld
2018-09-30 19:04 ` [PATCH 1/3] staging: mt7621-mmc: remove unnecessary braces from 'if' statements Dafna Hirschfeld
2018-09-30 20:18   ` [Outreachy kernel] " Julia Lawall
2018-10-01  7:57     ` Dafna Hirschfeld
2018-10-01  8:47       ` Julia Lawall
2018-10-02  8:24         ` Dafna Hirschfeld
2018-10-02  9:28           ` Himanshu Jha
2018-10-02  9:39             ` Julia Lawall
2018-10-03 18:10               ` Dafna Hirschfeld
2018-10-03 19:00                 ` Julia Lawall [this message]
2018-10-03 19:36                   ` Dafna Hirschfeld
2018-10-03 19:40                     ` Julia Lawall
2018-10-02 15:31             ` Dafna Hirschfeld
2018-10-02 20:05               ` Himanshu Jha
2018-10-02 20:17                 ` Vaishali Thakkar
2018-10-02 20:56                   ` Vaishali Thakkar
2018-10-02 20:24                 ` Julia Lawall
2018-09-30 19:04 ` [PATCH 2/3] staging: mt7621-mmc: Fix comparison to NULL Dafna Hirschfeld
2018-09-30 19:04 ` [PATCH 3/3] staging: mt7621-mmc: replace `printk` with preferred API Dafna Hirschfeld

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.1810032100040.2527@hadrien \
    --to=julia.lawall@lip6.fr \
    --cc=dafna3@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hdegoede@redhat.com \
    --cc=himanshujha199640@gmail.com \
    --cc=john@phrozen.org \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.