Re: [Outreachy kernel] [PATCH 1/3] staging: mt7621-mmc: remove unnecessary braces from 'if' statements

[Dafna Hirschfeld <dafna3@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 5490 bytes --]

Hi,
Apparently, the mt7621-mmc driver is for a specific SOC based on mips,
In order to compile it I installed mips compiler:

sudo apt install gcc-mips-linux-gnu

and set:
export CROSS_COMPILE=mips-linux-gnu-
export ARCH=mips

Then I used an initial .config file
from arch/mips/configs/generic_defconfig.
In the menuconfig ,
under "Machine Selection" I choose "Ralink SoC selection (MT7621)"
under  "Device Drivers" I chose "MMC/SD/SDIO card support" as a module.
under "Device Drivers -> staging drivers" I chose "MTK SD/MMC"

Then when compiling, the files in  drivers/staging/mt7621-mmc/ compiled ok,
but I had compilation error in drivers/staging/mt7621-pci/pci-mt7621.c,
with the first error:

drivers/staging/mt7621-pci/pci-mt7621.c:195:11: error:
‘pci_generic_config_read’ undeclared here (not in a function); did you mean
‘pci_write_config_word’?
  .read  = pci_generic_config_read,
           ^~~~~~~~~~~~~~~~~~~~~~~
           pci_write_config_word


Then in run "make menuconfig" again and under "Device Drivers -> staging
drivers" I chose "MediaTek MT7621 PCI Controller"
Hoping it will solve it , but it didn't.

The files I prepared the patchset for did compile ok , is it important that
all files will compile?

Dafna



On Mon, Oct 1, 2018 at 11:47 AM Julia Lawall <julia.lawall@lip6.fr> wrote:

>
>
> On Mon, 1 Oct 2018, Dafna Hirschfeld wrote:
>
> >
> >
> > On Mon, Oct 1, 2018 at 12:55 AM Julia Lawall <julia.lawall@lip6.fr>
> wrote:
> >
> >
> >       On Sun, 30 Sep 2018, Dafna Hirschfeld wrote:
> >
> >       > Remove unnecessary braces from one line 'if' statements.
> >       > Issues found with checkpatch.pl
> >       >
> >       > Signed-off-by: Dafna Hirschfeld <dafna3@gmail.com>
> >       > ---
> >       >  drivers/staging/mt7621-mmc/sd.c | 9 +++------
> >       >  1 file changed, 3 insertions(+), 6 deletions(-)
> >       >
> >       > diff --git a/drivers/staging/mt7621-mmc/sd.c
> >       b/drivers/staging/mt7621-mmc/sd.c
> >       > index e3c1546373ba..8c32cec5950a 100644
> >       > --- a/drivers/staging/mt7621-mmc/sd.c
> >       > +++ b/drivers/staging/mt7621-mmc/sd.c
> >       > @@ -520,9 +520,8 @@ static void msdc_pm(pm_message_t state,
> >       void *data)
> >       >               host->pm_state = state;  /* default PMSG_RESUME
> >       */
> >       >
> >       >       } else if (evt == PM_EVENT_RESUME || evt ==
> >       PM_EVENT_USER_RESUME) {
> >       > -             if (!host->suspend) {
> >       > +             if (!host->suspend)
> >       >                       return;
> >       > -             }
> >       >
> >       >               /* No PM resume when USR suspend */
> >       >               if (evt == PM_EVENT_RESUME &&
> >       host->pm_state.event == PM_EVENT_USER_SUSPEND) {
> >       > @@ -967,16 +966,14 @@ static int msdc_do_request(struct
> >       mmc_host *mmc, struct mmc_request *mrq)
> >       >       //if(host->id==1) {
> >       >       if (send_type == SND_CMD) {
> >       >               if (cmd->opcode == MMC_SEND_STATUS) {
> >       > -                     if ((cmd->resp[0] & CARD_READY_FOR_DATA)
> >       || (CARD_CURRENT_STATE(cmd->resp[0]) != 7)) {
> >       > +                     if ((cmd->resp[0] & CARD_READY_FOR_DATA)
> >       || (CARD_CURRENT_STATE(cmd->resp[0]) != 7))
> >
> >       This line is really long.  Since you have sent a series on this
> >       code,
> >       maybe you can add in another patch to clean this up.
> >
> >       julia
> >
> >
> > So add it as a 4th patch in the patchset ?
>
> That would be fine.
>
> julia
>
> > Dafna
> >
> >       >                               msdc_gate_clock(host->id);
> >       > -                     }
> >       >               } else {
> >       >                       msdc_gate_clock(host->id);
> >       >               }
> >       >       } else {
> >       > -             if (read) {
> >       > +             if (read)
> >       >                       msdc_gate_clock(host->id);
> >       > -             }
> >       >       }
> >       >       //}
> >       >  #else
> >       > --
> >       > 2.17.1
> >       >
> >       > --
> >       > You received this message because you are subscribed to the
> >       Google Groups "outreachy-kernel" group.
> >       > To unsubscribe from this group and stop receiving emails from
> >       it, send an email to
> >       outreachy-kernel+unsubscribe@googlegroups.com.
> >       > To post to this group, send email to
> >       outreachy-kernel@googlegroups.com.
> >       > To view this discussion on the web visithttps://
> groups.google.com/d/msgid/outreachy-kernel/bf3ba7a38f000d4359c4c56f
> >       ac98f17ae3ef6a2b.1538333858.git.dafna3%40gmail.com.
> >       > For more options, visit https://groups.google.com/d/optout.
> >       >
> >
> > --
> > You received this message because you are subscribed to the Google Groups
> > "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an
> > email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visithttps://
> groups.google.com/d/msgid/outreachy-kernel/CAJ1myNR7951qEF6hpN8DRJ-
> > hmckXMOzZWnzBJWrYqdaRoPLb2g%40mail.gmail.com.
> > For more options, visit https://groups.google.com/d/optout.
> >
> >

[-- Attachment #2: Type: text/html, Size: 8650 bytes --]