Re: [PATCH v2] arm64: dts: renesas: r8a77980: add thermal support

["Niklas Söderlund" <niklas.soderlund@ragnatech.se>]

Hi Geert,

On 2018-10-11 09:02:22 +0200, Geert Uytterhoeven wrote:
> Hi Niklas,
> 
> On Thu, Oct 11, 2018 at 12:11 AM Niklas S�derlund
> <niklas.soderlund@ragnatech.se> wrote:
> > On 2018-10-10 22:18:11 +0300, Sergei Shtylyov wrote:
> > > Describe THS/CIVM in the R8A77980 device trees.
> > >
> > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> 
> > > --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> > > +++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> > > @@ -330,6 +330,19 @@
> > >                       #power-domain-cells = <1>;
> > >               };
> > >
> > > +             tsc: thermal@e6198000 {
> > > +                     compatible = "renesas,r8a77980-thermal";
> > > +                     reg = <0 0xe6198000 0 0x100>,
> > > +                           <0 0xe61a0000 0 0x100>;
> > > +                     interrupts = <GIC_SPI 67 IRQ_TYPE_LEVEL_HIGH>,
> > > +                                  <GIC_SPI 68 IRQ_TYPE_LEVEL_HIGH>,
> > > +                                  <GIC_SPI 69 IRQ_TYPE_LEVEL_HIGH>;
> > > +                     clocks = <&cpg CPG_MOD 522>;
> > > +                     power-domains = <&sysc R8A77980_PD_ALWAYS_ON>;
> > > +                     resets = <&cpg 522>;
> > > +                     #thermal-sensor-cells = <1>;
> >
> > The status property is missing but as you told me in v1 it should not
> > matter. I will leave it for Simon to decide if he wants it to keep it
> > consistent with other SoC or if we should remove it from the other dtsi
> > files. In any case with or without the status property.
> 
> Forgot to review commit c79661eb5060e2bf ("arm64: dts: renesas: Remove
> unneeded status from thermal nodes")? ;-)

Not only that also reviewing using the context from v4.19-rc1 which of 
course is not correct for dtsi patches, thanks for enlightening me :-)

-- 
Regards,
Niklas S�derlund