Re: [PATCH i-g-t 6/6] tests/plane_damage: Integrate kernel selftest test-drm_damage_helper

From: Daniel Vetter <daniel@ffwll.ch>
To: Deepak Rawat <drawat@vmware.com>
Cc: thellstrom@vmware.com, syeh@vmware.com,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	intel-gfx@lists.freedesktop.org, igt-dev@lists.freedesktop.org,
	Pekka Paalanen <ppaalanen@gmail.com>,
	linux-graphics-maintainer@vmware.com
Subject: Re: [PATCH i-g-t 6/6] tests/plane_damage: Integrate kernel selftest test-drm_damage_helper
Date: Thu, 11 Oct 2018 11:05:35 +0200	[thread overview]
Message-ID: <20181011090535.GC31561@phenom.ffwll.local> (raw)
In-Reply-To: <20181011002104.1845-6-drawat@vmware.com>

On Wed, Oct 10, 2018 at 05:21:04PM -0700, Deepak Rawat wrote:
> Call kernel selftest module test-drm_damage_helper from igt.
> 
> v2:
> - Add test alphabetically.
> - Add test to meson build.
> 
> Cc: ville.syrjala@linux.intel.com
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Pekka Paalanen <ppaalanen@gmail.com>
> Cc: Daniel Stone <daniel@fooishbar.org>
> Signed-off-by: Deepak Rawat <drawat@vmware.com>
> ---
>  tests/Makefile.sources    |  1 +
>  tests/drm_plane_damage.c  | 10 ++++++++++
>  tests/igt_command_line.sh |  2 +-
>  tests/meson.build         |  1 +
>  4 files changed, 13 insertions(+), 1 deletion(-)
>  create mode 100644 tests/drm_plane_damage.c
> 
> diff --git a/tests/Makefile.sources b/tests/Makefile.sources
> index 001f1a2b..eae5f39e 100644
> --- a/tests/Makefile.sources
> +++ b/tests/Makefile.sources
> @@ -32,6 +32,7 @@ TESTS_progs = \
>  	debugfs_test \
>  	drm_import_export \
>  	drm_mm \
> +	drm_plane_damage \
>  	drm_read \
>  	drv_getparams_basic \
>  	drv_hangman \
> diff --git a/tests/drm_plane_damage.c b/tests/drm_plane_damage.c
> new file mode 100644
> index 00000000..c2b793cc
> --- /dev/null
> +++ b/tests/drm_plane_damage.c
> @@ -0,0 +1,10 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +#include "igt.h"
> +#include "igt_kmod.h"
> +
> +IGT_TEST_DESCRIPTION("Basic sanity check of DRM's plane damage helper iterator.");
> +
> +igt_main
> +{
> +	igt_kselftests("test-drm_damage_helper", NULL, NULL, NULL);
> +}
> diff --git a/tests/igt_command_line.sh b/tests/igt_command_line.sh
> index 8285ba62..621b2cbd 100755
> --- a/tests/igt_command_line.sh
> +++ b/tests/igt_command_line.sh
> @@ -90,7 +90,7 @@ check_test ()
>  		# Subtest enumeration of kernel selftest launchers depends
>  		# on the running kernel. If selftests are not enabled,
>  		# they will output nothing and exit with 0.
> -		if [ "$testname" != "drv_selftest" -a "$testname" != "drm_mm" ]; then
> +		if [ "$testname" != "drv_selftest" -a "$testname" != "drm_mm" -a "$testname" != "drm_plane_damage" ]; then
>  			fail $test
>  		fi
>  	fi
> diff --git a/tests/meson.build b/tests/meson.build
> index 697ff515..5acd7aa2 100644
> --- a/tests/meson.build
> +++ b/tests/meson.build
> @@ -9,6 +9,7 @@ test_progs = [
>  	'debugfs_test',
>  	'drm_import_export',
>  	'drm_mm',
> +	'drm_plane_damage',

For future proofing I think it'd be much better if we call this drm_kms or
similar. The individual subtest results will be all exposed, but there's a
bit a problem when we always have to upgrade both igt and the kernel at
the same time. At least with the current CI infrastructure.

I'm also asking the ARM folks to type selftests for the new block_* format
description stuff, so this will come in handy real soon.
-Daniel

>  	'drm_read',
>  	'drv_getparams_basic',
>  	'drv_hangman',
> -- 
> 2.17.1
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx