From: Daniel Vetter <daniel@ffwll.ch> To: Daniel Vetter <daniel@ffwll.ch>, Deepak Rawat <drawat@vmware.com>, thellstrom@vmware.com, syeh@vmware.com, intel-gfx@lists.freedesktop.org, igt-dev@lists.freedesktop.org, linux-graphics-maintainer@vmware.com Subject: Re: [igt-dev] [PATCH i-g-t 1/6] lib/igt_vmwgfx: Add vmwgfx device Date: Thu, 11 Oct 2018 11:46:31 +0200 [thread overview] Message-ID: <20181011094631.GD31561@phenom.ffwll.local> (raw) In-Reply-To: <20181011091123.GN17124@platvala-desk.ger.corp.intel.com> On Thu, Oct 11, 2018 at 12:11:23PM +0300, Petri Latvala wrote: > On Thu, Oct 11, 2018 at 11:01:48AM +0200, Daniel Vetter wrote: > > On Wed, Oct 10, 2018 at 05:20:59PM -0700, Deepak Rawat wrote: > > > Add DRIVER_VMWGFX to represent vmwgfx device for running igt tests. > > > > > > v2: Don't remove second virtio_gpu > > > > > > Signed-off-by: Deepak Rawat <drawat@vmware.com> > > > --- > > > lib/drmtest.c | 8 ++++++++ > > > lib/drmtest.h | 3 +++ > > > 2 files changed, 11 insertions(+) > > > > > > diff --git a/lib/drmtest.c b/lib/drmtest.c > > > index fee9d33a..9d013a00 100644 > > > --- a/lib/drmtest.c > > > +++ b/lib/drmtest.c > > > @@ -105,6 +105,11 @@ bool is_i915_device(int fd) > > > return __is_device(fd, "i915"); > > > } > > > > > > +bool is_vmwgfx_device(int fd) > > > +{ > > > + return __is_device(fd, "vmwg"); > > > +} > > > + > > > static bool has_known_intel_chipset(int fd) > > > { > > > struct drm_i915_getparam gp; > > > @@ -206,6 +211,7 @@ static const struct module { > > > { DRIVER_VGEM, "vgem" }, > > > { DRIVER_VIRTIO, "virtio-gpu" }, > > > { DRIVER_VIRTIO, "virtio_gpu" }, > > > + { DRIVER_VMWGFX, "vmwgfx" }, > > > {} > > > }; > > > > > > @@ -348,6 +354,8 @@ static const char *chipset_to_str(int chipset) > > > return "virtio"; > > > case DRIVER_AMDGPU: > > > return "amdgpu"; > > > + case DRIVER_VMWGFX: > > > + return "vmwgfx"; > > > case DRIVER_ANY: > > > return "any"; > > > default: > > > diff --git a/lib/drmtest.h b/lib/drmtest.h > > > index 949865ee..0213fb51 100644 > > > --- a/lib/drmtest.h > > > +++ b/lib/drmtest.h > > > @@ -43,6 +43,7 @@ > > > #define DRIVER_VGEM (1 << 2) > > > #define DRIVER_VIRTIO (1 << 3) > > > #define DRIVER_AMDGPU (1 << 4) > > > +#define DRIVER_VMWGFX (1 << 5) > > > > This seems not needed? For pure generic kms tests I think it'd be great if > > we don't have to sprinkle driver-specific checks all over. Which you seem > > to achive in your series here. > > > > So not clear why this here is needed? > > > Loading the .ko needs the name in this array: > > > > @@ -206,6 +211,7 @@ static const struct module { > > > { DRIVER_VGEM, "vgem" }, > > > { DRIVER_VIRTIO, "virtio-gpu" }, > > > { DRIVER_VIRTIO, "virtio_gpu" }, > > > + { DRIVER_VMWGFX, "vmwgfx" }, I guess I don't quite understand why we do that then. Adding driver flags for every kms driver under the sun isn't a maintainable thing going forward. And there's definitely people using igt who don't have their special flag+module autoloader. vgem and vkms needs it, but that's about it. Everything else sounds like papering over CI infrastructure mishaps to me ... -Daniel > > > > -- > Petri Latvala > > > > > > -Daniel > > > > > /* > > > * Exclude DRVER_VGEM from DRIVER_ANY since if you run on a system > > > * with vgem as well as a supported driver, you can end up with a > > > @@ -80,6 +81,8 @@ void igt_require_intel(int fd); > > > > > > bool is_i915_device(int fd); > > > > > > +bool is_vmwgfx_device(int fd); > > > + > > > /** > > > * do_or_die: > > > * @x: command > > > -- > > > 2.17.1 > > > > > > _______________________________________________ > > > igt-dev mailing list > > > igt-dev@lists.freedesktop.org > > > https://lists.freedesktop.org/mailman/listinfo/igt-dev > > > > -- > > Daniel Vetter > > Software Engineer, Intel Corporation > > http://blog.ffwll.ch > > _______________________________________________ > > igt-dev mailing list > > igt-dev@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/igt-dev -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch> To: Daniel Vetter <daniel@ffwll.ch>, Deepak Rawat <drawat@vmware.com>, thellstrom@vmware.com, syeh@vmware.com, intel-gfx@lists.freedesktop.org, igt-dev@lists.freedesktop.org, linux-graphics-maintainer@vmware.com Subject: Re: [igt-dev] [PATCH i-g-t 1/6] lib/igt_vmwgfx: Add vmwgfx device Date: Thu, 11 Oct 2018 11:46:31 +0200 [thread overview] Message-ID: <20181011094631.GD31561@phenom.ffwll.local> (raw) In-Reply-To: <20181011091123.GN17124@platvala-desk.ger.corp.intel.com> On Thu, Oct 11, 2018 at 12:11:23PM +0300, Petri Latvala wrote: > On Thu, Oct 11, 2018 at 11:01:48AM +0200, Daniel Vetter wrote: > > On Wed, Oct 10, 2018 at 05:20:59PM -0700, Deepak Rawat wrote: > > > Add DRIVER_VMWGFX to represent vmwgfx device for running igt tests. > > > > > > v2: Don't remove second virtio_gpu > > > > > > Signed-off-by: Deepak Rawat <drawat@vmware.com> > > > --- > > > lib/drmtest.c | 8 ++++++++ > > > lib/drmtest.h | 3 +++ > > > 2 files changed, 11 insertions(+) > > > > > > diff --git a/lib/drmtest.c b/lib/drmtest.c > > > index fee9d33a..9d013a00 100644 > > > --- a/lib/drmtest.c > > > +++ b/lib/drmtest.c > > > @@ -105,6 +105,11 @@ bool is_i915_device(int fd) > > > return __is_device(fd, "i915"); > > > } > > > > > > +bool is_vmwgfx_device(int fd) > > > +{ > > > + return __is_device(fd, "vmwg"); > > > +} > > > + > > > static bool has_known_intel_chipset(int fd) > > > { > > > struct drm_i915_getparam gp; > > > @@ -206,6 +211,7 @@ static const struct module { > > > { DRIVER_VGEM, "vgem" }, > > > { DRIVER_VIRTIO, "virtio-gpu" }, > > > { DRIVER_VIRTIO, "virtio_gpu" }, > > > + { DRIVER_VMWGFX, "vmwgfx" }, > > > {} > > > }; > > > > > > @@ -348,6 +354,8 @@ static const char *chipset_to_str(int chipset) > > > return "virtio"; > > > case DRIVER_AMDGPU: > > > return "amdgpu"; > > > + case DRIVER_VMWGFX: > > > + return "vmwgfx"; > > > case DRIVER_ANY: > > > return "any"; > > > default: > > > diff --git a/lib/drmtest.h b/lib/drmtest.h > > > index 949865ee..0213fb51 100644 > > > --- a/lib/drmtest.h > > > +++ b/lib/drmtest.h > > > @@ -43,6 +43,7 @@ > > > #define DRIVER_VGEM (1 << 2) > > > #define DRIVER_VIRTIO (1 << 3) > > > #define DRIVER_AMDGPU (1 << 4) > > > +#define DRIVER_VMWGFX (1 << 5) > > > > This seems not needed? For pure generic kms tests I think it'd be great if > > we don't have to sprinkle driver-specific checks all over. Which you seem > > to achive in your series here. > > > > So not clear why this here is needed? > > > Loading the .ko needs the name in this array: > > > > @@ -206,6 +211,7 @@ static const struct module { > > > { DRIVER_VGEM, "vgem" }, > > > { DRIVER_VIRTIO, "virtio-gpu" }, > > > { DRIVER_VIRTIO, "virtio_gpu" }, > > > + { DRIVER_VMWGFX, "vmwgfx" }, I guess I don't quite understand why we do that then. Adding driver flags for every kms driver under the sun isn't a maintainable thing going forward. And there's definitely people using igt who don't have their special flag+module autoloader. vgem and vkms needs it, but that's about it. Everything else sounds like papering over CI infrastructure mishaps to me ... -Daniel > > > > -- > Petri Latvala > > > > > > -Daniel > > > > > /* > > > * Exclude DRVER_VGEM from DRIVER_ANY since if you run on a system > > > * with vgem as well as a supported driver, you can end up with a > > > @@ -80,6 +81,8 @@ void igt_require_intel(int fd); > > > > > > bool is_i915_device(int fd); > > > > > > +bool is_vmwgfx_device(int fd); > > > + > > > /** > > > * do_or_die: > > > * @x: command > > > -- > > > 2.17.1 > > > > > > _______________________________________________ > > > igt-dev mailing list > > > igt-dev@lists.freedesktop.org > > > https://lists.freedesktop.org/mailman/listinfo/igt-dev > > > > -- > > Daniel Vetter > > Software Engineer, Intel Corporation > > http://blog.ffwll.ch > > _______________________________________________ > > igt-dev mailing list > > igt-dev@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/igt-dev -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2018-10-11 9:46 UTC|newest] Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-10-11 0:20 [PATCH i-g-t 1/6] lib/igt_vmwgfx: Add vmwgfx device Deepak Rawat 2018-10-11 0:20 ` [igt-dev] " Deepak Rawat 2018-10-11 0:21 ` [PATCH i-g-t 2/6] lib/igt_fb: Call dumb_destroy ioctl in case of dumb buffers Deepak Rawat 2018-10-11 0:21 ` [Intel-gfx] " Deepak Rawat 2018-10-11 0:21 ` [PATCH i-g-t 3/6] lib/igt_fb: Check for cairo surface success Deepak Rawat 2018-10-11 0:21 ` [Intel-gfx] " Deepak Rawat 2018-10-11 15:06 ` [igt-dev] " Ville Syrjälä 2018-10-11 15:06 ` Ville Syrjälä 2018-10-11 15:48 ` Deepak Singh Rawat 2018-10-11 15:48 ` Deepak Singh Rawat 2018-10-11 0:21 ` [PATCH i-g-t 4/6] lib: Don't call igt_require_fb_modifiers() when no modifier Deepak Rawat 2018-10-11 0:21 ` [igt-dev] " Deepak Rawat 2018-10-11 14:51 ` Ville Syrjälä 2018-10-11 14:51 ` Ville Syrjälä 2018-10-11 15:38 ` Deepak Singh Rawat 2018-10-11 15:38 ` Deepak Singh Rawat 2018-10-11 15:48 ` Daniel Vetter 2018-10-11 15:48 ` Daniel Vetter 2018-10-11 0:21 ` [PATCH i-g-t 5/6] tests/kms_atomic: Add a new test case for FB_DAMAGE_CLIPS plane property Deepak Rawat 2018-10-11 0:21 ` [Intel-gfx] " Deepak Rawat 2018-10-11 0:21 ` [PATCH i-g-t 6/6] tests/plane_damage: Integrate kernel selftest test-drm_damage_helper Deepak Rawat 2018-10-11 0:21 ` [Intel-gfx] " Deepak Rawat 2018-10-11 9:05 ` Daniel Vetter 2018-10-11 9:05 ` [Intel-gfx] " Daniel Vetter 2018-10-11 15:23 ` Deepak Singh Rawat 2018-10-11 15:23 ` [Intel-gfx] " Deepak Singh Rawat 2018-10-11 15:25 ` Daniel Vetter 2018-10-11 15:25 ` [Intel-gfx] " Daniel Vetter 2018-10-11 9:01 ` [igt-dev] [PATCH i-g-t 1/6] lib/igt_vmwgfx: Add vmwgfx device Daniel Vetter 2018-10-11 9:01 ` Daniel Vetter 2018-10-11 9:11 ` Petri Latvala 2018-10-11 9:11 ` Petri Latvala 2018-10-11 9:46 ` Daniel Vetter [this message] 2018-10-11 9:46 ` Daniel Vetter 2018-10-11 15:17 ` Deepak Singh Rawat 2018-10-11 15:17 ` Deepak Singh Rawat 2018-10-11 15:27 ` Daniel Vetter 2018-10-11 15:27 ` Daniel Vetter 2018-10-11 15:32 ` Deepak Singh Rawat 2018-10-11 15:32 ` Deepak Singh Rawat 2018-10-11 9:21 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/6] " Patchwork 2018-10-11 14:22 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181011094631.GD31561@phenom.ffwll.local \ --to=daniel@ffwll.ch \ --cc=drawat@vmware.com \ --cc=igt-dev@lists.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ --cc=linux-graphics-maintainer@vmware.com \ --cc=syeh@vmware.com \ --cc=thellstrom@vmware.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.