All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Deepak Rawat <drawat@vmware.com>
Cc: thellstrom@vmware.com, syeh@vmware.com,
	intel-gfx@lists.freedesktop.org, igt-dev@lists.freedesktop.org,
	linux-graphics-maintainer@vmware.com
Subject: Re: [igt-dev] [PATCH i-g-t 4/6] lib: Don't call igt_require_fb_modifiers() when no modifier
Date: Thu, 11 Oct 2018 17:51:04 +0300	[thread overview]
Message-ID: <20181011145104.GJ9144@intel.com> (raw)
In-Reply-To: <20181011002104.1845-4-drawat@vmware.com>

On Wed, Oct 10, 2018 at 05:21:02PM -0700, Deepak Rawat wrote:
> vmwgfx doesn't support fb modifier so skip igt_require_fb_modifiers()
> when modifier are not passed.
> 
> Signed-off-by: Deepak Rawat <drawat@vmware.com>
> ---
>  lib/ioctl_wrappers.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/ioctl_wrappers.c b/lib/ioctl_wrappers.c
> index 0929c43f..3a11cb6e 100644
> --- a/lib/ioctl_wrappers.c
> +++ b/lib/ioctl_wrappers.c
> @@ -1678,7 +1678,10 @@ int __kms_addfb(int fd, uint32_t handle,
>  	struct drm_mode_fb_cmd2 f;
>  	int ret, i;
>  
> -	igt_require_fb_modifiers(fd);
> +	if (modifier)
> +		igt_require_fb_modifiers(fd);
> +	else
> +		flags &= ~DRM_MODE_FB_MODIFIERS;

This would theoretically change the behviour for i915 at least. Without
the modifiers flag the kernel will pick the modifier for us based on 
the bo tiling, which in theory might not be what we wanted. But at least
igt_fb should be fine with that.

Maybe it would be better to just not pass the flags from the caller at
all, and instead have __kms_addfb() check if the driver has modifiers
or not and set the flag based on that?

>  
>  	memset(&f, 0, sizeof(f));
>  
> -- 
> 2.17.1
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Deepak Rawat <drawat@vmware.com>
Cc: thellstrom@vmware.com, petri.latvala@intel.com, syeh@vmware.com,
	intel-gfx@lists.freedesktop.org, igt-dev@lists.freedesktop.org,
	linux-graphics-maintainer@vmware.com
Subject: Re: [igt-dev] [PATCH i-g-t 4/6] lib: Don't call igt_require_fb_modifiers() when no modifier
Date: Thu, 11 Oct 2018 17:51:04 +0300	[thread overview]
Message-ID: <20181011145104.GJ9144@intel.com> (raw)
In-Reply-To: <20181011002104.1845-4-drawat@vmware.com>

On Wed, Oct 10, 2018 at 05:21:02PM -0700, Deepak Rawat wrote:
> vmwgfx doesn't support fb modifier so skip igt_require_fb_modifiers()
> when modifier are not passed.
> 
> Signed-off-by: Deepak Rawat <drawat@vmware.com>
> ---
>  lib/ioctl_wrappers.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/ioctl_wrappers.c b/lib/ioctl_wrappers.c
> index 0929c43f..3a11cb6e 100644
> --- a/lib/ioctl_wrappers.c
> +++ b/lib/ioctl_wrappers.c
> @@ -1678,7 +1678,10 @@ int __kms_addfb(int fd, uint32_t handle,
>  	struct drm_mode_fb_cmd2 f;
>  	int ret, i;
>  
> -	igt_require_fb_modifiers(fd);
> +	if (modifier)
> +		igt_require_fb_modifiers(fd);
> +	else
> +		flags &= ~DRM_MODE_FB_MODIFIERS;

This would theoretically change the behviour for i915 at least. Without
the modifiers flag the kernel will pick the modifier for us based on 
the bo tiling, which in theory might not be what we wanted. But at least
igt_fb should be fine with that.

Maybe it would be better to just not pass the flags from the caller at
all, and instead have __kms_addfb() check if the driver has modifiers
or not and set the flag based on that?

>  
>  	memset(&f, 0, sizeof(f));
>  
> -- 
> 2.17.1
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev

-- 
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  reply	other threads:[~2018-10-11 14:51 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-11  0:20 [PATCH i-g-t 1/6] lib/igt_vmwgfx: Add vmwgfx device Deepak Rawat
2018-10-11  0:20 ` [igt-dev] " Deepak Rawat
2018-10-11  0:21 ` [PATCH i-g-t 2/6] lib/igt_fb: Call dumb_destroy ioctl in case of dumb buffers Deepak Rawat
2018-10-11  0:21   ` [Intel-gfx] " Deepak Rawat
2018-10-11  0:21 ` [PATCH i-g-t 3/6] lib/igt_fb: Check for cairo surface success Deepak Rawat
2018-10-11  0:21   ` [Intel-gfx] " Deepak Rawat
2018-10-11 15:06   ` [igt-dev] " Ville Syrjälä
2018-10-11 15:06     ` Ville Syrjälä
2018-10-11 15:48     ` Deepak Singh Rawat
2018-10-11 15:48       ` Deepak Singh Rawat
2018-10-11  0:21 ` [PATCH i-g-t 4/6] lib: Don't call igt_require_fb_modifiers() when no modifier Deepak Rawat
2018-10-11  0:21   ` [igt-dev] " Deepak Rawat
2018-10-11 14:51   ` Ville Syrjälä [this message]
2018-10-11 14:51     ` Ville Syrjälä
2018-10-11 15:38     ` Deepak Singh Rawat
2018-10-11 15:38       ` Deepak Singh Rawat
2018-10-11 15:48       ` Daniel Vetter
2018-10-11 15:48         ` Daniel Vetter
2018-10-11  0:21 ` [PATCH i-g-t 5/6] tests/kms_atomic: Add a new test case for FB_DAMAGE_CLIPS plane property Deepak Rawat
2018-10-11  0:21   ` [Intel-gfx] " Deepak Rawat
2018-10-11  0:21 ` [PATCH i-g-t 6/6] tests/plane_damage: Integrate kernel selftest test-drm_damage_helper Deepak Rawat
2018-10-11  0:21   ` [Intel-gfx] " Deepak Rawat
2018-10-11  9:05   ` Daniel Vetter
2018-10-11  9:05     ` [Intel-gfx] " Daniel Vetter
2018-10-11 15:23     ` Deepak Singh Rawat
2018-10-11 15:23       ` [Intel-gfx] " Deepak Singh Rawat
2018-10-11 15:25       ` Daniel Vetter
2018-10-11 15:25         ` [Intel-gfx] " Daniel Vetter
2018-10-11  9:01 ` [igt-dev] [PATCH i-g-t 1/6] lib/igt_vmwgfx: Add vmwgfx device Daniel Vetter
2018-10-11  9:01   ` Daniel Vetter
2018-10-11  9:11   ` Petri Latvala
2018-10-11  9:11     ` Petri Latvala
2018-10-11  9:46     ` Daniel Vetter
2018-10-11  9:46       ` Daniel Vetter
2018-10-11 15:17   ` Deepak Singh Rawat
2018-10-11 15:17     ` Deepak Singh Rawat
2018-10-11 15:27     ` Daniel Vetter
2018-10-11 15:27       ` Daniel Vetter
2018-10-11 15:32       ` Deepak Singh Rawat
2018-10-11 15:32         ` Deepak Singh Rawat
2018-10-11  9:21 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/6] " Patchwork
2018-10-11 14:22 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181011145104.GJ9144@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=drawat@vmware.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=linux-graphics-maintainer@vmware.com \
    --cc=syeh@vmware.com \
    --cc=thellstrom@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.