[PATCH 1/2] ALSA: x86: Fix runtime PM for hdmi-lpe-audio

[PATCH 1/2] ALSA: x86: Fix runtime PM for hdmi-lpe-audio

[Ville Syrjala]

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Commit 46e831abe864 ("drm/i915/lpe: Mark LPE audio runtime pm as
"no callbacks"") broke runtime PM with lpe audio. We can no longer
runtime suspend the GPU since the sysfs  power/control for the
lpe-audio device no longer exists and the device is considered
always active. We can fix this by not marking the device as
active.

Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Takashi Iwai <tiwai@suse.de>
Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Fixes: 46e831abe864 ("drm/i915/lpe: Mark LPE audio runtime pm as "no callbacks"")
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 sound/x86/intel_hdmi_audio.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sound/x86/intel_hdmi_audio.c b/sound/x86/intel_hdmi_audio.c
index 83d76c345940..bbed4acaafd1 100644
--- a/sound/x86/intel_hdmi_audio.c
+++ b/sound/x86/intel_hdmi_audio.c
@@ -1877,7 +1877,6 @@ static int hdmi_lpe_audio_probe(struct platform_device *pdev)
 
 	pm_runtime_use_autosuspend(&pdev->dev);
 	pm_runtime_mark_last_busy(&pdev->dev);
-	pm_runtime_set_active(&pdev->dev);
 
 	dev_dbg(&pdev->dev, "%s: handle pending notification\n", __func__);
 	for_each_port(card_ctx, port) {
-- 
2.18.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PATCH 2/2] ALSA: x86: Rip out the lpe audio runtime suspend/resume hooks

[Ville Syrjala]

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Ever since commit 46e831abe864 ("drm/i915/lpe: Mark LPE audio runtime
pm as "no callbacks"") the runtime suspend/resume hooks are no longer
used. Inline them into the system suspend hooks.

Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Takashi Iwai <tiwai@suse.de>
Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 sound/x86/intel_hdmi_audio.c | 25 +++++--------------------
 1 file changed, 5 insertions(+), 20 deletions(-)

diff --git a/sound/x86/intel_hdmi_audio.c b/sound/x86/intel_hdmi_audio.c
index bbed4acaafd1..00c92eb854ce 100644
--- a/sound/x86/intel_hdmi_audio.c
+++ b/sound/x86/intel_hdmi_audio.c
@@ -1648,7 +1648,7 @@ static int had_create_jack(struct snd_intelhad *ctx,
  * PM callbacks
  */
 
-static int hdmi_lpe_audio_runtime_suspend(struct device *dev)
+static int __maybe_unused hdmi_lpe_audio_suspend(struct device *dev)
 {
 	struct snd_intelhad_card *card_ctx = dev_get_drvdata(dev);
 	int port;
@@ -1664,23 +1664,8 @@ static int hdmi_lpe_audio_runtime_suspend(struct device *dev)
 		}
 	}
 
-	return 0;
-}
-
-static int __maybe_unused hdmi_lpe_audio_suspend(struct device *dev)
-{
-	struct snd_intelhad_card *card_ctx = dev_get_drvdata(dev);
-	int err;
+	snd_power_change_state(card_ctx->card, SNDRV_CTL_POWER_D3hot);
 
-	err = hdmi_lpe_audio_runtime_suspend(dev);
-	if (!err)
-		snd_power_change_state(card_ctx->card, SNDRV_CTL_POWER_D3hot);
-	return err;
-}
-
-static int hdmi_lpe_audio_runtime_resume(struct device *dev)
-{
-	pm_runtime_mark_last_busy(dev);
 	return 0;
 }
 
@@ -1688,8 +1673,10 @@ static int __maybe_unused hdmi_lpe_audio_resume(struct device *dev)
 {
 	struct snd_intelhad_card *card_ctx = dev_get_drvdata(dev);
 
-	hdmi_lpe_audio_runtime_resume(dev);
+	pm_runtime_mark_last_busy(dev);
+
 	snd_power_change_state(card_ctx->card, SNDRV_CTL_POWER_D0);
+
 	return 0;
 }
 
@@ -1907,8 +1894,6 @@ static int hdmi_lpe_audio_remove(struct platform_device *pdev)
 
 static const struct dev_pm_ops hdmi_lpe_audio_pm = {
 	SET_SYSTEM_SLEEP_PM_OPS(hdmi_lpe_audio_suspend, hdmi_lpe_audio_resume)
-	SET_RUNTIME_PM_OPS(hdmi_lpe_audio_runtime_suspend,
-			   hdmi_lpe_audio_runtime_resume, NULL)
 };
 
 static struct platform_driver hdmi_lpe_audio_driver = {
-- 
2.18.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 1/2] ALSA: x86: Fix runtime PM for hdmi-lpe-audio

[Chris Wilson]

Quoting Ville Syrjala (2018-10-24 16:48:24)
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Commit 46e831abe864 ("drm/i915/lpe: Mark LPE audio runtime pm as
> "no callbacks"") broke runtime PM with lpe audio. We can no longer
> runtime suspend the GPU since the sysfs  power/control for the
> lpe-audio device no longer exists and the device is considered
> always active. We can fix this by not marking the device as
> active.

Do you also want to send with a HAX patch to force selection of SND_X86
for CI?
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 1/2] ALSA: x86: Fix runtime PM for hdmi-lpe-audio

[Chris Wilson]

Quoting Ville Syrjala (2018-10-24 16:48:24)
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Commit 46e831abe864 ("drm/i915/lpe: Mark LPE audio runtime pm as
> "no callbacks"") broke runtime PM with lpe audio. We can no longer
> runtime suspend the GPU since the sysfs  power/control for the
> lpe-audio device no longer exists and the device is considered
> always active. We can fix this by not marking the device as
> active.

Seems like this use is covered by runtime_pm.txt:

However, if the device has a parent and the parent's runtime PM is enabled,
calling pm_runtime_set_active() for the device will affect the parent, unless
the parent's 'power.ignore_children' flag is set.  Namely, in that case the
parent won't be able to suspend at run time, using the PM core's helper
functions, as long as the child's status is 'active', even if the child's
runtime PM is still disabled (i.e. pm_runtime_enable() hasn't been called for
the child yet or pm_runtime_disable() has been called for it).  For this reason,
once pm_runtime_set_active() has been called for the device, pm_runtime_enable()
should be called for it too as soon as reasonably possible or its runtime PM
status should be changed back to 'suspended' with the help of
pm_runtime_set_suspended().

> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Takashi Iwai <tiwai@suse.de>
> Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> Fixes: 46e831abe864 ("drm/i915/lpe: Mark LPE audio runtime pm as "no callbacks"")
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

So according to that the alternative is to add a call to
pm_runtime_enable(). Seems like the sensible course of action is to
merely mark it as busy and not set it as active.

With the caveat of checking with CI + SND_X86 :)
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 1/2] ALSA: x86: Fix runtime PM for hdmi-lpe-audio

[Ville Syrjälä]

On Wed, Oct 24, 2018 at 04:52:22PM +0100, Chris Wilson wrote:
> Quoting Ville Syrjala (2018-10-24 16:48:24)
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > 
> > Commit 46e831abe864 ("drm/i915/lpe: Mark LPE audio runtime pm as
> > "no callbacks"") broke runtime PM with lpe audio. We can no longer
> > runtime suspend the GPU since the sysfs  power/control for the
> > lpe-audio device no longer exists and the device is considered
> > always active. We can fix this by not marking the device as
> > active.
> 
> Do you also want to send with a HAX patch to force selection of SND_X86
> for CI?

Hmm. Would have been a good idea a few minutes ago. Not sure I want
to spam the list again. Depends how long it'll take to adjust the ci
.config I suppose.

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 1/2] ALSA: x86: Fix runtime PM for hdmi-lpe-audio

[Chris Wilson]

Quoting Ville Syrjälä (2018-10-24 17:28:45)
> On Wed, Oct 24, 2018 at 04:52:22PM +0100, Chris Wilson wrote:
> > Quoting Ville Syrjala (2018-10-24 16:48:24)
> > > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > 
> > > Commit 46e831abe864 ("drm/i915/lpe: Mark LPE audio runtime pm as
> > > "no callbacks"") broke runtime PM with lpe audio. We can no longer
> > > runtime suspend the GPU since the sysfs  power/control for the
> > > lpe-audio device no longer exists and the device is considered
> > > always active. We can fix this by not marking the device as
> > > active.
> > 
> > Do you also want to send with a HAX patch to force selection of SND_X86
> > for CI?
> 
> Hmm. Would have been a good idea a few minutes ago. Not sure I want
> to spam the list again. Depends how long it'll take to adjust the ci
> .config I suppose.

Trybot and link to the results?
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] ALSA: x86: Fix runtime PM for hdmi-lpe-audio

[Patchwork]

== Series Details ==

Series: series starting with [1/2] ALSA: x86: Fix runtime PM for hdmi-lpe-audio
URL   : https://patchwork.freedesktop.org/series/51461/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
fc8795c8431a ALSA: x86: Fix runtime PM for hdmi-lpe-audio
-:9: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'Commit 46e831abe864 ("drm/i915/lpe: Mark LPE audio runtime pm as "no callbacks"")'
#9: 
Commit 46e831abe864 ("drm/i915/lpe: Mark LPE audio runtime pm as

total: 1 errors, 0 warnings, 0 checks, 7 lines checked
d7d07439fb2f ALSA: x86: Rip out the lpe audio runtime suspend/resume hooks
-:9: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 46e831abe864 ("drm/i915/lpe: Mark LPE audio runtime pm as "no callbacks"")'
#9: 
Ever since commit 46e831abe864 ("drm/i915/lpe: Mark LPE audio runtime

total: 1 errors, 0 warnings, 0 checks, 51 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.BAT: success for series starting with [1/2] ALSA: x86: Fix runtime PM for hdmi-lpe-audio

[Patchwork]

== Series Details ==

Series: series starting with [1/2] ALSA: x86: Fix runtime PM for hdmi-lpe-audio
URL   : https://patchwork.freedesktop.org/series/51461/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_5029 -> Patchwork_10564 =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/51461/revisions/1/mbox/

== Known issues ==

  Here are the changes found in Patchwork_10564 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@drv_module_reload@basic-reload:
      fi-blb-e6850:       NOTRUN -> INCOMPLETE (fdo#107718)

    igt@kms_flip@basic-flip-vs-dpms:
      fi-hsw-4770r:       PASS -> DMESG-WARN (fdo#105602)

    igt@kms_frontbuffer_tracking@basic:
      fi-byt-clapper:     PASS -> FAIL (fdo#103167)

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
      fi-byt-clapper:     PASS -> FAIL (fdo#103191, fdo#107362) +1

    
    ==== Possible fixes ====

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
      fi-blb-e6850:       INCOMPLETE (fdo#107718) -> PASS

    
  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
  fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
  fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
  fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718


== Participating hosts (47 -> 43) ==

  Missing    (4): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan 


== Build changes ==

    * Linux: CI_DRM_5029 -> Patchwork_10564

  CI_DRM_5029: 3d6302c20ddeff4b564c71fa479871b8afc11c4b @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4691: d445be01f5edc7e7a324444c73e221c9ed75602e @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_10564: d7d07439fb2f0d82816f6f536898d4032e8f19e6 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

d7d07439fb2f ALSA: x86: Rip out the lpe audio runtime suspend/resume hooks
fc8795c8431a ALSA: x86: Fix runtime PM for hdmi-lpe-audio

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10564/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.IGT: success for series starting with [1/2] ALSA: x86: Fix runtime PM for hdmi-lpe-audio

[Patchwork]

== Series Details ==

Series: series starting with [1/2] ALSA: x86: Fix runtime PM for hdmi-lpe-audio
URL   : https://patchwork.freedesktop.org/series/51461/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_5029_full -> Patchwork_10564_full =

== Summary - SUCCESS ==

  No regressions found.

  

== Known issues ==

  Here are the changes found in Patchwork_10564_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@kms_busy@extended-modeset-hang-newfb-render-a:
      shard-skl:          NOTRUN -> DMESG-WARN (fdo#107956)

    igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-a:
      shard-glk:          PASS -> DMESG-WARN (fdo#107956)

    igt@kms_chv_cursor_fail@pipe-a-128x128-bottom-edge:
      shard-skl:          NOTRUN -> FAIL (fdo#104671)

    igt@kms_color@pipe-a-ctm-max:
      shard-skl:          NOTRUN -> FAIL (fdo#108147)

    igt@kms_cursor_crc@cursor-64x21-random:
      shard-apl:          PASS -> FAIL (fdo#103232) +3

    igt@kms_cursor_crc@cursor-64x64-sliding:
      shard-skl:          NOTRUN -> FAIL (fdo#103232)

    igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
      shard-skl:          PASS -> FAIL (fdo#102670)

    igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-untiled:
      shard-skl:          NOTRUN -> FAIL (fdo#103184) +1

    igt@kms_draw_crc@draw-method-xrgb8888-mmap-wc-ytiled:
      shard-skl:          PASS -> FAIL (fdo#103184)

    igt@kms_fbcon_fbt@fbc-suspend:
      shard-skl:          NOTRUN -> FAIL (fdo#103833, fdo#105682)

    igt@kms_flip@dpms-vs-vblank-race-interruptible:
      shard-kbl:          PASS -> DMESG-WARN (fdo#105345, fdo#103313)

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-msflip-blt:
      shard-skl:          PASS -> FAIL (fdo#105682)

    igt@kms_frontbuffer_tracking@fbc-1p-shrfb-fliptrack:
      shard-skl:          NOTRUN -> FAIL (fdo#105682) +1

    igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff:
      shard-glk:          PASS -> FAIL (fdo#103167)

    igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-move:
      shard-skl:          NOTRUN -> FAIL (fdo#103167) +2

    igt@kms_frontbuffer_tracking@psr-rgb565-draw-pwrite:
      shard-skl:          PASS -> FAIL (fdo#103167)

    igt@kms_mmap_write_crc:
      shard-skl:          NOTRUN -> FAIL (fdo#108228)

    igt@kms_plane@pixel-format-pipe-b-planes:
      shard-skl:          NOTRUN -> DMESG-FAIL (fdo#103166, fdo#106885)

    igt@kms_plane@plane-position-covered-pipe-a-planes:
      shard-glk:          PASS -> FAIL (fdo#103166)

    igt@kms_plane_alpha_blend@pipe-b-alpha-transparant-fb:
      shard-skl:          NOTRUN -> FAIL (fdo#108145) +2

    igt@kms_plane_alpha_blend@pipe-c-alpha-basic:
      shard-skl:          NOTRUN -> FAIL (fdo#107815, fdo#108145)

    igt@kms_setmode@basic:
      shard-skl:          NOTRUN -> FAIL (fdo#99912)

    igt@kms_vblank@pipe-b-accuracy-idle:
      shard-hsw:          PASS -> INCOMPLETE (fdo#103540)

    igt@pm_rpm@debugfs-read:
      shard-skl:          PASS -> INCOMPLETE (fdo#107807)

    
    ==== Possible fixes ====

    igt@gem_ctx_switch@basic-all-light:
      shard-apl:          INCOMPLETE (fdo#103927) -> PASS

    igt@gem_eio@in-flight-1us:
      shard-glk:          INCOMPLETE (k.org#198133, fdo#103359) -> PASS

    igt@gem_eio@in-flight-contexts-immediate:
      shard-glk:          FAIL (fdo#107799) -> PASS

    igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-c:
      shard-kbl:          DMESG-WARN (fdo#107956) -> PASS

    igt@kms_cursor_crc@cursor-128x128-onscreen:
      shard-apl:          FAIL (fdo#103232) -> PASS +1

    igt@kms_cursor_legacy@cursorb-vs-flipb-toggle:
      shard-glk:          DMESG-WARN (fdo#105763, fdo#106538) -> PASS

    igt@kms_flip@flip-vs-expired-vblank:
      shard-skl:          FAIL (fdo#105363) -> PASS

    igt@kms_flip@wf_vblank-ts-check:
      shard-apl:          DMESG-WARN (fdo#103558, fdo#105602) -> PASS +4

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt:
      shard-glk:          FAIL (fdo#103167) -> PASS +2

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render:
      shard-apl:          FAIL (fdo#103167) -> PASS

    igt@kms_frontbuffer_tracking@fbc-1p-rte:
      shard-apl:          DMESG-WARN (fdo#103558, fdo#108131) -> PASS

    igt@kms_setmode@basic:
      shard-kbl:          FAIL (fdo#99912) -> PASS

    igt@kms_universal_plane@universal-plane-pipe-a-functional:
      shard-glk:          FAIL (fdo#103166) -> PASS

    igt@pm_rpm@system-suspend-execbuf:
      shard-apl:          DMESG-WARN -> PASS

    
    ==== Warnings ====

    igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-gtt:
      shard-snb:          DMESG-WARN (fdo#107469) -> INCOMPLETE (fdo#105411)

    
  fdo#102670 https://bugs.freedesktop.org/show_bug.cgi?id=102670
  fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#103184 https://bugs.freedesktop.org/show_bug.cgi?id=103184
  fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
  fdo#103313 https://bugs.freedesktop.org/show_bug.cgi?id=103313
  fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
  fdo#103540 https://bugs.freedesktop.org/show_bug.cgi?id=103540
  fdo#103558 https://bugs.freedesktop.org/show_bug.cgi?id=103558
  fdo#103833 https://bugs.freedesktop.org/show_bug.cgi?id=103833
  fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
  fdo#104671 https://bugs.freedesktop.org/show_bug.cgi?id=104671
  fdo#105345 https://bugs.freedesktop.org/show_bug.cgi?id=105345
  fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
  fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
  fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
  fdo#105682 https://bugs.freedesktop.org/show_bug.cgi?id=105682
  fdo#105763 https://bugs.freedesktop.org/show_bug.cgi?id=105763
  fdo#106538 https://bugs.freedesktop.org/show_bug.cgi?id=106538
  fdo#106885 https://bugs.freedesktop.org/show_bug.cgi?id=106885
  fdo#107469 https://bugs.freedesktop.org/show_bug.cgi?id=107469
  fdo#107799 https://bugs.freedesktop.org/show_bug.cgi?id=107799
  fdo#107807 https://bugs.freedesktop.org/show_bug.cgi?id=107807
  fdo#107815 https://bugs.freedesktop.org/show_bug.cgi?id=107815
  fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
  fdo#108131 https://bugs.freedesktop.org/show_bug.cgi?id=108131
  fdo#108145 https://bugs.freedesktop.org/show_bug.cgi?id=108145
  fdo#108147 https://bugs.freedesktop.org/show_bug.cgi?id=108147
  fdo#108228 https://bugs.freedesktop.org/show_bug.cgi?id=108228
  fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
  k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133


== Participating hosts (6 -> 6) ==

  No changes in participating hosts


== Build changes ==

    * Linux: CI_DRM_5029 -> Patchwork_10564

  CI_DRM_5029: 3d6302c20ddeff4b564c71fa479871b8afc11c4b @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4691: d445be01f5edc7e7a324444c73e221c9ed75602e @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_10564: d7d07439fb2f0d82816f6f536898d4032e8f19e6 @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10564/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 1/2] ALSA: x86: Fix runtime PM for hdmi-lpe-audio

[Chris Wilson]

Quoting Chris Wilson (2018-10-24 17:32:04)
> Quoting Ville Syrjälä (2018-10-24 17:28:45)
> > On Wed, Oct 24, 2018 at 04:52:22PM +0100, Chris Wilson wrote:
> > > Quoting Ville Syrjala (2018-10-24 16:48:24)
> > > > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > > 
> > > > Commit 46e831abe864 ("drm/i915/lpe: Mark LPE audio runtime pm as
> > > > "no callbacks"") broke runtime PM with lpe audio. We can no longer
> > > > runtime suspend the GPU since the sysfs  power/control for the
> > > > lpe-audio device no longer exists and the device is considered
> > > > always active. We can fix this by not marking the device as
> > > > active.
> > > 
> > > Do you also want to send with a HAX patch to force selection of SND_X86
> > > for CI?
> > 
> > Hmm. Would have been a good idea a few minutes ago. Not sure I want
> > to spam the list again. Depends how long it'll take to adjust the ci
> > .config I suppose.
> 
> Trybot and link to the results?

https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_3118/issues.html

The fi-byt-clapper pm tests passed which is the most significant result.
For enabling LPE audio in CI, it appears we need to trick
snd_hdmi_lpe_audio.ko into unloading on demand.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 2/2] ALSA: x86: Rip out the lpe audio runtime suspend/resume hooks

[Chris Wilson]

Quoting Ville Syrjala (2018-10-24 16:48:25)
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Ever since commit 46e831abe864 ("drm/i915/lpe: Mark LPE audio runtime
> pm as "no callbacks"") the runtime suspend/resume hooks are no longer
> used. Inline them into the system suspend hooks.
> 
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Takashi Iwai <tiwai@suse.de>
> Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

All tallies up, and rpm continues to function as desired.
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 1/2] ALSA: x86: Fix runtime PM for hdmi-lpe-audio

[Ville Syrjälä]

On Thu, Oct 25, 2018 at 07:50:29AM +0100, Chris Wilson wrote:
> Quoting Chris Wilson (2018-10-24 17:32:04)
> > Quoting Ville Syrjälä (2018-10-24 17:28:45)
> > > On Wed, Oct 24, 2018 at 04:52:22PM +0100, Chris Wilson wrote:
> > > > Quoting Ville Syrjala (2018-10-24 16:48:24)
> > > > > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > > > 
> > > > > Commit 46e831abe864 ("drm/i915/lpe: Mark LPE audio runtime pm as
> > > > > "no callbacks"") broke runtime PM with lpe audio. We can no longer
> > > > > runtime suspend the GPU since the sysfs  power/control for the
> > > > > lpe-audio device no longer exists and the device is considered
> > > > > always active. We can fix this by not marking the device as
> > > > > active.
> > > > 
> > > > Do you also want to send with a HAX patch to force selection of SND_X86
> > > > for CI?
> > > 
> > > Hmm. Would have been a good idea a few minutes ago. Not sure I want
> > > to spam the list again. Depends how long it'll take to adjust the ci
> > > .config I suppose.
> > 
> > Trybot and link to the results?
> 
> https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_3118/issues.html
> 
> The fi-byt-clapper pm tests passed which is the most significant result.
> For enabling LPE audio in CI, it appears we need to trick
> snd_hdmi_lpe_audio.ko into unloading on demand.

Re-ran the test for good measure after fixing the module unload in igt.
Now all green.

https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_3140/issues.html

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 1/2] ALSA: x86: Fix runtime PM for hdmi-lpe-audio

[Ville Syrjälä]

On Wed, Oct 24, 2018 at 06:48:24PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Commit 46e831abe864 ("drm/i915/lpe: Mark LPE audio runtime pm as
> "no callbacks"") broke runtime PM with lpe audio. We can no longer
> runtime suspend the GPU since the sysfs  power/control for the
> lpe-audio device no longer exists and the device is considered
> always active. We can fix this by not marking the device as
> active.
> 
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Takashi Iwai <tiwai@suse.de>
> Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> Fixes: 46e831abe864 ("drm/i915/lpe: Mark LPE audio runtime pm as "no callbacks"")
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Takashi, do you want to take these or should I just smash them
into drm-intel?

> ---
>  sound/x86/intel_hdmi_audio.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/sound/x86/intel_hdmi_audio.c b/sound/x86/intel_hdmi_audio.c
> index 83d76c345940..bbed4acaafd1 100644
> --- a/sound/x86/intel_hdmi_audio.c
> +++ b/sound/x86/intel_hdmi_audio.c
> @@ -1877,7 +1877,6 @@ static int hdmi_lpe_audio_probe(struct platform_device *pdev)
>  
>  	pm_runtime_use_autosuspend(&pdev->dev);
>  	pm_runtime_mark_last_busy(&pdev->dev);
> -	pm_runtime_set_active(&pdev->dev);
>  
>  	dev_dbg(&pdev->dev, "%s: handle pending notification\n", __func__);
>  	for_each_port(card_ctx, port) {
> -- 
> 2.18.1

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 1/2] ALSA: x86: Fix runtime PM for hdmi-lpe-audio

[Takashi Iwai]

On Thu, 01 Nov 2018 16:24:36 +0100,
Ville Syrjälä wrote:
> 
> On Wed, Oct 24, 2018 at 06:48:24PM +0300, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > 
> > Commit 46e831abe864 ("drm/i915/lpe: Mark LPE audio runtime pm as
> > "no callbacks"") broke runtime PM with lpe audio. We can no longer
> > runtime suspend the GPU since the sysfs  power/control for the
> > lpe-audio device no longer exists and the device is considered
> > always active. We can fix this by not marking the device as
> > active.
> > 
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Takashi Iwai <tiwai@suse.de>
> > Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> > Fixes: 46e831abe864 ("drm/i915/lpe: Mark LPE audio runtime pm as "no callbacks"")
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Takashi, do you want to take these or should I just smash them
> into drm-intel?

Feel free to go through drm-intel.
  Acked-by: Takashi Iwai <tiwai@suse.de>


thanks,

Takashi

> 
> > ---
> >  sound/x86/intel_hdmi_audio.c | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/sound/x86/intel_hdmi_audio.c b/sound/x86/intel_hdmi_audio.c
> > index 83d76c345940..bbed4acaafd1 100644
> > --- a/sound/x86/intel_hdmi_audio.c
> > +++ b/sound/x86/intel_hdmi_audio.c
> > @@ -1877,7 +1877,6 @@ static int hdmi_lpe_audio_probe(struct platform_device *pdev)
> >  
> >  	pm_runtime_use_autosuspend(&pdev->dev);
> >  	pm_runtime_mark_last_busy(&pdev->dev);
> > -	pm_runtime_set_active(&pdev->dev);
> >  
> >  	dev_dbg(&pdev->dev, "%s: handle pending notification\n", __func__);
> >  	for_each_port(card_ctx, port) {
> > -- 
> > 2.18.1
> 
> -- 
> Ville Syrjälä
> Intel
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 1/2] ALSA: x86: Fix runtime PM for hdmi-lpe-audio

[Ville Syrjälä]

On Fri, Nov 02, 2018 at 10:31:37AM +0100, Takashi Iwai wrote:
> On Thu, 01 Nov 2018 16:24:36 +0100,
> Ville Syrjälä wrote:
> > 
> > On Wed, Oct 24, 2018 at 06:48:24PM +0300, Ville Syrjala wrote:
> > > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > 
> > > Commit 46e831abe864 ("drm/i915/lpe: Mark LPE audio runtime pm as
> > > "no callbacks"") broke runtime PM with lpe audio. We can no longer
> > > runtime suspend the GPU since the sysfs  power/control for the
> > > lpe-audio device no longer exists and the device is considered
> > > always active. We can fix this by not marking the device as
> > > active.
> > > 
> > > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > > Cc: Takashi Iwai <tiwai@suse.de>
> > > Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> > > Fixes: 46e831abe864 ("drm/i915/lpe: Mark LPE audio runtime pm as "no callbacks"")
> > > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > 
> > Takashi, do you want to take these or should I just smash them
> > into drm-intel?
> 
> Feel free to go through drm-intel.
>   Acked-by: Takashi Iwai <tiwai@suse.de>

Thanks. Series pushed.

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx