From: David Miller <davem@davemloft.net> To: starnight@g.ncu.edu.tw Cc: afaerber@suse.de, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, marcel@holtmann.org, dollar.chen@wtmec.com, ken.yu@rakwireless.com, linux-wpan@vger.kernel.org, stefan@datenfreihafen.org Subject: Re: [PATCH V2 2/7] net: lorawan: Add LoRaWAN socket module Date: Mon, 05 Nov 2018 10:16:10 -0800 (PST) [thread overview] Message-ID: <20181105.101610.1437737564548154497.davem@davemloft.net> (raw) In-Reply-To: <20181105165544.5215-3-starnight@g.ncu.edu.tw> From: Jian-Hong Pan <starnight@g.ncu.edu.tw> Date: Tue, 6 Nov 2018 00:55:40 +0800 > +static inline struct lrw_mac_cb * mac_cb(struct sk_buff *skb) "mac_cb()" is pretty generic for a name, and leads to namespace pollution, please use lrw_mac_cb() or similar. > +static inline struct dgram_sock * > +dgram_sk(const struct sock *sk) > +{ > + return container_of(sk, struct dgram_sock, sk); > +} > + > +static inline struct net_device * > +lrw_get_dev_by_addr(struct net *net, u32 devaddr) Never use inline for functions in a foo.c file, let the compiler decide. > +{ > + struct net_device *ndev = NULL; > + __be32 be_addr = cpu_to_be32(devaddr); Always order local variables from longest to shortest line. > +static int > +dgram_recvmsg(struct sock *sk, struct msghdr *msg, size_t len, > + int noblock, int flags, int *addr_len) > +{ > + struct sk_buff *skb; > + size_t copied = 0; > + DECLARE_SOCKADDR(struct sockaddr_lorawan *, saddr, msg->msg_name); > + int err; Likewise. I'm not going to point out every single place where you have made these two errors. Please audit your entire submission and fix the problems wherever they occur. Thank you.
WARNING: multiple messages have this Message-ID (diff)
From: davem@davemloft.net (David Miller) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH V2 2/7] net: lorawan: Add LoRaWAN socket module Date: Mon, 05 Nov 2018 10:16:10 -0800 (PST) [thread overview] Message-ID: <20181105.101610.1437737564548154497.davem@davemloft.net> (raw) In-Reply-To: <20181105165544.5215-3-starnight@g.ncu.edu.tw> From: Jian-Hong Pan <starnight@g.ncu.edu.tw> Date: Tue, 6 Nov 2018 00:55:40 +0800 > +static inline struct lrw_mac_cb * mac_cb(struct sk_buff *skb) "mac_cb()" is pretty generic for a name, and leads to namespace pollution, please use lrw_mac_cb() or similar. > +static inline struct dgram_sock * > +dgram_sk(const struct sock *sk) > +{ > + return container_of(sk, struct dgram_sock, sk); > +} > + > +static inline struct net_device * > +lrw_get_dev_by_addr(struct net *net, u32 devaddr) Never use inline for functions in a foo.c file, let the compiler decide. > +{ > + struct net_device *ndev = NULL; > + __be32 be_addr = cpu_to_be32(devaddr); Always order local variables from longest to shortest line. > +static int > +dgram_recvmsg(struct sock *sk, struct msghdr *msg, size_t len, > + int noblock, int flags, int *addr_len) > +{ > + struct sk_buff *skb; > + size_t copied = 0; > + DECLARE_SOCKADDR(struct sockaddr_lorawan *, saddr, msg->msg_name); > + int err; Likewise. I'm not going to point out every single place where you have made these two errors. Please audit your entire submission and fix the problems wherever they occur. Thank you.
next prev parent reply other threads:[~2018-11-05 18:22 UTC|newest] Thread overview: 162+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-08-23 17:15 [RFC 0/3 net] lorawan: Add LoRaWAN soft MAC module Jian-Hong Pan 2018-08-23 17:15 ` Jian-Hong Pan 2018-08-23 17:15 ` Jian-Hong Pan 2018-08-23 17:15 ` [RFC 1/3 net] lorawan: Add LoRaWAN class module Jian-Hong Pan 2018-08-23 17:15 ` Jian-Hong Pan 2018-08-23 17:15 ` Jian-Hong Pan 2018-08-23 17:43 ` Randy Dunlap 2018-08-23 17:43 ` Randy Dunlap 2018-08-23 17:43 ` Randy Dunlap 2018-08-23 17:43 ` Randy Dunlap 2018-08-24 15:58 ` Jian-Hong Pan 2018-08-24 15:58 ` Jian-Hong Pan 2018-08-24 15:58 ` Jian-Hong Pan 2018-09-23 16:40 ` Andreas Färber 2018-09-23 16:40 ` Andreas Färber 2018-09-23 16:40 ` Andreas Färber 2018-09-26 15:52 ` Jian-Hong Pan 2018-09-26 15:52 ` Jian-Hong Pan 2018-09-26 15:52 ` Jian-Hong Pan 2018-11-05 16:55 ` [PATCH V2 0/7] net: lorawan: Add LoRaWAN soft MAC module Jian-Hong Pan 2018-11-05 16:55 ` Jian-Hong Pan 2018-11-05 16:55 ` [PATCH V2 1/7] net: lorawan: Add macro and definition for LoRaWAN Jian-Hong Pan 2018-11-05 16:55 ` Jian-Hong Pan 2018-11-05 16:55 ` [PATCH V2 2/7] net: lorawan: Add LoRaWAN socket module Jian-Hong Pan 2018-11-05 16:55 ` Jian-Hong Pan 2018-11-05 18:16 ` David Miller [this message] 2018-11-05 18:16 ` David Miller 2018-11-06 14:28 ` Jian-Hong Pan 2018-11-06 14:28 ` Jian-Hong Pan 2018-11-14 16:01 ` [PATCH V3 0/7] net: lorawan: Add LoRaWAN soft MAC module Jian-Hong Pan 2018-11-14 16:01 ` Jian-Hong Pan 2018-11-14 16:01 ` [PATCH V3 1/7] net: lorawan: Add macro and definition for LoRaWAN Jian-Hong Pan 2018-11-14 16:01 ` Jian-Hong Pan 2018-11-14 16:12 ` Andreas Färber 2018-11-14 16:12 ` Andreas Färber 2018-11-17 6:47 ` Jian-Hong Pan 2018-11-17 6:47 ` Jian-Hong Pan 2018-11-17 6:47 ` Jian-Hong Pan 2018-11-14 16:01 ` [PATCH V3 2/7] net: lorawan: Add LoRaWAN socket module Jian-Hong Pan 2018-11-14 16:01 ` Jian-Hong Pan 2018-11-17 4:32 ` David Miller 2018-11-17 4:32 ` David Miller 2018-11-17 14:54 ` Jian-Hong Pan 2018-11-17 14:54 ` Jian-Hong Pan 2018-12-04 14:13 ` [PATCH V4 0/6] net: lorawan: Add LoRaWAN soft MAC module Jian-Hong Pan 2018-12-04 14:13 ` Jian-Hong Pan 2018-12-04 14:13 ` [PATCH V4 1/6] net: lorawan: Add LoRaWAN socket module Jian-Hong Pan 2018-12-04 14:13 ` Jian-Hong Pan 2018-12-04 14:13 ` [PATCH V4 2/6] net: lorawan: Add LoRaWAN API declaration for LoRa devices Jian-Hong Pan 2018-12-04 14:13 ` Jian-Hong Pan 2018-12-04 14:13 ` [PATCH V4 3/6] net: maclorawan: Add maclorawan module declaration Jian-Hong Pan 2018-12-04 14:13 ` Jian-Hong Pan 2018-12-04 14:13 ` [PATCH V4 4/6] net: maclorawan: Implement the crypto of maclorawan module Jian-Hong Pan 2018-12-04 14:13 ` Jian-Hong Pan 2018-12-04 14:13 ` [PATCH V4 5/6] net: maclorawan: Implement maclorawan class module Jian-Hong Pan 2018-12-04 14:13 ` Jian-Hong Pan 2018-12-04 20:45 ` Alan Cox 2018-12-04 20:45 ` Alan Cox 2018-12-04 20:45 ` Alan Cox 2018-12-09 8:27 ` Jian-Hong Pan 2018-12-09 8:27 ` Jian-Hong Pan 2018-12-16 10:18 ` [PATCH v5 0/6] net: lorawan: Add LoRaWAN soft MAC module Jian-Hong Pan 2018-12-16 10:18 ` Jian-Hong Pan 2018-12-17 13:51 ` Jiri Pirko 2018-12-17 13:51 ` Jiri Pirko 2018-12-16 10:18 ` [PATCH v5 1/6] net: lorawan: Add LoRaWAN socket module Jian-Hong Pan 2018-12-16 10:18 ` Jian-Hong Pan 2018-12-29 7:27 ` Andreas Färber 2018-12-29 7:27 ` Andreas Färber 2019-01-07 14:47 ` Jian-Hong Pan 2019-01-07 14:47 ` Jian-Hong Pan 2019-01-07 14:47 ` Jian-Hong Pan 2019-01-13 14:51 ` Jian-Hong Pan 2019-01-13 14:51 ` Jian-Hong Pan 2019-01-13 14:51 ` Jian-Hong Pan 2018-12-16 10:18 ` [PATCH v5 2/6] net: lorawan: Add LoRaWAN API declaration for LoRa devices Jian-Hong Pan 2018-12-16 10:18 ` Jian-Hong Pan 2018-12-16 10:18 ` [PATCH v5 3/6] net: maclorawan: Add maclorawan module declaration Jian-Hong Pan 2018-12-16 10:18 ` Jian-Hong Pan 2018-12-16 10:18 ` [PATCH v5 4/6] net: maclorawan: Implement the crypto of maclorawan module Jian-Hong Pan 2018-12-16 10:18 ` Jian-Hong Pan 2018-12-16 10:18 ` [PATCH v5 5/6] net: maclorawan: Implement maclorawan class module Jian-Hong Pan 2018-12-16 10:18 ` Jian-Hong Pan 2018-12-17 14:02 ` Jiri Pirko 2018-12-17 14:02 ` Jiri Pirko 2018-12-18 14:27 ` Jian-Hong Pan 2018-12-18 14:27 ` Jian-Hong Pan 2018-12-18 14:27 ` Jiri Pirko 2018-12-18 14:27 ` Jiri Pirko 2018-12-18 15:34 ` Jian-Hong Pan 2018-12-18 15:34 ` Jian-Hong Pan 2018-12-18 18:49 ` Andreas Färber 2018-12-18 18:49 ` Andreas Färber 2018-12-19 11:27 ` Ben Whitten 2018-12-19 11:27 ` Ben Whitten 2018-12-19 11:27 ` Ben Whitten 2018-12-19 16:26 ` Jian-Hong Pan 2018-12-19 16:26 ` Jian-Hong Pan 2018-12-20 9:20 ` Xue Liu 2018-12-20 16:00 ` Jian-Hong Pan 2018-12-28 8:11 ` Netlink userspace tools for LoRa(WAN), FSK, Sigfox, BLE, etc. (was: [PATCH v5 5/6] net: maclorawan: Implement maclorawan class module) Andreas Färber 2018-12-28 15:49 ` Alexander Aring 2018-12-20 10:19 ` [PATCH v5 5/6] net: maclorawan: Implement maclorawan class module Ben Whitten 2018-12-20 10:19 ` Ben Whitten 2018-12-20 15:31 ` Andreas Färber 2018-12-20 15:31 ` Andreas Färber 2018-12-20 15:31 ` Andreas Färber 2018-12-16 10:19 ` [PATCH v5 6/6] net: lorawan: List LORAWAN in menuconfig Jian-Hong Pan 2018-12-16 10:19 ` Jian-Hong Pan 2018-12-17 8:50 ` Xue Liu 2018-12-17 8:50 ` Xue Liu 2018-12-17 14:19 ` Andreas Färber 2018-12-17 14:19 ` Andreas Färber 2018-12-18 13:50 ` Xue Liu 2018-12-18 13:50 ` Xue Liu 2018-12-24 15:32 ` Alexander Aring 2018-12-24 15:32 ` Alexander Aring 2018-12-28 4:57 ` Andreas Färber 2018-12-28 4:57 ` Andreas Färber 2018-12-28 15:43 ` Alexander Aring 2018-12-28 15:43 ` Alexander Aring 2018-12-29 6:28 ` Andreas Färber 2018-12-29 6:28 ` Andreas Färber 2018-12-04 14:13 ` [PATCH V4 " Jian-Hong Pan 2018-12-04 14:13 ` Jian-Hong Pan 2018-11-14 16:01 ` [PATCH V3 3/7] net: lorawan: Add LoRaWAN API declaration for LoRa devices Jian-Hong Pan 2018-11-14 16:01 ` Jian-Hong Pan 2018-11-14 16:01 ` [PATCH V3 4/7] net: maclorawan: Add maclorawan module declaration Jian-Hong Pan 2018-11-14 16:01 ` Jian-Hong Pan 2018-11-17 4:32 ` David Miller 2018-11-17 4:32 ` David Miller 2018-11-17 6:32 ` Jian-Hong Pan 2018-11-17 6:32 ` Jian-Hong Pan 2018-11-14 16:01 ` [PATCH V3 5/7] net: maclorawan: Implement the crypto of maclorawan module Jian-Hong Pan 2018-11-14 16:01 ` Jian-Hong Pan 2018-11-14 16:01 ` [PATCH V3 6/7] net: maclorawan: Implement maclorawan class module Jian-Hong Pan 2018-11-14 16:01 ` Jian-Hong Pan 2018-11-14 16:01 ` [PATCH V3 7/7] net: lorawan: List LORAWAN in menuconfig Jian-Hong Pan 2018-11-14 16:01 ` Jian-Hong Pan 2018-11-05 16:55 ` [PATCH V2 3/7] net: lorawan: Add LoRaWAN API declaration for LoRa devices Jian-Hong Pan 2018-11-05 16:55 ` Jian-Hong Pan 2018-11-05 16:55 ` [PATCH V2 4/7] net: maclorawan: Add maclorawan module declaration Jian-Hong Pan 2018-11-05 16:55 ` Jian-Hong Pan 2018-11-05 16:55 ` [PATCH V2 5/7] net: maclorawan: Implement the crypto of maclorawan module Jian-Hong Pan 2018-11-05 16:55 ` Jian-Hong Pan 2018-11-05 16:55 ` Jian-Hong Pan 2018-11-05 16:55 ` [PATCH V2 6/7] net: maclorawan: Implement maclorawan class module Jian-Hong Pan 2018-11-05 16:55 ` Jian-Hong Pan 2018-11-05 16:55 ` [PATCH V2 7/7] net: lorawan: List LORAWAN in menuconfig Jian-Hong Pan 2018-11-05 16:55 ` Jian-Hong Pan 2018-08-23 17:15 ` [RFC 2/3 net] lorawan: Add macro and definition for LoRaWAN class modlue Jian-Hong Pan 2018-08-23 17:15 ` Jian-Hong Pan 2018-08-23 17:15 ` Jian-Hong Pan 2018-09-23 16:06 ` Andreas Färber 2018-09-23 16:06 ` Andreas Färber 2018-09-23 16:06 ` Andreas Färber 2018-09-26 14:46 ` Jian-Hong Pan 2018-09-26 14:46 ` Jian-Hong Pan 2018-09-26 14:46 ` Jian-Hong Pan 2018-08-23 17:15 ` [RFC 3/3 net] lorawan: List LORAWAN in menuconfig Jian-Hong Pan 2018-08-23 17:15 ` Jian-Hong Pan 2018-08-23 17:15 ` Jian-Hong Pan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181105.101610.1437737564548154497.davem@davemloft.net \ --to=davem@davemloft.net \ --cc=afaerber@suse.de \ --cc=dollar.chen@wtmec.com \ --cc=ken.yu@rakwireless.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-wpan@vger.kernel.org \ --cc=marcel@holtmann.org \ --cc=netdev@vger.kernel.org \ --cc=starnight@g.ncu.edu.tw \ --cc=stefan@datenfreihafen.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.