From: Jiri Pirko <jiri@resnulli.us> To: Jian-Hong Pan <starnight@g.ncu.edu.tw> Cc: "Andreas Färber" <afaerber@suse.de>, "David S . Miller" <davem@davemloft.net>, "Alan Cox" <gnomes@lxorguk.ukuu.org.uk>, linux-lpwan@lists.infradead.org, netdev@vger.kernel.org, "<linux-arm-kernel@lists.infradead.org\\" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org>," <linux-kernel@vger.kernel.org>, "Marcel Holtmann" <marcel@holtmann.org>, "Dollar Chen" <dollar.chen@wtmec.com>, "Ken Yu" <ken.yu@rakwireless.com>, "linux-wpan - ML" <linux-wpan@vger.kernel.org> Subject: Re: [PATCH v5 5/6] net: maclorawan: Implement maclorawan class module Date: Tue, 18 Dec 2018 15:27:56 +0100 [thread overview] Message-ID: <20181218142756.GA2031@nanopsycho> (raw) In-Reply-To: <CAC=mGziN5KrXPMAXoN_hhfQrtofCeyzTr4AjbbJLOoJ+p2+Nng@mail.gmail.com> Tue, Dec 18, 2018 at 03:27:09PM CET, starnight@g.ncu.edu.tw wrote: >> Sun, Dec 16, 2018 at 11:18:59AM CET, starnight@g.ncu.edu.tw wrote: >> >LoRaWAN defined by LoRa Alliance(TM) is the MAC layer over LoRa devices. >> > >> >This patch implements part of Class A end-devices SoftMAC defined in >> >LoRaWAN(TM) Specification Ver. 1.0.2: >> >1. End-device receive slot timing >> >2. Only single channel and single data rate for now >> >3. Unconfirmed data up/down message types >> > >> >On the other side, it defines the basic interface and operation >> >functions for compatible LoRa device drivers. >> > >> >Signed-off-by: Jian-Hong Pan <starnight@g.ncu.edu.tw> >> >--- >> >V2: >> >- Split the LoRaWAN class module patch in V1 into LoRaWAN socket and >> > LoRaWAN Soft MAC modules >> >- Modify for Big/Little-Endian >> >- Use SPDX license identifiers >> > >> >V3: >> >- Remove the decoration word - inline of the functions >> >- Order local variables from longest to shortest line in the functions >> >- Change the calling mac_cb function to lrw_get_mac_cb macro >> > >> >V4: >> >- Fix the delay period between RX window#1 and window#2 >> >- Fix by coding style report from scripts/checkpatch.pl >> > >> >V5: >> >- Initial rx_skb_list when it is allocated with LoRa hardware >> >- Check the sk_buff's data length before access it >> >- Deal FPort field and decrypt payload in lrw_parse_frame function >> >- Drop the recieved frame if parse failed >> >- Fix the bug which passes wrong skb properties from maclorawan to lorawan module >> > >> > net/maclorawan/Kconfig | 14 + >> > net/maclorawan/Makefile | 2 + >> > net/maclorawan/mac.c | 555 ++++++++++++++++++++++++++++++++++++ >> > net/maclorawan/main.c | 606 ++++++++++++++++++++++++++++++++++++++++ >> > 4 files changed, 1177 insertions(+) >> > create mode 100644 net/maclorawan/Kconfig >> > create mode 100644 net/maclorawan/Makefile >> > create mode 100644 net/maclorawan/mac.c >> > create mode 100644 net/maclorawan/main.c >> >> >> I don't get it. In patch "Add LoRaWAN API declaration for LoRa devices" >> you add headers for "API" and here you implement functions. That is just >> weird. Does it mean you can have other implementations? > >LoRaWAN defined by LoRa Alliance(TM) is the MAC layer over LoRa PHY. >This part is soft-MAC as Andreas mentioned >http://lists.infradead.org/pipermail/linux-lpwan/2018-December/000010.html Okay, that does not answer my concern about header file in one patch and the actual implementation of functions in another one. > >> Also, you don't really have any user of this API in the set. Please >> introduce at least 1 driver, preferably more (I see that Andreas has >> multiple ones in his patchset). You cannot push kernel infrastructure >> without kernel user. > >The soft-MAC is suitable for the LoRa chips' device drivers, like >sx1276/77/78/79, RFM95/96/97/98W ... >Still waiting for Andreas' sx1276 version 2 patch and more discussion. >For example, how to make PF_LORA and PF_LORAWAN like Ethernet, PF_INET >and PF_INET6 don't need separate devices either, both use eth0. >https://lkml.org/lkml/2018/8/3/266 Then you should push this is RFC or together with Andreases work in a single patchset. Infra without users cannot be merged. > >Jian-Hong Pan
WARNING: multiple messages have this Message-ID (diff)
From: Jiri Pirko <jiri@resnulli.us> To: Jian-Hong Pan <starnight@g.ncu.edu.tw> Cc: "Alan Cox" <gnomes@lxorguk.ukuu.org.uk>, "linux-kernel@vger.kernel.org>, " <linux-kernel@vger.kernel.org>, netdev@vger.kernel.org, "Marcel Holtmann" <marcel@holtmann.org>, linux-lpwan@lists.infradead.org, "David S . Miller" <davem@davemloft.net>, "Dollar Chen" <dollar.chen@wtmec.com>, "Ken Yu" <ken.yu@rakwireless.com>, "linux-wpan - ML" <linux-wpan@vger.kernel.org>, "Andreas Färber" <afaerber@suse.de>, "<linux-arm-kernel@lists.infradead.org\\" <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH v5 5/6] net: maclorawan: Implement maclorawan class module Date: Tue, 18 Dec 2018 15:27:56 +0100 [thread overview] Message-ID: <20181218142756.GA2031@nanopsycho> (raw) In-Reply-To: <CAC=mGziN5KrXPMAXoN_hhfQrtofCeyzTr4AjbbJLOoJ+p2+Nng@mail.gmail.com> Tue, Dec 18, 2018 at 03:27:09PM CET, starnight@g.ncu.edu.tw wrote: >> Sun, Dec 16, 2018 at 11:18:59AM CET, starnight@g.ncu.edu.tw wrote: >> >LoRaWAN defined by LoRa Alliance(TM) is the MAC layer over LoRa devices. >> > >> >This patch implements part of Class A end-devices SoftMAC defined in >> >LoRaWAN(TM) Specification Ver. 1.0.2: >> >1. End-device receive slot timing >> >2. Only single channel and single data rate for now >> >3. Unconfirmed data up/down message types >> > >> >On the other side, it defines the basic interface and operation >> >functions for compatible LoRa device drivers. >> > >> >Signed-off-by: Jian-Hong Pan <starnight@g.ncu.edu.tw> >> >--- >> >V2: >> >- Split the LoRaWAN class module patch in V1 into LoRaWAN socket and >> > LoRaWAN Soft MAC modules >> >- Modify for Big/Little-Endian >> >- Use SPDX license identifiers >> > >> >V3: >> >- Remove the decoration word - inline of the functions >> >- Order local variables from longest to shortest line in the functions >> >- Change the calling mac_cb function to lrw_get_mac_cb macro >> > >> >V4: >> >- Fix the delay period between RX window#1 and window#2 >> >- Fix by coding style report from scripts/checkpatch.pl >> > >> >V5: >> >- Initial rx_skb_list when it is allocated with LoRa hardware >> >- Check the sk_buff's data length before access it >> >- Deal FPort field and decrypt payload in lrw_parse_frame function >> >- Drop the recieved frame if parse failed >> >- Fix the bug which passes wrong skb properties from maclorawan to lorawan module >> > >> > net/maclorawan/Kconfig | 14 + >> > net/maclorawan/Makefile | 2 + >> > net/maclorawan/mac.c | 555 ++++++++++++++++++++++++++++++++++++ >> > net/maclorawan/main.c | 606 ++++++++++++++++++++++++++++++++++++++++ >> > 4 files changed, 1177 insertions(+) >> > create mode 100644 net/maclorawan/Kconfig >> > create mode 100644 net/maclorawan/Makefile >> > create mode 100644 net/maclorawan/mac.c >> > create mode 100644 net/maclorawan/main.c >> >> >> I don't get it. In patch "Add LoRaWAN API declaration for LoRa devices" >> you add headers for "API" and here you implement functions. That is just >> weird. Does it mean you can have other implementations? > >LoRaWAN defined by LoRa Alliance(TM) is the MAC layer over LoRa PHY. >This part is soft-MAC as Andreas mentioned >http://lists.infradead.org/pipermail/linux-lpwan/2018-December/000010.html Okay, that does not answer my concern about header file in one patch and the actual implementation of functions in another one. > >> Also, you don't really have any user of this API in the set. Please >> introduce at least 1 driver, preferably more (I see that Andreas has >> multiple ones in his patchset). You cannot push kernel infrastructure >> without kernel user. > >The soft-MAC is suitable for the LoRa chips' device drivers, like >sx1276/77/78/79, RFM95/96/97/98W ... >Still waiting for Andreas' sx1276 version 2 patch and more discussion. >For example, how to make PF_LORA and PF_LORAWAN like Ethernet, PF_INET >and PF_INET6 don't need separate devices either, both use eth0. >https://lkml.org/lkml/2018/8/3/266 Then you should push this is RFC or together with Andreases work in a single patchset. Infra without users cannot be merged. > >Jian-Hong Pan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2018-12-18 14:35 UTC|newest] Thread overview: 162+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-08-23 17:15 [RFC 0/3 net] lorawan: Add LoRaWAN soft MAC module Jian-Hong Pan 2018-08-23 17:15 ` Jian-Hong Pan 2018-08-23 17:15 ` Jian-Hong Pan 2018-08-23 17:15 ` [RFC 1/3 net] lorawan: Add LoRaWAN class module Jian-Hong Pan 2018-08-23 17:15 ` Jian-Hong Pan 2018-08-23 17:15 ` Jian-Hong Pan 2018-08-23 17:43 ` Randy Dunlap 2018-08-23 17:43 ` Randy Dunlap 2018-08-23 17:43 ` Randy Dunlap 2018-08-23 17:43 ` Randy Dunlap 2018-08-24 15:58 ` Jian-Hong Pan 2018-08-24 15:58 ` Jian-Hong Pan 2018-08-24 15:58 ` Jian-Hong Pan 2018-09-23 16:40 ` Andreas Färber 2018-09-23 16:40 ` Andreas Färber 2018-09-23 16:40 ` Andreas Färber 2018-09-26 15:52 ` Jian-Hong Pan 2018-09-26 15:52 ` Jian-Hong Pan 2018-09-26 15:52 ` Jian-Hong Pan 2018-11-05 16:55 ` [PATCH V2 0/7] net: lorawan: Add LoRaWAN soft MAC module Jian-Hong Pan 2018-11-05 16:55 ` Jian-Hong Pan 2018-11-05 16:55 ` [PATCH V2 1/7] net: lorawan: Add macro and definition for LoRaWAN Jian-Hong Pan 2018-11-05 16:55 ` Jian-Hong Pan 2018-11-05 16:55 ` [PATCH V2 2/7] net: lorawan: Add LoRaWAN socket module Jian-Hong Pan 2018-11-05 16:55 ` Jian-Hong Pan 2018-11-05 18:16 ` David Miller 2018-11-05 18:16 ` David Miller 2018-11-06 14:28 ` Jian-Hong Pan 2018-11-06 14:28 ` Jian-Hong Pan 2018-11-14 16:01 ` [PATCH V3 0/7] net: lorawan: Add LoRaWAN soft MAC module Jian-Hong Pan 2018-11-14 16:01 ` Jian-Hong Pan 2018-11-14 16:01 ` [PATCH V3 1/7] net: lorawan: Add macro and definition for LoRaWAN Jian-Hong Pan 2018-11-14 16:01 ` Jian-Hong Pan 2018-11-14 16:12 ` Andreas Färber 2018-11-14 16:12 ` Andreas Färber 2018-11-17 6:47 ` Jian-Hong Pan 2018-11-17 6:47 ` Jian-Hong Pan 2018-11-17 6:47 ` Jian-Hong Pan 2018-11-14 16:01 ` [PATCH V3 2/7] net: lorawan: Add LoRaWAN socket module Jian-Hong Pan 2018-11-14 16:01 ` Jian-Hong Pan 2018-11-17 4:32 ` David Miller 2018-11-17 4:32 ` David Miller 2018-11-17 14:54 ` Jian-Hong Pan 2018-11-17 14:54 ` Jian-Hong Pan 2018-12-04 14:13 ` [PATCH V4 0/6] net: lorawan: Add LoRaWAN soft MAC module Jian-Hong Pan 2018-12-04 14:13 ` Jian-Hong Pan 2018-12-04 14:13 ` [PATCH V4 1/6] net: lorawan: Add LoRaWAN socket module Jian-Hong Pan 2018-12-04 14:13 ` Jian-Hong Pan 2018-12-04 14:13 ` [PATCH V4 2/6] net: lorawan: Add LoRaWAN API declaration for LoRa devices Jian-Hong Pan 2018-12-04 14:13 ` Jian-Hong Pan 2018-12-04 14:13 ` [PATCH V4 3/6] net: maclorawan: Add maclorawan module declaration Jian-Hong Pan 2018-12-04 14:13 ` Jian-Hong Pan 2018-12-04 14:13 ` [PATCH V4 4/6] net: maclorawan: Implement the crypto of maclorawan module Jian-Hong Pan 2018-12-04 14:13 ` Jian-Hong Pan 2018-12-04 14:13 ` [PATCH V4 5/6] net: maclorawan: Implement maclorawan class module Jian-Hong Pan 2018-12-04 14:13 ` Jian-Hong Pan 2018-12-04 20:45 ` Alan Cox 2018-12-04 20:45 ` Alan Cox 2018-12-04 20:45 ` Alan Cox 2018-12-09 8:27 ` Jian-Hong Pan 2018-12-09 8:27 ` Jian-Hong Pan 2018-12-16 10:18 ` [PATCH v5 0/6] net: lorawan: Add LoRaWAN soft MAC module Jian-Hong Pan 2018-12-16 10:18 ` Jian-Hong Pan 2018-12-17 13:51 ` Jiri Pirko 2018-12-17 13:51 ` Jiri Pirko 2018-12-16 10:18 ` [PATCH v5 1/6] net: lorawan: Add LoRaWAN socket module Jian-Hong Pan 2018-12-16 10:18 ` Jian-Hong Pan 2018-12-29 7:27 ` Andreas Färber 2018-12-29 7:27 ` Andreas Färber 2019-01-07 14:47 ` Jian-Hong Pan 2019-01-07 14:47 ` Jian-Hong Pan 2019-01-07 14:47 ` Jian-Hong Pan 2019-01-13 14:51 ` Jian-Hong Pan 2019-01-13 14:51 ` Jian-Hong Pan 2019-01-13 14:51 ` Jian-Hong Pan 2018-12-16 10:18 ` [PATCH v5 2/6] net: lorawan: Add LoRaWAN API declaration for LoRa devices Jian-Hong Pan 2018-12-16 10:18 ` Jian-Hong Pan 2018-12-16 10:18 ` [PATCH v5 3/6] net: maclorawan: Add maclorawan module declaration Jian-Hong Pan 2018-12-16 10:18 ` Jian-Hong Pan 2018-12-16 10:18 ` [PATCH v5 4/6] net: maclorawan: Implement the crypto of maclorawan module Jian-Hong Pan 2018-12-16 10:18 ` Jian-Hong Pan 2018-12-16 10:18 ` [PATCH v5 5/6] net: maclorawan: Implement maclorawan class module Jian-Hong Pan 2018-12-16 10:18 ` Jian-Hong Pan 2018-12-17 14:02 ` Jiri Pirko 2018-12-17 14:02 ` Jiri Pirko 2018-12-18 14:27 ` Jian-Hong Pan 2018-12-18 14:27 ` Jian-Hong Pan 2018-12-18 14:27 ` Jiri Pirko [this message] 2018-12-18 14:27 ` Jiri Pirko 2018-12-18 15:34 ` Jian-Hong Pan 2018-12-18 15:34 ` Jian-Hong Pan 2018-12-18 18:49 ` Andreas Färber 2018-12-18 18:49 ` Andreas Färber 2018-12-19 11:27 ` Ben Whitten 2018-12-19 11:27 ` Ben Whitten 2018-12-19 11:27 ` Ben Whitten 2018-12-19 16:26 ` Jian-Hong Pan 2018-12-19 16:26 ` Jian-Hong Pan 2018-12-20 9:20 ` Xue Liu 2018-12-20 16:00 ` Jian-Hong Pan 2018-12-28 8:11 ` Netlink userspace tools for LoRa(WAN), FSK, Sigfox, BLE, etc. (was: [PATCH v5 5/6] net: maclorawan: Implement maclorawan class module) Andreas Färber 2018-12-28 15:49 ` Alexander Aring 2018-12-20 10:19 ` [PATCH v5 5/6] net: maclorawan: Implement maclorawan class module Ben Whitten 2018-12-20 10:19 ` Ben Whitten 2018-12-20 15:31 ` Andreas Färber 2018-12-20 15:31 ` Andreas Färber 2018-12-20 15:31 ` Andreas Färber 2018-12-16 10:19 ` [PATCH v5 6/6] net: lorawan: List LORAWAN in menuconfig Jian-Hong Pan 2018-12-16 10:19 ` Jian-Hong Pan 2018-12-17 8:50 ` Xue Liu 2018-12-17 8:50 ` Xue Liu 2018-12-17 14:19 ` Andreas Färber 2018-12-17 14:19 ` Andreas Färber 2018-12-18 13:50 ` Xue Liu 2018-12-18 13:50 ` Xue Liu 2018-12-24 15:32 ` Alexander Aring 2018-12-24 15:32 ` Alexander Aring 2018-12-28 4:57 ` Andreas Färber 2018-12-28 4:57 ` Andreas Färber 2018-12-28 15:43 ` Alexander Aring 2018-12-28 15:43 ` Alexander Aring 2018-12-29 6:28 ` Andreas Färber 2018-12-29 6:28 ` Andreas Färber 2018-12-04 14:13 ` [PATCH V4 " Jian-Hong Pan 2018-12-04 14:13 ` Jian-Hong Pan 2018-11-14 16:01 ` [PATCH V3 3/7] net: lorawan: Add LoRaWAN API declaration for LoRa devices Jian-Hong Pan 2018-11-14 16:01 ` Jian-Hong Pan 2018-11-14 16:01 ` [PATCH V3 4/7] net: maclorawan: Add maclorawan module declaration Jian-Hong Pan 2018-11-14 16:01 ` Jian-Hong Pan 2018-11-17 4:32 ` David Miller 2018-11-17 4:32 ` David Miller 2018-11-17 6:32 ` Jian-Hong Pan 2018-11-17 6:32 ` Jian-Hong Pan 2018-11-14 16:01 ` [PATCH V3 5/7] net: maclorawan: Implement the crypto of maclorawan module Jian-Hong Pan 2018-11-14 16:01 ` Jian-Hong Pan 2018-11-14 16:01 ` [PATCH V3 6/7] net: maclorawan: Implement maclorawan class module Jian-Hong Pan 2018-11-14 16:01 ` Jian-Hong Pan 2018-11-14 16:01 ` [PATCH V3 7/7] net: lorawan: List LORAWAN in menuconfig Jian-Hong Pan 2018-11-14 16:01 ` Jian-Hong Pan 2018-11-05 16:55 ` [PATCH V2 3/7] net: lorawan: Add LoRaWAN API declaration for LoRa devices Jian-Hong Pan 2018-11-05 16:55 ` Jian-Hong Pan 2018-11-05 16:55 ` [PATCH V2 4/7] net: maclorawan: Add maclorawan module declaration Jian-Hong Pan 2018-11-05 16:55 ` Jian-Hong Pan 2018-11-05 16:55 ` [PATCH V2 5/7] net: maclorawan: Implement the crypto of maclorawan module Jian-Hong Pan 2018-11-05 16:55 ` Jian-Hong Pan 2018-11-05 16:55 ` Jian-Hong Pan 2018-11-05 16:55 ` [PATCH V2 6/7] net: maclorawan: Implement maclorawan class module Jian-Hong Pan 2018-11-05 16:55 ` Jian-Hong Pan 2018-11-05 16:55 ` [PATCH V2 7/7] net: lorawan: List LORAWAN in menuconfig Jian-Hong Pan 2018-11-05 16:55 ` Jian-Hong Pan 2018-08-23 17:15 ` [RFC 2/3 net] lorawan: Add macro and definition for LoRaWAN class modlue Jian-Hong Pan 2018-08-23 17:15 ` Jian-Hong Pan 2018-08-23 17:15 ` Jian-Hong Pan 2018-09-23 16:06 ` Andreas Färber 2018-09-23 16:06 ` Andreas Färber 2018-09-23 16:06 ` Andreas Färber 2018-09-26 14:46 ` Jian-Hong Pan 2018-09-26 14:46 ` Jian-Hong Pan 2018-09-26 14:46 ` Jian-Hong Pan 2018-08-23 17:15 ` [RFC 3/3 net] lorawan: List LORAWAN in menuconfig Jian-Hong Pan 2018-08-23 17:15 ` Jian-Hong Pan 2018-08-23 17:15 ` Jian-Hong Pan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181218142756.GA2031@nanopsycho \ --to=jiri@resnulli.us \ --cc=afaerber@suse.de \ --cc=davem@davemloft.net \ --cc=dollar.chen@wtmec.com \ --cc=gnomes@lxorguk.ukuu.org.uk \ --cc=ken.yu@rakwireless.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-lpwan@lists.infradead.org \ --cc=linux-wpan@vger.kernel.org \ --cc=marcel@holtmann.org \ --cc=netdev@vger.kernel.org \ --cc=starnight@g.ncu.edu.tw \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.