From: Xue Liu <liuxuenetmail@gmail.com> To: "Andreas Färber" <afaerber@suse.de> Cc: Jian-Hong Pan <starnight@g.ncu.edu.tw>, "David S . Miller" <davem@davemloft.net>, Alan Cox <gnomes@lxorguk.ukuu.org.uk>, linux-lpwan@lists.infradead.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Marcel Holtmann <marcel@holtmann.org>, Dollar Chen <dollar.chen@wtmec.com>, Ken Yu <ken.yu@rakwireless.com>, linux-wpan - ML <linux-wpan@vger.kernel.org> Subject: Re: [PATCH v5 6/6] net: lorawan: List LORAWAN in menuconfig Date: Tue, 18 Dec 2018 14:50:58 +0100 [thread overview] Message-ID: <CAJuUDwsypFMEbTXZO+NwQ_FnD1wsO3ZRc3dthZphFGJ-u0n_=Q@mail.gmail.com> (raw) In-Reply-To: <8bfdccbf-fb47-daa5-fbd0-ed16a3d6d334@suse.de> Hello Andreas, On Mon, 17 Dec 2018 at 15:19, Andreas Färber <afaerber@suse.de> wrote: > > Hello Xue Liu, > > Am 17.12.18 um 09:50 schrieb Xue Liu: > > I have a question about the architecture of your module. AFAIK LoRaWAN > > is already the MAC Layer above the LoRa technology. Why do you want to > > make a new layer called "maclorawan" ? > > I had asked Jian-Hong to separate between his soft-MAC implementation > and the common bits needed to drive hard-MAC implementations found on > several of the hardware modules made available to me. > As a reference Linux 802.11 uses cfg80211 to talk with hard-MAC devices. We may also use the name “cfglora” for hard-MAC implementation. > The prefix "mac" was copied from mac80211 and mac802154: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/net > OK. Understood. I guess they use mac80211 and mac802154 to distinguish physical layer and MAC layer. Since LoRa and LoRaWAN are already separate I think "maclorawan" is not necessary. > If you have better ideas for how to structure this, just let us know, > ideally as inline comment where you see it (or on the cover letter). > > Only comment I have for this patch at the moment is that I would prefer > to have the Kconfig bits be in the patches adding the code, so that we > can actually build-test them before 6/6. > > Been updating my lab to 4.20-rcX with some hiccups. Ben's > regmap_noinc_write support made it into 4.20, so I expect to have Ben's > pending branch for sx1301 merged into rebased lora-next before Christmas > and my sx1276 conversion to follow, leaving the PF_PACKET vs. PF_LORA > discussion from ELCE - haven't assessed yet how much this series would > be affected by the underlying changes, but if the abstraction was done > right then only maclorawan implementation should be affected. > > Regards, > Andreas > > -- > SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany > GF: Felix Imendörffer, Jane Smithard, Graham Norton > HRB 21284 (AG Nürnberg) Regards, Xue Liu --
WARNING: multiple messages have this Message-ID (diff)
From: Xue Liu <liuxuenetmail@gmail.com> To: "Andreas Färber" <afaerber@suse.de> Cc: Alan Cox <gnomes@lxorguk.ukuu.org.uk>, netdev@vger.kernel.org, Marcel Holtmann <marcel@holtmann.org>, Dollar Chen <dollar.chen@wtmec.com>, linux-lpwan@lists.infradead.org, linux-kernel@vger.kernel.org, Jian-Hong Pan <starnight@g.ncu.edu.tw>, Ken Yu <ken.yu@rakwireless.com>, linux-wpan - ML <linux-wpan@vger.kernel.org>, "David S . Miller" <davem@davemloft.net>, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v5 6/6] net: lorawan: List LORAWAN in menuconfig Date: Tue, 18 Dec 2018 14:50:58 +0100 [thread overview] Message-ID: <CAJuUDwsypFMEbTXZO+NwQ_FnD1wsO3ZRc3dthZphFGJ-u0n_=Q@mail.gmail.com> (raw) In-Reply-To: <8bfdccbf-fb47-daa5-fbd0-ed16a3d6d334@suse.de> Hello Andreas, On Mon, 17 Dec 2018 at 15:19, Andreas Färber <afaerber@suse.de> wrote: > > Hello Xue Liu, > > Am 17.12.18 um 09:50 schrieb Xue Liu: > > I have a question about the architecture of your module. AFAIK LoRaWAN > > is already the MAC Layer above the LoRa technology. Why do you want to > > make a new layer called "maclorawan" ? > > I had asked Jian-Hong to separate between his soft-MAC implementation > and the common bits needed to drive hard-MAC implementations found on > several of the hardware modules made available to me. > As a reference Linux 802.11 uses cfg80211 to talk with hard-MAC devices. We may also use the name “cfglora” for hard-MAC implementation. > The prefix "mac" was copied from mac80211 and mac802154: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/net > OK. Understood. I guess they use mac80211 and mac802154 to distinguish physical layer and MAC layer. Since LoRa and LoRaWAN are already separate I think "maclorawan" is not necessary. > If you have better ideas for how to structure this, just let us know, > ideally as inline comment where you see it (or on the cover letter). > > Only comment I have for this patch at the moment is that I would prefer > to have the Kconfig bits be in the patches adding the code, so that we > can actually build-test them before 6/6. > > Been updating my lab to 4.20-rcX with some hiccups. Ben's > regmap_noinc_write support made it into 4.20, so I expect to have Ben's > pending branch for sx1301 merged into rebased lora-next before Christmas > and my sx1276 conversion to follow, leaving the PF_PACKET vs. PF_LORA > discussion from ELCE - haven't assessed yet how much this series would > be affected by the underlying changes, but if the abstraction was done > right then only maclorawan implementation should be affected. > > Regards, > Andreas > > -- > SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany > GF: Felix Imendörffer, Jane Smithard, Graham Norton > HRB 21284 (AG Nürnberg) Regards, Xue Liu -- _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2018-12-18 13:51 UTC|newest] Thread overview: 162+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-08-23 17:15 [RFC 0/3 net] lorawan: Add LoRaWAN soft MAC module Jian-Hong Pan 2018-08-23 17:15 ` Jian-Hong Pan 2018-08-23 17:15 ` Jian-Hong Pan 2018-08-23 17:15 ` [RFC 1/3 net] lorawan: Add LoRaWAN class module Jian-Hong Pan 2018-08-23 17:15 ` Jian-Hong Pan 2018-08-23 17:15 ` Jian-Hong Pan 2018-08-23 17:43 ` Randy Dunlap 2018-08-23 17:43 ` Randy Dunlap 2018-08-23 17:43 ` Randy Dunlap 2018-08-23 17:43 ` Randy Dunlap 2018-08-24 15:58 ` Jian-Hong Pan 2018-08-24 15:58 ` Jian-Hong Pan 2018-08-24 15:58 ` Jian-Hong Pan 2018-09-23 16:40 ` Andreas Färber 2018-09-23 16:40 ` Andreas Färber 2018-09-23 16:40 ` Andreas Färber 2018-09-26 15:52 ` Jian-Hong Pan 2018-09-26 15:52 ` Jian-Hong Pan 2018-09-26 15:52 ` Jian-Hong Pan 2018-11-05 16:55 ` [PATCH V2 0/7] net: lorawan: Add LoRaWAN soft MAC module Jian-Hong Pan 2018-11-05 16:55 ` Jian-Hong Pan 2018-11-05 16:55 ` [PATCH V2 1/7] net: lorawan: Add macro and definition for LoRaWAN Jian-Hong Pan 2018-11-05 16:55 ` Jian-Hong Pan 2018-11-05 16:55 ` [PATCH V2 2/7] net: lorawan: Add LoRaWAN socket module Jian-Hong Pan 2018-11-05 16:55 ` Jian-Hong Pan 2018-11-05 18:16 ` David Miller 2018-11-05 18:16 ` David Miller 2018-11-06 14:28 ` Jian-Hong Pan 2018-11-06 14:28 ` Jian-Hong Pan 2018-11-14 16:01 ` [PATCH V3 0/7] net: lorawan: Add LoRaWAN soft MAC module Jian-Hong Pan 2018-11-14 16:01 ` Jian-Hong Pan 2018-11-14 16:01 ` [PATCH V3 1/7] net: lorawan: Add macro and definition for LoRaWAN Jian-Hong Pan 2018-11-14 16:01 ` Jian-Hong Pan 2018-11-14 16:12 ` Andreas Färber 2018-11-14 16:12 ` Andreas Färber 2018-11-17 6:47 ` Jian-Hong Pan 2018-11-17 6:47 ` Jian-Hong Pan 2018-11-17 6:47 ` Jian-Hong Pan 2018-11-14 16:01 ` [PATCH V3 2/7] net: lorawan: Add LoRaWAN socket module Jian-Hong Pan 2018-11-14 16:01 ` Jian-Hong Pan 2018-11-17 4:32 ` David Miller 2018-11-17 4:32 ` David Miller 2018-11-17 14:54 ` Jian-Hong Pan 2018-11-17 14:54 ` Jian-Hong Pan 2018-12-04 14:13 ` [PATCH V4 0/6] net: lorawan: Add LoRaWAN soft MAC module Jian-Hong Pan 2018-12-04 14:13 ` Jian-Hong Pan 2018-12-04 14:13 ` [PATCH V4 1/6] net: lorawan: Add LoRaWAN socket module Jian-Hong Pan 2018-12-04 14:13 ` Jian-Hong Pan 2018-12-04 14:13 ` [PATCH V4 2/6] net: lorawan: Add LoRaWAN API declaration for LoRa devices Jian-Hong Pan 2018-12-04 14:13 ` Jian-Hong Pan 2018-12-04 14:13 ` [PATCH V4 3/6] net: maclorawan: Add maclorawan module declaration Jian-Hong Pan 2018-12-04 14:13 ` Jian-Hong Pan 2018-12-04 14:13 ` [PATCH V4 4/6] net: maclorawan: Implement the crypto of maclorawan module Jian-Hong Pan 2018-12-04 14:13 ` Jian-Hong Pan 2018-12-04 14:13 ` [PATCH V4 5/6] net: maclorawan: Implement maclorawan class module Jian-Hong Pan 2018-12-04 14:13 ` Jian-Hong Pan 2018-12-04 20:45 ` Alan Cox 2018-12-04 20:45 ` Alan Cox 2018-12-04 20:45 ` Alan Cox 2018-12-09 8:27 ` Jian-Hong Pan 2018-12-09 8:27 ` Jian-Hong Pan 2018-12-16 10:18 ` [PATCH v5 0/6] net: lorawan: Add LoRaWAN soft MAC module Jian-Hong Pan 2018-12-16 10:18 ` Jian-Hong Pan 2018-12-17 13:51 ` Jiri Pirko 2018-12-17 13:51 ` Jiri Pirko 2018-12-16 10:18 ` [PATCH v5 1/6] net: lorawan: Add LoRaWAN socket module Jian-Hong Pan 2018-12-16 10:18 ` Jian-Hong Pan 2018-12-29 7:27 ` Andreas Färber 2018-12-29 7:27 ` Andreas Färber 2019-01-07 14:47 ` Jian-Hong Pan 2019-01-07 14:47 ` Jian-Hong Pan 2019-01-07 14:47 ` Jian-Hong Pan 2019-01-13 14:51 ` Jian-Hong Pan 2019-01-13 14:51 ` Jian-Hong Pan 2019-01-13 14:51 ` Jian-Hong Pan 2018-12-16 10:18 ` [PATCH v5 2/6] net: lorawan: Add LoRaWAN API declaration for LoRa devices Jian-Hong Pan 2018-12-16 10:18 ` Jian-Hong Pan 2018-12-16 10:18 ` [PATCH v5 3/6] net: maclorawan: Add maclorawan module declaration Jian-Hong Pan 2018-12-16 10:18 ` Jian-Hong Pan 2018-12-16 10:18 ` [PATCH v5 4/6] net: maclorawan: Implement the crypto of maclorawan module Jian-Hong Pan 2018-12-16 10:18 ` Jian-Hong Pan 2018-12-16 10:18 ` [PATCH v5 5/6] net: maclorawan: Implement maclorawan class module Jian-Hong Pan 2018-12-16 10:18 ` Jian-Hong Pan 2018-12-17 14:02 ` Jiri Pirko 2018-12-17 14:02 ` Jiri Pirko 2018-12-18 14:27 ` Jian-Hong Pan 2018-12-18 14:27 ` Jian-Hong Pan 2018-12-18 14:27 ` Jiri Pirko 2018-12-18 14:27 ` Jiri Pirko 2018-12-18 15:34 ` Jian-Hong Pan 2018-12-18 15:34 ` Jian-Hong Pan 2018-12-18 18:49 ` Andreas Färber 2018-12-18 18:49 ` Andreas Färber 2018-12-19 11:27 ` Ben Whitten 2018-12-19 11:27 ` Ben Whitten 2018-12-19 11:27 ` Ben Whitten 2018-12-19 16:26 ` Jian-Hong Pan 2018-12-19 16:26 ` Jian-Hong Pan 2018-12-20 9:20 ` Xue Liu 2018-12-20 16:00 ` Jian-Hong Pan 2018-12-28 8:11 ` Netlink userspace tools for LoRa(WAN), FSK, Sigfox, BLE, etc. (was: [PATCH v5 5/6] net: maclorawan: Implement maclorawan class module) Andreas Färber 2018-12-28 15:49 ` Alexander Aring 2018-12-20 10:19 ` [PATCH v5 5/6] net: maclorawan: Implement maclorawan class module Ben Whitten 2018-12-20 10:19 ` Ben Whitten 2018-12-20 15:31 ` Andreas Färber 2018-12-20 15:31 ` Andreas Färber 2018-12-20 15:31 ` Andreas Färber 2018-12-16 10:19 ` [PATCH v5 6/6] net: lorawan: List LORAWAN in menuconfig Jian-Hong Pan 2018-12-16 10:19 ` Jian-Hong Pan 2018-12-17 8:50 ` Xue Liu 2018-12-17 8:50 ` Xue Liu 2018-12-17 14:19 ` Andreas Färber 2018-12-17 14:19 ` Andreas Färber 2018-12-18 13:50 ` Xue Liu [this message] 2018-12-18 13:50 ` Xue Liu 2018-12-24 15:32 ` Alexander Aring 2018-12-24 15:32 ` Alexander Aring 2018-12-28 4:57 ` Andreas Färber 2018-12-28 4:57 ` Andreas Färber 2018-12-28 15:43 ` Alexander Aring 2018-12-28 15:43 ` Alexander Aring 2018-12-29 6:28 ` Andreas Färber 2018-12-29 6:28 ` Andreas Färber 2018-12-04 14:13 ` [PATCH V4 " Jian-Hong Pan 2018-12-04 14:13 ` Jian-Hong Pan 2018-11-14 16:01 ` [PATCH V3 3/7] net: lorawan: Add LoRaWAN API declaration for LoRa devices Jian-Hong Pan 2018-11-14 16:01 ` Jian-Hong Pan 2018-11-14 16:01 ` [PATCH V3 4/7] net: maclorawan: Add maclorawan module declaration Jian-Hong Pan 2018-11-14 16:01 ` Jian-Hong Pan 2018-11-17 4:32 ` David Miller 2018-11-17 4:32 ` David Miller 2018-11-17 6:32 ` Jian-Hong Pan 2018-11-17 6:32 ` Jian-Hong Pan 2018-11-14 16:01 ` [PATCH V3 5/7] net: maclorawan: Implement the crypto of maclorawan module Jian-Hong Pan 2018-11-14 16:01 ` Jian-Hong Pan 2018-11-14 16:01 ` [PATCH V3 6/7] net: maclorawan: Implement maclorawan class module Jian-Hong Pan 2018-11-14 16:01 ` Jian-Hong Pan 2018-11-14 16:01 ` [PATCH V3 7/7] net: lorawan: List LORAWAN in menuconfig Jian-Hong Pan 2018-11-14 16:01 ` Jian-Hong Pan 2018-11-05 16:55 ` [PATCH V2 3/7] net: lorawan: Add LoRaWAN API declaration for LoRa devices Jian-Hong Pan 2018-11-05 16:55 ` Jian-Hong Pan 2018-11-05 16:55 ` [PATCH V2 4/7] net: maclorawan: Add maclorawan module declaration Jian-Hong Pan 2018-11-05 16:55 ` Jian-Hong Pan 2018-11-05 16:55 ` [PATCH V2 5/7] net: maclorawan: Implement the crypto of maclorawan module Jian-Hong Pan 2018-11-05 16:55 ` Jian-Hong Pan 2018-11-05 16:55 ` Jian-Hong Pan 2018-11-05 16:55 ` [PATCH V2 6/7] net: maclorawan: Implement maclorawan class module Jian-Hong Pan 2018-11-05 16:55 ` Jian-Hong Pan 2018-11-05 16:55 ` [PATCH V2 7/7] net: lorawan: List LORAWAN in menuconfig Jian-Hong Pan 2018-11-05 16:55 ` Jian-Hong Pan 2018-08-23 17:15 ` [RFC 2/3 net] lorawan: Add macro and definition for LoRaWAN class modlue Jian-Hong Pan 2018-08-23 17:15 ` Jian-Hong Pan 2018-08-23 17:15 ` Jian-Hong Pan 2018-09-23 16:06 ` Andreas Färber 2018-09-23 16:06 ` Andreas Färber 2018-09-23 16:06 ` Andreas Färber 2018-09-26 14:46 ` Jian-Hong Pan 2018-09-26 14:46 ` Jian-Hong Pan 2018-09-26 14:46 ` Jian-Hong Pan 2018-08-23 17:15 ` [RFC 3/3 net] lorawan: List LORAWAN in menuconfig Jian-Hong Pan 2018-08-23 17:15 ` Jian-Hong Pan 2018-08-23 17:15 ` Jian-Hong Pan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAJuUDwsypFMEbTXZO+NwQ_FnD1wsO3ZRc3dthZphFGJ-u0n_=Q@mail.gmail.com' \ --to=liuxuenetmail@gmail.com \ --cc=afaerber@suse.de \ --cc=davem@davemloft.net \ --cc=dollar.chen@wtmec.com \ --cc=gnomes@lxorguk.ukuu.org.uk \ --cc=ken.yu@rakwireless.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-lpwan@lists.infradead.org \ --cc=linux-wpan@vger.kernel.org \ --cc=marcel@holtmann.org \ --cc=netdev@vger.kernel.org \ --cc=starnight@g.ncu.edu.tw \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.