* [PATCH] drm/i915: Set MI_INVALIDATE_BSD for all video-decode engines
@ 2018-11-08 14:00 Chris Wilson
2018-11-08 14:22 ` ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Chris Wilson @ 2018-11-08 14:00 UTC (permalink / raw)
To: intel-gfx
We have multiple instances of VCS but only remember to invalidate the
BSD caches on the first, ignoring the stale caches of any other engine.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
drivers/gpu/drm/i915/intel_lrc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c
index f7892ddb3f13..08fd9b12e4d7 100644
--- a/drivers/gpu/drm/i915/intel_lrc.c
+++ b/drivers/gpu/drm/i915/intel_lrc.c
@@ -1956,7 +1956,7 @@ static int gen8_emit_flush(struct i915_request *request, u32 mode)
if (mode & EMIT_INVALIDATE) {
cmd |= MI_INVALIDATE_TLB;
- if (request->engine->id == VCS)
+ if (request->engine->class == VIDEO_DECODE_CLASS)
cmd |= MI_INVALIDATE_BSD;
}
--
2.19.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread* ✓ Fi.CI.BAT: success for drm/i915: Set MI_INVALIDATE_BSD for all video-decode engines
2018-11-08 14:00 [PATCH] drm/i915: Set MI_INVALIDATE_BSD for all video-decode engines Chris Wilson
@ 2018-11-08 14:22 ` Patchwork
2018-11-08 15:11 ` [PATCH] " Mika Kuoppala
2018-11-08 22:32 ` ✓ Fi.CI.IGT: success for " Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2018-11-08 14:22 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Set MI_INVALIDATE_BSD for all video-decode engines
URL : https://patchwork.freedesktop.org/series/52237/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_5105 -> Patchwork_10774 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/52237/revisions/1/mbox/
== Known issues ==
Here are the changes found in Patchwork_10774 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_close_race@basic-process:
fi-icl-u2: PASS -> DMESG-WARN (fdo#107724)
igt@gem_mmap_gtt@basic-small-copy:
fi-glk-dsi: NOTRUN -> INCOMPLETE (fdo#103359, k.org#198133)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
fi-byt-clapper: PASS -> FAIL (fdo#107362, fdo#103191)
==== Possible fixes ====
igt@gem_ctx_create@basic-files:
fi-icl-u2: DMESG-WARN (fdo#107724) -> PASS
igt@kms_chamelium@common-hpd-after-suspend:
fi-skl-6700k2: FAIL (fdo#103841) -> PASS
igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b-frame-sequence:
fi-byt-clapper: FAIL (fdo#107362, fdo#103191) -> PASS
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
fi-blb-e6850: INCOMPLETE (fdo#107718) -> PASS
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#103841 https://bugs.freedesktop.org/show_bug.cgi?id=103841
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
fdo#107724 https://bugs.freedesktop.org/show_bug.cgi?id=107724
k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133
== Participating hosts (51 -> 47) ==
Additional (2): fi-byt-j1900 fi-glk-dsi
Missing (6): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-snb-2520m
== Build changes ==
* Linux: CI_DRM_5105 -> Patchwork_10774
CI_DRM_5105: e44a1cc644d1719d195bd0afb9e319ae555059e1 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4712: a3ede1b535ac8137f6949c468edd7054453d5dae @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10774: 1cea25ea28bf2a5016c388dc36650ff01c74cf8e @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
1cea25ea28bf drm/i915: Set MI_INVALIDATE_BSD for all video-decode engines
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10774/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/i915: Set MI_INVALIDATE_BSD for all video-decode engines
2018-11-08 14:00 [PATCH] drm/i915: Set MI_INVALIDATE_BSD for all video-decode engines Chris Wilson
2018-11-08 14:22 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-11-08 15:11 ` Mika Kuoppala
2018-11-08 22:32 ` ✓ Fi.CI.IGT: success for " Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Mika Kuoppala @ 2018-11-08 15:11 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
Chris Wilson <chris@chris-wilson.co.uk> writes:
> We have multiple instances of VCS but only remember to invalidate the
> BSD caches on the first, ignoring the stale caches of any other engine.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Missing this prolly would have caused much hair pulling in future, so
nice catch.
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Lets flush also the LLC for gen9+ on followup patch?
-Mika
> ---
> drivers/gpu/drm/i915/intel_lrc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c
> index f7892ddb3f13..08fd9b12e4d7 100644
> --- a/drivers/gpu/drm/i915/intel_lrc.c
> +++ b/drivers/gpu/drm/i915/intel_lrc.c
> @@ -1956,7 +1956,7 @@ static int gen8_emit_flush(struct i915_request *request, u32 mode)
>
> if (mode & EMIT_INVALIDATE) {
> cmd |= MI_INVALIDATE_TLB;
> - if (request->engine->id == VCS)
> + if (request->engine->class == VIDEO_DECODE_CLASS)
> cmd |= MI_INVALIDATE_BSD;
> }
>
> --
> 2.19.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread* ✓ Fi.CI.IGT: success for drm/i915: Set MI_INVALIDATE_BSD for all video-decode engines
2018-11-08 14:00 [PATCH] drm/i915: Set MI_INVALIDATE_BSD for all video-decode engines Chris Wilson
2018-11-08 14:22 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-11-08 15:11 ` [PATCH] " Mika Kuoppala
@ 2018-11-08 22:32 ` Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2018-11-08 22:32 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Set MI_INVALIDATE_BSD for all video-decode engines
URL : https://patchwork.freedesktop.org/series/52237/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_5105_full -> Patchwork_10774_full =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_10774_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_10774_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_10774_full:
=== IGT changes ===
==== Warnings ====
igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions:
shard-snb: PASS -> SKIP +1
== Known issues ==
Here are the changes found in Patchwork_10774_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_exec_reuse@baggage:
shard-apl: PASS -> DMESG-WARN (fdo#108691)
igt@kms_cursor_crc@cursor-128x128-random:
shard-apl: PASS -> FAIL (fdo#103232) +6
igt@kms_cursor_legacy@cursorb-vs-flipb-varying-size:
shard-glk: PASS -> DMESG-WARN (fdo#105763, fdo#106538) +1
igt@kms_draw_crc@draw-method-rgb565-mmap-wc-untiled:
shard-skl: PASS -> FAIL (fdo#103184)
igt@kms_flip@flip-vs-expired-vblank:
shard-skl: PASS -> FAIL (fdo#105363)
shard-glk: PASS -> FAIL (fdo#105363, fdo#102887)
igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-indfb-plflip-blt:
shard-glk: PASS -> FAIL (fdo#103167) +2
igt@kms_frontbuffer_tracking@psr-farfromfence:
shard-apl: NOTRUN -> INCOMPLETE (fdo#103927)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
shard-skl: PASS -> INCOMPLETE (fdo#107773, fdo#104108)
igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
shard-skl: PASS -> FAIL (fdo#107815)
igt@kms_plane_multiple@atomic-pipe-b-tiling-yf:
shard-apl: PASS -> FAIL (fdo#103166)
igt@perf@blocking:
shard-hsw: PASS -> FAIL (fdo#102252)
==== Possible fixes ====
igt@drm_import_export@import-close-race-flink:
shard-skl: TIMEOUT (fdo#108667) -> PASS
igt@kms_available_modes_crc@available_mode_test_crc:
shard-snb: FAIL (fdo#106641) -> PASS
igt@kms_color@pipe-b-legacy-gamma:
shard-apl: FAIL (fdo#104782) -> PASS
igt@kms_cursor_crc@cursor-128x128-suspend:
shard-apl: FAIL (fdo#103232, fdo#103191) -> PASS +1
igt@kms_cursor_crc@cursor-64x64-random:
shard-glk: FAIL (fdo#103232) -> PASS
igt@kms_cursor_crc@cursor-size-change:
shard-apl: FAIL (fdo#103232) -> PASS
igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
shard-glk: FAIL (fdo#105363) -> PASS
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render:
shard-apl: FAIL (fdo#103167) -> PASS
igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-mmap-gtt:
shard-glk: FAIL (fdo#103167) -> PASS
igt@kms_frontbuffer_tracking@fbc-indfb-scaledprimary:
shard-skl: FAIL (fdo#103167) -> PASS
igt@kms_frontbuffer_tracking@psr-suspend:
shard-skl: INCOMPLETE (fdo#107773, fdo#106978, fdo#104108) -> PASS
igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
shard-skl: FAIL (fdo#107815, fdo#108145) -> PASS
igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
shard-apl: FAIL (fdo#103166) -> PASS +1
igt@kms_setmode@basic:
shard-kbl: FAIL (fdo#99912) -> PASS
fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103184 https://bugs.freedesktop.org/show_bug.cgi?id=103184
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#104108 https://bugs.freedesktop.org/show_bug.cgi?id=104108
fdo#104782 https://bugs.freedesktop.org/show_bug.cgi?id=104782
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#105763 https://bugs.freedesktop.org/show_bug.cgi?id=105763
fdo#106538 https://bugs.freedesktop.org/show_bug.cgi?id=106538
fdo#106641 https://bugs.freedesktop.org/show_bug.cgi?id=106641
fdo#106978 https://bugs.freedesktop.org/show_bug.cgi?id=106978
fdo#107773 https://bugs.freedesktop.org/show_bug.cgi?id=107773
fdo#107815 https://bugs.freedesktop.org/show_bug.cgi?id=107815
fdo#108145 https://bugs.freedesktop.org/show_bug.cgi?id=108145
fdo#108667 https://bugs.freedesktop.org/show_bug.cgi?id=108667
fdo#108691 https://bugs.freedesktop.org/show_bug.cgi?id=108691
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
== Participating hosts (6 -> 6) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_5105 -> Patchwork_10774
CI_DRM_5105: e44a1cc644d1719d195bd0afb9e319ae555059e1 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4712: a3ede1b535ac8137f6949c468edd7054453d5dae @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10774: 1cea25ea28bf2a5016c388dc36650ff01c74cf8e @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10774/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-11-08 22:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-08 14:00 [PATCH] drm/i915: Set MI_INVALIDATE_BSD for all video-decode engines Chris Wilson
2018-11-08 14:22 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-11-08 15:11 ` [PATCH] " Mika Kuoppala
2018-11-08 22:32 ` ✓ Fi.CI.IGT: success for " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.