From: Steve Douthit <stephend@silicom-usa.com> To: Jeff Kirsher <jeffrey.t.kirsher@intel.com> Cc: "David S. Miller" <davem@davemloft.net>, "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>, "netdev@vger.kernel.org" <netdev@vger.kernel.org>, Andrew Lunn <andrew@lunn.ch>, Florian Fainelli <f.fainelli@gmail.com>, Steve Douthit <stephend@silicom-usa.com> Subject: [PATCH net-next v2 0/2] Add mii_bus to ixgbe driver for dsa devs Date: Mon, 3 Dec 2018 16:32:47 +0000 [thread overview] Message-ID: <20181203163227.5107-1-stephend@silicom-usa.com> (raw) Address review comments from v1. I missed the intel-wired-lan list on the first submission, so check out the netdev list archive for the first rev of the patch. I think it's still up in the air on how best to register a single bus that's shared among up to four MACs. This code works for me, but there might be a better way to do this. Same caveats about testing still apply. My test setup is a Marvell Peridot switch hanging off of a Intel C3000 SoC. Clause 45 devices and other ixgbe devices have not been tested. Changes from v1 -> v2 [PATCH 1/2] ixgbe: register a mdiobus * Add intel-wired-lan@lists.osuosl.org to CC list, see * select MII in Kconfig (thanks to the kbuild bot) * Only call mdiobus_regsiter for single x500em_a device * Use readx_poll_timeout() in ixgbe_msca_cmd() * Register different bus->read/write callbacks in ixgbe_mii_bus_init() so there's device id check on every access * Use device pci_name() in bus->id instead of parent bridge's name [PATCH 2/2] ixgbe: use mii_bus to handle MII related ioctls * Only use mdiobus_read/write for adapters that registered a mdiobus Stephen Douthit (2): ixgbe: register a mdiobus ixgbe: use mii_bus to handle MII related ioctls drivers/net/ethernet/intel/Kconfig | 1 + drivers/net/ethernet/intel/ixgbe/ixgbe.h | 2 + drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 23 ++ drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c | 307 ++++++++++++++++++ drivers/net/ethernet/intel/ixgbe/ixgbe_phy.h | 2 + 5 files changed, 335 insertions(+) -- 2.17.2
WARNING: multiple messages have this Message-ID (diff)
From: Steve Douthit <stephend@silicom-usa.com> To: intel-wired-lan@osuosl.org Subject: [Intel-wired-lan] [PATCH net-next v2 0/2] Add mii_bus to ixgbe driver for dsa devs Date: Mon, 3 Dec 2018 16:32:47 +0000 [thread overview] Message-ID: <20181203163227.5107-1-stephend@silicom-usa.com> (raw) Address review comments from v1. I missed the intel-wired-lan list on the first submission, so check out the netdev list archive for the first rev of the patch. I think it's still up in the air on how best to register a single bus that's shared among up to four MACs. This code works for me, but there might be a better way to do this. Same caveats about testing still apply. My test setup is a Marvell Peridot switch hanging off of a Intel C3000 SoC. Clause 45 devices and other ixgbe devices have not been tested. Changes from v1 -> v2 [PATCH 1/2] ixgbe: register a mdiobus * Add intel-wired-lan at lists.osuosl.org to CC list, see * select MII in Kconfig (thanks to the kbuild bot) * Only call mdiobus_regsiter for single x500em_a device * Use readx_poll_timeout() in ixgbe_msca_cmd() * Register different bus->read/write callbacks in ixgbe_mii_bus_init() so there's device id check on every access * Use device pci_name() in bus->id instead of parent bridge's name [PATCH 2/2] ixgbe: use mii_bus to handle MII related ioctls * Only use mdiobus_read/write for adapters that registered a mdiobus Stephen Douthit (2): ixgbe: register a mdiobus ixgbe: use mii_bus to handle MII related ioctls drivers/net/ethernet/intel/Kconfig | 1 + drivers/net/ethernet/intel/ixgbe/ixgbe.h | 2 + drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 23 ++ drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c | 307 ++++++++++++++++++ drivers/net/ethernet/intel/ixgbe/ixgbe_phy.h | 2 + 5 files changed, 335 insertions(+) -- 2.17.2
next reply other threads:[~2018-12-03 16:32 UTC|newest] Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-12-03 16:32 Steve Douthit [this message] 2018-12-03 16:32 ` [Intel-wired-lan] [PATCH net-next v2 0/2] Add mii_bus to ixgbe driver for dsa devs Steve Douthit 2018-12-03 16:32 ` [PATCH net-next v2 1/2] ixgbe: register a mdiobus Steve Douthit 2018-12-03 16:32 ` [Intel-wired-lan] " Steve Douthit 2018-12-03 16:54 ` Andrew Lunn 2018-12-03 16:54 ` [Intel-wired-lan] " Andrew Lunn 2018-12-03 17:02 ` Steve Douthit 2018-12-03 17:02 ` [Intel-wired-lan] " Steve Douthit 2018-12-03 17:21 ` Andrew Lunn 2018-12-03 17:21 ` [Intel-wired-lan] " Andrew Lunn 2018-12-03 17:59 ` Steve Douthit 2018-12-03 17:59 ` [Intel-wired-lan] " Steve Douthit 2018-12-03 18:18 ` Andrew Lunn 2018-12-03 18:18 ` [Intel-wired-lan] " Andrew Lunn 2018-12-03 18:38 ` Steve Douthit 2018-12-03 18:38 ` [Intel-wired-lan] " Steve Douthit 2018-12-03 18:54 ` Andrew Lunn 2018-12-03 18:54 ` [Intel-wired-lan] " Andrew Lunn 2018-12-03 16:33 ` [PATCH net-next v2 2/2] ixgbe: use mii_bus to handle MII related ioctls Steve Douthit 2018-12-03 16:33 ` [Intel-wired-lan] " Steve Douthit 2018-12-03 18:55 ` [PATCH net-next v3 0/2] Add mii_bus to ixgbe driver for dsa devs Steve Douthit 2018-12-03 18:55 ` [Intel-wired-lan] " Steve Douthit 2018-12-03 18:55 ` [PATCH net-next v3 1/2] ixgbe: register a mdiobus Steve Douthit 2018-12-03 18:55 ` [Intel-wired-lan] " Steve Douthit 2018-12-03 19:00 ` Andrew Lunn 2018-12-03 19:00 ` [Intel-wired-lan] " Andrew Lunn 2018-12-03 19:07 ` Florian Fainelli 2018-12-03 19:07 ` [Intel-wired-lan] " Florian Fainelli 2018-12-03 19:44 ` Steve Douthit 2018-12-03 19:44 ` [Intel-wired-lan] " Steve Douthit 2018-12-03 19:45 ` Florian Fainelli 2018-12-03 19:45 ` [Intel-wired-lan] " Florian Fainelli 2018-12-03 18:55 ` [PATCH net-next v3 2/2] ixgbe: use mii_bus to handle MII related ioctls Steve Douthit 2018-12-03 18:55 ` [Intel-wired-lan] " Steve Douthit 2018-12-03 19:01 ` Andrew Lunn 2018-12-03 19:01 ` [Intel-wired-lan] " Andrew Lunn 2018-12-03 19:07 ` Florian Fainelli 2018-12-03 19:07 ` [Intel-wired-lan] " Florian Fainelli 2018-12-03 20:14 ` [PATCH net-next v4 0/2] Add mii_bus to ixgbe driver for dsa devs Steve Douthit 2018-12-03 20:14 ` [Intel-wired-lan] " Steve Douthit 2018-12-03 20:15 ` [PATCH net-next v4 1/2] ixgbe: register a mdiobus Steve Douthit 2018-12-03 20:15 ` [Intel-wired-lan] " Steve Douthit 2018-12-04 16:58 ` Bowers, AndrewX 2018-12-04 16:58 ` [Intel-wired-lan] " Bowers, AndrewX 2018-12-03 20:15 ` [PATCH net-next v4 2/2] ixgbe: use mii_bus to handle MII related ioctls Steve Douthit 2018-12-03 20:15 ` [Intel-wired-lan] " Steve Douthit 2018-12-04 16:59 ` Bowers, AndrewX 2018-12-04 16:59 ` [Intel-wired-lan] " Bowers, AndrewX 2018-12-03 20:51 ` [PATCH net-next v4 0/2] Add mii_bus to ixgbe driver for dsa devs Florian Fainelli 2018-12-03 20:51 ` [Intel-wired-lan] " Florian Fainelli 2018-12-03 23:42 ` Steve Douthit 2018-12-03 23:42 ` [Intel-wired-lan] " Steve Douthit 2018-12-03 23:46 ` Florian Fainelli 2018-12-03 23:46 ` [Intel-wired-lan] " Florian Fainelli 2018-12-04 10:40 ` Andrew Lunn 2018-12-04 10:40 ` [Intel-wired-lan] " Andrew Lunn 2018-12-04 16:02 ` Steve Douthit 2018-12-04 16:02 ` [Intel-wired-lan] " Steve Douthit 2018-12-06 15:50 ` [PATCH net-next v5 " Steve Douthit 2018-12-06 15:50 ` [Intel-wired-lan] " Steve Douthit 2018-12-06 15:50 ` [PATCH net-next v5 1/2] ixgbe: register a mdiobus Steve Douthit 2018-12-06 15:50 ` [Intel-wired-lan] " Steve Douthit 2018-12-06 15:50 ` [PATCH net-next v5 2/2] ixgbe: use mii_bus to handle MII related ioctls Steve Douthit 2018-12-06 15:50 ` [Intel-wired-lan] " Steve Douthit
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181203163227.5107-1-stephend@silicom-usa.com \ --to=stephend@silicom-usa.com \ --cc=andrew@lunn.ch \ --cc=davem@davemloft.net \ --cc=f.fainelli@gmail.com \ --cc=intel-wired-lan@lists.osuosl.org \ --cc=jeffrey.t.kirsher@intel.com \ --cc=netdev@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.