From: Steve Douthit <stephend@silicom-usa.com> To: Florian Fainelli <f.fainelli@gmail.com>, Jeff Kirsher <jeffrey.t.kirsher@intel.com> Cc: "David S. Miller" <davem@davemloft.net>, "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>, "netdev@vger.kernel.org" <netdev@vger.kernel.org>, Andrew Lunn <andrew@lunn.ch> Subject: Re: [PATCH net-next v3 1/2] ixgbe: register a mdiobus Date: Mon, 3 Dec 2018 19:44:22 +0000 [thread overview] Message-ID: <98205032-e218-7a6a-992f-65800e4f6351@silicom-usa.com> (raw) In-Reply-To: <b5de925d-bfef-0dff-61c7-63bd16113b1d@gmail.com> On 12/3/18 2:07 PM, Florian Fainelli wrote: > On 12/3/18 10:55 AM, Steve Douthit wrote: >> Most dsa devices expect a 'struct mii_bus' pointer to talk to switches >> via the MII interface. >> >> While this works for dsa devices, it will not work safely with Linux >> PHYs in all configurations since the firmware of the ixgbe device may >> be polling some PHY addresses in the background. >> >> Signed-off-by: Stephen Douthit <stephend@silicom-usa.com> >> --- > > [snip] > >> +/** >> + * ixgbe_mii_bus_write - Write a clause 22/45 register >> + * @hw: pointer to hardware structure >> + * @addr: address >> + * @regnum: register number >> + * @regnum: valueto write > > This should be @val to match the function parameters OK >> + **/ >> +static s32 ixgbe_mii_bus_write(struct mii_bus *bus, int addr, int regnum, >> + u16 val) >> +{ >> + struct ixgbe_adapter *adapter = (struct ixgbe_adapter *)bus->priv; > > Nitpick: cast is not necessary since this is a void * pointer (for that > reason). OK, I'll clean up this and other unnecessary casts. I forgot Andrew's suggestion to squash the swfw semaphore masks from: + u32 gssr = hw->phy.phy_semaphore_mask | IXGBE_GSSR_TOKEN_SM; + + if (hw->bus.lan_id) + gssr |= IXGBE_GSSR_PHY1_SM; + else + gssr |= IXGBE_GSSR_PHY0_SM; to + u32 gssr = hw->phy.phy_semaphore_mask; + gssr |= IXGBE_GSSR_TOKEN_SM | IXGBE_GSSR_PHY0_SM; Is it ok to collect both of your 'Reviewed-by:'s with that additional change for v4?
WARNING: multiple messages have this Message-ID (diff)
From: Steve Douthit <stephend@silicom-usa.com> To: intel-wired-lan@osuosl.org Subject: [Intel-wired-lan] [PATCH net-next v3 1/2] ixgbe: register a mdiobus Date: Mon, 3 Dec 2018 19:44:22 +0000 [thread overview] Message-ID: <98205032-e218-7a6a-992f-65800e4f6351@silicom-usa.com> (raw) In-Reply-To: <b5de925d-bfef-0dff-61c7-63bd16113b1d@gmail.com> On 12/3/18 2:07 PM, Florian Fainelli wrote: > On 12/3/18 10:55 AM, Steve Douthit wrote: >> Most dsa devices expect a 'struct mii_bus' pointer to talk to switches >> via the MII interface. >> >> While this works for dsa devices, it will not work safely with Linux >> PHYs in all configurations since the firmware of the ixgbe device may >> be polling some PHY addresses in the background. >> >> Signed-off-by: Stephen Douthit <stephend@silicom-usa.com> >> --- > > [snip] > >> +/** >> + * ixgbe_mii_bus_write - Write a clause 22/45 register >> + * @hw: pointer to hardware structure >> + * @addr: address >> + * @regnum: register number >> + * @regnum: valueto write > > This should be @val to match the function parameters OK >> + **/ >> +static s32 ixgbe_mii_bus_write(struct mii_bus *bus, int addr, int regnum, >> + u16 val) >> +{ >> + struct ixgbe_adapter *adapter = (struct ixgbe_adapter *)bus->priv; > > Nitpick: cast is not necessary since this is a void * pointer (for that > reason). OK, I'll clean up this and other unnecessary casts. I forgot Andrew's suggestion to squash the swfw semaphore masks from: + u32 gssr = hw->phy.phy_semaphore_mask | IXGBE_GSSR_TOKEN_SM; + + if (hw->bus.lan_id) + gssr |= IXGBE_GSSR_PHY1_SM; + else + gssr |= IXGBE_GSSR_PHY0_SM; to + u32 gssr = hw->phy.phy_semaphore_mask; + gssr |= IXGBE_GSSR_TOKEN_SM | IXGBE_GSSR_PHY0_SM; Is it ok to collect both of your 'Reviewed-by:'s with that additional change for v4?
next prev parent reply other threads:[~2018-12-03 19:45 UTC|newest] Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-12-03 16:32 [PATCH net-next v2 0/2] Add mii_bus to ixgbe driver for dsa devs Steve Douthit 2018-12-03 16:32 ` [Intel-wired-lan] " Steve Douthit 2018-12-03 16:32 ` [PATCH net-next v2 1/2] ixgbe: register a mdiobus Steve Douthit 2018-12-03 16:32 ` [Intel-wired-lan] " Steve Douthit 2018-12-03 16:54 ` Andrew Lunn 2018-12-03 16:54 ` [Intel-wired-lan] " Andrew Lunn 2018-12-03 17:02 ` Steve Douthit 2018-12-03 17:02 ` [Intel-wired-lan] " Steve Douthit 2018-12-03 17:21 ` Andrew Lunn 2018-12-03 17:21 ` [Intel-wired-lan] " Andrew Lunn 2018-12-03 17:59 ` Steve Douthit 2018-12-03 17:59 ` [Intel-wired-lan] " Steve Douthit 2018-12-03 18:18 ` Andrew Lunn 2018-12-03 18:18 ` [Intel-wired-lan] " Andrew Lunn 2018-12-03 18:38 ` Steve Douthit 2018-12-03 18:38 ` [Intel-wired-lan] " Steve Douthit 2018-12-03 18:54 ` Andrew Lunn 2018-12-03 18:54 ` [Intel-wired-lan] " Andrew Lunn 2018-12-03 16:33 ` [PATCH net-next v2 2/2] ixgbe: use mii_bus to handle MII related ioctls Steve Douthit 2018-12-03 16:33 ` [Intel-wired-lan] " Steve Douthit 2018-12-03 18:55 ` [PATCH net-next v3 0/2] Add mii_bus to ixgbe driver for dsa devs Steve Douthit 2018-12-03 18:55 ` [Intel-wired-lan] " Steve Douthit 2018-12-03 18:55 ` [PATCH net-next v3 1/2] ixgbe: register a mdiobus Steve Douthit 2018-12-03 18:55 ` [Intel-wired-lan] " Steve Douthit 2018-12-03 19:00 ` Andrew Lunn 2018-12-03 19:00 ` [Intel-wired-lan] " Andrew Lunn 2018-12-03 19:07 ` Florian Fainelli 2018-12-03 19:07 ` [Intel-wired-lan] " Florian Fainelli 2018-12-03 19:44 ` Steve Douthit [this message] 2018-12-03 19:44 ` Steve Douthit 2018-12-03 19:45 ` Florian Fainelli 2018-12-03 19:45 ` [Intel-wired-lan] " Florian Fainelli 2018-12-03 18:55 ` [PATCH net-next v3 2/2] ixgbe: use mii_bus to handle MII related ioctls Steve Douthit 2018-12-03 18:55 ` [Intel-wired-lan] " Steve Douthit 2018-12-03 19:01 ` Andrew Lunn 2018-12-03 19:01 ` [Intel-wired-lan] " Andrew Lunn 2018-12-03 19:07 ` Florian Fainelli 2018-12-03 19:07 ` [Intel-wired-lan] " Florian Fainelli 2018-12-03 20:14 ` [PATCH net-next v4 0/2] Add mii_bus to ixgbe driver for dsa devs Steve Douthit 2018-12-03 20:14 ` [Intel-wired-lan] " Steve Douthit 2018-12-03 20:15 ` [PATCH net-next v4 1/2] ixgbe: register a mdiobus Steve Douthit 2018-12-03 20:15 ` [Intel-wired-lan] " Steve Douthit 2018-12-04 16:58 ` Bowers, AndrewX 2018-12-04 16:58 ` [Intel-wired-lan] " Bowers, AndrewX 2018-12-03 20:15 ` [PATCH net-next v4 2/2] ixgbe: use mii_bus to handle MII related ioctls Steve Douthit 2018-12-03 20:15 ` [Intel-wired-lan] " Steve Douthit 2018-12-04 16:59 ` Bowers, AndrewX 2018-12-04 16:59 ` [Intel-wired-lan] " Bowers, AndrewX 2018-12-03 20:51 ` [PATCH net-next v4 0/2] Add mii_bus to ixgbe driver for dsa devs Florian Fainelli 2018-12-03 20:51 ` [Intel-wired-lan] " Florian Fainelli 2018-12-03 23:42 ` Steve Douthit 2018-12-03 23:42 ` [Intel-wired-lan] " Steve Douthit 2018-12-03 23:46 ` Florian Fainelli 2018-12-03 23:46 ` [Intel-wired-lan] " Florian Fainelli 2018-12-04 10:40 ` Andrew Lunn 2018-12-04 10:40 ` [Intel-wired-lan] " Andrew Lunn 2018-12-04 16:02 ` Steve Douthit 2018-12-04 16:02 ` [Intel-wired-lan] " Steve Douthit 2018-12-06 15:50 ` [PATCH net-next v5 " Steve Douthit 2018-12-06 15:50 ` [Intel-wired-lan] " Steve Douthit 2018-12-06 15:50 ` [PATCH net-next v5 1/2] ixgbe: register a mdiobus Steve Douthit 2018-12-06 15:50 ` [Intel-wired-lan] " Steve Douthit 2018-12-06 15:50 ` [PATCH net-next v5 2/2] ixgbe: use mii_bus to handle MII related ioctls Steve Douthit 2018-12-06 15:50 ` [Intel-wired-lan] " Steve Douthit
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=98205032-e218-7a6a-992f-65800e4f6351@silicom-usa.com \ --to=stephend@silicom-usa.com \ --cc=andrew@lunn.ch \ --cc=davem@davemloft.net \ --cc=f.fainelli@gmail.com \ --cc=intel-wired-lan@lists.osuosl.org \ --cc=jeffrey.t.kirsher@intel.com \ --cc=netdev@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.