From: Florian Fainelli <f.fainelli@gmail.com> To: Steve Douthit <stephend@silicom-usa.com>, Jeff Kirsher <jeffrey.t.kirsher@intel.com> Cc: "David S. Miller" <davem@davemloft.net>, "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>, "netdev@vger.kernel.org" <netdev@vger.kernel.org>, Andrew Lunn <andrew@lunn.ch> Subject: Re: [PATCH net-next v4 0/2] Add mii_bus to ixgbe driver for dsa devs Date: Mon, 3 Dec 2018 15:46:19 -0800 [thread overview] Message-ID: <c8e3976f-73f9-80be-f6d6-c9a1f064a096@gmail.com> (raw) In-Reply-To: <5c8b517a-6632-931d-c695-ec8a5302bfa4@silicom-usa.com> On 12/3/18 3:42 PM, Steve Douthit wrote: >> Not directly related to this patch series, are you using the legacy or >> "new" way of passing platform data in order to register the DSA switch? >> Since you mentioned 6390, I would assume this must be the "new" way of >> registering DSA devices with mdio_boardinfo etc. In that case, have you >> found yourself limited by the current dsa_chip_platform_data? > > With the new method I had an off-by-one error where the 'enabled_ports' > bitmask and 'port_names' array didn't match up in my first attempt. > That's definitely my fault, but the loop that searches for the "cpu" > string didn't like it and segfaulted. > > I've got something of a chicken-and-the-egg problem between where I'm > deferring while waiting for netdevs to show up, and registering the > mdio_board_info that needs those same pointers. For testing I exported > mdiobus_setup_mdiodev_from_board_info() and mdiobus_create_device() so I > could call the setup function again when the data was actually ready. Yes the current solution whereby we need to get a hold on the network device's struct device reference is not quite ideal, AFAIR, Andrew has had the same problem. > > It'd be nice to have more than one "cpu" port on a switch and have some > way to associate downstream and "cpu" ports. Not sure exactly what that > would look like, and it's not something I'm going to try and tackle at > the moment, but it's one for the wish list. Yes, we have been discussing that topic with Andrew and have a few ideas on how that could be achieved, but not code to use that at the moment. One of the idea was to finally allow enslaving the DSA master network device, that way you could assign specific ports to a specific CPU/DSA master network port within the switch, though that requires setting up a bridge. Would that work for your use case?
WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <f.fainelli@gmail.com> To: intel-wired-lan@osuosl.org Subject: [Intel-wired-lan] [PATCH net-next v4 0/2] Add mii_bus to ixgbe driver for dsa devs Date: Mon, 3 Dec 2018 15:46:19 -0800 [thread overview] Message-ID: <c8e3976f-73f9-80be-f6d6-c9a1f064a096@gmail.com> (raw) In-Reply-To: <5c8b517a-6632-931d-c695-ec8a5302bfa4@silicom-usa.com> On 12/3/18 3:42 PM, Steve Douthit wrote: >> Not directly related to this patch series, are you using the legacy or >> "new" way of passing platform data in order to register the DSA switch? >> Since you mentioned 6390, I would assume this must be the "new" way of >> registering DSA devices with mdio_boardinfo etc. In that case, have you >> found yourself limited by the current dsa_chip_platform_data? > > With the new method I had an off-by-one error where the 'enabled_ports' > bitmask and 'port_names' array didn't match up in my first attempt. > That's definitely my fault, but the loop that searches for the "cpu" > string didn't like it and segfaulted. > > I've got something of a chicken-and-the-egg problem between where I'm > deferring while waiting for netdevs to show up, and registering the > mdio_board_info that needs those same pointers. For testing I exported > mdiobus_setup_mdiodev_from_board_info() and mdiobus_create_device() so I > could call the setup function again when the data was actually ready. Yes the current solution whereby we need to get a hold on the network device's struct device reference is not quite ideal, AFAIR, Andrew has had the same problem. > > It'd be nice to have more than one "cpu" port on a switch and have some > way to associate downstream and "cpu" ports. Not sure exactly what that > would look like, and it's not something I'm going to try and tackle at > the moment, but it's one for the wish list. Yes, we have been discussing that topic with Andrew and have a few ideas on how that could be achieved, but not code to use that at the moment. One of the idea was to finally allow enslaving the DSA master network device, that way you could assign specific ports to a specific CPU/DSA master network port within the switch, though that requires setting up a bridge. Would that work for your use case? -- Florian
next prev parent reply other threads:[~2018-12-03 23:46 UTC|newest] Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-12-03 16:32 [PATCH net-next v2 0/2] Add mii_bus to ixgbe driver for dsa devs Steve Douthit 2018-12-03 16:32 ` [Intel-wired-lan] " Steve Douthit 2018-12-03 16:32 ` [PATCH net-next v2 1/2] ixgbe: register a mdiobus Steve Douthit 2018-12-03 16:32 ` [Intel-wired-lan] " Steve Douthit 2018-12-03 16:54 ` Andrew Lunn 2018-12-03 16:54 ` [Intel-wired-lan] " Andrew Lunn 2018-12-03 17:02 ` Steve Douthit 2018-12-03 17:02 ` [Intel-wired-lan] " Steve Douthit 2018-12-03 17:21 ` Andrew Lunn 2018-12-03 17:21 ` [Intel-wired-lan] " Andrew Lunn 2018-12-03 17:59 ` Steve Douthit 2018-12-03 17:59 ` [Intel-wired-lan] " Steve Douthit 2018-12-03 18:18 ` Andrew Lunn 2018-12-03 18:18 ` [Intel-wired-lan] " Andrew Lunn 2018-12-03 18:38 ` Steve Douthit 2018-12-03 18:38 ` [Intel-wired-lan] " Steve Douthit 2018-12-03 18:54 ` Andrew Lunn 2018-12-03 18:54 ` [Intel-wired-lan] " Andrew Lunn 2018-12-03 16:33 ` [PATCH net-next v2 2/2] ixgbe: use mii_bus to handle MII related ioctls Steve Douthit 2018-12-03 16:33 ` [Intel-wired-lan] " Steve Douthit 2018-12-03 18:55 ` [PATCH net-next v3 0/2] Add mii_bus to ixgbe driver for dsa devs Steve Douthit 2018-12-03 18:55 ` [Intel-wired-lan] " Steve Douthit 2018-12-03 18:55 ` [PATCH net-next v3 1/2] ixgbe: register a mdiobus Steve Douthit 2018-12-03 18:55 ` [Intel-wired-lan] " Steve Douthit 2018-12-03 19:00 ` Andrew Lunn 2018-12-03 19:00 ` [Intel-wired-lan] " Andrew Lunn 2018-12-03 19:07 ` Florian Fainelli 2018-12-03 19:07 ` [Intel-wired-lan] " Florian Fainelli 2018-12-03 19:44 ` Steve Douthit 2018-12-03 19:44 ` [Intel-wired-lan] " Steve Douthit 2018-12-03 19:45 ` Florian Fainelli 2018-12-03 19:45 ` [Intel-wired-lan] " Florian Fainelli 2018-12-03 18:55 ` [PATCH net-next v3 2/2] ixgbe: use mii_bus to handle MII related ioctls Steve Douthit 2018-12-03 18:55 ` [Intel-wired-lan] " Steve Douthit 2018-12-03 19:01 ` Andrew Lunn 2018-12-03 19:01 ` [Intel-wired-lan] " Andrew Lunn 2018-12-03 19:07 ` Florian Fainelli 2018-12-03 19:07 ` [Intel-wired-lan] " Florian Fainelli 2018-12-03 20:14 ` [PATCH net-next v4 0/2] Add mii_bus to ixgbe driver for dsa devs Steve Douthit 2018-12-03 20:14 ` [Intel-wired-lan] " Steve Douthit 2018-12-03 20:15 ` [PATCH net-next v4 1/2] ixgbe: register a mdiobus Steve Douthit 2018-12-03 20:15 ` [Intel-wired-lan] " Steve Douthit 2018-12-04 16:58 ` Bowers, AndrewX 2018-12-04 16:58 ` [Intel-wired-lan] " Bowers, AndrewX 2018-12-03 20:15 ` [PATCH net-next v4 2/2] ixgbe: use mii_bus to handle MII related ioctls Steve Douthit 2018-12-03 20:15 ` [Intel-wired-lan] " Steve Douthit 2018-12-04 16:59 ` Bowers, AndrewX 2018-12-04 16:59 ` [Intel-wired-lan] " Bowers, AndrewX 2018-12-03 20:51 ` [PATCH net-next v4 0/2] Add mii_bus to ixgbe driver for dsa devs Florian Fainelli 2018-12-03 20:51 ` [Intel-wired-lan] " Florian Fainelli 2018-12-03 23:42 ` Steve Douthit 2018-12-03 23:42 ` [Intel-wired-lan] " Steve Douthit 2018-12-03 23:46 ` Florian Fainelli [this message] 2018-12-03 23:46 ` Florian Fainelli 2018-12-04 10:40 ` Andrew Lunn 2018-12-04 10:40 ` [Intel-wired-lan] " Andrew Lunn 2018-12-04 16:02 ` Steve Douthit 2018-12-04 16:02 ` [Intel-wired-lan] " Steve Douthit 2018-12-06 15:50 ` [PATCH net-next v5 " Steve Douthit 2018-12-06 15:50 ` [Intel-wired-lan] " Steve Douthit 2018-12-06 15:50 ` [PATCH net-next v5 1/2] ixgbe: register a mdiobus Steve Douthit 2018-12-06 15:50 ` [Intel-wired-lan] " Steve Douthit 2018-12-06 15:50 ` [PATCH net-next v5 2/2] ixgbe: use mii_bus to handle MII related ioctls Steve Douthit 2018-12-06 15:50 ` [Intel-wired-lan] " Steve Douthit
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=c8e3976f-73f9-80be-f6d6-c9a1f064a096@gmail.com \ --to=f.fainelli@gmail.com \ --cc=andrew@lunn.ch \ --cc=davem@davemloft.net \ --cc=intel-wired-lan@lists.osuosl.org \ --cc=jeffrey.t.kirsher@intel.com \ --cc=netdev@vger.kernel.org \ --cc=stephend@silicom-usa.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.