* [PATCH v3 01/11] ACPI / LPSS: Make PCI dependency explicit
[not found] <20181223232521.11320-1-okaya@kernel.org>
@ 2018-12-23 23:25 ` Sinan Kaya
2018-12-23 23:25 ` Sinan Kaya
` (9 subsequent siblings)
10 siblings, 0 replies; 31+ messages in thread
From: Sinan Kaya @ 2018-12-23 23:25 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Rafael J. Wysocki, Len Brown, open list
This code depends on PCI. Compile only when PCI is present.
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
drivers/acpi/Makefile | 3 ++-
drivers/acpi/internal.h | 4 ++++
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/acpi/Makefile b/drivers/acpi/Makefile
index 7c6afc111d76..bb857421c2e8 100644
--- a/drivers/acpi/Makefile
+++ b/drivers/acpi/Makefile
@@ -41,7 +41,8 @@ acpi-y += ec.o
acpi-$(CONFIG_ACPI_DOCK) += dock.o
acpi-$(CONFIG_PCI) += pci_root.o pci_link.o pci_irq.o
obj-$(CONFIG_ACPI_MCFG) += pci_mcfg.o
-acpi-y += acpi_lpss.o acpi_apd.o
+acpi-$(CONFIG_PCI) += acpi_lpss.o
+acpi-y += acpi_apd.o
acpi-y += acpi_platform.o
acpi-y += acpi_pnp.o
acpi-$(CONFIG_ARM_AMBA) += acpi_amba.o
diff --git a/drivers/acpi/internal.h b/drivers/acpi/internal.h
index 7e6952edb5b0..6a9e1fb8913a 100644
--- a/drivers/acpi/internal.h
+++ b/drivers/acpi/internal.h
@@ -81,7 +81,11 @@ void acpi_debugfs_init(void);
#else
static inline void acpi_debugfs_init(void) { return; }
#endif
+#ifdef CONFIG_PCI
void acpi_lpss_init(void);
+#else
+static inline void acpi_lpss_init(void) {}
+#endif
void acpi_apd_init(void);
--
2.19.0
^ permalink raw reply related [flat|nested] 31+ messages in thread
* [PATCH v3 01/11] ACPI / LPSS: Make PCI dependency explicit
@ 2018-12-23 23:25 ` Sinan Kaya
0 siblings, 0 replies; 31+ messages in thread
From: Sinan Kaya @ 2018-12-23 23:25 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Rafael J. Wysocki, Len Brown, open list
This code depends on PCI. Compile only when PCI is present.
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
drivers/acpi/Makefile | 3 ++-
drivers/acpi/internal.h | 4 ++++
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/acpi/Makefile b/drivers/acpi/Makefile
index 7c6afc111d76..bb857421c2e8 100644
--- a/drivers/acpi/Makefile
+++ b/drivers/acpi/Makefile
@@ -41,7 +41,8 @@ acpi-y += ec.o
acpi-$(CONFIG_ACPI_DOCK) += dock.o
acpi-$(CONFIG_PCI) += pci_root.o pci_link.o pci_irq.o
obj-$(CONFIG_ACPI_MCFG) += pci_mcfg.o
-acpi-y += acpi_lpss.o acpi_apd.o
+acpi-$(CONFIG_PCI) += acpi_lpss.o
+acpi-y += acpi_apd.o
acpi-y += acpi_platform.o
acpi-y += acpi_pnp.o
acpi-$(CONFIG_ARM_AMBA) += acpi_amba.o
diff --git a/drivers/acpi/internal.h b/drivers/acpi/internal.h
index 7e6952edb5b0..6a9e1fb8913a 100644
--- a/drivers/acpi/internal.h
+++ b/drivers/acpi/internal.h
@@ -81,7 +81,11 @@ void acpi_debugfs_init(void);
#else
static inline void acpi_debugfs_init(void) { return; }
#endif
+#ifdef CONFIG_PCI
void acpi_lpss_init(void);
+#else
+static inline void acpi_lpss_init(void) {}
+#endif
void acpi_apd_init(void);
--
2.19.0
^ permalink raw reply related [flat|nested] 31+ messages in thread
* [PATCH v3 02/11] ata: make PCI dependency explicit for PATA_ACPI
[not found] <20181223232521.11320-1-okaya@kernel.org>
@ 2018-12-23 23:25 ` Sinan Kaya
2018-12-23 23:25 ` Sinan Kaya
` (9 subsequent siblings)
10 siblings, 0 replies; 31+ messages in thread
From: Sinan Kaya @ 2018-12-23 23:25 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Jens Axboe,
open list:LIBATA SUBSYSTEM Serial and Parallel ATA drivers,
open list
PATA_ACPI is a PCI device driver but the PCI dependency has not been
explicitly called out.
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
drivers/ata/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 4ca7a6b4eaae..8218db17ebdb 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -1091,7 +1091,7 @@ comment "Generic fallback / legacy drivers"
config PATA_ACPI
tristate "ACPI firmware driver for PATA"
- depends on ATA_ACPI && ATA_BMDMA
+ depends on ATA_ACPI && ATA_BMDMA && PCI
help
This option enables an ACPI method driver which drives
motherboard PATA controller interfaces through the ACPI
--
2.19.0
^ permalink raw reply related [flat|nested] 31+ messages in thread
* [PATCH v3 02/11] ata: make PCI dependency explicit for PATA_ACPI
@ 2018-12-23 23:25 ` Sinan Kaya
0 siblings, 0 replies; 31+ messages in thread
From: Sinan Kaya @ 2018-12-23 23:25 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Jens Axboe,
open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers),
open list
PATA_ACPI is a PCI device driver but the PCI dependency has not been
explicitly called out.
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
drivers/ata/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 4ca7a6b4eaae..8218db17ebdb 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -1091,7 +1091,7 @@ comment "Generic fallback / legacy drivers"
config PATA_ACPI
tristate "ACPI firmware driver for PATA"
- depends on ATA_ACPI && ATA_BMDMA
+ depends on ATA_ACPI && ATA_BMDMA && PCI
help
This option enables an ACPI method driver which drives
motherboard PATA controller interfaces through the ACPI
--
2.19.0
^ permalink raw reply related [flat|nested] 31+ messages in thread
* [PATCH v3 03/11] vga-switcheroo: make PCI dependency explicit
[not found] <20181223232521.11320-1-okaya@kernel.org>
@ 2018-12-23 23:25 ` Sinan Kaya
2018-12-23 23:25 ` Sinan Kaya
` (9 subsequent siblings)
10 siblings, 0 replies; 31+ messages in thread
From: Sinan Kaya @ 2018-12-23 23:25 UTC (permalink / raw)
To: linux-next
Cc: Maxime Ripard, Sinan Kaya, David Airlie, open list,
open list:DRM DRIVERS, linux-acpi, Sean Paul
This driver depends on the PCI infrastructure but the dependency has not
been explicitly called out.
Signed-off-by: Sinan Kaya <okaya@kernel.org>
Reviewed-by: Lukas Wunner <lukas@wunner.de>
---
drivers/gpu/vga/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/vga/Kconfig b/drivers/gpu/vga/Kconfig
index b677e5d524e6..d5f1d8e1c6f8 100644
--- a/drivers/gpu/vga/Kconfig
+++ b/drivers/gpu/vga/Kconfig
@@ -21,6 +21,7 @@ config VGA_SWITCHEROO
bool "Laptop Hybrid Graphics - GPU switching support"
depends on X86
depends on ACPI
+ depends on PCI
select VGA_ARB
help
Many laptops released in 2008/9/10 have two GPUs with a multiplexer
--
2.19.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 31+ messages in thread
* [PATCH v3 03/11] vga-switcheroo: make PCI dependency explicit
@ 2018-12-23 23:25 ` Sinan Kaya
0 siblings, 0 replies; 31+ messages in thread
From: Sinan Kaya @ 2018-12-23 23:25 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Maarten Lankhorst, Maxime Ripard,
Sean Paul, David Airlie, Daniel Vetter, open list:DRM DRIVERS,
open list
This driver depends on the PCI infrastructure but the dependency has not
been explicitly called out.
Signed-off-by: Sinan Kaya <okaya@kernel.org>
Reviewed-by: Lukas Wunner <lukas@wunner.de>
---
drivers/gpu/vga/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/vga/Kconfig b/drivers/gpu/vga/Kconfig
index b677e5d524e6..d5f1d8e1c6f8 100644
--- a/drivers/gpu/vga/Kconfig
+++ b/drivers/gpu/vga/Kconfig
@@ -21,6 +21,7 @@ config VGA_SWITCHEROO
bool "Laptop Hybrid Graphics - GPU switching support"
depends on X86
depends on ACPI
+ depends on PCI
select VGA_ARB
help
Many laptops released in 2008/9/10 have two GPUs with a multiplexer
--
2.19.0
^ permalink raw reply related [flat|nested] 31+ messages in thread
* [PATCH v3 04/11] platform/x86: intel_ips: make PCI dependency explicit
[not found] <20181223232521.11320-1-okaya@kernel.org>
@ 2018-12-23 23:25 ` Sinan Kaya
2018-12-23 23:25 ` Sinan Kaya
` (9 subsequent siblings)
10 siblings, 0 replies; 31+ messages in thread
From: Sinan Kaya @ 2018-12-23 23:25 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Darren Hart, Andy Shevchenko,
open list:X86 PLATFORM DRIVERS, open list
ipss driver is a PCI device driver but this has not been mentioned
anywhere in Kconfig.
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
drivers/platform/x86/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index e3b62c2ee8d1..b36ea14b41ad 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -1009,7 +1009,7 @@ config INTEL_MFLD_THERMAL
config INTEL_IPS
tristate "Intel Intelligent Power Sharing"
- depends on ACPI
+ depends on ACPI && PCI
---help---
Intel Calpella platforms support dynamic power sharing between the
CPU and GPU, maximizing performance in a given TDP. This driver,
--
2.19.0
^ permalink raw reply related [flat|nested] 31+ messages in thread
* [PATCH v3 04/11] platform/x86: intel_ips: make PCI dependency explicit
@ 2018-12-23 23:25 ` Sinan Kaya
0 siblings, 0 replies; 31+ messages in thread
From: Sinan Kaya @ 2018-12-23 23:25 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Darren Hart, Andy Shevchenko,
open list:X86 PLATFORM DRIVERS, open list
ipss driver is a PCI device driver but this has not been mentioned
anywhere in Kconfig.
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
drivers/platform/x86/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index e3b62c2ee8d1..b36ea14b41ad 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -1009,7 +1009,7 @@ config INTEL_MFLD_THERMAL
config INTEL_IPS
tristate "Intel Intelligent Power Sharing"
- depends on ACPI
+ depends on ACPI && PCI
---help---
Intel Calpella platforms support dynamic power sharing between the
CPU and GPU, maximizing performance in a given TDP. This driver,
--
2.19.0
^ permalink raw reply related [flat|nested] 31+ messages in thread
* [PATCH v3 05/11] platform/x86: intel_pmc: Make PCI dependency explicit
[not found] <20181223232521.11320-1-okaya@kernel.org>
@ 2018-12-23 23:25 ` Sinan Kaya
2018-12-23 23:25 ` Sinan Kaya
` (9 subsequent siblings)
10 siblings, 0 replies; 31+ messages in thread
From: Sinan Kaya @ 2018-12-23 23:25 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Darren Hart, Andy Shevchenko,
open list:X86 PLATFORM DRIVERS, open list
Code relies on PCI for execution. Specify this in the Kconfig.
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
drivers/platform/x86/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index b36ea14b41ad..7afb96cb1cd6 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -1174,7 +1174,7 @@ config INTEL_SMARTCONNECT
config INTEL_PMC_IPC
tristate "Intel PMC IPC Driver"
- depends on ACPI
+ depends on ACPI && PCI
---help---
This driver provides support for PMC control on some Intel platforms.
The PMC is an ARC processor which defines IPC commands for communication
--
2.19.0
^ permalink raw reply related [flat|nested] 31+ messages in thread
* [PATCH v3 05/11] platform/x86: intel_pmc: Make PCI dependency explicit
@ 2018-12-23 23:25 ` Sinan Kaya
0 siblings, 0 replies; 31+ messages in thread
From: Sinan Kaya @ 2018-12-23 23:25 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Darren Hart, Andy Shevchenko,
open list:X86 PLATFORM DRIVERS, open list
Code relies on PCI for execution. Specify this in the Kconfig.
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
drivers/platform/x86/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index b36ea14b41ad..7afb96cb1cd6 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -1174,7 +1174,7 @@ config INTEL_SMARTCONNECT
config INTEL_PMC_IPC
tristate "Intel PMC IPC Driver"
- depends on ACPI
+ depends on ACPI && PCI
---help---
This driver provides support for PMC control on some Intel platforms.
The PMC is an ARC processor which defines IPC commands for communication
--
2.19.0
^ permalink raw reply related [flat|nested] 31+ messages in thread
* [PATCH v3 06/11] apple-gmux: Make PCI dependency explicit
[not found] <20181223232521.11320-1-okaya@kernel.org>
@ 2018-12-23 23:25 ` Sinan Kaya
2018-12-23 23:25 ` Sinan Kaya
` (9 subsequent siblings)
10 siblings, 0 replies; 31+ messages in thread
From: Sinan Kaya @ 2018-12-23 23:25 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Darren Hart, Andy Shevchenko,
open list:X86 PLATFORM DRIVERS, open list
This driver depends on the PCI infrastructure but the dependency has not
been explicitly called out.
Signed-off-by: Sinan Kaya <okaya@kernel.org>
Reviewed-by: Lukas Wunner <lukas@wunner.de>
---
drivers/platform/x86/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 7afb96cb1cd6..89f4b86244a7 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -1136,6 +1136,7 @@ config SAMSUNG_Q10
config APPLE_GMUX
tristate "Apple Gmux Driver"
depends on ACPI
+ depends on PCI
depends on PNP
depends on BACKLIGHT_CLASS_DEVICE
depends on BACKLIGHT_APPLE=n || BACKLIGHT_APPLE
--
2.19.0
^ permalink raw reply related [flat|nested] 31+ messages in thread
* [PATCH v3 06/11] apple-gmux: Make PCI dependency explicit
@ 2018-12-23 23:25 ` Sinan Kaya
0 siblings, 0 replies; 31+ messages in thread
From: Sinan Kaya @ 2018-12-23 23:25 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Darren Hart, Andy Shevchenko,
open list:X86 PLATFORM DRIVERS, open list
This driver depends on the PCI infrastructure but the dependency has not
been explicitly called out.
Signed-off-by: Sinan Kaya <okaya@kernel.org>
Reviewed-by: Lukas Wunner <lukas@wunner.de>
---
drivers/platform/x86/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 7afb96cb1cd6..89f4b86244a7 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -1136,6 +1136,7 @@ config SAMSUNG_Q10
config APPLE_GMUX
tristate "Apple Gmux Driver"
depends on ACPI
+ depends on PCI
depends on PNP
depends on BACKLIGHT_CLASS_DEVICE
depends on BACKLIGHT_APPLE=n || BACKLIGHT_APPLE
--
2.19.0
^ permalink raw reply related [flat|nested] 31+ messages in thread
* [PATCH v3 07/11] drivers: thermal: int3406_thermal: Make PCI dependency explicit
[not found] <20181223232521.11320-1-okaya@kernel.org>
@ 2018-12-23 23:25 ` Sinan Kaya
2018-12-23 23:25 ` Sinan Kaya
` (9 subsequent siblings)
10 siblings, 0 replies; 31+ messages in thread
From: Sinan Kaya @ 2018-12-23 23:25 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Zhang Rui, Eduardo Valentin,
Daniel Lezcano, Amit Kucheria, open list:THERMAL, open list
Need CONFIG_PCI to be set in order to be able to use this driver.
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
drivers/thermal/intel/int340x_thermal/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/intel/int340x_thermal/Kconfig b/drivers/thermal/intel/int340x_thermal/Kconfig
index 0582bd12a239..fba1976d5f8d 100644
--- a/drivers/thermal/intel/int340x_thermal/Kconfig
+++ b/drivers/thermal/intel/int340x_thermal/Kconfig
@@ -31,7 +31,7 @@ if INT340X_THERMAL
config INT3406_THERMAL
tristate "ACPI INT3406 display thermal driver"
- depends on ACPI_VIDEO
+ depends on ACPI_VIDEO && PCI
help
The display thermal device represents the LED/LCD display panel
that may or may not include touch support. The main function of
--
2.19.0
^ permalink raw reply related [flat|nested] 31+ messages in thread
* [PATCH v3 07/11] drivers: thermal: int3406_thermal: Make PCI dependency explicit
@ 2018-12-23 23:25 ` Sinan Kaya
0 siblings, 0 replies; 31+ messages in thread
From: Sinan Kaya @ 2018-12-23 23:25 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Zhang Rui, Eduardo Valentin,
Daniel Lezcano, Amit Kucheria, open list:THERMAL, open list
Need CONFIG_PCI to be set in order to be able to use this driver.
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
drivers/thermal/intel/int340x_thermal/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/intel/int340x_thermal/Kconfig b/drivers/thermal/intel/int340x_thermal/Kconfig
index 0582bd12a239..fba1976d5f8d 100644
--- a/drivers/thermal/intel/int340x_thermal/Kconfig
+++ b/drivers/thermal/intel/int340x_thermal/Kconfig
@@ -31,7 +31,7 @@ if INT340X_THERMAL
config INT3406_THERMAL
tristate "ACPI INT3406 display thermal driver"
- depends on ACPI_VIDEO
+ depends on ACPI_VIDEO && PCI
help
The display thermal device represents the LED/LCD display panel
that may or may not include touch support. The main function of
--
2.19.0
^ permalink raw reply related [flat|nested] 31+ messages in thread
* [PATCH v3 08/11] ASoC: Intel: atom: Make PCI dependency explicit
[not found] <20181223232521.11320-1-okaya@kernel.org>
@ 2018-12-23 23:25 ` Sinan Kaya
2018-12-23 23:25 ` Sinan Kaya
` (9 subsequent siblings)
10 siblings, 0 replies; 31+ messages in thread
From: Sinan Kaya @ 2018-12-23 23:25 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Pierre-Louis Bossart, Liam Girdwood,
Jie Yang, Mark Brown, Jaroslav Kysela, Takashi Iwai,
moderated list:INTEL ASoC DRIVERS, open list
Code does unconditional select for IOSF_MBI. IOSF_MBI driver depends on
CONFIG_PCI set but this is not specified anywhere.
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
sound/soc/intel/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig
index 2fd1b61e8331..b0764b2fe001 100644
--- a/sound/soc/intel/Kconfig
+++ b/sound/soc/intel/Kconfig
@@ -91,7 +91,7 @@ config SND_SST_ATOM_HIFI2_PLATFORM_PCI
config SND_SST_ATOM_HIFI2_PLATFORM_ACPI
tristate "ACPI HiFi2 (Baytrail, Cherrytrail) Platforms"
default ACPI
- depends on X86 && ACPI
+ depends on X86 && ACPI && PCI
select SND_SST_IPC_ACPI
select SND_SST_ATOM_HIFI2_PLATFORM
select SND_SOC_ACPI_INTEL_MATCH
--
2.19.0
^ permalink raw reply related [flat|nested] 31+ messages in thread
* [PATCH v3 08/11] ASoC: Intel: atom: Make PCI dependency explicit
@ 2018-12-23 23:25 ` Sinan Kaya
0 siblings, 0 replies; 31+ messages in thread
From: Sinan Kaya @ 2018-12-23 23:25 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Pierre-Louis Bossart, Liam Girdwood,
Jie Yang, Mark Brown, Jaroslav Kysela, Takashi Iwai,
moderated list:INTEL ASoC DRIVERS, open list
Code does unconditional select for IOSF_MBI. IOSF_MBI driver depends on
CONFIG_PCI set but this is not specified anywhere.
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
sound/soc/intel/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig
index 2fd1b61e8331..b0764b2fe001 100644
--- a/sound/soc/intel/Kconfig
+++ b/sound/soc/intel/Kconfig
@@ -91,7 +91,7 @@ config SND_SST_ATOM_HIFI2_PLATFORM_PCI
config SND_SST_ATOM_HIFI2_PLATFORM_ACPI
tristate "ACPI HiFi2 (Baytrail, Cherrytrail) Platforms"
default ACPI
- depends on X86 && ACPI
+ depends on X86 && ACPI && PCI
select SND_SST_IPC_ACPI
select SND_SST_ATOM_HIFI2_PLATFORM
select SND_SOC_ACPI_INTEL_MATCH
--
2.19.0
^ permalink raw reply related [flat|nested] 31+ messages in thread
* [PATCH v3 09/11] mmc: add PCI dependency into IOSF_MBI
[not found] <20181223232521.11320-1-okaya@kernel.org>
@ 2018-12-23 23:25 ` Sinan Kaya
2018-12-23 23:25 ` Sinan Kaya
` (9 subsequent siblings)
10 siblings, 0 replies; 31+ messages in thread
From: Sinan Kaya @ 2018-12-23 23:25 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Ulf Hansson, Adrian Hunter, Shawn Lin,
Masahiro Yamada, Geert Uytterhoeven, Faiz Abbas, Chunyan Zhang,
Jisheng Zhang, Ludovic Barre, Arnd Bergmann, Alex Smith,
Chris Brandt, open list:MULTIMEDIA CARD MMC,
SECURE DIGITAL SD AND...,
open list
Select IOSF_MBI only when PCI is set.
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
drivers/mmc/host/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index e26b8145efb3..4c5f037b246d 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -117,7 +117,7 @@ config MMC_RICOH_MMC
config MMC_SDHCI_ACPI
tristate "SDHCI support for ACPI enumerated SDHCI controllers"
depends on MMC_SDHCI && ACPI
- select IOSF_MBI if X86
+ select IOSF_MBI if (X86 && PCI)
help
This selects support for ACPI enumerated SDHCI controllers,
identified by ACPI Compatibility ID PNP0D40 or specific
--
2.19.0
^ permalink raw reply related [flat|nested] 31+ messages in thread
* [PATCH v3 09/11] mmc: add PCI dependency into IOSF_MBI
@ 2018-12-23 23:25 ` Sinan Kaya
0 siblings, 0 replies; 31+ messages in thread
From: Sinan Kaya @ 2018-12-23 23:25 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Ulf Hansson, Adrian Hunter, Shawn Lin,
Masahiro Yamada, Geert Uytterhoeven, Faiz Abbas, Chunyan Zhang,
Jisheng Zhang, Ludovic Barre, Arnd Bergmann, Alex Smith,
Chris Brandt, open list:MULTIMEDIA CARD (MMC),
SECURE DIGITAL (SD) AND...,
open list
Select IOSF_MBI only when PCI is set.
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
drivers/mmc/host/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index e26b8145efb3..4c5f037b246d 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -117,7 +117,7 @@ config MMC_RICOH_MMC
config MMC_SDHCI_ACPI
tristate "SDHCI support for ACPI enumerated SDHCI controllers"
depends on MMC_SDHCI && ACPI
- select IOSF_MBI if X86
+ select IOSF_MBI if (X86 && PCI)
help
This selects support for ACPI enumerated SDHCI controllers,
identified by ACPI Compatibility ID PNP0D40 or specific
--
2.19.0
^ permalink raw reply related [flat|nested] 31+ messages in thread
* [PATCH v3 10/11] x86: select IOSF_MBI only when CONFIG_PCI is set
[not found] <20181223232521.11320-1-okaya@kernel.org>
@ 2018-12-23 23:25 ` Sinan Kaya
2018-12-23 23:25 ` Sinan Kaya
` (9 subsequent siblings)
10 siblings, 0 replies; 31+ messages in thread
From: Sinan Kaya @ 2018-12-23 23:25 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Thomas Gleixner, Ingo Molnar,
Borislav Petkov, H. Peter Anvin,
maintainer:X86 ARCHITECTURE 32-BIT AND 64-BIT,
open list:X86 ARCHITECTURE 32-BIT AND 64-BIT
Need CONFIG_PCI to be set in order to be able to use IOSF_MBI
functionality.
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
arch/x86/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index cc4f0c6ee1ed..322a58ababb0 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -617,7 +617,7 @@ config X86_INTEL_QUARK
config X86_INTEL_LPSS
bool "Intel Low Power Subsystem Support"
- depends on X86 && ACPI
+ depends on X86 && ACPI && PCI
select COMMON_CLK
select PINCTRL
select IOSF_MBI
--
2.19.0
^ permalink raw reply related [flat|nested] 31+ messages in thread
* [PATCH v3 10/11] x86: select IOSF_MBI only when CONFIG_PCI is set
@ 2018-12-23 23:25 ` Sinan Kaya
0 siblings, 0 replies; 31+ messages in thread
From: Sinan Kaya @ 2018-12-23 23:25 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Thomas Gleixner, Ingo Molnar,
Borislav Petkov, H. Peter Anvin,
maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT),
open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)
Need CONFIG_PCI to be set in order to be able to use IOSF_MBI
functionality.
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
arch/x86/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index cc4f0c6ee1ed..322a58ababb0 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -617,7 +617,7 @@ config X86_INTEL_QUARK
config X86_INTEL_LPSS
bool "Intel Low Power Subsystem Support"
- depends on X86 && ACPI
+ depends on X86 && ACPI && PCI
select COMMON_CLK
select PINCTRL
select IOSF_MBI
--
2.19.0
^ permalink raw reply related [flat|nested] 31+ messages in thread
* [PATCH v3 11/11] drivers: thermal: int340x_thermal: Make PCI dependency explicit
[not found] <20181223232521.11320-1-okaya@kernel.org>
@ 2018-12-23 23:25 ` Sinan Kaya
2018-12-23 23:25 ` Sinan Kaya
` (9 subsequent siblings)
10 siblings, 0 replies; 31+ messages in thread
From: Sinan Kaya @ 2018-12-23 23:25 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Zhang Rui, Eduardo Valentin,
Daniel Lezcano, Amit Kucheria, open list:THERMAL, open list
IOSF_CORE depends on PCI. This was never mentioned.
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
drivers/thermal/intel/int340x_thermal/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/intel/int340x_thermal/Kconfig b/drivers/thermal/intel/int340x_thermal/Kconfig
index fba1976d5f8d..2acddf8fb314 100644
--- a/drivers/thermal/intel/int340x_thermal/Kconfig
+++ b/drivers/thermal/intel/int340x_thermal/Kconfig
@@ -4,7 +4,7 @@
config INT340X_THERMAL
tristate "ACPI INT340X thermal drivers"
- depends on X86 && ACPI
+ depends on X86 && ACPI && PCI
select THERMAL_GOV_USER_SPACE
select ACPI_THERMAL_REL
select ACPI_FAN
--
2.19.0
^ permalink raw reply related [flat|nested] 31+ messages in thread
* [PATCH v3 11/11] drivers: thermal: int340x_thermal: Make PCI dependency explicit
@ 2018-12-23 23:25 ` Sinan Kaya
0 siblings, 0 replies; 31+ messages in thread
From: Sinan Kaya @ 2018-12-23 23:25 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Zhang Rui, Eduardo Valentin,
Daniel Lezcano, Amit Kucheria, open list:THERMAL, open list
IOSF_CORE depends on PCI. This was never mentioned.
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
drivers/thermal/intel/int340x_thermal/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/intel/int340x_thermal/Kconfig b/drivers/thermal/intel/int340x_thermal/Kconfig
index fba1976d5f8d..2acddf8fb314 100644
--- a/drivers/thermal/intel/int340x_thermal/Kconfig
+++ b/drivers/thermal/intel/int340x_thermal/Kconfig
@@ -4,7 +4,7 @@
config INT340X_THERMAL
tristate "ACPI INT340X thermal drivers"
- depends on X86 && ACPI
+ depends on X86 && ACPI && PCI
select THERMAL_GOV_USER_SPACE
select ACPI_THERMAL_REL
select ACPI_FAN
--
2.19.0
^ permalink raw reply related [flat|nested] 31+ messages in thread
* Re: [PATCH v3 10/11] x86: select IOSF_MBI only when CONFIG_PCI is set
2018-12-23 23:25 ` Sinan Kaya
(?)
@ 2018-12-25 9:13 ` Rafael J. Wysocki
2018-12-30 19:04 ` Sinan Kaya
-1 siblings, 1 reply; 31+ messages in thread
From: Rafael J. Wysocki @ 2018-12-25 9:13 UTC (permalink / raw)
To: okaya
Cc: Linux-Next Mailing List, ACPI Devel Maling List, Thomas Gleixner,
Ingo Molnar, Borislav Petkov, H. Peter Anvin,
the arch/x86 maintainers, Linux Kernel Mailing List
On Mon, Dec 24, 2018 at 12:25 AM Sinan Kaya <okaya@kernel.org> wrote:
>
> Need CONFIG_PCI to be set in order to be able to use IOSF_MBI
> functionality.
>
> Signed-off-by: Sinan Kaya <okaya@kernel.org>
The subject and changelog here don't match the changes below. Please fix.
> ---
> arch/x86/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index cc4f0c6ee1ed..322a58ababb0 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -617,7 +617,7 @@ config X86_INTEL_QUARK
>
> config X86_INTEL_LPSS
> bool "Intel Low Power Subsystem Support"
> - depends on X86 && ACPI
> + depends on X86 && ACPI && PCI
> select COMMON_CLK
> select PINCTRL
> select IOSF_MBI
> --
> 2.19.0
>
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH v3 09/11] mmc: add PCI dependency into IOSF_MBI
2018-12-23 23:25 ` Sinan Kaya
(?)
@ 2018-12-26 9:40 ` Rafael J. Wysocki
2018-12-30 18:56 ` Sinan Kaya
-1 siblings, 1 reply; 31+ messages in thread
From: Rafael J. Wysocki @ 2018-12-26 9:40 UTC (permalink / raw)
To: okaya
Cc: Linux-Next Mailing List, ACPI Devel Maling List, Ulf Hansson,
Hunter, Adrian, Shawn Lin, Masahiro Yamada, Geert Uytterhoeven,
faiz_abbas, chunyan.zhang, Jisheng.Zhang, ludovic.barre,
Arnd Bergmann, alex.smith, chris.brandt, linux-mmc,
Linux Kernel Mailing List
On Mon, Dec 24, 2018 at 12:26 AM Sinan Kaya <okaya@kernel.org> wrote:
>
> Select IOSF_MBI only when PCI is set.
>
> Signed-off-by: Sinan Kaya <okaya@kernel.org>
> ---
> drivers/mmc/host/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index e26b8145efb3..4c5f037b246d 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -117,7 +117,7 @@ config MMC_RICOH_MMC
> config MMC_SDHCI_ACPI
> tristate "SDHCI support for ACPI enumerated SDHCI controllers"
> depends on MMC_SDHCI && ACPI
It should depend on PCI as well, shouldn't it?
As it stands with the patch applied, randconfig can still select it if
PCI is unset AFAICS, can't it?
> - select IOSF_MBI if X86
> + select IOSF_MBI if (X86 && PCI)
> help
> This selects support for ACPI enumerated SDHCI controllers,
> identified by ACPI Compatibility ID PNP0D40 or specific
> --
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH v3 08/11] ASoC: Intel: atom: Make PCI dependency explicit
2018-12-23 23:25 ` Sinan Kaya
(?)
@ 2018-12-26 17:35 ` Pierre-Louis Bossart
2018-12-26 20:07 ` Sinan Kaya
-1 siblings, 1 reply; 31+ messages in thread
From: Pierre-Louis Bossart @ 2018-12-26 17:35 UTC (permalink / raw)
To: Sinan Kaya, linux-next
Cc: linux-acpi, Liam Girdwood, Jie Yang, Mark Brown, Jaroslav Kysela,
Takashi Iwai, moderated list:INTEL ASoC DRIVERS, open list
On 12/23/18 5:25 PM, Sinan Kaya wrote:
> Code does unconditional select for IOSF_MBI. IOSF_MBI driver depends on
> CONFIG_PCI set but this is not specified anywhere.
Can you please share the .config that exposes this problem? This hasn't
changed in a long time and I wonder why this pops up now. You have
similar cases elsewhere, e.g. arch/x86/Kconfig
config X86_INTEL_LPSS
bool "Intel Low Power Subsystem Support"
depends on X86 && ACPI
select COMMON_CLK
select PINCTRL
select IOSF_MBI
or for the MMC.
config MMC_SDHCI_ACPI
tristate "SDHCI support for ACPI enumerated SDHCI controllers"
depends on MMC_SDHCI && ACPI
select IOSF_MBI if X86
The use of IOSF_MBI is only for the Baytrail-CR detection and there are
already in-flight patches to change the code and move it to a helper.
My understanding is that for compilation you only need CONFIG_x86 since
there are fall-back routines available in iosf_mbi.h
Thanks!
>
> Signed-off-by: Sinan Kaya <okaya@kernel.org>
> ---
> sound/soc/intel/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig
> index 2fd1b61e8331..b0764b2fe001 100644
> --- a/sound/soc/intel/Kconfig
> +++ b/sound/soc/intel/Kconfig
> @@ -91,7 +91,7 @@ config SND_SST_ATOM_HIFI2_PLATFORM_PCI
> config SND_SST_ATOM_HIFI2_PLATFORM_ACPI
> tristate "ACPI HiFi2 (Baytrail, Cherrytrail) Platforms"
> default ACPI
> - depends on X86 && ACPI
> + depends on X86 && ACPI && PCI
> select SND_SST_IPC_ACPI
> select SND_SST_ATOM_HIFI2_PLATFORM
> select SND_SOC_ACPI_INTEL_MATCH
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH v3 08/11] ASoC: Intel: atom: Make PCI dependency explicit
2018-12-26 17:35 ` Pierre-Louis Bossart
@ 2018-12-26 20:07 ` Sinan Kaya
0 siblings, 0 replies; 31+ messages in thread
From: Sinan Kaya @ 2018-12-26 20:07 UTC (permalink / raw)
To: Pierre-Louis Bossart
Cc: Linux Next Mailing List, ACPI Devel Mailing List, Liam Girdwood,
Jie Yang, Mark Brown, Jaroslav Kysela, Takashi Iwai,
moderated list:INTEL ASoC DRIVERS, open list
On Wed, Dec 26, 2018 at 8:35 PM Pierre-Louis Bossart
<pierre-louis.bossart@linux.intel.com> wrote:
>
>
> On 12/23/18 5:25 PM, Sinan Kaya wrote:
> > Code does unconditional select for IOSF_MBI. IOSF_MBI driver depends on
> > CONFIG_PCI set but this is not specified anywhere.
>
> Can you please share the .config that exposes this problem? This hasn't
> changed in a long time and I wonder why this pops up now. You have
> similar cases elsewhere, e.g. arch/x86/Kconfig
>
Here is the background :
I have a changeset that was added to 4.21-rc1 that decouples ACPI from
PCI. PCI was automatically selected when ACPI was chosen before.
This is no longer true.
If a code needs PCI support, it now needs to explicitly state that.
This allows usecase for smaller kernels and component isolation.
> config X86_INTEL_LPSS
> bool "Intel Low Power Subsystem Support"
> depends on X86 && ACPI
> select COMMON_CLK
> select PINCTRL
> select IOSF_MBI
>
> or for the MMC.
>
> config MMC_SDHCI_ACPI
> tristate "SDHCI support for ACPI enumerated SDHCI controllers"
> depends on MMC_SDHCI && ACPI
> select IOSF_MBI if X86
>
> The use of IOSF_MBI is only for the Baytrail-CR detection and there are
> already in-flight patches to change the code and move it to a helper.
>
> My understanding is that for compilation you only need CONFIG_x86 since
> there are fall-back routines available in iosf_mbi.h
>
> Thanks!
>
> >
> > Signed-off-by: Sinan Kaya <okaya@kernel.org>
> > ---
> > sound/soc/intel/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig
> > index 2fd1b61e8331..b0764b2fe001 100644
> > --- a/sound/soc/intel/Kconfig
> > +++ b/sound/soc/intel/Kconfig
> > @@ -91,7 +91,7 @@ config SND_SST_ATOM_HIFI2_PLATFORM_PCI
> > config SND_SST_ATOM_HIFI2_PLATFORM_ACPI
> > tristate "ACPI HiFi2 (Baytrail, Cherrytrail) Platforms"
> > default ACPI
> > - depends on X86 && ACPI
> > + depends on X86 && ACPI && PCI
> > select SND_SST_IPC_ACPI
> > select SND_SST_ATOM_HIFI2_PLATFORM
> > select SND_SOC_ACPI_INTEL_MATCH
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH v3 09/11] mmc: add PCI dependency into IOSF_MBI
2018-12-26 9:40 ` Rafael J. Wysocki
@ 2018-12-30 18:56 ` Sinan Kaya
2018-12-31 9:40 ` Rafael J. Wysocki
0 siblings, 1 reply; 31+ messages in thread
From: Sinan Kaya @ 2018-12-30 18:56 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Linux-Next Mailing List, ACPI Devel Maling List, Ulf Hansson,
Hunter, Adrian, Shawn Lin, Masahiro Yamada, Geert Uytterhoeven,
faiz_abbas, chunyan.zhang, Jisheng.Zhang, ludovic.barre,
Arnd Bergmann, alex.smith, chris.brandt, linux-mmc,
Linux Kernel Mailing List
On Wed, Dec 26, 2018 at 12:41 PM Rafael J. Wysocki <rafael@kernel.org> wrote:
>
> On Mon, Dec 24, 2018 at 12:26 AM Sinan Kaya <okaya@kernel.org> wrote:
> >
> > Select IOSF_MBI only when PCI is set.
> >
> > Signed-off-by: Sinan Kaya <okaya@kernel.org>
> > ---
> > drivers/mmc/host/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> > index e26b8145efb3..4c5f037b246d 100644
> > --- a/drivers/mmc/host/Kconfig
> > +++ b/drivers/mmc/host/Kconfig
> > @@ -117,7 +117,7 @@ config MMC_RICOH_MMC
> > config MMC_SDHCI_ACPI
> > tristate "SDHCI support for ACPI enumerated SDHCI controllers"
> > depends on MMC_SDHCI && ACPI
>
> It should depend on PCI as well, shouldn't it?
>
I don't think so. The PCI dependency is at IOSF_MBI code so code
should select IOSF_MBI only when x86 and pci is defined as below.
This driver does not depend on PCI.
> As it stands with the patch applied, randconfig can still select it if
> PCI is unset AFAICS, can't it?
True, we also should be careful about separating ACPI from PCI.
Someone should be able to define a sdhci acpi object without PCI.
What do you think about this?
>
> > - select IOSF_MBI if X86
> > + select IOSF_MBI if (X86 && PCI)
> > help
> > This selects support for ACPI enumerated SDHCI controllers,
> > identified by ACPI Compatibility ID PNP0D40 or specific
> > --
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH v3 10/11] x86: select IOSF_MBI only when CONFIG_PCI is set
2018-12-25 9:13 ` Rafael J. Wysocki
@ 2018-12-30 19:04 ` Sinan Kaya
0 siblings, 0 replies; 31+ messages in thread
From: Sinan Kaya @ 2018-12-30 19:04 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Linux-Next Mailing List, ACPI Devel Maling List, Thomas Gleixner,
Ingo Molnar, Borislav Petkov, H. Peter Anvin,
the arch/x86 maintainers, Linux Kernel Mailing List
On Tue, Dec 25, 2018 at 12:14 PM Rafael J. Wysocki <rafael@kernel.org> wrote:
>
> On Mon, Dec 24, 2018 at 12:25 AM Sinan Kaya <okaya@kernel.org> wrote:
> >
> > Need CONFIG_PCI to be set in order to be able to use IOSF_MBI
> > functionality.
> >
> > Signed-off-by: Sinan Kaya <okaya@kernel.org>
>
> The subject and changelog here don't match the changes below. Please fix.
>
Done
> > ---
> > arch/x86/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> > index cc4f0c6ee1ed..322a58ababb0 100644
> > --- a/arch/x86/Kconfig
> > +++ b/arch/x86/Kconfig
> > @@ -617,7 +617,7 @@ config X86_INTEL_QUARK
> >
> > config X86_INTEL_LPSS
> > bool "Intel Low Power Subsystem Support"
> > - depends on X86 && ACPI
> > + depends on X86 && ACPI && PCI
> > select COMMON_CLK
> > select PINCTRL
> > select IOSF_MBI
> > --
> > 2.19.0
> >
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH v3 09/11] mmc: add PCI dependency into IOSF_MBI
2018-12-30 18:56 ` Sinan Kaya
@ 2018-12-31 9:40 ` Rafael J. Wysocki
2019-01-02 14:03 ` Adrian Hunter
0 siblings, 1 reply; 31+ messages in thread
From: Rafael J. Wysocki @ 2018-12-31 9:40 UTC (permalink / raw)
To: Sinan Kaya
Cc: Rafael J. Wysocki, Linux-Next Mailing List,
ACPI Devel Maling List, Ulf Hansson, Hunter, Adrian, Shawn Lin,
Masahiro Yamada, Geert Uytterhoeven, faiz_abbas, chunyan.zhang,
Jisheng.Zhang, ludovic.barre, Arnd Bergmann, alex.smith,
chris.brandt, linux-mmc, Linux Kernel Mailing List
On Sun, Dec 30, 2018 at 7:57 PM Sinan Kaya <Okaya@kernel.org> wrote:
>
> On Wed, Dec 26, 2018 at 12:41 PM Rafael J. Wysocki <rafael@kernel.org> wrote:
> >
> > On Mon, Dec 24, 2018 at 12:26 AM Sinan Kaya <okaya@kernel.org> wrote:
> > >
> > > Select IOSF_MBI only when PCI is set.
> > >
> > > Signed-off-by: Sinan Kaya <okaya@kernel.org>
> > > ---
> > > drivers/mmc/host/Kconfig | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> > > index e26b8145efb3..4c5f037b246d 100644
> > > --- a/drivers/mmc/host/Kconfig
> > > +++ b/drivers/mmc/host/Kconfig
> > > @@ -117,7 +117,7 @@ config MMC_RICOH_MMC
> > > config MMC_SDHCI_ACPI
> > > tristate "SDHCI support for ACPI enumerated SDHCI controllers"
> > > depends on MMC_SDHCI && ACPI
> >
> > It should depend on PCI as well, shouldn't it?
> >
>
> I don't think so. The PCI dependency is at IOSF_MBI code so code
> should select IOSF_MBI only when x86 and pci is defined as below.
>
> This driver does not depend on PCI.
Are you sure?
Do you know any systems in which to use it without PCI?
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH v3 09/11] mmc: add PCI dependency into IOSF_MBI
2018-12-31 9:40 ` Rafael J. Wysocki
@ 2019-01-02 14:03 ` Adrian Hunter
2019-01-02 14:15 ` Sinan Kaya
0 siblings, 1 reply; 31+ messages in thread
From: Adrian Hunter @ 2019-01-02 14:03 UTC (permalink / raw)
To: Rafael J. Wysocki, Sinan Kaya
Cc: Linux-Next Mailing List, ACPI Devel Maling List, Ulf Hansson,
Shawn Lin, Masahiro Yamada, Geert Uytterhoeven, faiz_abbas,
chunyan.zhang, Jisheng.Zhang, ludovic.barre, Arnd Bergmann,
alex.smith, chris.brandt, linux-mmc, Linux Kernel Mailing List
On 31/12/18 11:40 AM, Rafael J. Wysocki wrote:
> On Sun, Dec 30, 2018 at 7:57 PM Sinan Kaya <Okaya@kernel.org> wrote:
>>
>> On Wed, Dec 26, 2018 at 12:41 PM Rafael J. Wysocki <rafael@kernel.org> wrote:
>>>
>>> On Mon, Dec 24, 2018 at 12:26 AM Sinan Kaya <okaya@kernel.org> wrote:
>>>>
>>>> Select IOSF_MBI only when PCI is set.
>>>>
>>>> Signed-off-by: Sinan Kaya <okaya@kernel.org>
>>>> ---
>>>> drivers/mmc/host/Kconfig | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
>>>> index e26b8145efb3..4c5f037b246d 100644
>>>> --- a/drivers/mmc/host/Kconfig
>>>> +++ b/drivers/mmc/host/Kconfig
>>>> @@ -117,7 +117,7 @@ config MMC_RICOH_MMC
>>>> config MMC_SDHCI_ACPI
>>>> tristate "SDHCI support for ACPI enumerated SDHCI controllers"
>>>> depends on MMC_SDHCI && ACPI
>>>
>>> It should depend on PCI as well, shouldn't it?
>>>
>>
>> I don't think so. The PCI dependency is at IOSF_MBI code so code
>> should select IOSF_MBI only when x86 and pci is defined as below.
>>
>> This driver does not depend on PCI.
>
> Are you sure?
>
> Do you know any systems in which to use it without PCI?
>
Qualcomm use it and I don't know if those systems have PCI.
AMD use it but probably also have PCI. And yes Intel systems (just BYT and
CHT IIRC) that use this driver will always have PCI.
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH v3 09/11] mmc: add PCI dependency into IOSF_MBI
2019-01-02 14:03 ` Adrian Hunter
@ 2019-01-02 14:15 ` Sinan Kaya
0 siblings, 0 replies; 31+ messages in thread
From: Sinan Kaya @ 2019-01-02 14:15 UTC (permalink / raw)
To: Adrian Hunter
Cc: Rafael J. Wysocki, Linux-Next Mailing List,
ACPI Devel Maling List, Ulf Hansson, Shawn Lin, Masahiro Yamada,
Geert Uytterhoeven, faiz_abbas, chunyan.zhang, Jisheng.Zhang,
ludovic.barre, Arnd Bergmann, alex.smith, chris.brandt,
linux-mmc, Linux Kernel Mailing List
On Wed, Jan 2, 2019 at 2:04 PM Adrian Hunter <adrian.hunter@intel.com> wrote:
>
> On 31/12/18 11:40 AM, Rafael J. Wysocki wrote:
> > On Sun, Dec 30, 2018 at 7:57 PM Sinan Kaya <Okaya@kernel.org> wrote:
> >>
> >> On Wed, Dec 26, 2018 at 12:41 PM Rafael J. Wysocki <rafael@kernel.org> wrote:
> >>>
> >>> On Mon, Dec 24, 2018 at 12:26 AM Sinan Kaya <okaya@kernel.org> wrote:
> >>>>
> >>>> Select IOSF_MBI only when PCI is set.
> >>>>
> >>>> Signed-off-by: Sinan Kaya <okaya@kernel.org>
> >>>> ---
> >>>> drivers/mmc/host/Kconfig | 2 +-
> >>>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>>
> >>>> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> >>>> index e26b8145efb3..4c5f037b246d 100644
> >>>> --- a/drivers/mmc/host/Kconfig
> >>>> +++ b/drivers/mmc/host/Kconfig
> >>>> @@ -117,7 +117,7 @@ config MMC_RICOH_MMC
> >>>> config MMC_SDHCI_ACPI
> >>>> tristate "SDHCI support for ACPI enumerated SDHCI controllers"
> >>>> depends on MMC_SDHCI && ACPI
> >>>
> >>> It should depend on PCI as well, shouldn't it?
> >>>
> >>
> >> I don't think so. The PCI dependency is at IOSF_MBI code so code
> >> should select IOSF_MBI only when x86 and pci is defined as below.
> >>
> >> This driver does not depend on PCI.
> >
> > Are you sure?
> >
> > Do you know any systems in which to use it without PCI?
> >
>
> Qualcomm use it and I don't know if those systems have PCI.
> AMD use it but probably also have PCI. And yes Intel systems (just BYT and
> CHT IIRC) that use this driver will always have PCI.
QCOM doesn't use PCI for SDHC.
^ permalink raw reply [flat|nested] 31+ messages in thread
end of thread, other threads:[~2019-01-02 14:15 UTC | newest]
Thread overview: 31+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20181223232521.11320-1-okaya@kernel.org>
2018-12-23 23:25 ` [PATCH v3 01/11] ACPI / LPSS: Make PCI dependency explicit Sinan Kaya
2018-12-23 23:25 ` Sinan Kaya
2018-12-23 23:25 ` [PATCH v3 02/11] ata: make PCI dependency explicit for PATA_ACPI Sinan Kaya
2018-12-23 23:25 ` Sinan Kaya
2018-12-23 23:25 ` [PATCH v3 03/11] vga-switcheroo: make PCI dependency explicit Sinan Kaya
2018-12-23 23:25 ` Sinan Kaya
2018-12-23 23:25 ` [PATCH v3 04/11] platform/x86: intel_ips: " Sinan Kaya
2018-12-23 23:25 ` Sinan Kaya
2018-12-23 23:25 ` [PATCH v3 05/11] platform/x86: intel_pmc: Make " Sinan Kaya
2018-12-23 23:25 ` Sinan Kaya
2018-12-23 23:25 ` [PATCH v3 06/11] apple-gmux: " Sinan Kaya
2018-12-23 23:25 ` Sinan Kaya
2018-12-23 23:25 ` [PATCH v3 07/11] drivers: thermal: int3406_thermal: " Sinan Kaya
2018-12-23 23:25 ` Sinan Kaya
2018-12-23 23:25 ` [PATCH v3 08/11] ASoC: Intel: atom: " Sinan Kaya
2018-12-23 23:25 ` Sinan Kaya
2018-12-26 17:35 ` Pierre-Louis Bossart
2018-12-26 20:07 ` Sinan Kaya
2018-12-23 23:25 ` [PATCH v3 09/11] mmc: add PCI dependency into IOSF_MBI Sinan Kaya
2018-12-23 23:25 ` Sinan Kaya
2018-12-26 9:40 ` Rafael J. Wysocki
2018-12-30 18:56 ` Sinan Kaya
2018-12-31 9:40 ` Rafael J. Wysocki
2019-01-02 14:03 ` Adrian Hunter
2019-01-02 14:15 ` Sinan Kaya
2018-12-23 23:25 ` [PATCH v3 10/11] x86: select IOSF_MBI only when CONFIG_PCI is set Sinan Kaya
2018-12-23 23:25 ` Sinan Kaya
2018-12-25 9:13 ` Rafael J. Wysocki
2018-12-30 19:04 ` Sinan Kaya
2018-12-23 23:25 ` [PATCH v3 11/11] drivers: thermal: int340x_thermal: Make PCI dependency explicit Sinan Kaya
2018-12-23 23:25 ` Sinan Kaya
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.