From: Christoph Hellwig <hch@infradead.org> To: "Björn Töpel" <bjorn.topel@gmail.com> Cc: linux-riscv@lists.infradead.org, palmer@sifive.com, davidlee@sifive.com, daniel@iogearbox.net, netdev@vger.kernel.org Subject: Re: [RFC PATCH 2/3] riscv: add build infra for JIT compiler Date: Tue, 15 Jan 2019 07:43:27 -0800 [thread overview] Message-ID: <20190115154327.GH26443@infradead.org> (raw) In-Reply-To: <20190115083518.10149-3-bjorn.topel@gmail.com> > core-y += arch/riscv/kernel/ arch/riscv/mm/ > > +ifeq ($(CONFIG_ARCH_RV64I),y) > +core-y += arch/riscv/net/ > +endif I think this should be core-$(CONFIG_ARCH_RV64I) to get the same result. Or even better just core-y given that the Kconfig dependencies should ensure you can't ever enable CONFIG_BPF_JIT for 32-bit builds. > new file mode 100644 > index 000000000000..b0b6ac13edf5 > --- /dev/null > +++ b/arch/riscv/net/Makefile > @@ -0,0 +1,5 @@ > +# > +# RISCV networking code > +# I don't think this comment adds any value. In fact it is highly confusing given that we use bpf for a lot more than networking these days. > diff --git a/arch/riscv/net/bpf_jit_comp.c b/arch/riscv/net/bpf_jit_comp.c > new file mode 100644 > index 000000000000..7e359d3249ee > --- /dev/null > +++ b/arch/riscv/net/bpf_jit_comp.c > @@ -0,0 +1,4 @@ > +struct bpf_prog *bpf_int_jit_compile(struct bpf_prog *prog) > +{ > + return prog; > +} Please don't just add stubs files. This patch should probably be merged into the one adding the actual implementation.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org> To: "Björn Töpel" <bjorn.topel@gmail.com> Cc: netdev@vger.kernel.org, linux-riscv@lists.infradead.org, palmer@sifive.com, daniel@iogearbox.net, davidlee@sifive.com Subject: Re: [RFC PATCH 2/3] riscv: add build infra for JIT compiler Date: Tue, 15 Jan 2019 07:43:27 -0800 [thread overview] Message-ID: <20190115154327.GH26443@infradead.org> (raw) In-Reply-To: <20190115083518.10149-3-bjorn.topel@gmail.com> > core-y += arch/riscv/kernel/ arch/riscv/mm/ > > +ifeq ($(CONFIG_ARCH_RV64I),y) > +core-y += arch/riscv/net/ > +endif I think this should be core-$(CONFIG_ARCH_RV64I) to get the same result. Or even better just core-y given that the Kconfig dependencies should ensure you can't ever enable CONFIG_BPF_JIT for 32-bit builds. > new file mode 100644 > index 000000000000..b0b6ac13edf5 > --- /dev/null > +++ b/arch/riscv/net/Makefile > @@ -0,0 +1,5 @@ > +# > +# RISCV networking code > +# I don't think this comment adds any value. In fact it is highly confusing given that we use bpf for a lot more than networking these days. > diff --git a/arch/riscv/net/bpf_jit_comp.c b/arch/riscv/net/bpf_jit_comp.c > new file mode 100644 > index 000000000000..7e359d3249ee > --- /dev/null > +++ b/arch/riscv/net/bpf_jit_comp.c > @@ -0,0 +1,4 @@ > +struct bpf_prog *bpf_int_jit_compile(struct bpf_prog *prog) > +{ > + return prog; > +} Please don't just add stubs files. This patch should probably be merged into the one adding the actual implementation. _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2019-01-15 15:43 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-01-15 8:35 [RFC PATCH 0/3] RV64G eBPF JIT Björn Töpel 2019-01-15 8:35 ` Björn Töpel 2019-01-15 8:35 ` Björn Töpel 2019-01-15 8:35 ` [RFC PATCH 1/3] riscv: set HAVE_EFFICIENT_UNALIGNED_ACCESS Björn Töpel 2019-01-15 8:35 ` Björn Töpel 2019-01-15 15:39 ` Christoph Hellwig 2019-01-15 15:39 ` Christoph Hellwig 2019-01-15 16:06 ` Björn Töpel 2019-01-15 16:06 ` Björn Töpel 2019-01-25 20:21 ` Palmer Dabbelt 2019-01-25 20:21 ` Palmer Dabbelt 2019-01-26 1:33 ` Jim Wilson 2019-01-26 1:33 ` Jim Wilson 2019-01-29 2:43 ` Palmer Dabbelt 2019-01-29 2:43 ` Palmer Dabbelt 2019-01-15 8:35 ` [RFC PATCH 2/3] riscv: add build infra for JIT compiler Björn Töpel 2019-01-15 8:35 ` Björn Töpel 2019-01-15 15:43 ` Christoph Hellwig [this message] 2019-01-15 15:43 ` Christoph Hellwig 2019-01-15 16:09 ` Björn Töpel 2019-01-15 16:09 ` Björn Töpel 2019-01-15 8:35 ` [RFC PATCH 3/3] bpf, riscv: added eBPF JIT for RV64G Björn Töpel 2019-01-15 8:35 ` Björn Töpel 2019-01-15 8:35 ` Björn Töpel 2019-01-15 23:49 ` Daniel Borkmann 2019-01-15 23:49 ` Daniel Borkmann 2019-01-16 7:23 ` Björn Töpel 2019-01-16 7:23 ` Björn Töpel 2019-01-16 15:41 ` Daniel Borkmann 2019-01-16 15:41 ` Daniel Borkmann 2019-01-16 19:06 ` Björn Töpel 2019-01-16 19:06 ` Björn Töpel 2019-01-15 15:40 ` [RFC PATCH 0/3] RV64G eBPF JIT Christoph Hellwig 2019-01-15 15:40 ` Christoph Hellwig 2019-01-15 16:03 ` Björn Töpel 2019-01-15 16:03 ` Björn Töpel 2019-01-25 19:02 ` Palmer Dabbelt 2019-01-25 19:02 ` Palmer Dabbelt 2019-01-25 19:54 ` Paul Walmsley 2019-01-25 19:54 ` Paul Walmsley 2019-01-27 12:28 ` Björn Töpel 2019-01-27 12:28 ` Björn Töpel 2019-01-30 2:02 ` Palmer Dabbelt 2019-01-30 2:02 ` Palmer Dabbelt
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190115154327.GH26443@infradead.org \ --to=hch@infradead.org \ --cc=bjorn.topel@gmail.com \ --cc=daniel@iogearbox.net \ --cc=davidlee@sifive.com \ --cc=linux-riscv@lists.infradead.org \ --cc=netdev@vger.kernel.org \ --cc=palmer@sifive.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.