From: Palmer Dabbelt <palmer@sifive.com>
To: Jim Wilson <jimw@sifive.com>
Cc: bjorn.topel@gmail.com, Christoph Hellwig <hch@infradead.org>,
linux-riscv@lists.infradead.org, davidlee@sifive.com,
daniel@iogearbox.net, netdev@vger.kernel.org
Subject: Re: [RFC PATCH 1/3] riscv: set HAVE_EFFICIENT_UNALIGNED_ACCESS
Date: Mon, 28 Jan 2019 18:43:14 -0800 (PST) [thread overview]
Message-ID: <mhng-13e1a533-81f1-47cc-8d1e-a4e5332600f4@palmer-si-x1c4> (raw)
In-Reply-To: <CAFyWVaaAg9TuNVPbNmP0ongf6y2hmqFMiXJZHo8K84O4-BV0yw@mail.gmail.com>
On Fri, 25 Jan 2019 17:33:50 PST (-0800), Jim Wilson wrote:
> On Fri, Jan 25, 2019 at 12:21 PM Palmer Dabbelt <palmer@sifive.com> wrote:
>> Jim, would you be opposed to something like this?
>
> This looks OK to me.
OK, thanks. I'll send some patches around :)
>
>> + builtin_define_with_int_value ("__riscv_tune_misaligned_load_cost",
>> + riscv_tune_info->slow_unaligned_access ? 1024 : 1);
>> + builtin_define_with_int_value ("__riscv_tune_misaligned_store_cost",
>> + riscv_tune_info->slow_unaligned_access ? 1024 : 1);
>
> It would be nice to have a better way to compute these values, maybe
> an extra field in the tune structure, but we can always worry about
> that later when we need it.
I agree. I just went and designed the external interface first and hid the
ugliness here. The internal interfaces are easier to change :)
WARNING: multiple messages have this Message-ID (diff)
From: Palmer Dabbelt <palmer@sifive.com>
To: Jim Wilson <jimw@sifive.com>
Cc: davidlee@sifive.com, daniel@iogearbox.net, bjorn.topel@gmail.com,
Christoph Hellwig <hch@infradead.org>,
netdev@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [RFC PATCH 1/3] riscv: set HAVE_EFFICIENT_UNALIGNED_ACCESS
Date: Mon, 28 Jan 2019 18:43:14 -0800 (PST) [thread overview]
Message-ID: <mhng-13e1a533-81f1-47cc-8d1e-a4e5332600f4@palmer-si-x1c4> (raw)
In-Reply-To: <CAFyWVaaAg9TuNVPbNmP0ongf6y2hmqFMiXJZHo8K84O4-BV0yw@mail.gmail.com>
On Fri, 25 Jan 2019 17:33:50 PST (-0800), Jim Wilson wrote:
> On Fri, Jan 25, 2019 at 12:21 PM Palmer Dabbelt <palmer@sifive.com> wrote:
>> Jim, would you be opposed to something like this?
>
> This looks OK to me.
OK, thanks. I'll send some patches around :)
>
>> + builtin_define_with_int_value ("__riscv_tune_misaligned_load_cost",
>> + riscv_tune_info->slow_unaligned_access ? 1024 : 1);
>> + builtin_define_with_int_value ("__riscv_tune_misaligned_store_cost",
>> + riscv_tune_info->slow_unaligned_access ? 1024 : 1);
>
> It would be nice to have a better way to compute these values, maybe
> an extra field in the tune structure, but we can always worry about
> that later when we need it.
I agree. I just went and designed the external interface first and hid the
ugliness here. The internal interfaces are easier to change :)
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2019-01-29 2:43 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 8:35 [RFC PATCH 0/3] RV64G eBPF JIT Björn Töpel
2019-01-15 8:35 ` Björn Töpel
2019-01-15 8:35 ` Björn Töpel
2019-01-15 8:35 ` [RFC PATCH 1/3] riscv: set HAVE_EFFICIENT_UNALIGNED_ACCESS Björn Töpel
2019-01-15 8:35 ` Björn Töpel
2019-01-15 15:39 ` Christoph Hellwig
2019-01-15 15:39 ` Christoph Hellwig
2019-01-15 16:06 ` Björn Töpel
2019-01-15 16:06 ` Björn Töpel
2019-01-25 20:21 ` Palmer Dabbelt
2019-01-25 20:21 ` Palmer Dabbelt
2019-01-26 1:33 ` Jim Wilson
2019-01-26 1:33 ` Jim Wilson
2019-01-29 2:43 ` Palmer Dabbelt [this message]
2019-01-29 2:43 ` Palmer Dabbelt
2019-01-15 8:35 ` [RFC PATCH 2/3] riscv: add build infra for JIT compiler Björn Töpel
2019-01-15 8:35 ` Björn Töpel
2019-01-15 15:43 ` Christoph Hellwig
2019-01-15 15:43 ` Christoph Hellwig
2019-01-15 16:09 ` Björn Töpel
2019-01-15 16:09 ` Björn Töpel
2019-01-15 8:35 ` [RFC PATCH 3/3] bpf, riscv: added eBPF JIT for RV64G Björn Töpel
2019-01-15 8:35 ` Björn Töpel
2019-01-15 8:35 ` Björn Töpel
2019-01-15 23:49 ` Daniel Borkmann
2019-01-15 23:49 ` Daniel Borkmann
2019-01-16 7:23 ` Björn Töpel
2019-01-16 7:23 ` Björn Töpel
2019-01-16 15:41 ` Daniel Borkmann
2019-01-16 15:41 ` Daniel Borkmann
2019-01-16 19:06 ` Björn Töpel
2019-01-16 19:06 ` Björn Töpel
2019-01-15 15:40 ` [RFC PATCH 0/3] RV64G eBPF JIT Christoph Hellwig
2019-01-15 15:40 ` Christoph Hellwig
2019-01-15 16:03 ` Björn Töpel
2019-01-15 16:03 ` Björn Töpel
2019-01-25 19:02 ` Palmer Dabbelt
2019-01-25 19:02 ` Palmer Dabbelt
2019-01-25 19:54 ` Paul Walmsley
2019-01-25 19:54 ` Paul Walmsley
2019-01-27 12:28 ` Björn Töpel
2019-01-27 12:28 ` Björn Töpel
2019-01-30 2:02 ` Palmer Dabbelt
2019-01-30 2:02 ` Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mhng-13e1a533-81f1-47cc-8d1e-a4e5332600f4@palmer-si-x1c4 \
--to=palmer@sifive.com \
--cc=bjorn.topel@gmail.com \
--cc=daniel@iogearbox.net \
--cc=davidlee@sifive.com \
--cc=hch@infradead.org \
--cc=jimw@sifive.com \
--cc=linux-riscv@lists.infradead.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.