From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: Arti Zirk <arti.zirk@gmail.com>
Cc: git@vger.kernel.org, e@80x24.org, peff@peff.net,
jnareb@gmail.com, flavio@polettix.it, wil@nohakostudios.net
Subject: Re: [PATCH v1] git-instaweb: Add Python builtin http.server support
Date: Fri, 25 Jan 2019 02:04:52 +0000 [thread overview]
Message-ID: <20190125020451.GU423984@genre.crustytoothpaste.net> (raw)
In-Reply-To: <20190124161331.25945-1-arti.zirk@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1162 bytes --]
On Thu, Jan 24, 2019 at 06:13:31PM +0200, Arti Zirk wrote:
> With this patch it is possible to launch git-instaweb by using
> Python 3 http.server CGI handler via `-d python` option.
>
> git-instaweb generates a small wrapper around the http.server
> (in GIT_DIR/gitweb/) that address a limitation of the CGI handler
> where CGI scripts have to be in a cgi-bin subdirectory and
> directory index can't be easily changed. To keep the implementation
> small, gitweb is running on url `/cgi-bin/gitweb.cgi` and an automatic
> redirection is done when opening `/`.
>
> Python 3 is by default installed on most modern Linux distributions
> which enables running `git instaweb -d python` without needing
> anything else.
I'm glad we're using Python 3 here, but I wonder if the name "python"
will lead people to think it will work with Python 2 as well. There are
people using up-to-date Git on systems like CentOS 6 and 7, where Python
3 is not generally available.
Could we call this "python3" instead, or provide some other way to
communicate this to the user?
--
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 868 bytes --]
next prev parent reply other threads:[~2019-01-25 2:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-24 16:13 [PATCH v1] git-instaweb: Add Python builtin http.server support Arti Zirk
2019-01-24 20:52 ` Junio C Hamano
2019-01-25 2:04 ` brian m. carlson [this message]
2019-01-25 14:34 ` Junio C Hamano
2019-01-25 15:22 ` Arti Zirk
2019-01-25 23:58 ` brian m. carlson
2019-01-28 0:02 ` Junio C Hamano
2019-01-28 13:24 ` [PATCH v2] " Arti Zirk
2019-01-28 16:52 ` brian m. carlson
2019-01-28 17:48 ` Arti Zirk
2019-01-28 18:27 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190125020451.GU423984@genre.crustytoothpaste.net \
--to=sandals@crustytoothpaste.net \
--cc=arti.zirk@gmail.com \
--cc=e@80x24.org \
--cc=flavio@polettix.it \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=peff@peff.net \
--cc=wil@nohakostudios.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.