All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: Arti Zirk <arti.zirk@gmail.com>,
	git@vger.kernel.org, e@80x24.org, peff@peff.net,
	jnareb@gmail.com, flavio@polettix.it, wil@nohakostudios.net
Subject: Re: [PATCH v1] git-instaweb: Add Python builtin http.server support
Date: Sun, 27 Jan 2019 16:02:52 -0800	[thread overview]
Message-ID: <xmqqh8dtejir.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20190125235811.GW423984@genre.crustytoothpaste.net> (brian m. carlson's message of "Fri, 25 Jan 2019 23:58:11 +0000")

"brian m. carlson" <sandals@crustytoothpaste.net> writes:

> On Fri, Jan 25, 2019 at 05:22:45PM +0200, Arti Zirk wrote:
>> This is the built in http server that Python comes with (like Ruby
>> users have builtin webrick server). While it is possible to install
>> something else, I don't think many casual git-instaweb users would do
>> it. 
>> 
>> I haven't looked in depth into it but I'm pretty sure that by simply
>> changing the imports I could make this code also work in python2.
>> 
>> Upstream python2 support ends in ~11 months and would Red Hat/CentOS 7
>> users using new git releases really care about "git instaweb -d python"
>> not working on installations without Python 3?
>
> I'm sensitive to the fact that upstream is dropping support for Python
> 2, and I have no objections to limiting this to Python 3. However,
> whether we like it or not, Red Hat/CentOS 7 is going to be around for
> four years after that.
>
>> In the end I would like to keep the name just "python" to signal that
>> it only needs standard Python installation and nothing else.
>
> Could you update the documentation to put "Python 3" in parentheses or
> otherwise make it clear in the documentation? My goal is to avoid
> confusing users who are on systems that still have Python 2.

Calling the option python3 (not python) would give readers the same
message loud and clear in a simpler way, I would think.  Is there
any reasonable reason why we'd want to avoid saying python3?  It's
not like we are afraid of sending an message that we won't stay
working with python4 that is in the near horizon ;-), and as Arti
says, those who already live in Python3 world would know, when they
see either "python" or "python3", that is what they have anyway no?



  reply	other threads:[~2019-01-28  0:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-24 16:13 [PATCH v1] git-instaweb: Add Python builtin http.server support Arti Zirk
2019-01-24 20:52 ` Junio C Hamano
2019-01-25  2:04 ` brian m. carlson
2019-01-25 14:34   ` Junio C Hamano
2019-01-25 15:22     ` Arti Zirk
2019-01-25 23:58       ` brian m. carlson
2019-01-28  0:02         ` Junio C Hamano [this message]
2019-01-28 13:24 ` [PATCH v2] " Arti Zirk
2019-01-28 16:52   ` brian m. carlson
2019-01-28 17:48     ` Arti Zirk
2019-01-28 18:27   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqh8dtejir.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=arti.zirk@gmail.com \
    --cc=e@80x24.org \
    --cc=flavio@polettix.it \
    --cc=git@vger.kernel.org \
    --cc=jnareb@gmail.com \
    --cc=peff@peff.net \
    --cc=sandals@crustytoothpaste.net \
    --cc=wil@nohakostudios.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.