All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Arti Zirk <arti.zirk@gmail.com>
Cc: git@vger.kernel.org, e@80x24.org, peff@peff.net,
	jnareb@gmail.com, flavio@polettix.it, wil@nohakostudios.net
Subject: Re: [PATCH v1] git-instaweb: Add Python builtin http.server support
Date: Thu, 24 Jan 2019 12:52:26 -0800	[thread overview]
Message-ID: <xmqqpnslhj79.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20190124161331.25945-1-arti.zirk@gmail.com> (Arti Zirk's message of "Thu, 24 Jan 2019 18:13:31 +0200")

Arti Zirk <arti.zirk@gmail.com> writes:

> With this patch it is possible to launch git-instaweb by using
> Python 3 http.server CGI handler via `-d python` option.
>
> git-instaweb generates a small wrapper around the http.server
> (in GIT_DIR/gitweb/) ...

I know this follows an existing pattern (psgi and webrick also
writes nontrivial amount of code inside GIT_DIR/gitweb), but can we
somehow clean it up so that we can do instaweb out of a repository
without writing so much into it first, before adding yet another one
to make the situation even worse, I wonder?

For now I'll queue this so that we won't lose sight of the topic,
but I am not exactly enthused.







  reply	other threads:[~2019-01-24 20:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-24 16:13 [PATCH v1] git-instaweb: Add Python builtin http.server support Arti Zirk
2019-01-24 20:52 ` Junio C Hamano [this message]
2019-01-25  2:04 ` brian m. carlson
2019-01-25 14:34   ` Junio C Hamano
2019-01-25 15:22     ` Arti Zirk
2019-01-25 23:58       ` brian m. carlson
2019-01-28  0:02         ` Junio C Hamano
2019-01-28 13:24 ` [PATCH v2] " Arti Zirk
2019-01-28 16:52   ` brian m. carlson
2019-01-28 17:48     ` Arti Zirk
2019-01-28 18:27   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqpnslhj79.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=arti.zirk@gmail.com \
    --cc=e@80x24.org \
    --cc=flavio@polettix.it \
    --cc=git@vger.kernel.org \
    --cc=jnareb@gmail.com \
    --cc=peff@peff.net \
    --cc=wil@nohakostudios.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.