All of lore.kernel.org
 help / color / mirror / Atom feed
From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: Arti Zirk <arti.zirk@gmail.com>
Cc: git@vger.kernel.org, e@80x24.org, peff@peff.net,
	jnareb@gmail.com, flavio@polettix.it, gitster@pobox.com
Subject: Re: [PATCH v2] git-instaweb: Add Python builtin http.server support
Date: Mon, 28 Jan 2019 16:52:36 +0000	[thread overview]
Message-ID: <20190128165236.GC423984@genre.crustytoothpaste.net> (raw)
In-Reply-To: <20190128132458.31401-1-arti.zirk@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 605 bytes --]

On Mon, Jan 28, 2019 at 03:24:59PM +0200, Arti Zirk wrote:
> +	# generate a standalone 'python http.server' script in $fqgitdir/gitweb
> +	# This asumes that python is in user's $PATH
> +	# This script is Python 2 and 3 compatible
> +	cat > "$fqgitdir/gitweb/gitweb.py" <<EOF
> +#!/usr/bin/env python

I will point out, that despite what the PEPs say, on Debian and
derivatives, "python" will always invoke Python 2, and never Python 3.

This is probably fine for now, but we'll need to reconsider it before
2020.
-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 868 bytes --]

  reply	other threads:[~2019-01-28 16:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-24 16:13 [PATCH v1] git-instaweb: Add Python builtin http.server support Arti Zirk
2019-01-24 20:52 ` Junio C Hamano
2019-01-25  2:04 ` brian m. carlson
2019-01-25 14:34   ` Junio C Hamano
2019-01-25 15:22     ` Arti Zirk
2019-01-25 23:58       ` brian m. carlson
2019-01-28  0:02         ` Junio C Hamano
2019-01-28 13:24 ` [PATCH v2] " Arti Zirk
2019-01-28 16:52   ` brian m. carlson [this message]
2019-01-28 17:48     ` Arti Zirk
2019-01-28 18:27   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190128165236.GC423984@genre.crustytoothpaste.net \
    --to=sandals@crustytoothpaste.net \
    --cc=arti.zirk@gmail.com \
    --cc=e@80x24.org \
    --cc=flavio@polettix.it \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jnareb@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.