All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Cc: igt-dev@lists.freedesktop.org, Mika Kuoppala <mika.kuoppala@intel.com>
Subject: [PATCH i-g-t] i915/gem_eio: Check we only ban the context
Date: Tue, 19 Feb 2019 17:11:24 +0000	[thread overview]
Message-ID: <20190219171124.23724-1-chris@chris-wilson.co.uk> (raw)
In-Reply-To: <20190217143556.9482-2-chris@chris-wilson.co.uk>

In trigger the ban, we only want to observe the local context be banned
and not the fpriv as a whole.

v2: And send an execbuf down the new context.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@intel.com>
Cc: Antonio Argenziano <antonio.argenziano@intel.com>
---
 tests/i915/gem_eio.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/tests/i915/gem_eio.c b/tests/i915/gem_eio.c
index ac85a2eff..b0be128ef 100644
--- a/tests/i915/gem_eio.c
+++ b/tests/i915/gem_eio.c
@@ -313,8 +313,20 @@ static void __test_banned(int fd)
 		igt_spin_t *hang;
 
 		if (__gem_execbuf(fd, &execbuf) == -EIO) {
+			uint32_t ctx = 0;
+
 			igt_info("Banned after causing %lu hangs\n", count);
 			igt_assert(count > 1);
+
+			/* Only this context, not the file, should be banned */
+			igt_assert_neq(__gem_context_create(fd, &ctx), -EIO);
+			igt_assert_neq(ctx, 0);
+
+			/* And check it actually works! */
+			execbuf.rsvd1 = ctx;
+			gem_execbuf(fd, &execbuf);
+
+			gem_context_destroy(fd, ctx);
 			return;
 		}
 
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Cc: igt-dev@lists.freedesktop.org, Mika Kuoppala <mika.kuoppala@intel.com>
Subject: [Intel-gfx] [PATCH i-g-t] i915/gem_eio: Check we only ban the context
Date: Tue, 19 Feb 2019 17:11:24 +0000	[thread overview]
Message-ID: <20190219171124.23724-1-chris@chris-wilson.co.uk> (raw)
In-Reply-To: <20190217143556.9482-2-chris@chris-wilson.co.uk>

In trigger the ban, we only want to observe the local context be banned
and not the fpriv as a whole.

v2: And send an execbuf down the new context.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@intel.com>
Cc: Antonio Argenziano <antonio.argenziano@intel.com>
---
 tests/i915/gem_eio.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/tests/i915/gem_eio.c b/tests/i915/gem_eio.c
index ac85a2eff..b0be128ef 100644
--- a/tests/i915/gem_eio.c
+++ b/tests/i915/gem_eio.c
@@ -313,8 +313,20 @@ static void __test_banned(int fd)
 		igt_spin_t *hang;
 
 		if (__gem_execbuf(fd, &execbuf) == -EIO) {
+			uint32_t ctx = 0;
+
 			igt_info("Banned after causing %lu hangs\n", count);
 			igt_assert(count > 1);
+
+			/* Only this context, not the file, should be banned */
+			igt_assert_neq(__gem_context_create(fd, &ctx), -EIO);
+			igt_assert_neq(ctx, 0);
+
+			/* And check it actually works! */
+			execbuf.rsvd1 = ctx;
+			gem_execbuf(fd, &execbuf);
+
+			gem_context_destroy(fd, ctx);
 			return;
 		}
 
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-02-19 17:11 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-17 14:35 [PATCH i-g-t 1/8] i915/gem_eio: Check that context create fails when wedged Chris Wilson
2019-02-17 14:35 ` [Intel-gfx] " Chris Wilson
2019-02-17 14:35 ` [PATCH i-g-t 2/8] i915/gem_eio: Check we only ban the context Chris Wilson
2019-02-17 14:35   ` [igt-dev] " Chris Wilson
2019-02-19 16:53   ` Antonio Argenziano
2019-02-19 16:53     ` Antonio Argenziano
2019-02-19 17:05     ` Chris Wilson
2019-02-19 17:05       ` Chris Wilson
2019-02-19 17:11   ` Chris Wilson [this message]
2019-02-19 17:11     ` [Intel-gfx] [PATCH i-g-t] " Chris Wilson
2019-02-19 17:27     ` Antonio Argenziano
2019-02-19 17:27       ` [igt-dev] " Antonio Argenziano
2019-02-17 14:35 ` [PATCH i-g-t 3/8] lib: Restore the i915.reset modparam before cleaning up Chris Wilson
2019-02-17 14:35   ` [Intel-gfx] " Chris Wilson
2019-02-19 18:22   ` [igt-dev] " Antonio Argenziano
2019-02-19 18:22     ` Antonio Argenziano
2019-02-19 21:03     ` Chris Wilson
2019-02-19 21:03       ` Chris Wilson
2019-02-17 14:35 ` [PATCH i-g-t 4/8] i915/gem_create: Verify that all new objects are clear Chris Wilson
2019-02-17 14:35   ` [igt-dev] " Chris Wilson
2019-02-17 14:35 ` [PATCH i-g-t 5/8] i915/gem_exec_big: Add a single shot test Chris Wilson
2019-02-17 14:35   ` [igt-dev] " Chris Wilson
2019-02-17 14:35 ` [PATCH i-g-t 6/8] i915/gem_exec_parse: Switch to a fixed timeout for basic-allocations Chris Wilson
2019-02-17 14:35   ` [Intel-gfx] " Chris Wilson
2019-03-06 11:50   ` [igt-dev] " Tvrtko Ursulin
2019-03-06 11:50     ` Tvrtko Ursulin
2019-02-17 14:35 ` [PATCH i-g-t 7/8] kms_fence_pin_leak: Ask for the GPU before use Chris Wilson
2019-02-17 14:35   ` [igt-dev] " Chris Wilson
2019-02-17 14:35 ` [PATCH i-g-t 8/8] kms_fence_pin_leak: Move beneath i915/ Chris Wilson
2019-02-17 14:35   ` [Intel-gfx] " Chris Wilson
2019-02-18 13:37   ` Arkadiusz Hiler
2019-02-18 13:37     ` [igt-dev] " Arkadiusz Hiler
2019-02-18 13:42     ` Chris Wilson
2019-02-18 13:42       ` [igt-dev] " Chris Wilson
2019-02-18 13:43       ` Chris Wilson
2019-02-18 13:43         ` [igt-dev] " Chris Wilson
2019-02-18 14:01         ` Arkadiusz Hiler
2019-02-18 14:01           ` [igt-dev] " Arkadiusz Hiler
2019-02-18 14:08           ` Chris Wilson
2019-02-18 14:08             ` [igt-dev] " Chris Wilson
2019-02-18 14:19             ` Arkadiusz Hiler
2019-02-18 14:19               ` [igt-dev] " Arkadiusz Hiler
2019-02-17 15:22 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/8] i915/gem_eio: Check that context create fails when wedged Patchwork
2019-02-17 18:24 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2019-02-19 16:53 ` [PATCH i-g-t 1/8] " Antonio Argenziano
2019-02-19 16:53   ` [igt-dev] [Intel-gfx] " Antonio Argenziano
2019-02-19 17:36 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/8] i915/gem_eio: Check that context create fails when wedged (rev2) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190219171124.23724-1-chris@chris-wilson.co.uk \
    --to=chris@chris-wilson.co.uk \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=mika.kuoppala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.