From: Antonio Argenziano <antonio.argenziano@intel.com> To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org Cc: igt-dev@lists.freedesktop.org, Mika Kuoppala <mika.kuoppala@intel.com> Subject: Re: [igt-dev] [PATCH i-g-t 3/8] lib: Restore the i915.reset modparam before cleaning up Date: Tue, 19 Feb 2019 10:22:26 -0800 [thread overview] Message-ID: <55deb269-4ff0-706a-64bb-ad51fca12629@intel.com> (raw) In-Reply-To: <20190217143556.9482-3-chris@chris-wilson.co.uk> On 17/02/19 06:35, Chris Wilson wrote: > We force a reset on test exit so that we can rapidly cleanup after a > naughty test, it is not unknown for us to leave a queue of hanging > batches around. However, if we have also fiddled with the i915.reset > parameter in the meantime, this can leave the kernel unable to fulfil typo -------------------------------------------------------------^ > our request (and those naughty batches continue to disrupt testing). > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > Cc: Mika Kuoppala <mika.kuoppala@intel.com> > Cc: Petri Latvala <petri.latvala@intel.com> Re-enabling reset sounds good. Acked-by: Antonio Argenziano <antonio.argenziano@intel.com> > --- > lib/drmtest.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/lib/drmtest.c b/lib/drmtest.c > index 1964795a6..6c0a0e381 100644 > --- a/lib/drmtest.c > +++ b/lib/drmtest.c > @@ -54,6 +54,7 @@ > #include "igt_device.h" > #include "igt_gt.h" > #include "igt_kmod.h" > +#include "igt_sysfs.h" > #include "version.h" > #include "config.h" > #include "intel_reg.h" > @@ -345,6 +346,7 @@ static void __cancel_work_at_exit(int fd) > { > igt_terminate_spin_batches(); /* for older kernels */ > > + igt_sysfs_set_parameter(fd, "reset", "%x", -1u /* any method */); > igt_drop_caches_set(fd, > /* cancel everything */ > DROP_RESET_ACTIVE | DROP_RESET_SEQNO | > _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Antonio Argenziano <antonio.argenziano@intel.com> To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org Cc: igt-dev@lists.freedesktop.org, Petri Latvala <petri.latvala@intel.com>, Mika Kuoppala <mika.kuoppala@intel.com> Subject: Re: [igt-dev] [PATCH i-g-t 3/8] lib: Restore the i915.reset modparam before cleaning up Date: Tue, 19 Feb 2019 10:22:26 -0800 [thread overview] Message-ID: <55deb269-4ff0-706a-64bb-ad51fca12629@intel.com> (raw) In-Reply-To: <20190217143556.9482-3-chris@chris-wilson.co.uk> On 17/02/19 06:35, Chris Wilson wrote: > We force a reset on test exit so that we can rapidly cleanup after a > naughty test, it is not unknown for us to leave a queue of hanging > batches around. However, if we have also fiddled with the i915.reset > parameter in the meantime, this can leave the kernel unable to fulfil typo -------------------------------------------------------------^ > our request (and those naughty batches continue to disrupt testing). > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > Cc: Mika Kuoppala <mika.kuoppala@intel.com> > Cc: Petri Latvala <petri.latvala@intel.com> Re-enabling reset sounds good. Acked-by: Antonio Argenziano <antonio.argenziano@intel.com> > --- > lib/drmtest.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/lib/drmtest.c b/lib/drmtest.c > index 1964795a6..6c0a0e381 100644 > --- a/lib/drmtest.c > +++ b/lib/drmtest.c > @@ -54,6 +54,7 @@ > #include "igt_device.h" > #include "igt_gt.h" > #include "igt_kmod.h" > +#include "igt_sysfs.h" > #include "version.h" > #include "config.h" > #include "intel_reg.h" > @@ -345,6 +346,7 @@ static void __cancel_work_at_exit(int fd) > { > igt_terminate_spin_batches(); /* for older kernels */ > > + igt_sysfs_set_parameter(fd, "reset", "%x", -1u /* any method */); > igt_drop_caches_set(fd, > /* cancel everything */ > DROP_RESET_ACTIVE | DROP_RESET_SEQNO | > _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-02-19 18:22 UTC|newest] Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-02-17 14:35 [PATCH i-g-t 1/8] i915/gem_eio: Check that context create fails when wedged Chris Wilson 2019-02-17 14:35 ` [Intel-gfx] " Chris Wilson 2019-02-17 14:35 ` [PATCH i-g-t 2/8] i915/gem_eio: Check we only ban the context Chris Wilson 2019-02-17 14:35 ` [igt-dev] " Chris Wilson 2019-02-19 16:53 ` Antonio Argenziano 2019-02-19 16:53 ` Antonio Argenziano 2019-02-19 17:05 ` Chris Wilson 2019-02-19 17:05 ` Chris Wilson 2019-02-19 17:11 ` [PATCH i-g-t] " Chris Wilson 2019-02-19 17:11 ` [Intel-gfx] " Chris Wilson 2019-02-19 17:27 ` Antonio Argenziano 2019-02-19 17:27 ` [igt-dev] " Antonio Argenziano 2019-02-17 14:35 ` [PATCH i-g-t 3/8] lib: Restore the i915.reset modparam before cleaning up Chris Wilson 2019-02-17 14:35 ` [Intel-gfx] " Chris Wilson 2019-02-19 18:22 ` Antonio Argenziano [this message] 2019-02-19 18:22 ` [igt-dev] " Antonio Argenziano 2019-02-19 21:03 ` Chris Wilson 2019-02-19 21:03 ` Chris Wilson 2019-02-17 14:35 ` [PATCH i-g-t 4/8] i915/gem_create: Verify that all new objects are clear Chris Wilson 2019-02-17 14:35 ` [igt-dev] " Chris Wilson 2019-02-17 14:35 ` [PATCH i-g-t 5/8] i915/gem_exec_big: Add a single shot test Chris Wilson 2019-02-17 14:35 ` [igt-dev] " Chris Wilson 2019-02-17 14:35 ` [PATCH i-g-t 6/8] i915/gem_exec_parse: Switch to a fixed timeout for basic-allocations Chris Wilson 2019-02-17 14:35 ` [Intel-gfx] " Chris Wilson 2019-03-06 11:50 ` [igt-dev] " Tvrtko Ursulin 2019-03-06 11:50 ` Tvrtko Ursulin 2019-02-17 14:35 ` [PATCH i-g-t 7/8] kms_fence_pin_leak: Ask for the GPU before use Chris Wilson 2019-02-17 14:35 ` [igt-dev] " Chris Wilson 2019-02-17 14:35 ` [PATCH i-g-t 8/8] kms_fence_pin_leak: Move beneath i915/ Chris Wilson 2019-02-17 14:35 ` [Intel-gfx] " Chris Wilson 2019-02-18 13:37 ` Arkadiusz Hiler 2019-02-18 13:37 ` [igt-dev] " Arkadiusz Hiler 2019-02-18 13:42 ` Chris Wilson 2019-02-18 13:42 ` [igt-dev] " Chris Wilson 2019-02-18 13:43 ` Chris Wilson 2019-02-18 13:43 ` [igt-dev] " Chris Wilson 2019-02-18 14:01 ` Arkadiusz Hiler 2019-02-18 14:01 ` [igt-dev] " Arkadiusz Hiler 2019-02-18 14:08 ` Chris Wilson 2019-02-18 14:08 ` [igt-dev] " Chris Wilson 2019-02-18 14:19 ` Arkadiusz Hiler 2019-02-18 14:19 ` [igt-dev] " Arkadiusz Hiler 2019-02-17 15:22 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/8] i915/gem_eio: Check that context create fails when wedged Patchwork 2019-02-17 18:24 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork 2019-02-19 16:53 ` [PATCH i-g-t 1/8] " Antonio Argenziano 2019-02-19 16:53 ` [igt-dev] [Intel-gfx] " Antonio Argenziano 2019-02-19 17:36 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/8] i915/gem_eio: Check that context create fails when wedged (rev2) Patchwork
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=55deb269-4ff0-706a-64bb-ad51fca12629@intel.com \ --to=antonio.argenziano@intel.com \ --cc=chris@chris-wilson.co.uk \ --cc=igt-dev@lists.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ --cc=mika.kuoppala@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.