Re: [igt-dev] [PATCH i-g-t 2/8] i915/gem_eio: Check we only ban the context

From: Antonio Argenziano <antonio.argenziano@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: igt-dev@lists.freedesktop.org, Mika Kuoppala <mika.kuoppala@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t 2/8] i915/gem_eio: Check we only ban the context
Date: Tue, 19 Feb 2019 08:53:57 -0800	[thread overview]
Message-ID: <7b4076e1-0636-5958-5d8c-fc57047d9019@intel.com> (raw)
In-Reply-To: <20190217143556.9482-2-chris@chris-wilson.co.uk>

On 17/02/19 06:35, Chris Wilson wrote:
> In trigger the ban, we only want to observe the local context be banned
> and not the fpriv as a whole.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@intel.com>
> ---
>   tests/i915/gem_eio.c | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/tests/i915/gem_eio.c b/tests/i915/gem_eio.c
> index 3c54820c9..3afdbd69e 100644
> --- a/tests/i915/gem_eio.c
> +++ b/tests/i915/gem_eio.c
> @@ -324,8 +324,15 @@ static void __test_banned(int fd)
>   		igt_spin_t *hang;
>   
>   		if (__gem_execbuf(fd, &execbuf) == -EIO) {
> +			uint32_t ctx = 0;
> +
>   			igt_info("Banned after causing %lu hangs\n", count);
>   			igt_assert(count > 1);
> +
> +			/* Only this context, not the file, should be banned */
> +			igt_assert_neq(__gem_context_create(fd, &ctx), -EIO);

Should we check submission works on the new context?

Antonio

> +			igt_assert_neq(ctx, 0);
> +			gem_context_destroy(fd, ctx);
>   			return;
>   		}
>   
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx