From: "Michael S. Tsirkin" <mst@redhat.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Alexander Duyck <alexander.h.duyck@intel.com>,
virtio-dev <virtio-dev@lists.oasis-open.org>,
Jiri Pirko <jiri@resnulli.us>, Jakub Kicinski <kubakici@wp.pl>,
"Samudrala, Sridhar" <sridhar.samudrala@intel.com>,
virtualization@lists.linux-foundation.org,
Siwei Liu <loseweigh@gmail.com>,
liran.alon@oracle.com, Netdev <netdev@vger.kernel.org>,
si-wei liu <si-wei.liu@oracle.com>,
David Miller <davem@davemloft.net>
Subject: Re: [virtio-dev] Re: net_failover slave udev renaming (was Re: [RFC PATCH net-next v6 4/4] netvsc: refactor notifier/event handling code to use the bypass framework)
Date: Wed, 27 Feb 2019 19:38:34 -0500 [thread overview]
Message-ID: <20190227193330-mutt-send-email-mst__7921.8053071358$1551315049$gmane$org@kernel.org> (raw)
In-Reply-To: <20190227160342.788dc2b4@shemminger-XPS-13-9360>
On Wed, Feb 27, 2019 at 04:03:42PM -0800, Stephen Hemminger wrote:
> > With this approach kernel will deny attempts by userspace to rename
> > slaves. Slaves will always be named XXXnsby and XXnpry. Master renames
> > will rename both slaves.
> >
> > It seems pretty solid to me, the only issue is that in theory userspace
> > can use a name like XXXnsby for something else. But this seems unlikely.
>
> Similar schemes (with kernel providing naming) were also previously rejected
> upstream.
Links?
I'm inclined to try and see what happens.
> It has been a consistent theme that the kernel should not be in
> the renaming business.
In this case it's not in renaming business per se. The only reason
we even have the original name is due to the ways internal APIs
work. You can look at it as simply having slaves names being
part of master.
> It will certainly break userspace.
That's a strong claim. What is it based on? It so happens that
userspace renaming slaves is already broken on virtio. So we can fix it
any way we like :)
And yes it won't help netvsc because netvsc wants compatibility with old
scripts but then netvsc uses a 2 device model anyway.
--
MST
next prev parent reply other threads:[~2019-02-28 0:38 UTC|newest]
Thread overview: 147+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 18:59 [RFC PATCH net-next v6 0/4] Enable virtio_net to act as a backup for a passthru device Sridhar Samudrala
2018-04-10 18:59 ` [virtio-dev] " Sridhar Samudrala
2018-04-10 18:59 ` [RFC PATCH net-next v6 1/4] virtio_net: Introduce VIRTIO_NET_F_BACKUP feature bit Sridhar Samudrala
2018-04-10 18:59 ` [virtio-dev] " Sridhar Samudrala
2018-04-10 18:59 ` [RFC PATCH net-next v6 2/4] net: Introduce generic bypass module Sridhar Samudrala
2018-04-10 18:59 ` [virtio-dev] " Sridhar Samudrala
2018-04-11 15:51 ` Jiri Pirko
2018-04-11 19:13 ` Samudrala, Sridhar
2018-04-11 19:13 ` Samudrala, Sridhar
2018-04-11 19:13 ` [virtio-dev] " Samudrala, Sridhar
2018-04-18 9:25 ` Jiri Pirko
2018-04-18 9:25 ` Jiri Pirko
2018-04-18 18:43 ` Samudrala, Sridhar
2018-04-18 18:43 ` Samudrala, Sridhar
2018-04-18 18:43 ` [virtio-dev] " Samudrala, Sridhar
2018-04-18 19:13 ` Jiri Pirko
2018-04-18 19:13 ` Jiri Pirko
2018-04-18 19:46 ` Michael S. Tsirkin
2018-04-18 19:46 ` [virtio-dev] " Michael S. Tsirkin
2018-04-18 20:32 ` Jiri Pirko
2018-04-18 22:46 ` Samudrala, Sridhar
2018-04-18 22:46 ` [virtio-dev] " Samudrala, Sridhar
2018-04-19 6:35 ` Jiri Pirko
2018-04-19 6:35 ` Jiri Pirko
2018-04-18 22:46 ` Samudrala, Sridhar
2018-04-19 4:08 ` Michael S. Tsirkin
2018-04-19 4:08 ` [virtio-dev] " Michael S. Tsirkin
2018-04-19 7:22 ` Jiri Pirko
2018-04-19 7:22 ` Jiri Pirko
2018-04-19 4:08 ` Michael S. Tsirkin
2018-04-18 20:32 ` Jiri Pirko
2018-04-11 15:51 ` Jiri Pirko
2018-04-10 18:59 ` [RFC PATCH net-next v6 3/4] virtio_net: Extend virtio to use VF datapath when available Sridhar Samudrala
2018-04-10 18:59 ` [virtio-dev] " Sridhar Samudrala
2018-04-10 18:59 ` [RFC PATCH net-next v6 4/4] netvsc: refactor notifier/event handling code to use the bypass framework Sridhar Samudrala
2018-04-10 18:59 ` [virtio-dev] " Sridhar Samudrala
2018-04-10 21:26 ` Stephen Hemminger
2018-04-10 22:56 ` Samudrala, Sridhar
2018-04-10 22:56 ` [virtio-dev] " Samudrala, Sridhar
2018-04-10 23:28 ` Michael S. Tsirkin
2018-04-10 23:28 ` Michael S. Tsirkin
2018-04-10 23:28 ` [virtio-dev] " Michael S. Tsirkin
2018-04-10 23:44 ` Siwei Liu
2018-04-10 23:44 ` [virtio-dev] " Siwei Liu
2018-04-10 23:59 ` Stephen Hemminger
2018-04-10 23:44 ` Siwei Liu
2018-04-11 7:50 ` Jiri Pirko
2018-04-11 7:50 ` Jiri Pirko
2018-04-11 1:21 ` Michael S. Tsirkin
2018-04-11 1:21 ` Michael S. Tsirkin
2018-04-11 7:53 ` Jiri Pirko
2018-04-11 7:53 ` Jiri Pirko
2019-02-22 1:14 ` net_failover slave udev renaming (was Re: [RFC PATCH net-next v6 4/4] netvsc: refactor notifier/event handling code to use the bypass framework) Siwei Liu
2019-02-22 1:14 ` [virtio-dev] " Siwei Liu
2019-02-22 1:39 ` Michael S. Tsirkin
2019-02-22 1:39 ` [virtio-dev] " Michael S. Tsirkin
2019-02-22 3:33 ` si-wei liu
2019-02-22 3:33 ` si-wei liu
2019-02-22 7:00 ` Samudrala, Sridhar
2019-02-22 7:55 ` si-wei liu
2019-02-22 7:55 ` si-wei liu
2019-02-22 12:58 ` Rob Miller
2019-02-22 12:58 ` Rob Miller
2019-02-22 15:14 ` Michael S. Tsirkin
2019-02-22 15:14 ` Michael S. Tsirkin
2019-02-26 0:58 ` si-wei liu
2019-02-26 0:58 ` si-wei liu
2019-02-26 1:39 ` Stephen Hemminger
2019-02-26 1:39 ` Stephen Hemminger
2019-02-26 2:05 ` Michael S. Tsirkin
2019-02-26 2:05 ` Michael S. Tsirkin
2019-02-26 2:05 ` Michael S. Tsirkin
2019-02-27 0:49 ` si-wei liu
2019-02-27 0:49 ` si-wei liu
2019-02-26 2:08 ` Michael S. Tsirkin
2019-02-26 2:08 ` Michael S. Tsirkin
2019-02-26 2:08 ` Michael S. Tsirkin
2019-02-27 0:17 ` si-wei liu
2019-02-27 0:17 ` si-wei liu
2019-02-27 21:57 ` Stephen Hemminger
2019-02-27 21:57 ` Stephen Hemminger
2019-02-27 22:30 ` si-wei liu
2019-02-27 22:30 ` si-wei liu
2019-02-27 22:38 ` Michael S. Tsirkin
2019-02-27 22:38 ` Michael S. Tsirkin
2019-02-27 22:38 ` Michael S. Tsirkin
2019-02-27 23:34 ` si-wei liu
2019-02-27 23:34 ` si-wei liu
2019-02-27 23:50 ` Michael S. Tsirkin
2019-02-27 23:50 ` Michael S. Tsirkin
2019-02-27 23:50 ` Michael S. Tsirkin
2019-02-28 0:00 ` Liran Alon
2019-02-28 0:00 ` Liran Alon
2019-02-28 0:03 ` Stephen Hemminger
2019-02-28 0:38 ` Michael S. Tsirkin [this message]
2019-02-28 0:38 ` Michael S. Tsirkin
2019-02-28 0:38 ` Michael S. Tsirkin
2019-02-28 0:03 ` Stephen Hemminger
2019-02-28 0:38 ` si-wei liu
2019-02-28 0:38 ` si-wei liu
2019-02-28 0:41 ` Michael S. Tsirkin
2019-02-28 0:41 ` Michael S. Tsirkin
2019-02-28 0:41 ` Michael S. Tsirkin
2019-02-28 0:52 ` Jakub Kicinski
2019-02-28 0:52 ` Jakub Kicinski
2019-02-28 1:26 ` Michael S. Tsirkin
2019-02-28 1:26 ` Michael S. Tsirkin
2019-02-28 1:52 ` Jakub Kicinski
2019-02-28 1:52 ` Jakub Kicinski
2019-02-28 4:47 ` Michael S. Tsirkin
2019-02-28 4:47 ` Michael S. Tsirkin
2019-02-28 4:47 ` Michael S. Tsirkin
2019-02-28 18:13 ` Jakub Kicinski
2019-02-28 19:36 ` Michael S. Tsirkin
2019-02-28 19:36 ` Michael S. Tsirkin
2019-02-28 19:36 ` Michael S. Tsirkin
2019-02-28 19:56 ` Jakub Kicinski
2019-02-28 19:56 ` Jakub Kicinski
2019-02-28 20:14 ` Michael S. Tsirkin
2019-02-28 20:14 ` Michael S. Tsirkin
2019-02-28 23:31 ` Jakub Kicinski
2019-02-28 23:31 ` Jakub Kicinski
2019-03-01 0:20 ` Siwei Liu
2019-03-01 0:20 ` Siwei Liu
2019-03-01 1:05 ` Jakub Kicinski
2019-03-02 0:30 ` Siwei Liu
2019-03-02 0:30 ` Siwei Liu
2019-03-01 1:05 ` Jakub Kicinski
2019-02-28 18:13 ` Jakub Kicinski
2019-02-28 1:26 ` Michael S. Tsirkin
2019-02-28 9:32 ` si-wei liu
2019-02-28 9:32 ` si-wei liu
2019-02-28 14:26 ` Michael S. Tsirkin
2019-02-28 14:26 ` Michael S. Tsirkin
2019-03-01 1:30 ` si-wei liu
2019-03-01 1:30 ` si-wei liu
2019-03-01 13:27 ` Michael S. Tsirkin
2019-03-01 13:27 ` Michael S. Tsirkin
2019-03-01 13:27 ` Michael S. Tsirkin
2019-03-01 20:55 ` si-wei liu
2019-03-01 20:55 ` si-wei liu
2019-02-28 14:26 ` Michael S. Tsirkin
2019-02-22 15:14 ` Michael S. Tsirkin
2019-02-22 7:00 ` Samudrala, Sridhar
2019-02-22 1:39 ` Michael S. Tsirkin
2019-02-22 1:14 ` Siwei Liu
2018-04-10 21:26 ` [RFC PATCH net-next v6 4/4] netvsc: refactor notifier/event handling code to use the bypass framework Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20190227193330-mutt-send-email-mst__7921.8053071358$1551315049$gmane$org@kernel.org' \
--to=mst@redhat.com \
--cc=alexander.h.duyck@intel.com \
--cc=davem@davemloft.net \
--cc=jiri@resnulli.us \
--cc=kubakici@wp.pl \
--cc=liran.alon@oracle.com \
--cc=loseweigh@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=si-wei.liu@oracle.com \
--cc=sridhar.samudrala@intel.com \
--cc=stephen@networkplumber.org \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.