* [igt-dev] [PATCH i-g-t 1/9] tests/kms_lease: Add invalid planes tests
@ 2019-02-20 16:25 Daniel Vetter
2019-02-20 16:25 ` [igt-dev] [PATCH i-g-t 2/9] tests/kms_lease: Run on simulation Daniel Vetter
` (23 more replies)
0 siblings, 24 replies; 42+ messages in thread
From: Daniel Vetter @ 2019-02-20 16:25 UTC (permalink / raw)
To: IGT development; +Cc: Keith Packard
Test gap because we're using universal planes by default. Fix that.
Cc: Keith Packard <keithp@keithp.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
tests/kms_lease.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/tests/kms_lease.c b/tests/kms_lease.c
index cca424598ea7..70a96362d77a 100644
--- a/tests/kms_lease.c
+++ b/tests/kms_lease.c
@@ -573,6 +573,20 @@ static void lease_invalid_crtc(data_t *data)
igt_assert_eq(ret, -EINVAL);
}
+static void lease_invalid_plane(data_t *data)
+{
+ lease_t lease;
+ uint32_t save_plane_id;
+ int ret;
+
+ /* Create an invalid lease */
+ save_plane_id = data->plane_id;
+ data->plane_id = 0xbaadf00d;
+ ret = make_lease(data, &lease);
+ data->plane_id = save_plane_id;
+ igt_assert_eq(ret, -EINVAL);
+}
+
static void run_test(data_t *data, void (*testfunc)(data_t *))
{
@@ -625,6 +639,7 @@ igt_main
{ "lease_again", lease_again },
{ "lease_invalid_connector", lease_invalid_connector },
{ "lease_invalid_crtc", lease_invalid_crtc },
+ { "lease_invalid_plane", lease_invalid_plane },
{ }
}, *f;
--
2.14.4
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 42+ messages in thread
* [igt-dev] [PATCH i-g-t 2/9] tests/kms_lease: Run on simulation
2019-02-20 16:25 [igt-dev] [PATCH i-g-t 1/9] tests/kms_lease: Add invalid planes tests Daniel Vetter
@ 2019-02-20 16:25 ` Daniel Vetter
2019-03-14 9:29 ` Boris Brezillon
2019-02-20 16:25 ` [igt-dev] [PATCH i-g-t 3/9] tests/kms_lease: invalid corner-cases for create-lease ioctl Daniel Vetter
` (22 subsequent siblings)
23 siblings, 1 reply; 42+ messages in thread
From: Daniel Vetter @ 2019-02-20 16:25 UTC (permalink / raw)
To: IGT development; +Cc: Keith Packard
It's all kernel code that's being tested here, no reason not to run
in simulated environments ...
Cc: Keith Packard <keithp@keithp.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
tests/kms_lease.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/tests/kms_lease.c b/tests/kms_lease.c
index 70a96362d77a..fa97f6e11334 100644
--- a/tests/kms_lease.c
+++ b/tests/kms_lease.c
@@ -643,8 +643,6 @@ igt_main
{ }
}, *f;
- igt_skip_on_simulation();
-
igt_fixture {
data.master.fd = drm_open_driver_master(DRIVER_ANY);
kmstest_set_vt_graphics_mode();
--
2.14.4
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 42+ messages in thread
* [igt-dev] [PATCH i-g-t 3/9] tests/kms_lease: invalid corner-cases for create-lease ioctl
2019-02-20 16:25 [igt-dev] [PATCH i-g-t 1/9] tests/kms_lease: Add invalid planes tests Daniel Vetter
2019-02-20 16:25 ` [igt-dev] [PATCH i-g-t 2/9] tests/kms_lease: Run on simulation Daniel Vetter
@ 2019-02-20 16:25 ` Daniel Vetter
2019-02-20 20:43 ` Lyude Paul
` (2 more replies)
2019-02-20 16:25 ` [igt-dev] [PATCH i-g-t 4/9] tests/kms_release: invalid checks for revoke-lease ioctl Daniel Vetter
` (21 subsequent siblings)
23 siblings, 3 replies; 42+ messages in thread
From: Daniel Vetter @ 2019-02-20 16:25 UTC (permalink / raw)
To: IGT development; +Cc: Keith Packard
Found a few things in the kernel that looks suspicious, separate
patches on their way.
I also reviewed coverage for list-lesses and get-lease, and coverage
seems complete for these.
Cc: Keith Packard <keithp@keithp.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
tests/kms_lease.c | 100 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 100 insertions(+)
diff --git a/tests/kms_lease.c b/tests/kms_lease.c
index fa97f6e11334..4062a0b365c9 100644
--- a/tests/kms_lease.c
+++ b/tests/kms_lease.c
@@ -623,6 +623,103 @@ static void run_test(data_t *data, void (*testfunc)(data_t *))
"no valid crtc/connector combinations found\n");
}
+static void invalid_create_leases(data_t *data)
+{
+ uint32_t object_ids[4];
+ struct local_drm_mode_create_lease mcl;
+ drmModeRes *resources;
+ int tmp_fd;
+
+ /* empty lease */
+ mcl.object_ids = 0;
+ mcl.object_count = 0;
+ mcl.flags = 0;
+ igt_assert_eq(create_lease(data->master.fd, &mcl), -EINVAL);
+
+ /* NULL array pointer */
+ mcl.object_count = 1;
+ igt_assert_eq(create_lease(data->master.fd, &mcl), -EFAULT);
+
+ /* nil object */
+ object_ids[0] = 0;
+ mcl.object_ids = (uint64_t) (uintptr_t) object_ids;
+ mcl.object_count = 1;
+ igt_assert_eq(create_lease(data->master.fd, &mcl), -ENOENT);
+
+ /* no crtc, non-universal_plane */
+ drmSetClientCap(data->master.fd, DRM_CLIENT_CAP_UNIVERSAL_PLANES, 0);
+ object_ids[0] = data->master.display.outputs[0].id;
+ igt_assert_eq(create_lease(data->master.fd, &mcl), -EINVAL);
+
+ /* no connector, non-universal_plane */
+ object_ids[0] = data->master.display.pipes[0].crtc_id;
+ igt_assert_eq(create_lease(data->master.fd, &mcl), -EINVAL);
+
+ /* sanity check */
+ object_ids[0] = data->master.display.pipes[0].crtc_id;
+ object_ids[1] = data->master.display.outputs[0].id;
+ mcl.object_count = 2;
+ igt_assert_eq(create_lease(data->master.fd, &mcl), 0);
+ close(mcl.fd);
+
+ /* no plane, universal planes */
+ drmSetClientCap(data->master.fd, DRM_CLIENT_CAP_UNIVERSAL_PLANES, 1);
+ igt_assert_eq(create_lease(data->master.fd, &mcl), -EINVAL);
+
+ /* sanity check */
+ object_ids[2] = igt_pipe_get_plane_type(&data->master.display.pipes[0],
+ DRM_PLANE_TYPE_PRIMARY)->drm_plane->plane_id;
+ mcl.object_count = 3;
+ igt_assert_eq(create_lease(data->master.fd, &mcl), 0);
+ close(mcl.fd);
+
+ /* array overflow */
+ mcl.object_count = UINT32_MAX / sizeof(object_ids[0]) + 1;
+ igt_assert_eq(create_lease(data->master.fd, &mcl), -ENOMEM);
+ mcl.object_count = UINT32_MAX / sizeof(object_ids[0]) + 2;
+ igt_assert_eq(create_lease(data->master.fd, &mcl), -ENOMEM);
+ mcl.object_count = UINT32_MAX / sizeof(object_ids[0]) + 3;
+ igt_assert_eq(create_lease(data->master.fd, &mcl), -ENOMEM);
+ mcl.object_count = UINT32_MAX / sizeof(object_ids[0]) + 4;
+ igt_assert_eq(create_lease(data->master.fd, &mcl), -ENOMEM);
+
+ /* invalid flags */
+ mcl.object_count = 3;
+ mcl.flags = O_CLOEXEC | O_NONBLOCK;
+ igt_assert_eq(create_lease(data->master.fd, &mcl), 0);
+ close(mcl.fd);
+ mcl.flags = -1;
+ igt_assert_eq(create_lease(data->master.fd, &mcl), -EINVAL);
+
+ /* no subleasing */
+ mcl.object_count = 3;
+ mcl.flags = 0;
+ igt_assert_eq(create_lease(data->master.fd, &mcl), 0);
+ tmp_fd = mcl.fd;
+ igt_assert_eq(create_lease(tmp_fd, &mcl), -EINVAL);
+ close(tmp_fd);
+
+ /* no double-leasing */
+ igt_assert_eq(create_lease(data->master.fd, &mcl), 0);
+ tmp_fd = mcl.fd;
+ igt_assert_eq(create_lease(data->master.fd, &mcl), -EBUSY);
+ close(tmp_fd);
+
+ /* no double leasing */
+ object_ids[3] = object_ids[2];
+ mcl.object_count = 4;
+ /* Note: the ENOSPC is from idr double-insertion failing */
+ igt_assert_eq(create_lease(data->master.fd, &mcl), -ENOSPC);
+
+ /* no encoder leasing */
+ resources = drmModeGetResources(data->master.fd);
+ igt_assert(resources);
+ igt_assert(resources->count_encoders > 0);
+ object_ids[3] = resources->encoders[0];
+ igt_assert_eq(create_lease(data->master.fd, &mcl), -EINVAL);
+ drmModeFreeResources(resources);
+}
+
igt_main
{
data_t data;
@@ -655,4 +752,7 @@ igt_main
run_test(&data, f->func);
}
}
+
+ igt_subtest("invalid-create-leases")
+ invalid_create_leases(&data);
}
--
2.14.4
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 42+ messages in thread
* [igt-dev] [PATCH i-g-t 4/9] tests/kms_release: invalid checks for revoke-lease ioctl
2019-02-20 16:25 [igt-dev] [PATCH i-g-t 1/9] tests/kms_lease: Add invalid planes tests Daniel Vetter
2019-02-20 16:25 ` [igt-dev] [PATCH i-g-t 2/9] tests/kms_lease: Run on simulation Daniel Vetter
2019-02-20 16:25 ` [igt-dev] [PATCH i-g-t 3/9] tests/kms_lease: invalid corner-cases for create-lease ioctl Daniel Vetter
@ 2019-02-20 16:25 ` Daniel Vetter
2019-03-14 9:35 ` Boris Brezillon
2019-02-20 16:25 ` [igt-dev] [PATCH i-g-t 5/9] tests/kms_lease: validate the possible_crtcs filtering Daniel Vetter
` (20 subsequent siblings)
23 siblings, 1 reply; 42+ messages in thread
From: Daniel Vetter @ 2019-02-20 16:25 UTC (permalink / raw)
To: IGT development; +Cc: Keith Packard, Daniel Vetter
Found a few corner cases to validate. Put them into the existing
testcase.
Cc: Keith Packard <keithp@keithp.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
tests/kms_lease.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/tests/kms_lease.c b/tests/kms_lease.c
index 4062a0b365c9..298d81c71ba9 100644
--- a/tests/kms_lease.c
+++ b/tests/kms_lease.c
@@ -511,6 +511,14 @@ static void lease_revoke(data_t *data)
igt_display_require(&lease.display, lease.fd);
+ /* try to revoke an invalid lease */
+ mrl.lessee_id = 0;
+ igt_assert_eq(revoke_lease(data->master.fd, &mrl), -ENOENT);
+
+ /* try to revoke with the wrong fd */
+ mrl.lessee_id = lease.lessee_id;
+ igt_assert_eq(revoke_lease(lease.fd, &mrl), -EACCES);
+
/* Revoke the lease using the master fd */
mrl.lessee_id = lease.lessee_id;
igt_assert_eq(revoke_lease(data->master.fd, &mrl), 0);
@@ -522,6 +530,10 @@ static void lease_revoke(data_t *data)
igt_assert_eq(ret, -ENOENT);
terminate_lease(&lease);
+
+ /* make sure the lease is gone */
+ mrl.lessee_id = lease.lessee_id;
+ igt_assert_eq(revoke_lease(data->master.fd, &mrl), -ENOENT);
}
/* Test leasing objects more than once */
--
2.14.4
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 42+ messages in thread
* [igt-dev] [PATCH i-g-t 5/9] tests/kms_lease: validate the possible_crtcs filtering
2019-02-20 16:25 [igt-dev] [PATCH i-g-t 1/9] tests/kms_lease: Add invalid planes tests Daniel Vetter
` (2 preceding siblings ...)
2019-02-20 16:25 ` [igt-dev] [PATCH i-g-t 4/9] tests/kms_release: invalid checks for revoke-lease ioctl Daniel Vetter
@ 2019-02-20 16:25 ` Daniel Vetter
2019-02-20 16:25 ` [igt-dev] [PATCH i-g-t 6/9] tests/kms_lease: Test drop/set_master interactions Daniel Vetter
` (19 subsequent siblings)
23 siblings, 0 replies; 42+ messages in thread
From: Daniel Vetter @ 2019-02-20 16:25 UTC (permalink / raw)
To: IGT development; +Cc: Keith Packard, Daniel Vetter
Makes sure the possible_crtcs logically match between master and
lease, and that the values are correctly renumbered on the lease side.
Cc: Keith Packard <keithp@keithp.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
tests/kms_lease.c | 105 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 105 insertions(+)
diff --git a/tests/kms_lease.c b/tests/kms_lease.c
index 298d81c71ba9..207a598d6f5a 100644
--- a/tests/kms_lease.c
+++ b/tests/kms_lease.c
@@ -732,6 +732,108 @@ static void invalid_create_leases(data_t *data)
drmModeFreeResources(resources);
}
+static void check_crtc_masks(int master_fd, int lease_fd, uint32_t crtc_mask)
+{
+ drmModeRes *resources;
+ drmModePlaneRes *plane_resources;
+ int i;
+
+ resources = drmModeGetResources(master_fd);
+ igt_assert(resources);
+ plane_resources = drmModeGetPlaneResources(master_fd);
+ igt_assert(plane_resources);
+
+ for (i = 0; i < resources->count_encoders; i++) {
+ drmModeEncoder *master_e, *lease_e;
+ bool possible;
+
+ master_e = drmModeGetEncoder(master_fd, resources->encoders[i]);
+ igt_assert(master_e);
+ lease_e = drmModeGetEncoder(lease_fd, resources->encoders[i]);
+ igt_assert(lease_e);
+
+ possible = master_e->possible_crtcs & crtc_mask;
+
+ igt_assert_eq(lease_e->possible_crtcs,
+ possible ? 1 : 0);
+ igt_assert_eq(master_e->possible_crtcs & crtc_mask,
+ possible ? crtc_mask : 0);
+ drmModeFreeEncoder(master_e);
+ drmModeFreeEncoder(lease_e);
+ }
+
+ for (i = 0; i < plane_resources->count_planes; i++) {
+ drmModePlane *master_p, *lease_p;
+ bool possible;
+
+ master_p = drmModeGetPlane(master_fd, plane_resources->planes[i]);
+ igt_assert(master_p);
+ lease_p = drmModeGetPlane(lease_fd, plane_resources->planes[i]);
+ igt_assert(lease_p);
+
+ possible = master_p->possible_crtcs & crtc_mask;
+
+ igt_assert_eq(lease_p->possible_crtcs,
+ possible ? 1 : 0);
+ igt_assert_eq(master_p->possible_crtcs & crtc_mask,
+ possible ? crtc_mask : 0);
+ drmModeFreePlane(master_p);
+ drmModeFreePlane(lease_p);
+ }
+
+ drmModeFreePlaneResources(plane_resources);
+ drmModeFreeResources(resources);
+}
+
+static void possible_crtcs_filtering(data_t *data)
+{
+ uint32_t *object_ids;
+ struct local_drm_mode_create_lease mcl;
+ drmModeRes *resources;
+ drmModePlaneRes *plane_resources;
+ int i;
+ int master_fd = data->master.fd;
+
+ resources = drmModeGetResources(master_fd);
+ igt_assert(resources);
+ plane_resources = drmModeGetPlaneResources(master_fd);
+ igt_assert(plane_resources);
+ mcl.object_count = resources->count_connectors +
+ plane_resources->count_planes + 1;
+ object_ids = calloc(mcl.object_count, sizeof(*object_ids));
+ igt_assert(object_ids);
+
+ for (i = 0; i < resources->count_connectors; i++)
+ object_ids[i] = resources->connectors[i];
+
+ for (i = 0; i < plane_resources->count_planes; i++)
+ object_ids[i + resources->count_connectors] =
+ plane_resources->planes[i];
+
+ mcl.object_ids = (uint64_t) (uintptr_t) object_ids;
+ mcl.flags = 0;
+
+ for (i = 0; i < resources->count_crtcs; i++) {
+ int lease_fd;
+
+ object_ids[mcl.object_count - 1] =
+ resources->crtcs[i];
+
+ igt_assert_eq(create_lease(master_fd, &mcl), 0);
+ lease_fd = mcl.fd;
+
+ drmSetClientCap(lease_fd, DRM_CLIENT_CAP_UNIVERSAL_PLANES, 1);
+
+ check_crtc_masks(master_fd, lease_fd, 1 << i);
+
+ close(lease_fd);
+ }
+
+ free(object_ids);
+ drmModeFreePlaneResources(plane_resources);
+ drmModeFreeResources(resources);
+}
+
igt_main
{
data_t data;
@@ -767,4 +869,7 @@ igt_main
igt_subtest("invalid-create-leases")
invalid_create_leases(&data);
+
+ igt_subtest("possible-crtcs-filtering")
+ possible_crtcs_filtering(&data);
}
--
2.14.4
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 42+ messages in thread
* [igt-dev] [PATCH i-g-t 6/9] tests/kms_lease: Test drop/set_master interactions
2019-02-20 16:25 [igt-dev] [PATCH i-g-t 1/9] tests/kms_lease: Add invalid planes tests Daniel Vetter
` (3 preceding siblings ...)
2019-02-20 16:25 ` [igt-dev] [PATCH i-g-t 5/9] tests/kms_lease: validate the possible_crtcs filtering Daniel Vetter
@ 2019-02-20 16:25 ` Daniel Vetter
2019-02-20 16:25 ` [igt-dev] [PATCH i-g-t 7/9] tests/kms_lease: multimaster testcase Daniel Vetter
` (18 subsequent siblings)
23 siblings, 0 replies; 42+ messages in thread
From: Daniel Vetter @ 2019-02-20 16:25 UTC (permalink / raw)
To: IGT development; +Cc: Keith Packard, Daniel Vetter
- make sure leases change master status together with lessor
- make sure lease can't change the master status
Cc: Keith Packard <keithp@keithp.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
tests/kms_lease.c | 45 +++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 45 insertions(+)
diff --git a/tests/kms_lease.c b/tests/kms_lease.c
index 207a598d6f5a..e69964dd3990 100644
--- a/tests/kms_lease.c
+++ b/tests/kms_lease.c
@@ -834,6 +834,48 @@ static void possible_crtcs_filtering(data_t *data)
drmModeFreeResources(resources);
}
+static bool is_master(int fd)
+{
+ /* FIXME: replace with drmIsMaster once we bumped libdrm version */
+ return drmAuthMagic(fd, 0) != -EACCES;
+}
+static void master_vs_lease(data_t *data)
+{
+ uint32_t object_ids[3];
+ struct local_drm_mode_create_lease mcl;
+
+ object_ids[0] = data->master.display.pipes[0].crtc_id;
+ object_ids[1] = data->master.display.outputs[0].id;
+ object_ids[2] = igt_pipe_get_plane_type(&data->master.display.pipes[0],
+ DRM_PLANE_TYPE_PRIMARY)->drm_plane->plane_id;
+ mcl.object_ids = (uint64_t) (uintptr_t) object_ids;
+ mcl.object_count = 3;
+ mcl.flags = 0;
+
+ igt_assert_eq(create_lease(data->master.fd, &mcl), 0);
+
+ igt_assert_eq(drmDropMaster(mcl.fd), -1);
+ igt_assert_eq(errno, EINVAL);
+
+ igt_assert(is_master(data->master.fd));
+ igt_assert(is_master(mcl.fd));
+
+ do_or_die(drmDropMaster(data->master.fd));
+
+ igt_assert(!is_master(data->master.fd));
+ igt_assert(!is_master(mcl.fd));
+
+ igt_assert_eq(drmSetMaster(mcl.fd), -1);
+ igt_assert_eq(errno, EINVAL);
+
+ do_or_die(drmSetMaster(data->master.fd));
+
+ igt_assert(is_master(data->master.fd));
+ igt_assert(is_master(mcl.fd));
+
+ close(mcl.fd);
+}
+
igt_main
{
data_t data;
@@ -872,4 +914,7 @@ igt_main
igt_subtest("possible-crtcs-filtering")
possible_crtcs_filtering(&data);
+
+ igt_subtest("master-vs-lease")
+ master_vs_lease(&data);
}
--
2.14.4
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 42+ messages in thread
* [igt-dev] [PATCH i-g-t 7/9] tests/kms_lease: multimaster testcase
2019-02-20 16:25 [igt-dev] [PATCH i-g-t 1/9] tests/kms_lease: Add invalid planes tests Daniel Vetter
` (4 preceding siblings ...)
2019-02-20 16:25 ` [igt-dev] [PATCH i-g-t 6/9] tests/kms_lease: Test drop/set_master interactions Daniel Vetter
@ 2019-02-20 16:25 ` Daniel Vetter
2019-02-20 16:25 ` [igt-dev] [PATCH i-g-t 8/9] tests/kms_lease: validate implicitly added planes Daniel Vetter
` (17 subsequent siblings)
23 siblings, 0 replies; 42+ messages in thread
From: Daniel Vetter @ 2019-02-20 16:25 UTC (permalink / raw)
To: IGT development; +Cc: Keith Packard, Daniel Vetter
Check that the 2nd master can only create leases while being active
master, and that leases on the first master don't prevent lease
creation for the 2nd master.
Also check that a disappearing master does also invalidate all its
leases.
Cc: Keith Packard <keithp@keithp.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
tests/kms_lease.c | 72 ++++++++++++++++++++++++++++++++++++++++++++++++-------
1 file changed, 64 insertions(+), 8 deletions(-)
diff --git a/tests/kms_lease.c b/tests/kms_lease.c
index e69964dd3990..e064b6274789 100644
--- a/tests/kms_lease.c
+++ b/tests/kms_lease.c
@@ -839,7 +839,8 @@ static bool is_master(int fd)
/* FIXME: replace with drmIsMaster once we bumped libdrm version */
return drmAuthMagic(fd, 0) != -EACCES;
}
-static void master_vs_lease(data_t *data)
+
+static int _create_simple_lease(int master_fd, data_t *data, int expected_ret)
{
uint32_t object_ids[3];
struct local_drm_mode_create_lease mcl;
@@ -852,28 +853,80 @@ static void master_vs_lease(data_t *data)
mcl.object_count = 3;
mcl.flags = 0;
- igt_assert_eq(create_lease(data->master.fd, &mcl), 0);
+ igt_assert_eq(create_lease(master_fd, &mcl), expected_ret);
+
+ return expected_ret == 0 ? mcl.fd : 0;
+}
- igt_assert_eq(drmDropMaster(mcl.fd), -1);
+static int create_simple_lease(int master_fd, data_t *data)
+{
+ return _create_simple_lease(master_fd, data, 0);
+}
+
+/* check lease master status in lockdep with lessors, but can't change it
+ * themselves */
+static void master_vs_lease(data_t *data)
+{
+ int lease_fd;
+
+ lease_fd = create_simple_lease(data->master.fd, data);
+
+ igt_assert_eq(drmDropMaster(lease_fd), -1);
igt_assert_eq(errno, EINVAL);
igt_assert(is_master(data->master.fd));
- igt_assert(is_master(mcl.fd));
+ igt_assert(is_master(lease_fd));
do_or_die(drmDropMaster(data->master.fd));
igt_assert(!is_master(data->master.fd));
- igt_assert(!is_master(mcl.fd));
+ igt_assert(!is_master(lease_fd));
- igt_assert_eq(drmSetMaster(mcl.fd), -1);
+ igt_assert_eq(drmSetMaster(lease_fd), -1);
igt_assert_eq(errno, EINVAL);
do_or_die(drmSetMaster(data->master.fd));
igt_assert(is_master(data->master.fd));
- igt_assert(is_master(mcl.fd));
+ igt_assert(is_master(lease_fd));
- close(mcl.fd);
+ close(lease_fd);
+}
+
+static void multimaster_lease(data_t *data)
+{
+ int lease_fd, master2_fd, lease2_fd;
+
+ lease_fd = create_simple_lease(data->master.fd, data);
+
+ igt_assert(is_master(data->master.fd));
+ igt_assert(is_master(lease_fd));
+
+ master2_fd = drm_open_driver(DRIVER_ANY);
+
+ igt_assert(!is_master(master2_fd));
+
+ _create_simple_lease(master2_fd, data, -EACCES);
+
+ do_or_die(drmDropMaster(data->master.fd));
+ do_or_die(drmSetMaster(master2_fd));
+
+ igt_assert(!is_master(data->master.fd));
+ igt_assert(!is_master(lease_fd));
+ igt_assert(is_master(master2_fd));
+
+ drmSetClientCap(master2_fd, DRM_CLIENT_CAP_UNIVERSAL_PLANES, 1);
+ lease2_fd = create_simple_lease(master2_fd, data);
+
+ close(master2_fd); /* close is an implicit DropMaster */
+ igt_assert(!is_master(lease2_fd));
+
+ do_or_die(drmSetMaster(data->master.fd));
+ igt_assert(is_master(data->master.fd));
+ igt_assert(is_master(lease_fd));
+
+ close(lease2_fd);
+ close(lease_fd);
}
igt_main
@@ -917,4 +970,7 @@ igt_main
igt_subtest("master-vs-lease")
master_vs_lease(&data);
+
+ igt_subtest("multimaster-lease")
+ multimaster_lease(&data);
}
--
2.14.4
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 42+ messages in thread
* [igt-dev] [PATCH i-g-t 8/9] tests/kms_lease: validate implicitly added planes
2019-02-20 16:25 [igt-dev] [PATCH i-g-t 1/9] tests/kms_lease: Add invalid planes tests Daniel Vetter
` (5 preceding siblings ...)
2019-02-20 16:25 ` [igt-dev] [PATCH i-g-t 7/9] tests/kms_lease: multimaster testcase Daniel Vetter
@ 2019-02-20 16:25 ` Daniel Vetter
2019-02-20 16:25 ` [igt-dev] [PATCH i-g-t 9/9] tests/kms_lease: exercise uevent Daniel Vetter
` (16 subsequent siblings)
23 siblings, 0 replies; 42+ messages in thread
From: Daniel Vetter @ 2019-02-20 16:25 UTC (permalink / raw)
To: IGT development; +Cc: Keith Packard, Daniel Vetter
Without universal planes the kernel should auto-add the (in that case
hidden) primary and cursor planes. Check this works and all the error
handling is there for evil userspace.
Cc: Keith Packard <keithp@keithp.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
tests/kms_lease.c | 50 ++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 50 insertions(+)
diff --git a/tests/kms_lease.c b/tests/kms_lease.c
index e064b6274789..d082a7988eaa 100644
--- a/tests/kms_lease.c
+++ b/tests/kms_lease.c
@@ -929,6 +929,53 @@ static void multimaster_lease(data_t *data)
close(lease_fd);
}
+static void implicit_plane_lease(data_t *data)
+{
+ uint32_t object_ids[3];
+ struct local_drm_mode_create_lease mcl;
+ struct local_drm_mode_get_lease mgl;
+
+ uint32_t cursor_id = igt_pipe_get_plane_type(&data->master.display.pipes[0],
+ DRM_PLANE_TYPE_CURSOR)->drm_plane->plane_id;
+
+ object_ids[0] = data->master.display.pipes[0].crtc_id;
+ object_ids[1] = data->master.display.outputs[0].id;
+ object_ids[2] = igt_pipe_get_plane_type(&data->master.display.pipes[0],
+ DRM_PLANE_TYPE_PRIMARY)->drm_plane->plane_id;
+ mcl.object_ids = (uint64_t) (uintptr_t) object_ids;
+ mcl.object_count = 3;
+ mcl.flags = 0;
+
+ /* sanity check */
+ igt_assert_eq(create_lease(data->master.fd, &mcl), 0);
+ close(mcl.fd);
+ drmSetClientCap(data->master.fd, DRM_CLIENT_CAP_UNIVERSAL_PLANES, 0);
+
+ /* non universal plane automatically adds primary/cursor plane */
+ mcl.object_count = 2;
+ igt_assert_eq(create_lease(data->master.fd, &mcl), 0);
+
+ mgl.pad = 0;
+ mgl.count_objects = 0;
+ mgl.objects_ptr = 0;
+ igt_assert_eq(get_lease(mcl.fd, &mgl), 0);
+
+ igt_assert_eq(mgl.count_objects, 3 + (cursor_id ? 1 : 0));
+
+ close(mcl.fd);
+
+ /* check that implicit lease doesn't lead to confusion when
+ * explicitly adding primary plane */
+ mcl.object_count = 3;
+ igt_assert_eq(create_lease(data->master.fd, &mcl), -ENOSPC);
+
+ /* same for the cursor */
+ object_ids[2] = cursor_id;
+ igt_assert_eq(create_lease(data->master.fd, &mcl), -ENOSPC);
+
+ drmSetClientCap(data->master.fd, DRM_CLIENT_CAP_UNIVERSAL_PLANES, 1);
+}
+
igt_main
{
data_t data;
@@ -973,4 +1020,7 @@ igt_main
igt_subtest("multimaster-lease")
multimaster_lease(&data);
+
+ igt_subtest("implicit-plane-lease")
+ implicit_plane_lease(&data);
}
--
2.14.4
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 42+ messages in thread
* [igt-dev] [PATCH i-g-t 9/9] tests/kms_lease: exercise uevent
2019-02-20 16:25 [igt-dev] [PATCH i-g-t 1/9] tests/kms_lease: Add invalid planes tests Daniel Vetter
` (6 preceding siblings ...)
2019-02-20 16:25 ` [igt-dev] [PATCH i-g-t 8/9] tests/kms_lease: validate implicitly added planes Daniel Vetter
@ 2019-02-20 16:25 ` Daniel Vetter
2019-02-20 20:33 ` [igt-dev] [PATCH i-g-t] " Daniel Vetter
` (2 more replies)
2019-02-20 17:00 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests Patchwork
` (15 subsequent siblings)
23 siblings, 3 replies; 42+ messages in thread
From: Daniel Vetter @ 2019-02-20 16:25 UTC (permalink / raw)
To: IGT development; +Cc: Keith Packard, Daniel Vetter
And make sure we get the LEASE=1 value, indicating a lessee change.
Cc: Keith Packard <keithp@keithp.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
tests/kms_lease.c | 66 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 66 insertions(+)
diff --git a/tests/kms_lease.c b/tests/kms_lease.c
index d082a7988eaa..26dfc6fa4a15 100644
--- a/tests/kms_lease.c
+++ b/tests/kms_lease.c
@@ -40,6 +40,8 @@
#include <sys/time.h>
#include <sys/wait.h>
+#include <libudev.h>
+
#include <drm.h>
IGT_TEST_DESCRIPTION("Test of CreateLease.");
@@ -976,6 +978,67 @@ static void implicit_plane_lease(data_t *data)
drmSetClientCap(data->master.fd, DRM_CLIENT_CAP_UNIVERSAL_PLANES, 1);
}
+static void lease_uevent(data_t *data)
+{
+ int lease_fd;
+ struct local_drm_mode_list_lessees mll;
+ struct udev_monitor *uevent_monitor;
+ struct udev *udev;
+ struct udev_device *dev;
+ const char *lease;
+ struct pollfd udev_fd;
+
+ udev = udev_new();
+ igt_assert(udev);
+
+ uevent_monitor = udev_monitor_new_from_netlink(udev, "udev");
+ igt_assert(uevent_monitor);
+
+ do_or_die(udev_monitor_filter_add_match_subsystem_devtype(uevent_monitor,
+ "drm",
+ "drm_minor"));
+ do_or_die(udev_monitor_enable_receiving(uevent_monitor));
+
+ /* netlink is not synchronous ... */
+ udev_fd.fd = udev_monitor_get_fd(uevent_monitor);
+ udev_fd.revents = 0;
+ udev_fd.events = POLLIN;
+
+ poll(&udev_fd, 1, 100);
+ dev = udev_monitor_receive_device(uevent_monitor);
+ igt_assert(!dev);
+
+ lease_fd = create_simple_lease(data->master.fd, data);
+
+ poll(&udev_fd, 1, 100);
+ dev = udev_monitor_receive_device(uevent_monitor);
+ igt_assert(!dev);
+
+ mll.pad = 0;
+ mll.count_lessees = 0;
+ mll.lessees_ptr = 0;
+ igt_assert_eq(list_lessees(data->master.fd, &mll), 0);
+ igt_assert_eq(mll.count_lessees, 1);
+
+ close(lease_fd);
+
+ poll(&udev_fd, 1, 100);
+ dev = udev_monitor_receive_device(uevent_monitor);
+ igt_assert(dev);
+
+ lease = udev_device_get_property_value(dev, "LEASE");
+ igt_assert(lease);
+ igt_assert(strcmp(lease, "1") == 0);
+
+ udev_device_unref(dev);
+
+ mll.lessees_ptr = 0;
+ igt_assert_eq(list_lessees(data->master.fd, &mll), 0);
+ igt_assert_eq(mll.count_lessees, 0);
+
+ udev_monitor_unref(uevent_monitor);
+}
+
igt_main
{
data_t data;
@@ -1023,4 +1086,7 @@ igt_main
igt_subtest("implicit-plane-lease")
implicit_plane_lease(&data);
+
+ igt_subtest("lease-uevent")
+ lease_uevent(&data);
}
--
2.14.4
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 42+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests
2019-02-20 16:25 [igt-dev] [PATCH i-g-t 1/9] tests/kms_lease: Add invalid planes tests Daniel Vetter
` (7 preceding siblings ...)
2019-02-20 16:25 ` [igt-dev] [PATCH i-g-t 9/9] tests/kms_lease: exercise uevent Daniel Vetter
@ 2019-02-20 17:00 ` Patchwork
2019-02-20 19:51 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
` (14 subsequent siblings)
23 siblings, 0 replies; 42+ messages in thread
From: Patchwork @ 2019-02-20 17:00 UTC (permalink / raw)
To: igt-dev
== Series Details ==
Series: series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests
URL : https://patchwork.freedesktop.org/series/56970/
State : success
== Summary ==
CI Bug Log - changes from IGT_4844 -> IGTPW_2458
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/56970/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2458 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_frontbuffer_tracking@basic:
- fi-byt-clapper: PASS -> FAIL [fdo#103167]
* igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence:
- fi-byt-clapper: PASS -> FAIL [fdo#103191] / [fdo#107362]
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- fi-blb-e6850: PASS -> INCOMPLETE [fdo#107718]
* igt@runner@aborted:
- fi-apl-guc: NOTRUN -> FAIL [fdo#108622]
#### Possible fixes ####
* igt@kms_busy@basic-flip-b:
- fi-gdg-551: FAIL [fdo#103182] -> PASS
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- fi-byt-clapper: FAIL [fdo#103191] / [fdo#107362] -> PASS
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108622]: https://bugs.freedesktop.org/show_bug.cgi?id=108622
Participating hosts (46 -> 39)
------------------------------
Missing (7): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-y fi-bdw-samus
Build changes
-------------
* IGT: IGT_4844 -> IGTPW_2458
CI_DRM_5636: b33b7e4ffb889d3d3e03ad9b64d0fe15dd2184b4 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2458: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2458/
IGT_4844: ee6e006202a50c5aef373c0b075027ed7177935a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Testlist changes ==
+igt@kms_lease@implicit-plane-lease
+igt@kms_lease@invalid-create-leases
+igt@kms_lease@lease-uevent
+igt@kms_lease@lease_invalid_plane
+igt@kms_lease@master-vs-lease
+igt@kms_lease@multimaster-lease
+igt@kms_lease@possible-crtcs-filtering
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2458/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 42+ messages in thread
* [igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests
2019-02-20 16:25 [igt-dev] [PATCH i-g-t 1/9] tests/kms_lease: Add invalid planes tests Daniel Vetter
` (8 preceding siblings ...)
2019-02-20 17:00 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests Patchwork
@ 2019-02-20 19:51 ` Patchwork
2019-02-20 20:42 ` Daniel Vetter
2019-02-20 21:11 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests (rev2) Patchwork
` (13 subsequent siblings)
23 siblings, 1 reply; 42+ messages in thread
From: Patchwork @ 2019-02-20 19:51 UTC (permalink / raw)
To: igt-dev
== Series Details ==
Series: series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests
URL : https://patchwork.freedesktop.org/series/56970/
State : failure
== Summary ==
CI Bug Log - changes from IGT_4844_full -> IGTPW_2458_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_2458_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_2458_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/56970/revisions/1/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_2458_full:
### IGT changes ###
#### Possible regressions ####
* {igt@kms_lease@invalid-create-leases} (NEW):
- shard-kbl: NOTRUN -> DMESG-WARN
- shard-hsw: NOTRUN -> DMESG-WARN
- shard-snb: NOTRUN -> DMESG-WARN
- shard-glk: NOTRUN -> DMESG-WARN
- shard-apl: NOTRUN -> DMESG-WARN
* {igt@kms_lease@lease-uevent} (NEW):
- shard-apl: NOTRUN -> FAIL +1
* igt@runner@aborted:
- shard-hsw: NOTRUN -> FAIL
- shard-snb: NOTRUN -> FAIL
- shard-kbl: NOTRUN -> FAIL
New tests
---------
New tests have been introduced between IGT_4844_full and IGTPW_2458_full:
### New IGT tests (7) ###
* igt@kms_lease@implicit-plane-lease:
- Statuses : 5 pass(s)
- Exec time: [0.00] s
* igt@kms_lease@invalid-create-leases:
- Statuses : 5 dmesg-warn(s)
- Exec time: [0.00, 0.01] s
* igt@kms_lease@lease-uevent:
- Statuses : 1 fail(s) 3 pass(s)
- Exec time: [0.21, 1.25] s
* igt@kms_lease@lease_invalid_plane:
- Statuses : 5 pass(s)
- Exec time: [0.0] s
* igt@kms_lease@master-vs-lease:
- Statuses : 4 pass(s)
- Exec time: [0.0, 0.00] s
* igt@kms_lease@multimaster-lease:
- Statuses : 2 pass(s)
- Exec time: [0.00] s
* igt@kms_lease@possible-crtcs-filtering:
- Statuses : 5 pass(s)
- Exec time: [0.00, 0.01] s
Known issues
------------
Here are the changes found in IGTPW_2458_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_schedule@preempt-other-chain-blt:
- shard-snb: NOTRUN -> SKIP [fdo#109271] +174
* igt@kms_atomic_transition@3x-modeset-transitions-nonblocking-fencing:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_busy@basic-modeset-f:
- shard-glk: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +2
* igt@kms_busy@extended-modeset-hang-newfb-render-a:
- shard-hsw: NOTRUN -> DMESG-WARN [fdo#107956]
* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-a:
- shard-glk: NOTRUN -> DMESG-WARN [fdo#107956]
* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-d:
- shard-apl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_color@pipe-a-ctm-max:
- shard-glk: NOTRUN -> FAIL [fdo#108147]
* igt@kms_color@pipe-b-degamma:
- shard-apl: PASS -> FAIL [fdo#104782]
* igt@kms_cursor_crc@cursor-128x42-sliding:
- shard-kbl: PASS -> FAIL [fdo#103232]
- shard-apl: PASS -> FAIL [fdo#103232] +4
* igt@kms_cursor_crc@cursor-256x256-sliding:
- shard-glk: NOTRUN -> FAIL [fdo#103232]
* igt@kms_cursor_crc@cursor-256x256-suspend:
- shard-apl: PASS -> FAIL [fdo#103191] / [fdo#103232]
* igt@kms_cursor_crc@cursor-alpha-opaque:
- shard-apl: PASS -> FAIL [fdo#109350]
* igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic:
- shard-glk: NOTRUN -> FAIL [fdo#105454] / [fdo#106509]
* igt@kms_flip@2x-plain-flip-ts-check:
- shard-apl: NOTRUN -> SKIP [fdo#109271] +18
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-glk: PASS -> FAIL [fdo#105363]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
- shard-apl: PASS -> FAIL [fdo#103167] +1
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-cpu:
- shard-glk: PASS -> FAIL [fdo#103167] +8
* igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-mmap-wc:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] +22
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-blt:
- shard-hsw: NOTRUN -> SKIP [fdo#109271] +54
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-shrfb-msflip-blt:
- shard-glk: NOTRUN -> SKIP [fdo#109271] +30
* igt@kms_plane@plane-position-covered-pipe-b-planes:
- shard-kbl: PASS -> FAIL [fdo#103166] +1
* igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb:
- shard-snb: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +21
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max:
- shard-glk: PASS -> FAIL [fdo#108145] +2
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-hsw: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +2
* igt@kms_plane_multiple@atomic-pipe-c-tiling-none:
- shard-apl: PASS -> FAIL [fdo#103166] +1
* igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
- shard-apl: NOTRUN -> FAIL [fdo#103166]
* igt@kms_setmode@basic:
- shard-apl: PASS -> FAIL [fdo#99912]
* igt@kms_universal_plane@universal-plane-pipe-c-functional:
- shard-glk: PASS -> FAIL [fdo#103166] +5
* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-apl: PASS -> FAIL [fdo#104894]
- shard-kbl: PASS -> FAIL [fdo#104894]
#### Possible fixes ####
* igt@i915_pm_rpm@system-suspend:
- shard-kbl: INCOMPLETE [fdo#103665] / [fdo#107807] -> PASS
* igt@kms_atomic_transition@plane-all-modeset-transition:
- shard-kbl: INCOMPLETE [fdo#103665] -> PASS +1
* igt@kms_atomic_transition@plane-all-modeset-transition-fencing:
- shard-apl: INCOMPLETE [fdo#103927] -> PASS +1
* igt@kms_color@pipe-c-legacy-gamma:
- shard-apl: FAIL [fdo#104782] -> PASS
* igt@kms_cursor_crc@cursor-128x128-random:
- shard-apl: FAIL [fdo#103232] -> PASS +4
* igt@kms_cursor_crc@cursor-128x128-suspend:
- shard-apl: FAIL [fdo#103191] / [fdo#103232] -> PASS
- shard-kbl: FAIL [fdo#103191] / [fdo#103232] -> PASS
* igt@kms_cursor_crc@cursor-64x64-onscreen:
- shard-kbl: FAIL [fdo#103232] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc:
- shard-glk: FAIL [fdo#103167] -> PASS +1
* igt@kms_plane@pixel-format-pipe-a-planes-source-clamping:
- shard-glk: FAIL [fdo#108948] -> PASS
* igt@kms_plane@plane-position-covered-pipe-c-planes:
- shard-apl: FAIL [fdo#103166] -> PASS +1
- shard-kbl: FAIL [fdo#103166] -> PASS
* igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
- shard-glk: FAIL [fdo#103166] -> PASS +5
* igt@kms_rotation_crc@multiplane-rotation-cropping-bottom:
- shard-kbl: DMESG-FAIL [fdo#105763] -> PASS
* igt@kms_vblank@pipe-b-ts-continuation-dpms-rpm:
- shard-apl: FAIL [fdo#104894] -> PASS
- shard-kbl: FAIL [fdo#104894] -> PASS
#### Warnings ####
* igt@runner@aborted:
- shard-glk: FAIL [fdo#109373] / [k.org#202321] -> ( 2 FAIL ) [fdo#109373] / [k.org#202321]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
[fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105454]: https://bugs.freedesktop.org/show_bug.cgi?id=105454
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#106509]: https://bugs.freedesktop.org/show_bug.cgi?id=106509
[fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
[fdo#108739]: https://bugs.freedesktop.org/show_bug.cgi?id=108739
[fdo#108948]: https://bugs.freedesktop.org/show_bug.cgi?id=108948
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109350]: https://bugs.freedesktop.org/show_bug.cgi?id=109350
[fdo#109373]: https://bugs.freedesktop.org/show_bug.cgi?id=109373
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
[k.org#202321]: https://bugzilla.kernel.org/show_bug.cgi?id=202321
Participating hosts (7 -> 5)
------------------------------
Missing (2): shard-skl shard-iclb
Build changes
-------------
* IGT: IGT_4844 -> IGTPW_2458
CI_DRM_5636: b33b7e4ffb889d3d3e03ad9b64d0fe15dd2184b4 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2458: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2458/
IGT_4844: ee6e006202a50c5aef373c0b075027ed7177935a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2458/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 42+ messages in thread
* [igt-dev] [PATCH i-g-t] tests/kms_lease: exercise uevent
2019-02-20 16:25 ` [igt-dev] [PATCH i-g-t 9/9] tests/kms_lease: exercise uevent Daniel Vetter
@ 2019-02-20 20:33 ` Daniel Vetter
2019-02-20 22:25 ` Lyude Paul
2019-02-20 21:01 ` Daniel Vetter
2019-02-20 21:17 ` Daniel Vetter
2 siblings, 1 reply; 42+ messages in thread
From: Daniel Vetter @ 2019-02-20 20:33 UTC (permalink / raw)
To: IGT development; +Cc: Keith Packard, Daniel Vetter
And make sure we get the LEASE=1 value, indicating a lessee change.
v2: Apparently netlink reading can leak EAGAIN out through
udev_monitor_receive_device. No idea what's going on there, so let's
wrap some duct tape around it.
Cc: Keith Packard <keithp@keithp.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
tests/kms_lease.c | 68 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 68 insertions(+)
diff --git a/tests/kms_lease.c b/tests/kms_lease.c
index d082a7988eaa..6fe91615a70d 100644
--- a/tests/kms_lease.c
+++ b/tests/kms_lease.c
@@ -40,6 +40,8 @@
#include <sys/time.h>
#include <sys/wait.h>
+#include <libudev.h>
+
#include <drm.h>
IGT_TEST_DESCRIPTION("Test of CreateLease.");
@@ -976,6 +978,69 @@ static void implicit_plane_lease(data_t *data)
drmSetClientCap(data->master.fd, DRM_CLIENT_CAP_UNIVERSAL_PLANES, 1);
}
+static void lease_uevent(data_t *data)
+{
+ int lease_fd;
+ struct local_drm_mode_list_lessees mll;
+ struct udev_monitor *uevent_monitor;
+ struct udev *udev;
+ struct udev_device *dev;
+ const char *lease;
+ struct pollfd udev_fd;
+
+ udev = udev_new();
+ igt_assert(udev);
+
+ uevent_monitor = udev_monitor_new_from_netlink(udev, "udev");
+ igt_assert(uevent_monitor);
+
+ do_or_die(udev_monitor_filter_add_match_subsystem_devtype(uevent_monitor,
+ "drm",
+ "drm_minor"));
+ do_or_die(udev_monitor_enable_receiving(uevent_monitor));
+
+ /* netlink is not synchronous ... */
+ udev_fd.fd = udev_monitor_get_fd(uevent_monitor);
+ udev_fd.revents = 0;
+ udev_fd.events = POLLIN;
+
+ poll(&udev_fd, 1, 100);
+ dev = udev_monitor_receive_device(uevent_monitor);
+ igt_assert(!dev);
+
+ lease_fd = create_simple_lease(data->master.fd, data);
+
+ poll(&udev_fd, 1, 100);
+ dev = udev_monitor_receive_device(uevent_monitor);
+ igt_assert(!dev);
+
+ mll.pad = 0;
+ mll.count_lessees = 0;
+ mll.lessees_ptr = 0;
+ igt_assert_eq(list_lessees(data->master.fd, &mll), 0);
+ igt_assert_eq(mll.count_lessees, 1);
+
+ close(lease_fd);
+
+ poll(&udev_fd, 1, 100);
+ do {
+ dev = udev_monitor_receive_device(uevent_monitor);
+ } while (!dev && errno == EAGAIN);
+ igt_assert(dev);
+
+ lease = udev_device_get_property_value(dev, "LEASE");
+ igt_assert(lease);
+ igt_assert(strcmp(lease, "1") == 0);
+
+ udev_device_unref(dev);
+
+ mll.lessees_ptr = 0;
+ igt_assert_eq(list_lessees(data->master.fd, &mll), 0);
+ igt_assert_eq(mll.count_lessees, 0);
+
+ udev_monitor_unref(uevent_monitor);
+}
+
igt_main
{
data_t data;
@@ -1023,4 +1088,7 @@ igt_main
igt_subtest("implicit-plane-lease")
implicit_plane_lease(&data);
+
+ igt_subtest("lease-uevent")
+ lease_uevent(&data);
}
--
2.14.4
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 42+ messages in thread
* Re: [igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests
2019-02-20 19:51 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
@ 2019-02-20 20:42 ` Daniel Vetter
0 siblings, 0 replies; 42+ messages in thread
From: Daniel Vetter @ 2019-02-20 20:42 UTC (permalink / raw)
To: igt-dev
On Wed, Feb 20, 2019 at 07:51:47PM -0000, Patchwork wrote:
> == Series Details ==
>
> Series: series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests
> URL : https://patchwork.freedesktop.org/series/56970/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from IGT_4844_full -> IGTPW_2458_full
> ====================================================
>
> Summary
> -------
>
> **FAILURE**
>
> Serious unknown changes coming with IGTPW_2458_full absolutely need to be
> verified manually.
>
> If you think the reported changes have nothing to do with the changes
> introduced in IGTPW_2458_full, please notify your bug team to allow them
> to document this new failure mode, which will reduce false positives in CI.
>
> External URL: https://patchwork.freedesktop.org/api/1.0/series/56970/revisions/1/mbox/
>
> Possible new issues
> -------------------
>
> Here are the unknown changes that may have been introduced in IGTPW_2458_full:
>
> ### IGT changes ###
>
> #### Possible regressions ####
>
> * {igt@kms_lease@invalid-create-leases} (NEW):
> - shard-kbl: NOTRUN -> DMESG-WARN
> - shard-hsw: NOTRUN -> DMESG-WARN
> - shard-snb: NOTRUN -> DMESG-WARN
> - shard-glk: NOTRUN -> DMESG-WARN
> - shard-apl: NOTRUN -> DMESG-WARN
Submitted a core mm patch to shut these up:
https://patchwork.freedesktop.org/patch/287139/
We might need to put that one into our fixup branch :-/
> * {igt@kms_lease@lease-uevent} (NEW):
> - shard-apl: NOTRUN -> FAIL +1
EAGAIN from udev. v2 has more duct-tape.
> * igt@runner@aborted:
> - shard-hsw: NOTRUN -> FAIL
> - shard-snb: NOTRUN -> FAIL
> - shard-kbl: NOTRUN -> FAIL
Not exactly sure what's happening here, my tests didnt kill the machine
really. But there's lots of fail around. Let's see whether this sticks
around for v2.
-Daniel
>
>
> New tests
> ---------
>
> New tests have been introduced between IGT_4844_full and IGTPW_2458_full:
>
> ### New IGT tests (7) ###
>
> * igt@kms_lease@implicit-plane-lease:
> - Statuses : 5 pass(s)
> - Exec time: [0.00] s
>
> * igt@kms_lease@invalid-create-leases:
> - Statuses : 5 dmesg-warn(s)
> - Exec time: [0.00, 0.01] s
>
> * igt@kms_lease@lease-uevent:
> - Statuses : 1 fail(s) 3 pass(s)
> - Exec time: [0.21, 1.25] s
>
> * igt@kms_lease@lease_invalid_plane:
> - Statuses : 5 pass(s)
> - Exec time: [0.0] s
>
> * igt@kms_lease@master-vs-lease:
> - Statuses : 4 pass(s)
> - Exec time: [0.0, 0.00] s
>
> * igt@kms_lease@multimaster-lease:
> - Statuses : 2 pass(s)
> - Exec time: [0.00] s
>
> * igt@kms_lease@possible-crtcs-filtering:
> - Statuses : 5 pass(s)
> - Exec time: [0.00, 0.01] s
>
>
>
> Known issues
> ------------
>
> Here are the changes found in IGTPW_2458_full that come from known issues:
>
> ### IGT changes ###
>
> #### Issues hit ####
>
> * igt@gem_exec_schedule@preempt-other-chain-blt:
> - shard-snb: NOTRUN -> SKIP [fdo#109271] +174
>
> * igt@kms_atomic_transition@3x-modeset-transitions-nonblocking-fencing:
> - shard-kbl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
>
> * igt@kms_busy@basic-modeset-f:
> - shard-glk: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +2
>
> * igt@kms_busy@extended-modeset-hang-newfb-render-a:
> - shard-hsw: NOTRUN -> DMESG-WARN [fdo#107956]
>
> * igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-a:
> - shard-glk: NOTRUN -> DMESG-WARN [fdo#107956]
>
> * igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-d:
> - shard-apl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
>
> * igt@kms_color@pipe-a-ctm-max:
> - shard-glk: NOTRUN -> FAIL [fdo#108147]
>
> * igt@kms_color@pipe-b-degamma:
> - shard-apl: PASS -> FAIL [fdo#104782]
>
> * igt@kms_cursor_crc@cursor-128x42-sliding:
> - shard-kbl: PASS -> FAIL [fdo#103232]
> - shard-apl: PASS -> FAIL [fdo#103232] +4
>
> * igt@kms_cursor_crc@cursor-256x256-sliding:
> - shard-glk: NOTRUN -> FAIL [fdo#103232]
>
> * igt@kms_cursor_crc@cursor-256x256-suspend:
> - shard-apl: PASS -> FAIL [fdo#103191] / [fdo#103232]
>
> * igt@kms_cursor_crc@cursor-alpha-opaque:
> - shard-apl: PASS -> FAIL [fdo#109350]
>
> * igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic:
> - shard-glk: NOTRUN -> FAIL [fdo#105454] / [fdo#106509]
>
> * igt@kms_flip@2x-plain-flip-ts-check:
> - shard-apl: NOTRUN -> SKIP [fdo#109271] +18
>
> * igt@kms_flip@flip-vs-expired-vblank-interruptible:
> - shard-glk: PASS -> FAIL [fdo#105363]
>
> * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
> - shard-apl: PASS -> FAIL [fdo#103167] +1
>
> * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-cpu:
> - shard-glk: PASS -> FAIL [fdo#103167] +8
>
> * igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-mmap-wc:
> - shard-kbl: NOTRUN -> SKIP [fdo#109271] +22
>
> * igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-blt:
> - shard-hsw: NOTRUN -> SKIP [fdo#109271] +54
>
> * igt@kms_frontbuffer_tracking@psr-2p-scndscrn-shrfb-msflip-blt:
> - shard-glk: NOTRUN -> SKIP [fdo#109271] +30
>
> * igt@kms_plane@plane-position-covered-pipe-b-planes:
> - shard-kbl: PASS -> FAIL [fdo#103166] +1
>
> * igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb:
> - shard-snb: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +21
>
> * igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max:
> - shard-glk: PASS -> FAIL [fdo#108145] +2
>
> * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
> - shard-hsw: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +2
>
> * igt@kms_plane_multiple@atomic-pipe-c-tiling-none:
> - shard-apl: PASS -> FAIL [fdo#103166] +1
>
> * igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
> - shard-apl: NOTRUN -> FAIL [fdo#103166]
>
> * igt@kms_setmode@basic:
> - shard-apl: PASS -> FAIL [fdo#99912]
>
> * igt@kms_universal_plane@universal-plane-pipe-c-functional:
> - shard-glk: PASS -> FAIL [fdo#103166] +5
>
> * igt@kms_vblank@pipe-c-ts-continuation-suspend:
> - shard-apl: PASS -> FAIL [fdo#104894]
> - shard-kbl: PASS -> FAIL [fdo#104894]
>
>
> #### Possible fixes ####
>
> * igt@i915_pm_rpm@system-suspend:
> - shard-kbl: INCOMPLETE [fdo#103665] / [fdo#107807] -> PASS
>
> * igt@kms_atomic_transition@plane-all-modeset-transition:
> - shard-kbl: INCOMPLETE [fdo#103665] -> PASS +1
>
> * igt@kms_atomic_transition@plane-all-modeset-transition-fencing:
> - shard-apl: INCOMPLETE [fdo#103927] -> PASS +1
>
> * igt@kms_color@pipe-c-legacy-gamma:
> - shard-apl: FAIL [fdo#104782] -> PASS
>
> * igt@kms_cursor_crc@cursor-128x128-random:
> - shard-apl: FAIL [fdo#103232] -> PASS +4
>
> * igt@kms_cursor_crc@cursor-128x128-suspend:
> - shard-apl: FAIL [fdo#103191] / [fdo#103232] -> PASS
> - shard-kbl: FAIL [fdo#103191] / [fdo#103232] -> PASS
>
> * igt@kms_cursor_crc@cursor-64x64-onscreen:
> - shard-kbl: FAIL [fdo#103232] -> PASS
>
> * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc:
> - shard-glk: FAIL [fdo#103167] -> PASS +1
>
> * igt@kms_plane@pixel-format-pipe-a-planes-source-clamping:
> - shard-glk: FAIL [fdo#108948] -> PASS
>
> * igt@kms_plane@plane-position-covered-pipe-c-planes:
> - shard-apl: FAIL [fdo#103166] -> PASS +1
> - shard-kbl: FAIL [fdo#103166] -> PASS
>
> * igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
> - shard-glk: FAIL [fdo#103166] -> PASS +5
>
> * igt@kms_rotation_crc@multiplane-rotation-cropping-bottom:
> - shard-kbl: DMESG-FAIL [fdo#105763] -> PASS
>
> * igt@kms_vblank@pipe-b-ts-continuation-dpms-rpm:
> - shard-apl: FAIL [fdo#104894] -> PASS
> - shard-kbl: FAIL [fdo#104894] -> PASS
>
>
> #### Warnings ####
>
> * igt@runner@aborted:
> - shard-glk: FAIL [fdo#109373] / [k.org#202321] -> ( 2 FAIL ) [fdo#109373] / [k.org#202321]
>
>
> {name}: This element is suppressed. This means it is ignored when computing
> the status of the difference (SUCCESS, WARNING, or FAILURE).
>
> [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
> [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
> [fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
> [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
> [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
> [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
> [fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
> [fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894
> [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
> [fdo#105454]: https://bugs.freedesktop.org/show_bug.cgi?id=105454
> [fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
> [fdo#106509]: https://bugs.freedesktop.org/show_bug.cgi?id=106509
> [fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
> [fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
> [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
> [fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
> [fdo#108739]: https://bugs.freedesktop.org/show_bug.cgi?id=108739
> [fdo#108948]: https://bugs.freedesktop.org/show_bug.cgi?id=108948
> [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
> [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
> [fdo#109350]: https://bugs.freedesktop.org/show_bug.cgi?id=109350
> [fdo#109373]: https://bugs.freedesktop.org/show_bug.cgi?id=109373
> [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
> [k.org#202321]: https://bugzilla.kernel.org/show_bug.cgi?id=202321
>
>
> Participating hosts (7 -> 5)
> ------------------------------
>
> Missing (2): shard-skl shard-iclb
>
>
> Build changes
> -------------
>
> * IGT: IGT_4844 -> IGTPW_2458
>
> CI_DRM_5636: b33b7e4ffb889d3d3e03ad9b64d0fe15dd2184b4 @ git://anongit.freedesktop.org/gfx-ci/linux
> IGTPW_2458: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2458/
> IGT_4844: ee6e006202a50c5aef373c0b075027ed7177935a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
>
> == Logs ==
>
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2458/
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 3/9] tests/kms_lease: invalid corner-cases for create-lease ioctl
2019-02-20 16:25 ` [igt-dev] [PATCH i-g-t 3/9] tests/kms_lease: invalid corner-cases for create-lease ioctl Daniel Vetter
@ 2019-02-20 20:43 ` Lyude Paul
2019-02-20 21:20 ` Daniel Vetter
2019-02-20 21:23 ` [igt-dev] [PATCH i-g-t] " Daniel Vetter
2019-02-21 3:08 ` [igt-dev] [PATCH i-g-t 3/9] " Keith Packard
2 siblings, 1 reply; 42+ messages in thread
From: Lyude Paul @ 2019-02-20 20:43 UTC (permalink / raw)
To: Daniel Vetter, IGT development; +Cc: Keith Packard
On Wed, 2019-02-20 at 17:25 +0100, Daniel Vetter wrote:
> Found a few things in the kernel that looks suspicious, separate
> patches on their way.
>
> I also reviewed coverage for list-lesses and get-lease, and coverage
> seems complete for these.
>
> Cc: Keith Packard <keithp@keithp.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> tests/kms_lease.c | 100
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 100 insertions(+)
>
> diff --git a/tests/kms_lease.c b/tests/kms_lease.c
> index fa97f6e11334..4062a0b365c9 100644
> --- a/tests/kms_lease.c
> +++ b/tests/kms_lease.c
> @@ -623,6 +623,103 @@ static void run_test(data_t *data, void
> (*testfunc)(data_t *))
> "no valid crtc/connector combinations found\n");
> }
>
> +static void invalid_create_leases(data_t *data)
> +{
> + uint32_t object_ids[4];
> + struct local_drm_mode_create_lease mcl;
> + drmModeRes *resources;
> + int tmp_fd;
> +
> + /* empty lease */
> + mcl.object_ids = 0;
> + mcl.object_count = 0;
> + mcl.flags = 0;
> + igt_assert_eq(create_lease(data->master.fd, &mcl), -EINVAL);
> +
> + /* NULL array pointer */
> + mcl.object_count = 1;
> + igt_assert_eq(create_lease(data->master.fd, &mcl), -EFAULT);
> +
> + /* nil object */
> + object_ids[0] = 0;
> + mcl.object_ids = (uint64_t) (uintptr_t) object_ids;
> + mcl.object_count = 1;
> + igt_assert_eq(create_lease(data->master.fd, &mcl), -ENOENT);
> +
> + /* no crtc, non-universal_plane */
> + drmSetClientCap(data->master.fd, DRM_CLIENT_CAP_UNIVERSAL_PLANES, 0);
> + object_ids[0] = data->master.display.outputs[0].id;
> + igt_assert_eq(create_lease(data->master.fd, &mcl), -EINVAL);
> +
> + /* no connector, non-universal_plane */
> + object_ids[0] = data->master.display.pipes[0].crtc_id;
> + igt_assert_eq(create_lease(data->master.fd, &mcl), -EINVAL);
> +
> + /* sanity check */
> + object_ids[0] = data->master.display.pipes[0].crtc_id;
> + object_ids[1] = data->master.display.outputs[0].id;
> + mcl.object_count = 2;
> + igt_assert_eq(create_lease(data->master.fd, &mcl), 0);
> + close(mcl.fd);
> +
> + /* no plane, universal planes */
> + drmSetClientCap(data->master.fd, DRM_CLIENT_CAP_UNIVERSAL_PLANES, 1);
> + igt_assert_eq(create_lease(data->master.fd, &mcl), -EINVAL);
> +
> + /* sanity check */
> + object_ids[2] = igt_pipe_get_plane_type(&data-
> >master.display.pipes[0],
> + DRM_PLANE_TYPE_PRIMARY)-
> >drm_plane->plane_id;
> + mcl.object_count = 3;
> + igt_assert_eq(create_lease(data->master.fd, &mcl), 0);
> + close(mcl.fd);
> +
> + /* array overflow */
> + mcl.object_count = UINT32_MAX / sizeof(object_ids[0]) + 1;
> + igt_assert_eq(create_lease(data->master.fd, &mcl), -ENOMEM);
> + mcl.object_count = UINT32_MAX / sizeof(object_ids[0]) + 2;
> + igt_assert_eq(create_lease(data->master.fd, &mcl), -ENOMEM);
> + mcl.object_count = UINT32_MAX / sizeof(object_ids[0]) + 3;
> + igt_assert_eq(create_lease(data->master.fd, &mcl), -ENOMEM);
> + mcl.object_count = UINT32_MAX / sizeof(object_ids[0]) + 4;
> + igt_assert_eq(create_lease(data->master.fd, &mcl), -ENOMEM);
nitpick: could probably make this a loop, up to you
> +
> + /* invalid flags */
> + mcl.object_count = 3;
> + mcl.flags = O_CLOEXEC | O_NONBLOCK;
> + igt_assert_eq(create_lease(data->master.fd, &mcl), 0);
> + close(mcl.fd);
I think I'm missing something. The hunk below this makes sense, but I'm not
quite sure I understand what's happening above here? ^
Besides that, the rest of this patch looks good to me
> + mcl.flags = -1;
> + igt_assert_eq(create_lease(data->master.fd, &mcl), -EINVAL);
> +
> + /* no subleasing */
> + mcl.object_count = 3;
> + mcl.flags = 0;
> + igt_assert_eq(create_lease(data->master.fd, &mcl), 0);
> + tmp_fd = mcl.fd;
> + igt_assert_eq(create_lease(tmp_fd, &mcl), -EINVAL);
> + close(tmp_fd);
> +
> + /* no double-leasing */
> + igt_assert_eq(create_lease(data->master.fd, &mcl), 0);
> + tmp_fd = mcl.fd;
> + igt_assert_eq(create_lease(data->master.fd, &mcl), -EBUSY);
> + close(tmp_fd);
> +
> + /* no double leasing */
> + object_ids[3] = object_ids[2];
> + mcl.object_count = 4;
> + /* Note: the ENOSPC is from idr double-insertion failing */
> + igt_assert_eq(create_lease(data->master.fd, &mcl), -ENOSPC);
> +
> + /* no encoder leasing */
> + resources = drmModeGetResources(data->master.fd);
> + igt_assert(resources);
> + igt_assert(resources->count_encoders > 0);
> + object_ids[3] = resources->encoders[0];
> + igt_assert_eq(create_lease(data->master.fd, &mcl), -EINVAL);
> + drmModeFreeResources(resources);
> +}
> +
> igt_main
> {
> data_t data;
> @@ -655,4 +752,7 @@ igt_main
> run_test(&data, f->func);
> }
> }
> +
> + igt_subtest("invalid-create-leases")
> + invalid_create_leases(&data);
> }
--
Cheers,
Lyude Paul
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 42+ messages in thread
* [igt-dev] [PATCH i-g-t] tests/kms_lease: exercise uevent
2019-02-20 16:25 ` [igt-dev] [PATCH i-g-t 9/9] tests/kms_lease: exercise uevent Daniel Vetter
2019-02-20 20:33 ` [igt-dev] [PATCH i-g-t] " Daniel Vetter
@ 2019-02-20 21:01 ` Daniel Vetter
2019-02-20 21:17 ` Daniel Vetter
2 siblings, 0 replies; 42+ messages in thread
From: Daniel Vetter @ 2019-02-20 21:01 UTC (permalink / raw)
To: IGT development; +Cc: Keith Packard, Daniel Vetter
And make sure we get the LEASE=1 value, indicating a lessee change.
v2: Apparently netlink reading can leak EAGAIN out through
udev_monitor_receive_device. No idea what's going on there, so let's
wrap some duct tape around it.
v3: Lyude reported that we might get a few udev events on startup of
the test. Drain those first.
Cc: Lyude Paul <lyude@redhat.com>
Cc: Keith Packard <keithp@keithp.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
tests/kms_lease.c | 67 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 67 insertions(+)
diff --git a/tests/kms_lease.c b/tests/kms_lease.c
index d082a7988eaa..a2f85b664724 100644
--- a/tests/kms_lease.c
+++ b/tests/kms_lease.c
@@ -40,6 +40,8 @@
#include <sys/time.h>
#include <sys/wait.h>
+#include <libudev.h>
+
#include <drm.h>
IGT_TEST_DESCRIPTION("Test of CreateLease.");
@@ -976,6 +978,68 @@ static void implicit_plane_lease(data_t *data)
drmSetClientCap(data->master.fd, DRM_CLIENT_CAP_UNIVERSAL_PLANES, 1);
}
+static void lease_uevent(data_t *data)
+{
+ int lease_fd;
+ struct local_drm_mode_list_lessees mll;
+ struct udev_monitor *uevent_monitor;
+ struct udev *udev;
+ struct udev_device *dev;
+ const char *lease;
+ struct pollfd udev_fd;
+
+ udev = udev_new();
+ igt_assert(udev);
+
+ uevent_monitor = udev_monitor_new_from_netlink(udev, "udev");
+ igt_assert(uevent_monitor);
+
+ do_or_die(udev_monitor_filter_add_match_subsystem_devtype(uevent_monitor,
+ "drm",
+ "drm_minor"));
+ do_or_die(udev_monitor_enable_receiving(uevent_monitor));
+
+ while ((dev = udev_monitor_receive_device(uevent_monitor)))
+ udev_device_unref(dev);
+
+ lease_fd = create_simple_lease(data->master.fd, data);
+
+ /* netlink is not synchronous ... */
+ udev_fd.fd = udev_monitor_get_fd(uevent_monitor);
+ udev_fd.revents = 0;
+ udev_fd.events = POLLIN;
+
+ poll(&udev_fd, 1, 100);
+ dev = udev_monitor_receive_device(uevent_monitor);
+ igt_assert(!dev);
+
+ mll.pad = 0;
+ mll.count_lessees = 0;
+ mll.lessees_ptr = 0;
+ igt_assert_eq(list_lessees(data->master.fd, &mll), 0);
+ igt_assert_eq(mll.count_lessees, 1);
+
+ close(lease_fd);
+
+ poll(&udev_fd, 1, 100);
+ do {
+ dev = udev_monitor_receive_device(uevent_monitor);
+ } while (!dev && errno == EAGAIN);
+ igt_assert(dev);
+
+ lease = udev_device_get_property_value(dev, "LEASE");
+ igt_assert(lease);
+ igt_assert(strcmp(lease, "1") == 0);
+
+ udev_device_unref(dev);
+
+ mll.lessees_ptr = 0;
+ igt_assert_eq(list_lessees(data->master.fd, &mll), 0);
+ igt_assert_eq(mll.count_lessees, 0);
+
+ udev_monitor_unref(uevent_monitor);
+}
+
igt_main
{
data_t data;
@@ -1023,4 +1087,7 @@ igt_main
igt_subtest("implicit-plane-lease")
implicit_plane_lease(&data);
+
+ igt_subtest("lease-uevent")
+ lease_uevent(&data);
}
--
2.14.4
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 42+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests (rev2)
2019-02-20 16:25 [igt-dev] [PATCH i-g-t 1/9] tests/kms_lease: Add invalid planes tests Daniel Vetter
` (9 preceding siblings ...)
2019-02-20 19:51 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
@ 2019-02-20 21:11 ` Patchwork
2019-02-20 21:51 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests (rev3) Patchwork
` (12 subsequent siblings)
23 siblings, 0 replies; 42+ messages in thread
From: Patchwork @ 2019-02-20 21:11 UTC (permalink / raw)
To: igt-dev
== Series Details ==
Series: series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests (rev2)
URL : https://patchwork.freedesktop.org/series/56970/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5642 -> IGTPW_2460
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/56970/revisions/2/mbox/
Known issues
------------
Here are the changes found in IGTPW_2460 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_basic@readonly-bsd2:
- fi-pnv-d510: NOTRUN -> SKIP [fdo#109271] +71
* igt@kms_busy@basic-flip-c:
- fi-skl-6770hq: PASS -> SKIP [fdo#109271] / [fdo#109278] +2
- fi-pnv-d510: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: PASS -> FAIL [fdo#109485]
* igt@kms_flip@basic-flip-vs-dpms:
- fi-skl-6770hq: PASS -> SKIP [fdo#109271] +31
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- fi-blb-e6850: PASS -> INCOMPLETE [fdo#107718]
#### Possible fixes ####
* igt@gem_ctx_switch@basic-default:
- {fi-icl-y}: INCOMPLETE [fdo#108569] -> PASS
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- fi-byt-clapper: FAIL [fdo#103191] / [fdo#107362] -> PASS +1
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#105998]: https://bugs.freedesktop.org/show_bug.cgi?id=105998
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109294]: https://bugs.freedesktop.org/show_bug.cgi?id=109294
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109485]: https://bugs.freedesktop.org/show_bug.cgi?id=109485
[fdo#109527]: https://bugs.freedesktop.org/show_bug.cgi?id=109527
[fdo#109528]: https://bugs.freedesktop.org/show_bug.cgi?id=109528
[fdo#109530]: https://bugs.freedesktop.org/show_bug.cgi?id=109530
Participating hosts (45 -> 40)
------------------------------
Additional (1): fi-pnv-d510
Missing (6): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-ilk-650 fi-bdw-samus
Build changes
-------------
* IGT: IGT_4844 -> IGTPW_2460
CI_DRM_5642: c35913ab36f318bf8981f9b3576035a95659591e @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2460: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2460/
IGT_4844: ee6e006202a50c5aef373c0b075027ed7177935a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Testlist changes ==
+igt@kms_lease@implicit-plane-lease
+igt@kms_lease@invalid-create-leases
+igt@kms_lease@lease-uevent
+igt@kms_lease@lease_invalid_plane
+igt@kms_lease@master-vs-lease
+igt@kms_lease@multimaster-lease
+igt@kms_lease@possible-crtcs-filtering
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2460/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 42+ messages in thread
* [igt-dev] [PATCH i-g-t] tests/kms_lease: exercise uevent
2019-02-20 16:25 ` [igt-dev] [PATCH i-g-t 9/9] tests/kms_lease: exercise uevent Daniel Vetter
2019-02-20 20:33 ` [igt-dev] [PATCH i-g-t] " Daniel Vetter
2019-02-20 21:01 ` Daniel Vetter
@ 2019-02-20 21:17 ` Daniel Vetter
2019-02-20 23:42 ` Lyude Paul
2 siblings, 1 reply; 42+ messages in thread
From: Daniel Vetter @ 2019-02-20 21:17 UTC (permalink / raw)
To: IGT development; +Cc: Keith Packard, Daniel Vetter
And make sure we get the LEASE=1 value, indicating a lessee change.
v2: Apparently netlink reading can leak EAGAIN out through
udev_monitor_receive_device. No idea what's going on there, so let's
wrap some duct tape around it.
v3: Lyude reported that we might get a few udev events on startup of
the test. Drain those first.
v4: Use the igt hotplug library functions, they already take care of
all the uevent special cases.
Cc: Lyude Paul <lyude@redhat.com>
Cc: Keith Packard <keithp@keithp.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
lib/igt_kms.c | 42 +++++++++++++++++++++++++++++++-----------
lib/igt_kms.h | 2 ++
tests/kms_lease.c | 36 ++++++++++++++++++++++++++++++++++++
3 files changed, 69 insertions(+), 11 deletions(-)
diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index 85a911e11060..8f0b79d7727b 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -4019,16 +4019,8 @@ struct udev_monitor *igt_watch_hotplug(void)
return mon;
}
-/**
- * igt_hotplug_detected:
- * @mon: A udev monitor initialized with #igt_watch_hotplug
- * @timeout_secs: How long to wait for a hotplug event to occur.
- *
- * Assert that a hotplug event was received since we last checked the monitor.
- *
- * Returns: true if a sysfs hotplug event was received, false if we timed out
- */
-bool igt_hotplug_detected(struct udev_monitor *mon, int timeout_secs)
+static bool event_detected(struct udev_monitor *mon, int timeout_secs,
+ const char *property)
{
struct udev_device *dev;
const char *hotplug_val;
@@ -4046,7 +4038,7 @@ bool igt_hotplug_detected(struct udev_monitor *mon, int timeout_secs)
while (!hotplug_received && poll(&fd, 1, timeout_secs * 1000)) {
dev = udev_monitor_receive_device(mon);
- hotplug_val = udev_device_get_property_value(dev, "HOTPLUG");
+ hotplug_val = udev_device_get_property_value(dev, property);
if (hotplug_val && atoi(hotplug_val) == 1)
hotplug_received = true;
@@ -4056,6 +4048,34 @@ bool igt_hotplug_detected(struct udev_monitor *mon, int timeout_secs)
return hotplug_received;
}
+/**
+ * igt_hotplug_detected:
+ * @mon: A udev monitor initialized with #igt_watch_hotplug
+ * @timeout_secs: How long to wait for a hotplug event to occur.
+ *
+ * Assert that a hotplug event was received since we last checked the monitor.
+ *
+ * Returns: true if a sysfs hotplug event was received, false if we timed out
+ */
+bool igt_hotplug_detected(struct udev_monitor *mon, int timeout_secs)
+{
+ return event_detected(mon, timeout_secs, "HOTPLUG");
+}
+
+/**
+ * igt_lease_change_detected:
+ * @mon: A udev monitor initialized with #igt_watch_hotplug
+ * @timeout_secs: How long to wait for a lease change event to occur.
+ *
+ * Assert that a lease change event was received since we last checked the monitor.
+ *
+ * Returns: true if a sysfs lease change event was received, false if we timed out
+ */
+bool igt_lease_change_detected(struct udev_monitor *mon, int timeout_secs)
+{
+ return event_detected(mon, timeout_secs, "LEASE");
+}
+
/**
* igt_flush_hotplugs:
* @mon: A udev monitor initialized with #igt_watch_hotplug
diff --git a/lib/igt_kms.h b/lib/igt_kms.h
index 679d4e84fab8..5755b160d13e 100644
--- a/lib/igt_kms.h
+++ b/lib/igt_kms.h
@@ -749,6 +749,8 @@ const unsigned char* igt_kms_get_alt_edid(void);
struct udev_monitor *igt_watch_hotplug(void);
bool igt_hotplug_detected(struct udev_monitor *mon,
int timeout_secs);
+bool igt_lease_change_detected(struct udev_monitor *mon,
+ int timeout_secs);
void igt_flush_hotplugs(struct udev_monitor *mon);
void igt_cleanup_hotplug(struct udev_monitor *mon);
diff --git a/tests/kms_lease.c b/tests/kms_lease.c
index d082a7988eaa..600f6779561d 100644
--- a/tests/kms_lease.c
+++ b/tests/kms_lease.c
@@ -40,6 +40,8 @@
#include <sys/time.h>
#include <sys/wait.h>
+#include <libudev.h>
+
#include <drm.h>
IGT_TEST_DESCRIPTION("Test of CreateLease.");
@@ -976,6 +978,37 @@ static void implicit_plane_lease(data_t *data)
drmSetClientCap(data->master.fd, DRM_CLIENT_CAP_UNIVERSAL_PLANES, 1);
}
+static void lease_uevent(data_t *data)
+{
+ int lease_fd;
+ struct local_drm_mode_list_lessees mll;
+ struct udev_monitor *uevent_monitor;
+
+ uevent_monitor = igt_watch_hotplug();
+
+ igt_flush_hotplugs(uevent_monitor);
+
+ lease_fd = create_simple_lease(data->master.fd, data);
+
+ igt_assert(!igt_lease_change_detected(uevent_monitor, 1));
+
+ mll.pad = 0;
+ mll.count_lessees = 0;
+ mll.lessees_ptr = 0;
+ igt_assert_eq(list_lessees(data->master.fd, &mll), 0);
+ igt_assert_eq(mll.count_lessees, 1);
+
+ close(lease_fd);
+
+ igt_assert(igt_lease_change_detected(uevent_monitor, 1));
+
+ mll.lessees_ptr = 0;
+ igt_assert_eq(list_lessees(data->master.fd, &mll), 0);
+ igt_assert_eq(mll.count_lessees, 0);
+
+ igt_cleanup_hotplug(uevent_monitor);
+}
+
igt_main
{
data_t data;
@@ -1023,4 +1056,7 @@ igt_main
igt_subtest("implicit-plane-lease")
implicit_plane_lease(&data);
+
+ igt_subtest("lease-uevent")
+ lease_uevent(&data);
}
--
2.14.4
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 42+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 3/9] tests/kms_lease: invalid corner-cases for create-lease ioctl
2019-02-20 20:43 ` Lyude Paul
@ 2019-02-20 21:20 ` Daniel Vetter
0 siblings, 0 replies; 42+ messages in thread
From: Daniel Vetter @ 2019-02-20 21:20 UTC (permalink / raw)
To: Lyude Paul; +Cc: IGT development, Keith Packard
On Wed, Feb 20, 2019 at 03:43:45PM -0500, Lyude Paul wrote:
> On Wed, 2019-02-20 at 17:25 +0100, Daniel Vetter wrote:
> > Found a few things in the kernel that looks suspicious, separate
> > patches on their way.
> >
> > I also reviewed coverage for list-lesses and get-lease, and coverage
> > seems complete for these.
> >
> > Cc: Keith Packard <keithp@keithp.com>
> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> > ---
> > tests/kms_lease.c | 100
> > ++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 100 insertions(+)
> >
> > diff --git a/tests/kms_lease.c b/tests/kms_lease.c
> > index fa97f6e11334..4062a0b365c9 100644
> > --- a/tests/kms_lease.c
> > +++ b/tests/kms_lease.c
> > @@ -623,6 +623,103 @@ static void run_test(data_t *data, void
> > (*testfunc)(data_t *))
> > "no valid crtc/connector combinations found\n");
> > }
> >
> > +static void invalid_create_leases(data_t *data)
> > +{
> > + uint32_t object_ids[4];
> > + struct local_drm_mode_create_lease mcl;
> > + drmModeRes *resources;
> > + int tmp_fd;
> > +
> > + /* empty lease */
> > + mcl.object_ids = 0;
> > + mcl.object_count = 0;
> > + mcl.flags = 0;
> > + igt_assert_eq(create_lease(data->master.fd, &mcl), -EINVAL);
> > +
> > + /* NULL array pointer */
> > + mcl.object_count = 1;
> > + igt_assert_eq(create_lease(data->master.fd, &mcl), -EFAULT);
> > +
> > + /* nil object */
> > + object_ids[0] = 0;
> > + mcl.object_ids = (uint64_t) (uintptr_t) object_ids;
> > + mcl.object_count = 1;
> > + igt_assert_eq(create_lease(data->master.fd, &mcl), -ENOENT);
> > +
> > + /* no crtc, non-universal_plane */
> > + drmSetClientCap(data->master.fd, DRM_CLIENT_CAP_UNIVERSAL_PLANES, 0);
> > + object_ids[0] = data->master.display.outputs[0].id;
> > + igt_assert_eq(create_lease(data->master.fd, &mcl), -EINVAL);
> > +
> > + /* no connector, non-universal_plane */
> > + object_ids[0] = data->master.display.pipes[0].crtc_id;
> > + igt_assert_eq(create_lease(data->master.fd, &mcl), -EINVAL);
> > +
> > + /* sanity check */
> > + object_ids[0] = data->master.display.pipes[0].crtc_id;
> > + object_ids[1] = data->master.display.outputs[0].id;
> > + mcl.object_count = 2;
> > + igt_assert_eq(create_lease(data->master.fd, &mcl), 0);
> > + close(mcl.fd);
> > +
> > + /* no plane, universal planes */
> > + drmSetClientCap(data->master.fd, DRM_CLIENT_CAP_UNIVERSAL_PLANES, 1);
> > + igt_assert_eq(create_lease(data->master.fd, &mcl), -EINVAL);
> > +
> > + /* sanity check */
> > + object_ids[2] = igt_pipe_get_plane_type(&data-
> > >master.display.pipes[0],
> > + DRM_PLANE_TYPE_PRIMARY)-
> > >drm_plane->plane_id;
> > + mcl.object_count = 3;
> > + igt_assert_eq(create_lease(data->master.fd, &mcl), 0);
> > + close(mcl.fd);
> > +
> > + /* array overflow */
> > + mcl.object_count = UINT32_MAX / sizeof(object_ids[0]) + 1;
> > + igt_assert_eq(create_lease(data->master.fd, &mcl), -ENOMEM);
> > + mcl.object_count = UINT32_MAX / sizeof(object_ids[0]) + 2;
> > + igt_assert_eq(create_lease(data->master.fd, &mcl), -ENOMEM);
> > + mcl.object_count = UINT32_MAX / sizeof(object_ids[0]) + 3;
> > + igt_assert_eq(create_lease(data->master.fd, &mcl), -ENOMEM);
> > + mcl.object_count = UINT32_MAX / sizeof(object_ids[0]) + 4;
> > + igt_assert_eq(create_lease(data->master.fd, &mcl), -ENOMEM);
>
> nitpick: could probably make this a loop, up to you
Yeah, will do.
>
> > +
> > + /* invalid flags */
> > + mcl.object_count = 3;
> > + mcl.flags = O_CLOEXEC | O_NONBLOCK;
> > + igt_assert_eq(create_lease(data->master.fd, &mcl), 0);
> > + close(mcl.fd);
>
> I think I'm missing something. The hunk below this makes sense, but I'm not
> quite sure I understand what's happening above here? ^
I like to sprinkle in sanity check tests, to make sure I'm actually
testing what I'm testing. First run something you know should work, then
change one thing (and one thing only), then you'll know the kernel fails
because of that one thing you're testing, and not some strange interaction
which might hide bugs.
I'll add a /* sanity check */ here and move the /* invalid flags */ down.
-Daniel
>
> Besides that, the rest of this patch looks good to me
>
> > + mcl.flags = -1;
> > + igt_assert_eq(create_lease(data->master.fd, &mcl), -EINVAL);
> > +
> > + /* no subleasing */
> > + mcl.object_count = 3;
> > + mcl.flags = 0;
> > + igt_assert_eq(create_lease(data->master.fd, &mcl), 0);
> > + tmp_fd = mcl.fd;
> > + igt_assert_eq(create_lease(tmp_fd, &mcl), -EINVAL);
> > + close(tmp_fd);
> > +
> > + /* no double-leasing */
> > + igt_assert_eq(create_lease(data->master.fd, &mcl), 0);
> > + tmp_fd = mcl.fd;
> > + igt_assert_eq(create_lease(data->master.fd, &mcl), -EBUSY);
> > + close(tmp_fd);
> > +
> > + /* no double leasing */
> > + object_ids[3] = object_ids[2];
> > + mcl.object_count = 4;
> > + /* Note: the ENOSPC is from idr double-insertion failing */
> > + igt_assert_eq(create_lease(data->master.fd, &mcl), -ENOSPC);
> > +
> > + /* no encoder leasing */
> > + resources = drmModeGetResources(data->master.fd);
> > + igt_assert(resources);
> > + igt_assert(resources->count_encoders > 0);
> > + object_ids[3] = resources->encoders[0];
> > + igt_assert_eq(create_lease(data->master.fd, &mcl), -EINVAL);
> > + drmModeFreeResources(resources);
> > +}
> > +
> > igt_main
> > {
> > data_t data;
> > @@ -655,4 +752,7 @@ igt_main
> > run_test(&data, f->func);
> > }
> > }
> > +
> > + igt_subtest("invalid-create-leases")
> > + invalid_create_leases(&data);
> > }
> --
> Cheers,
> Lyude Paul
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 42+ messages in thread
* [igt-dev] [PATCH i-g-t] tests/kms_lease: invalid corner-cases for create-lease ioctl
2019-02-20 16:25 ` [igt-dev] [PATCH i-g-t 3/9] tests/kms_lease: invalid corner-cases for create-lease ioctl Daniel Vetter
2019-02-20 20:43 ` Lyude Paul
@ 2019-02-20 21:23 ` Daniel Vetter
2019-02-21 3:08 ` [igt-dev] [PATCH i-g-t 3/9] " Keith Packard
2 siblings, 0 replies; 42+ messages in thread
From: Daniel Vetter @ 2019-02-20 21:23 UTC (permalink / raw)
To: IGT development; +Cc: Keith Packard
Found a few things in the kernel that looks suspicious, separate
patches on their way.
I also reviewed coverage for list-lesses and get-lease, and coverage
seems complete for these.
v2: Bit of polish to address Lyude's comments.
Cc: Lyude Paul <lyude@redhat.com>
Cc: Keith Packard <keithp@keithp.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
tests/kms_lease.c | 98 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 98 insertions(+)
diff --git a/tests/kms_lease.c b/tests/kms_lease.c
index fa97f6e11334..3fa0aace9b4f 100644
--- a/tests/kms_lease.c
+++ b/tests/kms_lease.c
@@ -623,6 +623,101 @@ static void run_test(data_t *data, void (*testfunc)(data_t *))
"no valid crtc/connector combinations found\n");
}
+static void invalid_create_leases(data_t *data)
+{
+ uint32_t object_ids[4];
+ struct local_drm_mode_create_lease mcl;
+ drmModeRes *resources;
+ int tmp_fd;
+
+ /* empty lease */
+ mcl.object_ids = 0;
+ mcl.object_count = 0;
+ mcl.flags = 0;
+ igt_assert_eq(create_lease(data->master.fd, &mcl), -EINVAL);
+
+ /* NULL array pointer */
+ mcl.object_count = 1;
+ igt_assert_eq(create_lease(data->master.fd, &mcl), -EFAULT);
+
+ /* nil object */
+ object_ids[0] = 0;
+ mcl.object_ids = (uint64_t) (uintptr_t) object_ids;
+ mcl.object_count = 1;
+ igt_assert_eq(create_lease(data->master.fd, &mcl), -ENOENT);
+
+ /* no crtc, non-universal_plane */
+ drmSetClientCap(data->master.fd, DRM_CLIENT_CAP_UNIVERSAL_PLANES, 0);
+ object_ids[0] = data->master.display.outputs[0].id;
+ igt_assert_eq(create_lease(data->master.fd, &mcl), -EINVAL);
+
+ /* no connector, non-universal_plane */
+ object_ids[0] = data->master.display.pipes[0].crtc_id;
+ igt_assert_eq(create_lease(data->master.fd, &mcl), -EINVAL);
+
+ /* sanity check */
+ object_ids[0] = data->master.display.pipes[0].crtc_id;
+ object_ids[1] = data->master.display.outputs[0].id;
+ mcl.object_count = 2;
+ igt_assert_eq(create_lease(data->master.fd, &mcl), 0);
+ close(mcl.fd);
+
+ /* no plane, universal planes */
+ drmSetClientCap(data->master.fd, DRM_CLIENT_CAP_UNIVERSAL_PLANES, 1);
+ igt_assert_eq(create_lease(data->master.fd, &mcl), -EINVAL);
+
+ /* sanity check */
+ object_ids[2] = igt_pipe_get_plane_type(&data->master.display.pipes[0],
+ DRM_PLANE_TYPE_PRIMARY)->drm_plane->plane_id;
+ mcl.object_count = 3;
+ igt_assert_eq(create_lease(data->master.fd, &mcl), 0);
+ close(mcl.fd);
+
+ /* array overflow, do a small scan around overflow sizes */
+ for (int i = 1; i <= 4; i++) {
+ mcl.object_count = UINT32_MAX / sizeof(object_ids[0]) + i;
+ igt_assert_eq(create_lease(data->master.fd, &mcl), -ENOMEM);
+ }
+
+ /* sanity check */
+ mcl.object_count = 3;
+ mcl.flags = O_CLOEXEC | O_NONBLOCK;
+ igt_assert_eq(create_lease(data->master.fd, &mcl), 0);
+ close(mcl.fd);
+
+ /* invalid flags */
+ mcl.flags = -1;
+ igt_assert_eq(create_lease(data->master.fd, &mcl), -EINVAL);
+
+ /* no subleasing */
+ mcl.object_count = 3;
+ mcl.flags = 0;
+ igt_assert_eq(create_lease(data->master.fd, &mcl), 0);
+ tmp_fd = mcl.fd;
+ igt_assert_eq(create_lease(tmp_fd, &mcl), -EINVAL);
+ close(tmp_fd);
+
+ /* no double-leasing */
+ igt_assert_eq(create_lease(data->master.fd, &mcl), 0);
+ tmp_fd = mcl.fd;
+ igt_assert_eq(create_lease(data->master.fd, &mcl), -EBUSY);
+ close(tmp_fd);
+
+ /* no double leasing */
+ object_ids[3] = object_ids[2];
+ mcl.object_count = 4;
+ /* Note: the ENOSPC is from idr double-insertion failing */
+ igt_assert_eq(create_lease(data->master.fd, &mcl), -ENOSPC);
+
+ /* no encoder leasing */
+ resources = drmModeGetResources(data->master.fd);
+ igt_assert(resources);
+ igt_assert(resources->count_encoders > 0);
+ object_ids[3] = resources->encoders[0];
+ igt_assert_eq(create_lease(data->master.fd, &mcl), -EINVAL);
+ drmModeFreeResources(resources);
+}
+
igt_main
{
data_t data;
@@ -655,4 +750,7 @@ igt_main
run_test(&data, f->func);
}
}
+
+ igt_subtest("invalid-create-leases")
+ invalid_create_leases(&data);
}
--
2.14.4
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 42+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests (rev3)
2019-02-20 16:25 [igt-dev] [PATCH i-g-t 1/9] tests/kms_lease: Add invalid planes tests Daniel Vetter
` (10 preceding siblings ...)
2019-02-20 21:11 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests (rev2) Patchwork
@ 2019-02-20 21:51 ` Patchwork
2019-02-20 22:02 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests (rev5) Patchwork
` (11 subsequent siblings)
23 siblings, 0 replies; 42+ messages in thread
From: Patchwork @ 2019-02-20 21:51 UTC (permalink / raw)
To: igt-dev
== Series Details ==
Series: series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests (rev3)
URL : https://patchwork.freedesktop.org/series/56970/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5642 -> IGTPW_2461
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/56970/revisions/3/mbox/
Known issues
------------
Here are the changes found in IGTPW_2461 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_basic@readonly-bsd2:
- fi-pnv-d510: NOTRUN -> SKIP [fdo#109271] +71
* igt@kms_busy@basic-flip-a:
- fi-gdg-551: PASS -> FAIL [fdo#103182]
* igt@kms_busy@basic-flip-c:
- fi-pnv-d510: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-b:
- fi-byt-clapper: PASS -> FAIL [fdo#103191] / [fdo#107362]
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b:
- fi-byt-clapper: PASS -> FAIL [fdo#107362]
#### Possible fixes ####
* igt@gem_ctx_switch@basic-default:
- {fi-icl-y}: INCOMPLETE [fdo#108569] -> PASS
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- fi-byt-clapper: FAIL [fdo#103191] / [fdo#107362] -> PASS +1
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#105998]: https://bugs.freedesktop.org/show_bug.cgi?id=105998
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109294]: https://bugs.freedesktop.org/show_bug.cgi?id=109294
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109527]: https://bugs.freedesktop.org/show_bug.cgi?id=109527
[fdo#109528]: https://bugs.freedesktop.org/show_bug.cgi?id=109528
[fdo#109530]: https://bugs.freedesktop.org/show_bug.cgi?id=109530
Participating hosts (45 -> 41)
------------------------------
Additional (1): fi-pnv-d510
Missing (5): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-bdw-samus
Build changes
-------------
* IGT: IGT_4844 -> IGTPW_2461
CI_DRM_5642: c35913ab36f318bf8981f9b3576035a95659591e @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2461: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2461/
IGT_4844: ee6e006202a50c5aef373c0b075027ed7177935a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Testlist changes ==
+igt@kms_lease@implicit-plane-lease
+igt@kms_lease@invalid-create-leases
+igt@kms_lease@lease-uevent
+igt@kms_lease@lease_invalid_plane
+igt@kms_lease@master-vs-lease
+igt@kms_lease@multimaster-lease
+igt@kms_lease@possible-crtcs-filtering
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2461/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 42+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests (rev5)
2019-02-20 16:25 [igt-dev] [PATCH i-g-t 1/9] tests/kms_lease: Add invalid planes tests Daniel Vetter
` (11 preceding siblings ...)
2019-02-20 21:51 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests (rev3) Patchwork
@ 2019-02-20 22:02 ` Patchwork
2019-02-20 22:26 ` [igt-dev] [PATCH i-g-t 1/9] tests/kms_lease: Add invalid planes tests Lyude Paul
` (10 subsequent siblings)
23 siblings, 0 replies; 42+ messages in thread
From: Patchwork @ 2019-02-20 22:02 UTC (permalink / raw)
To: igt-dev
== Series Details ==
Series: series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests (rev5)
URL : https://patchwork.freedesktop.org/series/56970/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5642 -> IGTPW_2463
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/56970/revisions/5/mbox/
Known issues
------------
Here are the changes found in IGTPW_2463 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@userptr:
- fi-kbl-8809g: PASS -> DMESG-WARN [fdo#108965]
* igt@gem_exec_basic@readonly-bsd2:
- fi-pnv-d510: NOTRUN -> SKIP [fdo#109271] +71
* igt@kms_busy@basic-flip-c:
- fi-pnv-d510: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
#### Possible fixes ####
* igt@i915_selftest@live_execlists:
- fi-apl-guc: INCOMPLETE [fdo#103927] -> PASS
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- fi-byt-clapper: FAIL [fdo#103191] / [fdo#107362] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#108965]: https://bugs.freedesktop.org/show_bug.cgi?id=108965
[fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
Participating hosts (45 -> 41)
------------------------------
Additional (1): fi-pnv-d510
Missing (5): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-bdw-samus
Build changes
-------------
* IGT: IGT_4844 -> IGTPW_2463
CI_DRM_5642: c35913ab36f318bf8981f9b3576035a95659591e @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2463: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2463/
IGT_4844: ee6e006202a50c5aef373c0b075027ed7177935a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Testlist changes ==
+igt@kms_lease@implicit-plane-lease
+igt@kms_lease@invalid-create-leases
+igt@kms_lease@lease-uevent
+igt@kms_lease@lease_invalid_plane
+igt@kms_lease@master-vs-lease
+igt@kms_lease@multimaster-lease
+igt@kms_lease@possible-crtcs-filtering
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2463/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_lease: exercise uevent
2019-02-20 20:33 ` [igt-dev] [PATCH i-g-t] " Daniel Vetter
@ 2019-02-20 22:25 ` Lyude Paul
2019-02-20 23:33 ` Daniel Vetter
0 siblings, 1 reply; 42+ messages in thread
From: Lyude Paul @ 2019-02-20 22:25 UTC (permalink / raw)
To: Daniel Vetter, IGT development; +Cc: Daniel Vetter, Keith Packard
On Wed, 2019-02-20 at 21:33 +0100, Daniel Vetter wrote:
> And make sure we get the LEASE=1 value, indicating a lessee change.
>
> v2: Apparently netlink reading can leak EAGAIN out through
> udev_monitor_receive_device. No idea what's going on there, so let's
> wrap some duct tape around it.
>
> Cc: Keith Packard <keithp@keithp.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
> tests/kms_lease.c | 68
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 68 insertions(+)
>
> diff --git a/tests/kms_lease.c b/tests/kms_lease.c
> index d082a7988eaa..6fe91615a70d 100644
> --- a/tests/kms_lease.c
> +++ b/tests/kms_lease.c
> @@ -40,6 +40,8 @@
> #include <sys/time.h>
> #include <sys/wait.h>
>
> +#include <libudev.h>
> +
> #include <drm.h>
>
> IGT_TEST_DESCRIPTION("Test of CreateLease.");
> @@ -976,6 +978,69 @@ static void implicit_plane_lease(data_t *data)
> drmSetClientCap(data->master.fd, DRM_CLIENT_CAP_UNIVERSAL_PLANES, 1);
> }
>
> +static void lease_uevent(data_t *data)
> +{
> + int lease_fd;
> + struct local_drm_mode_list_lessees mll;
> + struct udev_monitor *uevent_monitor;
> + struct udev *udev;
> + struct udev_device *dev;
> + const char *lease;
> + struct pollfd udev_fd;
> +
> + udev = udev_new();
> + igt_assert(udev);
> +
> + uevent_monitor = udev_monitor_new_from_netlink(udev, "udev");
> + igt_assert(uevent_monitor);
> +
> + do_or_die(udev_monitor_filter_add_match_subsystem_devtype(uevent_monit
> or,
> + "drm",
> + "drm_minor")
> );
> + do_or_die(udev_monitor_enable_receiving(uevent_monitor));
> +
> + /* netlink is not synchronous ... */
> + udev_fd.fd = udev_monitor_get_fd(uevent_monitor);
> + udev_fd.revents = 0;
> + udev_fd.events = POLLIN;
> +
> + poll(&udev_fd, 1, 100);
> + dev = udev_monitor_receive_device(uevent_monitor);
> + igt_assert(!dev);
I think this is a sanity check to ensure there's no leftover events when we
start the test, if I'm correct we should probably leave a comment here
indicating that.
> +
> + lease_fd = create_simple_lease(data->master.fd, data);
> +
> + poll(&udev_fd, 1, 100);
> + dev = udev_monitor_receive_device(uevent_monitor);
> + igt_assert(!dev);
Probably should have a comment explaining what this check for is as well
> +
> + mll.pad = 0;
> + mll.count_lessees = 0;
> + mll.lessees_ptr = 0;
> + igt_assert_eq(list_lessees(data->master.fd, &mll), 0);
> + igt_assert_eq(mll.count_lessees, 1);
> +
> + close(lease_fd);
> +
> + poll(&udev_fd, 1, 100);
> + do {
> + dev = udev_monitor_receive_device(uevent_monitor);
> + } while (!dev && errno == EAGAIN);
> + igt_assert(dev);
> +
> + lease = udev_device_get_property_value(dev, "LEASE");
> + igt_assert(lease);
> + igt_assert(strcmp(lease, "1") == 0);
> +
> + udev_device_unref(dev);
> +
> + mll.lessees_ptr = 0;
> + igt_assert_eq(list_lessees(data->master.fd, &mll), 0);
> + igt_assert_eq(mll.count_lessees, 0);
> +
> + udev_monitor_unref(uevent_monitor);
> +}
> +
> igt_main
> {
> data_t data;
> @@ -1023,4 +1088,7 @@ igt_main
>
> igt_subtest("implicit-plane-lease")
> implicit_plane_lease(&data);
> +
> + igt_subtest("lease-uevent")
> + lease_uevent(&data);
> }
--
Cheers,
Lyude Paul
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 1/9] tests/kms_lease: Add invalid planes tests
2019-02-20 16:25 [igt-dev] [PATCH i-g-t 1/9] tests/kms_lease: Add invalid planes tests Daniel Vetter
` (12 preceding siblings ...)
2019-02-20 22:02 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests (rev5) Patchwork
@ 2019-02-20 22:26 ` Lyude Paul
2019-02-21 1:25 ` [igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests (rev2) Patchwork
` (9 subsequent siblings)
23 siblings, 0 replies; 42+ messages in thread
From: Lyude Paul @ 2019-02-20 22:26 UTC (permalink / raw)
To: Daniel Vetter, IGT development; +Cc: Keith Packard
Alright-minus the few comments I left, this looks good to me. With those
changes:
Reviewed-by: Lyude Paul <lyude@redhat.com>
On Wed, 2019-02-20 at 17:25 +0100, Daniel Vetter wrote:
> Test gap because we're using universal planes by default. Fix that.
>
> Cc: Keith Packard <keithp@keithp.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> tests/kms_lease.c | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/tests/kms_lease.c b/tests/kms_lease.c
> index cca424598ea7..70a96362d77a 100644
> --- a/tests/kms_lease.c
> +++ b/tests/kms_lease.c
> @@ -573,6 +573,20 @@ static void lease_invalid_crtc(data_t *data)
> igt_assert_eq(ret, -EINVAL);
> }
>
> +static void lease_invalid_plane(data_t *data)
> +{
> + lease_t lease;
> + uint32_t save_plane_id;
> + int ret;
> +
> + /* Create an invalid lease */
> + save_plane_id = data->plane_id;
> + data->plane_id = 0xbaadf00d;
> + ret = make_lease(data, &lease);
> + data->plane_id = save_plane_id;
> + igt_assert_eq(ret, -EINVAL);
> +}
> +
>
> static void run_test(data_t *data, void (*testfunc)(data_t *))
> {
> @@ -625,6 +639,7 @@ igt_main
> { "lease_again", lease_again },
> { "lease_invalid_connector", lease_invalid_connector },
> { "lease_invalid_crtc", lease_invalid_crtc },
> + { "lease_invalid_plane", lease_invalid_plane },
> { }
> }, *f;
>
--
Cheers,
Lyude Paul
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_lease: exercise uevent
2019-02-20 22:25 ` Lyude Paul
@ 2019-02-20 23:33 ` Daniel Vetter
2019-02-20 23:34 ` Lyude Paul
0 siblings, 1 reply; 42+ messages in thread
From: Daniel Vetter @ 2019-02-20 23:33 UTC (permalink / raw)
To: Lyude Paul; +Cc: IGT development, Keith Packard, Daniel Vetter
On Wed, Feb 20, 2019 at 05:25:33PM -0500, Lyude Paul wrote:
> On Wed, 2019-02-20 at 21:33 +0100, Daniel Vetter wrote:
> > And make sure we get the LEASE=1 value, indicating a lessee change.
> >
> > v2: Apparently netlink reading can leak EAGAIN out through
> > udev_monitor_receive_device. No idea what's going on there, so let's
> > wrap some duct tape around it.
> >
> > Cc: Keith Packard <keithp@keithp.com>
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > ---
> > tests/kms_lease.c | 68
> > +++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 68 insertions(+)
> >
> > diff --git a/tests/kms_lease.c b/tests/kms_lease.c
> > index d082a7988eaa..6fe91615a70d 100644
> > --- a/tests/kms_lease.c
> > +++ b/tests/kms_lease.c
> > @@ -40,6 +40,8 @@
> > #include <sys/time.h>
> > #include <sys/wait.h>
> >
> > +#include <libudev.h>
> > +
> > #include <drm.h>
> >
> > IGT_TEST_DESCRIPTION("Test of CreateLease.");
> > @@ -976,6 +978,69 @@ static void implicit_plane_lease(data_t *data)
> > drmSetClientCap(data->master.fd, DRM_CLIENT_CAP_UNIVERSAL_PLANES, 1);
> > }
> >
> > +static void lease_uevent(data_t *data)
> > +{
> > + int lease_fd;
> > + struct local_drm_mode_list_lessees mll;
> > + struct udev_monitor *uevent_monitor;
> > + struct udev *udev;
> > + struct udev_device *dev;
> > + const char *lease;
> > + struct pollfd udev_fd;
> > +
> > + udev = udev_new();
> > + igt_assert(udev);
> > +
> > + uevent_monitor = udev_monitor_new_from_netlink(udev, "udev");
> > + igt_assert(uevent_monitor);
> > +
> > + do_or_die(udev_monitor_filter_add_match_subsystem_devtype(uevent_monit
> > or,
> > + "drm",
> > + "drm_minor")
> > );
> > + do_or_die(udev_monitor_enable_receiving(uevent_monitor));
> > +
> > + /* netlink is not synchronous ... */
> > + udev_fd.fd = udev_monitor_get_fd(uevent_monitor);
> > + udev_fd.revents = 0;
> > + udev_fd.events = POLLIN;
> > +
> > + poll(&udev_fd, 1, 100);
> > + dev = udev_monitor_receive_device(uevent_monitor);
> > + igt_assert(!dev);
> I think this is a sanity check to ensure there's no leftover events when we
> start the test, if I'm correct we should probably leave a comment here
> indicating that.
v4 is much prettier, since it uses the library. Can you pls take a look at
that and see whether it's fine? It's a bit a bigger change.
> > +
> > + lease_fd = create_simple_lease(data->master.fd, data);
> > +
> > + poll(&udev_fd, 1, 100);
> > + dev = udev_monitor_receive_device(uevent_monitor);
> > + igt_assert(!dev);
> Probably should have a comment explaining what this check for is as well
Yeah I can add a comment to v4 that we expect no event after create, but
one when the lessee is closed.
Cheers, Daniel
> > +
> > + mll.pad = 0;
> > + mll.count_lessees = 0;
> > + mll.lessees_ptr = 0;
> > + igt_assert_eq(list_lessees(data->master.fd, &mll), 0);
> > + igt_assert_eq(mll.count_lessees, 1);
> > +
> > + close(lease_fd);
> > +
> > + poll(&udev_fd, 1, 100);
> > + do {
> > + dev = udev_monitor_receive_device(uevent_monitor);
> > + } while (!dev && errno == EAGAIN);
> > + igt_assert(dev);
> > +
> > + lease = udev_device_get_property_value(dev, "LEASE");
> > + igt_assert(lease);
> > + igt_assert(strcmp(lease, "1") == 0);
> > +
> > + udev_device_unref(dev);
> > +
> > + mll.lessees_ptr = 0;
> > + igt_assert_eq(list_lessees(data->master.fd, &mll), 0);
> > + igt_assert_eq(mll.count_lessees, 0);
> > +
> > + udev_monitor_unref(uevent_monitor);
> > +}
> > +
> > igt_main
> > {
> > data_t data;
> > @@ -1023,4 +1088,7 @@ igt_main
> >
> > igt_subtest("implicit-plane-lease")
> > implicit_plane_lease(&data);
> > +
> > + igt_subtest("lease-uevent")
> > + lease_uevent(&data);
> > }
> --
> Cheers,
> Lyude Paul
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_lease: exercise uevent
2019-02-20 23:33 ` Daniel Vetter
@ 2019-02-20 23:34 ` Lyude Paul
0 siblings, 0 replies; 42+ messages in thread
From: Lyude Paul @ 2019-02-20 23:34 UTC (permalink / raw)
To: Daniel Vetter; +Cc: IGT development, Keith Packard, Daniel Vetter
On Thu, 2019-02-21 at 00:33 +0100, Daniel Vetter wrote:
> On Wed, Feb 20, 2019 at 05:25:33PM -0500, Lyude Paul wrote:
> > On Wed, 2019-02-20 at 21:33 +0100, Daniel Vetter wrote:
> > > And make sure we get the LEASE=1 value, indicating a lessee change.
> > >
> > > v2: Apparently netlink reading can leak EAGAIN out through
> > > udev_monitor_receive_device. No idea what's going on there, so let's
> > > wrap some duct tape around it.
> > >
> > > Cc: Keith Packard <keithp@keithp.com>
> > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > > ---
> > > tests/kms_lease.c | 68
> > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > > 1 file changed, 68 insertions(+)
> > >
> > > diff --git a/tests/kms_lease.c b/tests/kms_lease.c
> > > index d082a7988eaa..6fe91615a70d 100644
> > > --- a/tests/kms_lease.c
> > > +++ b/tests/kms_lease.c
> > > @@ -40,6 +40,8 @@
> > > #include <sys/time.h>
> > > #include <sys/wait.h>
> > >
> > > +#include <libudev.h>
> > > +
> > > #include <drm.h>
> > >
> > > IGT_TEST_DESCRIPTION("Test of CreateLease.");
> > > @@ -976,6 +978,69 @@ static void implicit_plane_lease(data_t *data)
> > > drmSetClientCap(data->master.fd, DRM_CLIENT_CAP_UNIVERSAL_PLANES, 1);
> > > }
> > >
> > > +static void lease_uevent(data_t *data)
> > > +{
> > > + int lease_fd;
> > > + struct local_drm_mode_list_lessees mll;
> > > + struct udev_monitor *uevent_monitor;
> > > + struct udev *udev;
> > > + struct udev_device *dev;
> > > + const char *lease;
> > > + struct pollfd udev_fd;
> > > +
> > > + udev = udev_new();
> > > + igt_assert(udev);
> > > +
> > > + uevent_monitor = udev_monitor_new_from_netlink(udev, "udev");
> > > + igt_assert(uevent_monitor);
> > > +
> > > + do_or_die(udev_monitor_filter_add_match_subsystem_devtype(uevent_monit
> > > or,
> > > + "drm",
> > > + "drm_minor")
> > > );
> > > + do_or_die(udev_monitor_enable_receiving(uevent_monitor));
> > > +
> > > + /* netlink is not synchronous ... */
> > > + udev_fd.fd = udev_monitor_get_fd(uevent_monitor);
> > > + udev_fd.revents = 0;
> > > + udev_fd.events = POLLIN;
> > > +
> > > + poll(&udev_fd, 1, 100);
> > > + dev = udev_monitor_receive_device(uevent_monitor);
> > > + igt_assert(!dev);
> > I think this is a sanity check to ensure there's no leftover events when
> > we
> > start the test, if I'm correct we should probably leave a comment here
> > indicating that.
>
> v4 is much prettier, since it uses the library. Can you pls take a look at
> that and see whether it's fine? It's a bit a bigger change.
Whoops :), was wondering why I didn't see any igt_hotplug* calls there...
>
> > > +
> > > + lease_fd = create_simple_lease(data->master.fd, data);
> > > +
> > > + poll(&udev_fd, 1, 100);
> > > + dev = udev_monitor_receive_device(uevent_monitor);
> > > + igt_assert(!dev);
> > Probably should have a comment explaining what this check for is as well
>
> Yeah I can add a comment to v4 that we expect no event after create, but
> one when the lessee is closed.
>
> Cheers, Daniel
>
> > > +
> > > + mll.pad = 0;
> > > + mll.count_lessees = 0;
> > > + mll.lessees_ptr = 0;
> > > + igt_assert_eq(list_lessees(data->master.fd, &mll), 0);
> > > + igt_assert_eq(mll.count_lessees, 1);
> > > +
> > > + close(lease_fd);
> > > +
> > > + poll(&udev_fd, 1, 100);
> > > + do {
> > > + dev = udev_monitor_receive_device(uevent_monitor);
> > > + } while (!dev && errno == EAGAIN);
> > > + igt_assert(dev);
> > > +
> > > + lease = udev_device_get_property_value(dev, "LEASE");
> > > + igt_assert(lease);
> > > + igt_assert(strcmp(lease, "1") == 0);
> > > +
> > > + udev_device_unref(dev);
> > > +
> > > + mll.lessees_ptr = 0;
> > > + igt_assert_eq(list_lessees(data->master.fd, &mll), 0);
> > > + igt_assert_eq(mll.count_lessees, 0);
> > > +
> > > + udev_monitor_unref(uevent_monitor);
> > > +}
> > > +
> > > igt_main
> > > {
> > > data_t data;
> > > @@ -1023,4 +1088,7 @@ igt_main
> > >
> > > igt_subtest("implicit-plane-lease")
> > > implicit_plane_lease(&data);
> > > +
> > > + igt_subtest("lease-uevent")
> > > + lease_uevent(&data);
> > > }
> > --
> > Cheers,
> > Lyude Paul
> >
--
Cheers,
Lyude Paul
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_lease: exercise uevent
2019-02-20 21:17 ` Daniel Vetter
@ 2019-02-20 23:42 ` Lyude Paul
2019-02-20 23:48 ` Daniel Vetter
0 siblings, 1 reply; 42+ messages in thread
From: Lyude Paul @ 2019-02-20 23:42 UTC (permalink / raw)
To: Daniel Vetter, IGT development; +Cc: Daniel Vetter, Keith Packard
On Wed, 2019-02-20 at 22:17 +0100, Daniel Vetter wrote:
> And make sure we get the LEASE=1 value, indicating a lessee change.
>
> v2: Apparently netlink reading can leak EAGAIN out through
> udev_monitor_receive_device. No idea what's going on there, so let's
> wrap some duct tape around it.
>
> v3: Lyude reported that we might get a few udev events on startup of
> the test. Drain those first.
>
> v4: Use the igt hotplug library functions, they already take care of
> all the uevent special cases.
>
> Cc: Lyude Paul <lyude@redhat.com>
> Cc: Keith Packard <keithp@keithp.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
> lib/igt_kms.c | 42 +++++++++++++++++++++++++++++++-----------
> lib/igt_kms.h | 2 ++
> tests/kms_lease.c | 36 ++++++++++++++++++++++++++++++++++++
> 3 files changed, 69 insertions(+), 11 deletions(-)
>
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index 85a911e11060..8f0b79d7727b 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -4019,16 +4019,8 @@ struct udev_monitor *igt_watch_hotplug(void)
> return mon;
> }
>
> -/**
> - * igt_hotplug_detected:
> - * @mon: A udev monitor initialized with #igt_watch_hotplug
> - * @timeout_secs: How long to wait for a hotplug event to occur.
> - *
> - * Assert that a hotplug event was received since we last checked the
> monitor.
> - *
> - * Returns: true if a sysfs hotplug event was received, false if we timed
> out
> - */
> -bool igt_hotplug_detected(struct udev_monitor *mon, int timeout_secs)
> +static bool event_detected(struct udev_monitor *mon, int timeout_secs,
> + const char *property)
> {
> struct udev_device *dev;
> const char *hotplug_val;
> @@ -4046,7 +4038,7 @@ bool igt_hotplug_detected(struct udev_monitor *mon,
> int timeout_secs)
> while (!hotplug_received && poll(&fd, 1, timeout_secs * 1000)) {
> dev = udev_monitor_receive_device(mon);
>
> - hotplug_val = udev_device_get_property_value(dev, "HOTPLUG");
> + hotplug_val = udev_device_get_property_value(dev, property);
> if (hotplug_val && atoi(hotplug_val) == 1)
> hotplug_received = true;
>
> @@ -4056,6 +4048,34 @@ bool igt_hotplug_detected(struct udev_monitor *mon,
> int timeout_secs)
> return hotplug_received;
> }
>
> +/**
> + * igt_hotplug_detected:
> + * @mon: A udev monitor initialized with #igt_watch_hotplug
> + * @timeout_secs: How long to wait for a hotplug event to occur.
> + *
> + * Assert that a hotplug event was received since we last checked the
> monitor.
> + *
> + * Returns: true if a sysfs hotplug event was received, false if we timed
> out
> + */
> +bool igt_hotplug_detected(struct udev_monitor *mon, int timeout_secs)
> +{
> + return event_detected(mon, timeout_secs, "HOTPLUG");
> +}
> +
> +/**
> + * igt_lease_change_detected:
> + * @mon: A udev monitor initialized with #igt_watch_hotplug
> + * @timeout_secs: How long to wait for a lease change event to occur.
> + *
> + * Assert that a lease change event was received since we last checked the
> monitor.
> + *
> + * Returns: true if a sysfs lease change event was received, false if we
> timed out
> + */
> +bool igt_lease_change_detected(struct udev_monitor *mon, int timeout_secs)
> +{
> + return event_detected(mon, timeout_secs, "LEASE");
> +}
> +
> /**
> * igt_flush_hotplugs:
> * @mon: A udev monitor initialized with #igt_watch_hotplug
> diff --git a/lib/igt_kms.h b/lib/igt_kms.h
> index 679d4e84fab8..5755b160d13e 100644
> --- a/lib/igt_kms.h
> +++ b/lib/igt_kms.h
> @@ -749,6 +749,8 @@ const unsigned char* igt_kms_get_alt_edid(void);
> struct udev_monitor *igt_watch_hotplug(void);
> bool igt_hotplug_detected(struct udev_monitor *mon,
> int timeout_secs);
> +bool igt_lease_change_detected(struct udev_monitor *mon,
> + int timeout_secs);
> void igt_flush_hotplugs(struct udev_monitor *mon);
> void igt_cleanup_hotplug(struct udev_monitor *mon);
>
> diff --git a/tests/kms_lease.c b/tests/kms_lease.c
> index d082a7988eaa..600f6779561d 100644
> --- a/tests/kms_lease.c
> +++ b/tests/kms_lease.c
> @@ -40,6 +40,8 @@
> #include <sys/time.h>
> #include <sys/wait.h>
>
> +#include <libudev.h>
> +
> #include <drm.h>
>
> IGT_TEST_DESCRIPTION("Test of CreateLease.");
> @@ -976,6 +978,37 @@ static void implicit_plane_lease(data_t *data)
> drmSetClientCap(data->master.fd, DRM_CLIENT_CAP_UNIVERSAL_PLANES, 1);
> }
>
> +static void lease_uevent(data_t *data)
> +{
> + int lease_fd;
> + struct local_drm_mode_list_lessees mll;
> + struct udev_monitor *uevent_monitor;
> +
> + uevent_monitor = igt_watch_hotplug();
> +
> + igt_flush_hotplugs(uevent_monitor);
Shouldn't we rename
igt_watch_hotplug()/igt_flush_hotplugs()/igt_cleanup_hotplug()/etc. as well to
reflect that these are used for more then udev hotplug events now?
Otherwise, looks good to me
> +
> + lease_fd = create_simple_lease(data->master.fd, data);
> +
> + igt_assert(!igt_lease_change_detected(uevent_monitor, 1));
> +
> + mll.pad = 0;
> + mll.count_lessees = 0;
> + mll.lessees_ptr = 0;
> + igt_assert_eq(list_lessees(data->master.fd, &mll), 0);
> + igt_assert_eq(mll.count_lessees, 1);
> +
> + close(lease_fd);
> +
> + igt_assert(igt_lease_change_detected(uevent_monitor, 1));
> +
> + mll.lessees_ptr = 0;
> + igt_assert_eq(list_lessees(data->master.fd, &mll), 0);
> + igt_assert_eq(mll.count_lessees, 0);
> +
> + igt_cleanup_hotplug(uevent_monitor);
> +}
> +
> igt_main
> {
> data_t data;
> @@ -1023,4 +1056,7 @@ igt_main
>
> igt_subtest("implicit-plane-lease")
> implicit_plane_lease(&data);
> +
> + igt_subtest("lease-uevent")
> + lease_uevent(&data);
> }
--
Cheers,
Lyude Paul
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_lease: exercise uevent
2019-02-20 23:42 ` Lyude Paul
@ 2019-02-20 23:48 ` Daniel Vetter
2019-02-21 0:16 ` Lyude Paul
0 siblings, 1 reply; 42+ messages in thread
From: Daniel Vetter @ 2019-02-20 23:48 UTC (permalink / raw)
To: Lyude Paul; +Cc: IGT development, Keith Packard, Daniel Vetter
On Wed, Feb 20, 2019 at 06:42:43PM -0500, Lyude Paul wrote:
> On Wed, 2019-02-20 at 22:17 +0100, Daniel Vetter wrote:
> > And make sure we get the LEASE=1 value, indicating a lessee change.
> >
> > v2: Apparently netlink reading can leak EAGAIN out through
> > udev_monitor_receive_device. No idea what's going on there, so let's
> > wrap some duct tape around it.
> >
> > v3: Lyude reported that we might get a few udev events on startup of
> > the test. Drain those first.
> >
> > v4: Use the igt hotplug library functions, they already take care of
> > all the uevent special cases.
> >
> > Cc: Lyude Paul <lyude@redhat.com>
> > Cc: Keith Packard <keithp@keithp.com>
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > ---
> > lib/igt_kms.c | 42 +++++++++++++++++++++++++++++++-----------
> > lib/igt_kms.h | 2 ++
> > tests/kms_lease.c | 36 ++++++++++++++++++++++++++++++++++++
> > 3 files changed, 69 insertions(+), 11 deletions(-)
> >
> > diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> > index 85a911e11060..8f0b79d7727b 100644
> > --- a/lib/igt_kms.c
> > +++ b/lib/igt_kms.c
> > @@ -4019,16 +4019,8 @@ struct udev_monitor *igt_watch_hotplug(void)
> > return mon;
> > }
> >
> > -/**
> > - * igt_hotplug_detected:
> > - * @mon: A udev monitor initialized with #igt_watch_hotplug
> > - * @timeout_secs: How long to wait for a hotplug event to occur.
> > - *
> > - * Assert that a hotplug event was received since we last checked the
> > monitor.
> > - *
> > - * Returns: true if a sysfs hotplug event was received, false if we timed
> > out
> > - */
> > -bool igt_hotplug_detected(struct udev_monitor *mon, int timeout_secs)
> > +static bool event_detected(struct udev_monitor *mon, int timeout_secs,
> > + const char *property)
> > {
> > struct udev_device *dev;
> > const char *hotplug_val;
> > @@ -4046,7 +4038,7 @@ bool igt_hotplug_detected(struct udev_monitor *mon,
> > int timeout_secs)
> > while (!hotplug_received && poll(&fd, 1, timeout_secs * 1000)) {
> > dev = udev_monitor_receive_device(mon);
> >
> > - hotplug_val = udev_device_get_property_value(dev, "HOTPLUG");
> > + hotplug_val = udev_device_get_property_value(dev, property);
> > if (hotplug_val && atoi(hotplug_val) == 1)
> > hotplug_received = true;
> >
> > @@ -4056,6 +4048,34 @@ bool igt_hotplug_detected(struct udev_monitor *mon,
> > int timeout_secs)
> > return hotplug_received;
> > }
> >
> > +/**
> > + * igt_hotplug_detected:
> > + * @mon: A udev monitor initialized with #igt_watch_hotplug
> > + * @timeout_secs: How long to wait for a hotplug event to occur.
> > + *
> > + * Assert that a hotplug event was received since we last checked the
> > monitor.
> > + *
> > + * Returns: true if a sysfs hotplug event was received, false if we timed
> > out
> > + */
> > +bool igt_hotplug_detected(struct udev_monitor *mon, int timeout_secs)
> > +{
> > + return event_detected(mon, timeout_secs, "HOTPLUG");
> > +}
> > +
> > +/**
> > + * igt_lease_change_detected:
> > + * @mon: A udev monitor initialized with #igt_watch_hotplug
> > + * @timeout_secs: How long to wait for a lease change event to occur.
> > + *
> > + * Assert that a lease change event was received since we last checked the
> > monitor.
> > + *
> > + * Returns: true if a sysfs lease change event was received, false if we
> > timed out
> > + */
> > +bool igt_lease_change_detected(struct udev_monitor *mon, int timeout_secs)
> > +{
> > + return event_detected(mon, timeout_secs, "LEASE");
> > +}
> > +
> > /**
> > * igt_flush_hotplugs:
> > * @mon: A udev monitor initialized with #igt_watch_hotplug
> > diff --git a/lib/igt_kms.h b/lib/igt_kms.h
> > index 679d4e84fab8..5755b160d13e 100644
> > --- a/lib/igt_kms.h
> > +++ b/lib/igt_kms.h
> > @@ -749,6 +749,8 @@ const unsigned char* igt_kms_get_alt_edid(void);
> > struct udev_monitor *igt_watch_hotplug(void);
> > bool igt_hotplug_detected(struct udev_monitor *mon,
> > int timeout_secs);
> > +bool igt_lease_change_detected(struct udev_monitor *mon,
> > + int timeout_secs);
> > void igt_flush_hotplugs(struct udev_monitor *mon);
> > void igt_cleanup_hotplug(struct udev_monitor *mon);
> >
> > diff --git a/tests/kms_lease.c b/tests/kms_lease.c
> > index d082a7988eaa..600f6779561d 100644
> > --- a/tests/kms_lease.c
> > +++ b/tests/kms_lease.c
> > @@ -40,6 +40,8 @@
> > #include <sys/time.h>
> > #include <sys/wait.h>
> >
> > +#include <libudev.h>
> > +
> > #include <drm.h>
> >
> > IGT_TEST_DESCRIPTION("Test of CreateLease.");
> > @@ -976,6 +978,37 @@ static void implicit_plane_lease(data_t *data)
> > drmSetClientCap(data->master.fd, DRM_CLIENT_CAP_UNIVERSAL_PLANES, 1);
> > }
> >
> > +static void lease_uevent(data_t *data)
> > +{
> > + int lease_fd;
> > + struct local_drm_mode_list_lessees mll;
> > + struct udev_monitor *uevent_monitor;
> > +
> > + uevent_monitor = igt_watch_hotplug();
> > +
> > + igt_flush_hotplugs(uevent_monitor);
> Shouldn't we rename
> igt_watch_hotplug()/igt_flush_hotplugs()/igt_cleanup_hotplug()/etc. as well to
> reflect that these are used for more then udev hotplug events now?
I was feeling unmotivated :-)
Slightly more seriously, the excuse is that I expect all testcases except
this one will want hotplug uevents, nothing else. So the naming makes
some sense to keep, leaving kms_lease here as the special case.
Originally drm leases even use HOTPLUG=1 as their uevent too, but we fixed
that before it became uapi. -modesetting still doesn't differentiate.
-Daniel
>
> Otherwise, looks good to me
>
> > +
> > + lease_fd = create_simple_lease(data->master.fd, data);
> > +
> > + igt_assert(!igt_lease_change_detected(uevent_monitor, 1));
> > +
> > + mll.pad = 0;
> > + mll.count_lessees = 0;
> > + mll.lessees_ptr = 0;
> > + igt_assert_eq(list_lessees(data->master.fd, &mll), 0);
> > + igt_assert_eq(mll.count_lessees, 1);
> > +
> > + close(lease_fd);
> > +
> > + igt_assert(igt_lease_change_detected(uevent_monitor, 1));
> > +
> > + mll.lessees_ptr = 0;
> > + igt_assert_eq(list_lessees(data->master.fd, &mll), 0);
> > + igt_assert_eq(mll.count_lessees, 0);
> > +
> > + igt_cleanup_hotplug(uevent_monitor);
> > +}
> > +
> > igt_main
> > {
> > data_t data;
> > @@ -1023,4 +1056,7 @@ igt_main
> >
> > igt_subtest("implicit-plane-lease")
> > implicit_plane_lease(&data);
> > +
> > + igt_subtest("lease-uevent")
> > + lease_uevent(&data);
> > }
> --
> Cheers,
> Lyude Paul
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_lease: exercise uevent
2019-02-20 23:48 ` Daniel Vetter
@ 2019-02-21 0:16 ` Lyude Paul
0 siblings, 0 replies; 42+ messages in thread
From: Lyude Paul @ 2019-02-21 0:16 UTC (permalink / raw)
To: Daniel Vetter; +Cc: IGT development, Keith Packard, Daniel Vetter
On Thu, 2019-02-21 at 00:48 +0100, Daniel Vetter wrote:
> On Wed, Feb 20, 2019 at 06:42:43PM -0500, Lyude Paul wrote:
> > On Wed, 2019-02-20 at 22:17 +0100, Daniel Vetter wrote:
> > > And make sure we get the LEASE=1 value, indicating a lessee change.
> > >
> > > v2: Apparently netlink reading can leak EAGAIN out through
> > > udev_monitor_receive_device. No idea what's going on there, so let's
> > > wrap some duct tape around it.
> > >
> > > v3: Lyude reported that we might get a few udev events on startup of
> > > the test. Drain those first.
> > >
> > > v4: Use the igt hotplug library functions, they already take care of
> > > all the uevent special cases.
> > >
> > > Cc: Lyude Paul <lyude@redhat.com>
> > > Cc: Keith Packard <keithp@keithp.com>
> > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > > ---
> > > lib/igt_kms.c | 42 +++++++++++++++++++++++++++++++-----------
> > > lib/igt_kms.h | 2 ++
> > > tests/kms_lease.c | 36 ++++++++++++++++++++++++++++++++++++
> > > 3 files changed, 69 insertions(+), 11 deletions(-)
> > >
> > > diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> > > index 85a911e11060..8f0b79d7727b 100644
> > > --- a/lib/igt_kms.c
> > > +++ b/lib/igt_kms.c
> > > @@ -4019,16 +4019,8 @@ struct udev_monitor *igt_watch_hotplug(void)
> > > return mon;
> > > }
> > >
> > > -/**
> > > - * igt_hotplug_detected:
> > > - * @mon: A udev monitor initialized with #igt_watch_hotplug
> > > - * @timeout_secs: How long to wait for a hotplug event to occur.
> > > - *
> > > - * Assert that a hotplug event was received since we last checked the
> > > monitor.
> > > - *
> > > - * Returns: true if a sysfs hotplug event was received, false if we
> > > timed
> > > out
> > > - */
> > > -bool igt_hotplug_detected(struct udev_monitor *mon, int timeout_secs)
> > > +static bool event_detected(struct udev_monitor *mon, int timeout_secs,
> > > + const char *property)
> > > {
> > > struct udev_device *dev;
> > > const char *hotplug_val;
> > > @@ -4046,7 +4038,7 @@ bool igt_hotplug_detected(struct udev_monitor
> > > *mon,
> > > int timeout_secs)
> > > while (!hotplug_received && poll(&fd, 1, timeout_secs * 1000)) {
> > > dev = udev_monitor_receive_device(mon);
> > >
> > > - hotplug_val = udev_device_get_property_value(dev, "HOTPLUG");
> > > + hotplug_val = udev_device_get_property_value(dev, property);
> > > if (hotplug_val && atoi(hotplug_val) == 1)
> > > hotplug_received = true;
> > >
> > > @@ -4056,6 +4048,34 @@ bool igt_hotplug_detected(struct udev_monitor
> > > *mon,
> > > int timeout_secs)
> > > return hotplug_received;
> > > }
> > >
> > > +/**
> > > + * igt_hotplug_detected:
> > > + * @mon: A udev monitor initialized with #igt_watch_hotplug
> > > + * @timeout_secs: How long to wait for a hotplug event to occur.
> > > + *
> > > + * Assert that a hotplug event was received since we last checked the
> > > monitor.
> > > + *
> > > + * Returns: true if a sysfs hotplug event was received, false if we
> > > timed
> > > out
> > > + */
> > > +bool igt_hotplug_detected(struct udev_monitor *mon, int timeout_secs)
> > > +{
> > > + return event_detected(mon, timeout_secs, "HOTPLUG");
> > > +}
> > > +
> > > +/**
> > > + * igt_lease_change_detected:
> > > + * @mon: A udev monitor initialized with #igt_watch_hotplug
> > > + * @timeout_secs: How long to wait for a lease change event to occur.
> > > + *
> > > + * Assert that a lease change event was received since we last checked
> > > the
> > > monitor.
> > > + *
> > > + * Returns: true if a sysfs lease change event was received, false if
> > > we
> > > timed out
> > > + */
> > > +bool igt_lease_change_detected(struct udev_monitor *mon, int
> > > timeout_secs)
> > > +{
> > > + return event_detected(mon, timeout_secs, "LEASE");
> > > +}
> > > +
> > > /**
> > > * igt_flush_hotplugs:
> > > * @mon: A udev monitor initialized with #igt_watch_hotplug
> > > diff --git a/lib/igt_kms.h b/lib/igt_kms.h
> > > index 679d4e84fab8..5755b160d13e 100644
> > > --- a/lib/igt_kms.h
> > > +++ b/lib/igt_kms.h
> > > @@ -749,6 +749,8 @@ const unsigned char* igt_kms_get_alt_edid(void);
> > > struct udev_monitor *igt_watch_hotplug(void);
> > > bool igt_hotplug_detected(struct udev_monitor *mon,
> > > int timeout_secs);
> > > +bool igt_lease_change_detected(struct udev_monitor *mon,
> > > + int timeout_secs);
> > > void igt_flush_hotplugs(struct udev_monitor *mon);
> > > void igt_cleanup_hotplug(struct udev_monitor *mon);
> > >
> > > diff --git a/tests/kms_lease.c b/tests/kms_lease.c
> > > index d082a7988eaa..600f6779561d 100644
> > > --- a/tests/kms_lease.c
> > > +++ b/tests/kms_lease.c
> > > @@ -40,6 +40,8 @@
> > > #include <sys/time.h>
> > > #include <sys/wait.h>
> > >
> > > +#include <libudev.h>
> > > +
> > > #include <drm.h>
> > >
> > > IGT_TEST_DESCRIPTION("Test of CreateLease.");
> > > @@ -976,6 +978,37 @@ static void implicit_plane_lease(data_t *data)
> > > drmSetClientCap(data->master.fd, DRM_CLIENT_CAP_UNIVERSAL_PLANES, 1);
> > > }
> > >
> > > +static void lease_uevent(data_t *data)
> > > +{
> > > + int lease_fd;
> > > + struct local_drm_mode_list_lessees mll;
> > > + struct udev_monitor *uevent_monitor;
> > > +
> > > + uevent_monitor = igt_watch_hotplug();
> > > +
> > > + igt_flush_hotplugs(uevent_monitor);
> > Shouldn't we rename
> > igt_watch_hotplug()/igt_flush_hotplugs()/igt_cleanup_hotplug()/etc. as
> > well to
> > reflect that these are used for more then udev hotplug events now?
>
> I was feeling unmotivated :-)
>
> Slightly more seriously, the excuse is that I expect all testcases except
> this one will want hotplug uevents, nothing else. So the naming makes
> some sense to keep, leaving kms_lease here as the special case.
>
> Originally drm leases even use HOTPLUG=1 as their uevent too, but we fixed
> that before it became uapi. -modesetting still doesn't differentiate.
> -Daniel
Makes sense. In that case:
Reviewed-by: Lyude Paul <lyude@redhat.com>
>
> > Otherwise, looks good to me
> >
> > > +
> > > + lease_fd = create_simple_lease(data->master.fd, data);
> > > +
> > > + igt_assert(!igt_lease_change_detected(uevent_monitor, 1));
> > > +
> > > + mll.pad = 0;
> > > + mll.count_lessees = 0;
> > > + mll.lessees_ptr = 0;
> > > + igt_assert_eq(list_lessees(data->master.fd, &mll), 0);
> > > + igt_assert_eq(mll.count_lessees, 1);
> > > +
> > > + close(lease_fd);
> > > +
> > > + igt_assert(igt_lease_change_detected(uevent_monitor, 1));
> > > +
> > > + mll.lessees_ptr = 0;
> > > + igt_assert_eq(list_lessees(data->master.fd, &mll), 0);
> > > + igt_assert_eq(mll.count_lessees, 0);
> > > +
> > > + igt_cleanup_hotplug(uevent_monitor);
> > > +}
> > > +
> > > igt_main
> > > {
> > > data_t data;
> > > @@ -1023,4 +1056,7 @@ igt_main
> > >
> > > igt_subtest("implicit-plane-lease")
> > > implicit_plane_lease(&data);
> > > +
> > > + igt_subtest("lease-uevent")
> > > + lease_uevent(&data);
> > > }
> > --
> > Cheers,
> > Lyude Paul
> >
--
Cheers,
Lyude Paul
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 42+ messages in thread
* [igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests (rev2)
2019-02-20 16:25 [igt-dev] [PATCH i-g-t 1/9] tests/kms_lease: Add invalid planes tests Daniel Vetter
` (13 preceding siblings ...)
2019-02-20 22:26 ` [igt-dev] [PATCH i-g-t 1/9] tests/kms_lease: Add invalid planes tests Lyude Paul
@ 2019-02-21 1:25 ` Patchwork
2019-02-21 1:52 ` [igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests (rev3) Patchwork
` (8 subsequent siblings)
23 siblings, 0 replies; 42+ messages in thread
From: Patchwork @ 2019-02-21 1:25 UTC (permalink / raw)
To: igt-dev
== Series Details ==
Series: series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests (rev2)
URL : https://patchwork.freedesktop.org/series/56970/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_5642_full -> IGTPW_2460_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_2460_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_2460_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/56970/revisions/2/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_2460_full:
### IGT changes ###
#### Possible regressions ####
* {igt@kms_lease@invalid-create-leases} (NEW):
- shard-kbl: NOTRUN -> DMESG-WARN
- shard-hsw: NOTRUN -> DMESG-WARN
- shard-snb: NOTRUN -> DMESG-WARN
- shard-glk: NOTRUN -> DMESG-WARN
- shard-apl: NOTRUN -> DMESG-WARN
* igt@runner@aborted:
- shard-hsw: NOTRUN -> FAIL
- shard-snb: NOTRUN -> FAIL
- shard-kbl: NOTRUN -> FAIL
- shard-apl: NOTRUN -> FAIL
New tests
---------
New tests have been introduced between CI_DRM_5642_full and IGTPW_2460_full:
### New IGT tests (7) ###
* igt@kms_lease@implicit-plane-lease:
- Statuses : 5 pass(s)
- Exec time: [0.00, 0.01] s
* igt@kms_lease@invalid-create-leases:
- Statuses : 5 dmesg-warn(s)
- Exec time: [0.00, 0.01] s
* igt@kms_lease@lease-uevent:
- Statuses : 5 pass(s)
- Exec time: [0.21, 0.23] s
* igt@kms_lease@lease_invalid_plane:
- Statuses : 5 pass(s)
- Exec time: [0.0] s
* igt@kms_lease@master-vs-lease:
- Statuses : 5 pass(s)
- Exec time: [0.0, 0.01] s
* igt@kms_lease@multimaster-lease:
- Statuses : 5 pass(s)
- Exec time: [0.0, 0.01] s
* igt@kms_lease@possible-crtcs-filtering:
- Statuses : 5 pass(s)
- Exec time: [0.00, 0.01] s
Known issues
------------
Here are the changes found in IGTPW_2460_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_flush@basic-batch-kernel-default-cmd:
- shard-glk: NOTRUN -> SKIP [fdo#109271] +9
* igt@gem_exec_schedule@preempt-other-chain-blt:
- shard-snb: NOTRUN -> SKIP [fdo#109271] +167
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
- shard-snb: NOTRUN -> DMESG-WARN [fdo#107956]
* igt@kms_busy@extended-modeset-hang-oldfb-render-f:
- shard-glk: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-d:
- shard-apl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +1
* igt@kms_color@pipe-a-ctm-max:
- shard-glk: NOTRUN -> FAIL [fdo#108147]
* igt@kms_cursor_crc@cursor-256x256-sliding:
- shard-glk: NOTRUN -> FAIL [fdo#103232]
* igt@kms_cursor_crc@cursor-64x64-sliding:
- shard-apl: PASS -> FAIL [fdo#103232]
* igt@kms_flip@2x-plain-flip-ts-check:
- shard-apl: NOTRUN -> SKIP [fdo#109271] +28
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
- shard-glk: PASS -> FAIL [fdo#103167] +2
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-cur-indfb-draw-render:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] +9
* igt@kms_plane@pixel-format-pipe-a-planes:
- shard-kbl: PASS -> FAIL [fdo#103166] +1
* igt@kms_plane@pixel-format-pipe-b-planes-source-clamping:
- shard-apl: PASS -> FAIL [fdo#108948]
* igt@kms_plane@pixel-format-pipe-c-planes-source-clamping:
- shard-glk: PASS -> FAIL [fdo#108948]
* igt@kms_plane_alpha_blend@pipe-b-alpha-7efc:
- shard-apl: NOTRUN -> FAIL [fdo#108145]
* igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb:
- shard-snb: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +19
* igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
- shard-glk: PASS -> FAIL [fdo#103166] +6
- shard-apl: PASS -> FAIL [fdo#103166] +1
* igt@kms_rotation_crc@multiplane-rotation-cropping-bottom:
- shard-glk: PASS -> DMESG-FAIL [fdo#105763] / [fdo#106538]
- shard-kbl: PASS -> DMESG-FAIL [fdo#105763]
* igt@kms_sysfs_edid_timing:
- shard-apl: NOTRUN -> FAIL [fdo#100047]
* igt@kms_vblank@pipe-c-ts-continuation-modeset:
- shard-apl: PASS -> FAIL [fdo#104894]
* igt@testdisplay:
- shard-apl: PASS -> INCOMPLETE [fdo#103927]
#### Possible fixes ####
* igt@i915_pm_rpm@system-suspend:
- shard-kbl: INCOMPLETE [fdo#103665] / [fdo#107807] -> PASS
* igt@kms_atomic_transition@plane-all-modeset-transition:
- shard-kbl: INCOMPLETE [fdo#103665] -> PASS
* igt@kms_cursor_crc@cursor-128x128-suspend:
- shard-apl: FAIL [fdo#103191] / [fdo#103232] -> PASS
- shard-kbl: FAIL [fdo#103191] / [fdo#103232] -> PASS
* igt@kms_cursor_crc@cursor-256x85-sliding:
- shard-apl: FAIL [fdo#103232] -> PASS +2
* igt@kms_cursor_crc@cursor-64x64-onscreen:
- shard-kbl: FAIL [fdo#103232] -> PASS
* igt@kms_flip@plain-flip-fb-recreate-interruptible:
- shard-apl: INCOMPLETE [fdo#103927] -> PASS +2
* igt@kms_frontbuffer_tracking@fbc-1p-rte:
- shard-glk: FAIL [fdo#103167] / [fdo#105682] -> PASS
* igt@kms_plane@plane-position-covered-pipe-c-planes:
- shard-apl: FAIL [fdo#103166] -> PASS +1
- shard-kbl: FAIL [fdo#103166] -> PASS
* igt@kms_plane_multiple@atomic-pipe-b-tiling-none:
- shard-glk: FAIL [fdo#103166] -> PASS
* igt@kms_vblank@pipe-b-ts-continuation-dpms-rpm:
- shard-apl: FAIL [fdo#104894] -> PASS
- shard-kbl: FAIL [fdo#104894] -> PASS
* igt@perf_pmu@rc6:
- shard-kbl: SKIP [fdo#109271] -> PASS
#### Warnings ####
* igt@runner@aborted:
- shard-glk: FAIL [fdo#109373] / [k.org#202321] -> ( 2 FAIL ) [fdo#109373] / [k.org#202321]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894
[fdo#105682]: https://bugs.freedesktop.org/show_bug.cgi?id=105682
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#106538]: https://bugs.freedesktop.org/show_bug.cgi?id=106538
[fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
[fdo#108739]: https://bugs.freedesktop.org/show_bug.cgi?id=108739
[fdo#108948]: https://bugs.freedesktop.org/show_bug.cgi?id=108948
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109373]: https://bugs.freedesktop.org/show_bug.cgi?id=109373
[k.org#202321]: https://bugzilla.kernel.org/show_bug.cgi?id=202321
Participating hosts (6 -> 5)
------------------------------
Missing (1): shard-skl
Build changes
-------------
* IGT: IGT_4844 -> IGTPW_2460
* Piglit: piglit_4509 -> None
CI_DRM_5642: c35913ab36f318bf8981f9b3576035a95659591e @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2460: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2460/
IGT_4844: ee6e006202a50c5aef373c0b075027ed7177935a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2460/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 42+ messages in thread
* [igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests (rev3)
2019-02-20 16:25 [igt-dev] [PATCH i-g-t 1/9] tests/kms_lease: Add invalid planes tests Daniel Vetter
` (14 preceding siblings ...)
2019-02-21 1:25 ` [igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests (rev2) Patchwork
@ 2019-02-21 1:52 ` Patchwork
2019-02-21 2:57 ` [igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests (rev5) Patchwork
` (7 subsequent siblings)
23 siblings, 0 replies; 42+ messages in thread
From: Patchwork @ 2019-02-21 1:52 UTC (permalink / raw)
To: igt-dev
== Series Details ==
Series: series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests (rev3)
URL : https://patchwork.freedesktop.org/series/56970/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_5642_full -> IGTPW_2461_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_2461_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_2461_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/56970/revisions/3/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_2461_full:
### IGT changes ###
#### Possible regressions ####
* {igt@kms_lease@invalid-create-leases} (NEW):
- shard-kbl: NOTRUN -> DMESG-WARN
- shard-hsw: NOTRUN -> DMESG-WARN
- shard-snb: NOTRUN -> DMESG-WARN
- shard-glk: NOTRUN -> DMESG-WARN
- shard-apl: NOTRUN -> DMESG-WARN
* igt@runner@aborted:
- shard-hsw: NOTRUN -> FAIL
- shard-snb: NOTRUN -> FAIL
- shard-kbl: NOTRUN -> FAIL
- shard-apl: NOTRUN -> FAIL
New tests
---------
New tests have been introduced between CI_DRM_5642_full and IGTPW_2461_full:
### New IGT tests (7) ###
* igt@kms_lease@implicit-plane-lease:
- Statuses : 5 pass(s)
- Exec time: [0.0, 0.00] s
* igt@kms_lease@invalid-create-leases:
- Statuses : 5 dmesg-warn(s)
- Exec time: [0.00, 0.01] s
* igt@kms_lease@lease-uevent:
- Statuses : 5 pass(s)
- Exec time: [0.10, 0.11] s
* igt@kms_lease@lease_invalid_plane:
- Statuses : 5 pass(s)
- Exec time: [0.0, 0.00] s
* igt@kms_lease@master-vs-lease:
- Statuses : 5 pass(s)
- Exec time: [0.0, 0.01] s
* igt@kms_lease@multimaster-lease:
- Statuses : 5 pass(s)
- Exec time: [0.0, 0.01] s
* igt@kms_lease@possible-crtcs-filtering:
- Statuses : 5 pass(s)
- Exec time: [0.00, 0.01] s
Known issues
------------
Here are the changes found in IGTPW_2461_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_eio@in-flight-suspend:
- shard-snb: PASS -> FAIL [fdo#103375]
* igt@gem_eio@reset-stress:
- shard-snb: PASS -> FAIL [fdo#109661]
* igt@gem_exec_flush@basic-batch-kernel-default-cmd:
- shard-glk: NOTRUN -> SKIP [fdo#109271] +8
* igt@gem_exec_schedule@preempt-other-chain-blt:
- shard-snb: NOTRUN -> SKIP [fdo#109271] +161
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
- shard-snb: NOTRUN -> DMESG-WARN [fdo#107956]
* igt@kms_busy@extended-modeset-hang-oldfb-render-f:
- shard-glk: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-d:
- shard-apl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +2
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
- shard-apl: PASS -> FAIL [fdo#106510] / [fdo#108145]
* igt@kms_color@pipe-a-ctm-max:
- shard-glk: NOTRUN -> FAIL [fdo#108147]
* igt@kms_cursor_crc@cursor-128x42-onscreen:
- shard-apl: PASS -> FAIL [fdo#103232] +2
* igt@kms_cursor_crc@cursor-256x256-sliding:
- shard-glk: NOTRUN -> FAIL [fdo#103232]
* igt@kms_cursor_crc@cursor-64x21-onscreen:
- shard-kbl: PASS -> FAIL [fdo#103232] +1
* igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic:
- shard-glk: NOTRUN -> FAIL [fdo#105454] / [fdo#106509]
* igt@kms_cursor_legacy@cursor-vs-flip-atomic:
- shard-hsw: PASS -> FAIL [fdo#103355]
* igt@kms_flip@2x-plain-flip-ts-check:
- shard-apl: NOTRUN -> SKIP [fdo#109271] +28
* igt@kms_flip@flip-vs-expired-vblank:
- shard-glk: PASS -> FAIL [fdo#102887] / [fdo#105363]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
- shard-apl: PASS -> FAIL [fdo#103167] +1
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
- shard-glk: PASS -> FAIL [fdo#103167] +4
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-cur-indfb-draw-render:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] +9
* igt@kms_plane@pixel-format-pipe-b-planes:
- shard-apl: NOTRUN -> FAIL [fdo#103166]
* igt@kms_plane_alpha_blend@pipe-b-alpha-7efc:
- shard-apl: NOTRUN -> FAIL [fdo#108145]
* igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb:
- shard-snb: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +13
* igt@kms_plane_multiple@atomic-pipe-a-tiling-none:
- shard-apl: PASS -> FAIL [fdo#103166]
* igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
- shard-glk: PASS -> FAIL [fdo#103166] +5
* igt@kms_plane_multiple@atomic-pipe-c-tiling-x:
- shard-kbl: PASS -> FAIL [fdo#103166]
* igt@kms_rotation_crc@multiplane-rotation-cropping-bottom:
- shard-kbl: PASS -> DMESG-FAIL [fdo#105763] +1
* igt@kms_rotation_crc@multiplane-rotation-cropping-top:
- shard-kbl: PASS -> FAIL [fdo#109016]
* igt@kms_setmode@basic:
- shard-apl: PASS -> FAIL [fdo#99912]
* igt@kms_sysfs_edid_timing:
- shard-apl: NOTRUN -> FAIL [fdo#100047]
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: PASS -> FAIL [fdo#104894] +1
- shard-apl: PASS -> FAIL [fdo#104894] +1
#### Possible fixes ####
* igt@i915_pm_rpm@system-suspend:
- shard-kbl: INCOMPLETE [fdo#103665] / [fdo#107807] -> PASS
* igt@kms_atomic_transition@plane-all-modeset-transition:
- shard-kbl: INCOMPLETE [fdo#103665] -> PASS
* igt@kms_cursor_crc@cursor-128x128-suspend:
- shard-apl: FAIL [fdo#103191] / [fdo#103232] -> PASS
- shard-kbl: FAIL [fdo#103191] / [fdo#103232] -> PASS
* igt@kms_cursor_crc@cursor-64x64-onscreen:
- shard-kbl: FAIL [fdo#103232] -> PASS
* igt@kms_cursor_crc@cursor-64x64-random:
- shard-apl: FAIL [fdo#103232] -> PASS
* igt@kms_flip@plain-flip-fb-recreate-interruptible:
- shard-apl: INCOMPLETE [fdo#103927] -> PASS +1
* igt@kms_frontbuffer_tracking@fbc-1p-rte:
- shard-glk: FAIL [fdo#103167] / [fdo#105682] -> PASS
* igt@kms_plane@plane-position-covered-pipe-b-planes:
- shard-glk: FAIL [fdo#103166] -> PASS +1
* igt@kms_plane@plane-position-covered-pipe-c-planes:
- shard-apl: FAIL [fdo#103166] -> PASS
- shard-kbl: FAIL [fdo#103166] -> PASS
* igt@kms_setmode@basic:
- shard-hsw: FAIL [fdo#99912] -> PASS
- shard-kbl: FAIL [fdo#99912] -> PASS
* igt@kms_vblank@pipe-b-ts-continuation-dpms-rpm:
- shard-apl: FAIL [fdo#104894] -> PASS
- shard-kbl: FAIL [fdo#104894] -> PASS
* igt@perf_pmu@rc6:
- shard-kbl: SKIP [fdo#109271] -> PASS
#### Warnings ####
* igt@runner@aborted:
- shard-glk: FAIL [fdo#109373] / [k.org#202321] -> ( 2 FAIL ) [fdo#109373] / [k.org#202321]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047
[fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105454]: https://bugs.freedesktop.org/show_bug.cgi?id=105454
[fdo#105682]: https://bugs.freedesktop.org/show_bug.cgi?id=105682
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#106509]: https://bugs.freedesktop.org/show_bug.cgi?id=106509
[fdo#106510]: https://bugs.freedesktop.org/show_bug.cgi?id=106510
[fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
[fdo#108739]: https://bugs.freedesktop.org/show_bug.cgi?id=108739
[fdo#109016]: https://bugs.freedesktop.org/show_bug.cgi?id=109016
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109373]: https://bugs.freedesktop.org/show_bug.cgi?id=109373
[fdo#109661]: https://bugs.freedesktop.org/show_bug.cgi?id=109661
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
[k.org#202321]: https://bugzilla.kernel.org/show_bug.cgi?id=202321
Participating hosts (6 -> 5)
------------------------------
Missing (1): shard-skl
Build changes
-------------
* IGT: IGT_4844 -> IGTPW_2461
* Piglit: piglit_4509 -> None
CI_DRM_5642: c35913ab36f318bf8981f9b3576035a95659591e @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2461: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2461/
IGT_4844: ee6e006202a50c5aef373c0b075027ed7177935a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2461/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 42+ messages in thread
* [igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests (rev5)
2019-02-20 16:25 [igt-dev] [PATCH i-g-t 1/9] tests/kms_lease: Add invalid planes tests Daniel Vetter
` (15 preceding siblings ...)
2019-02-21 1:52 ` [igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests (rev3) Patchwork
@ 2019-02-21 2:57 ` Patchwork
2019-02-21 12:57 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests (rev6) Patchwork
` (6 subsequent siblings)
23 siblings, 0 replies; 42+ messages in thread
From: Patchwork @ 2019-02-21 2:57 UTC (permalink / raw)
To: igt-dev
== Series Details ==
Series: series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests (rev5)
URL : https://patchwork.freedesktop.org/series/56970/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_5642_full -> IGTPW_2463_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_2463_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_2463_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/56970/revisions/5/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_2463_full:
### IGT changes ###
#### Possible regressions ####
* {igt@kms_lease@invalid-create-leases} (NEW):
- shard-kbl: NOTRUN -> DMESG-WARN
- shard-hsw: NOTRUN -> DMESG-WARN
- shard-snb: NOTRUN -> DMESG-WARN
- shard-glk: NOTRUN -> DMESG-WARN
- shard-apl: NOTRUN -> DMESG-WARN
* igt@runner@aborted:
- shard-hsw: NOTRUN -> FAIL
- shard-snb: NOTRUN -> FAIL
- shard-kbl: NOTRUN -> FAIL
- shard-apl: NOTRUN -> FAIL
New tests
---------
New tests have been introduced between CI_DRM_5642_full and IGTPW_2463_full:
### New IGT tests (7) ###
* igt@kms_lease@implicit-plane-lease:
- Statuses : 5 pass(s)
- Exec time: [0.00, 0.01] s
* igt@kms_lease@invalid-create-leases:
- Statuses : 5 dmesg-warn(s)
- Exec time: [0.00, 0.01] s
* igt@kms_lease@lease-uevent:
- Statuses : 5 pass(s)
- Exec time: [1.01, 1.02] s
* igt@kms_lease@lease_invalid_plane:
- Statuses : 4 pass(s)
- Exec time: [0.0, 0.00] s
* igt@kms_lease@master-vs-lease:
- Statuses : 5 pass(s)
- Exec time: [0.0, 0.00] s
* igt@kms_lease@multimaster-lease:
- Statuses : 4 pass(s)
- Exec time: [0.00] s
* igt@kms_lease@possible-crtcs-filtering:
- Statuses : 4 pass(s)
- Exec time: [0.00, 0.01] s
Known issues
------------
Here are the changes found in IGTPW_2463_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_flush@basic-batch-kernel-default-cmd:
- shard-glk: NOTRUN -> SKIP [fdo#109271] +8
* igt@gem_exec_schedule@preempt-other-chain-blt:
- shard-snb: NOTRUN -> SKIP [fdo#109271] +149
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
- shard-snb: NOTRUN -> DMESG-WARN [fdo#107956]
* igt@kms_busy@extended-modeset-hang-oldfb-render-f:
- shard-glk: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-d:
- shard-apl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +2
* igt@kms_color@pipe-a-ctm-max:
- shard-glk: NOTRUN -> FAIL [fdo#108147]
* igt@kms_cursor_crc@cursor-128x128-onscreen:
- shard-kbl: PASS -> FAIL [fdo#103232] +3
- shard-apl: NOTRUN -> FAIL [fdo#103232]
* igt@kms_cursor_crc@cursor-256x256-sliding:
- shard-glk: NOTRUN -> FAIL [fdo#103232]
* igt@kms_cursor_crc@cursor-256x256-suspend:
- shard-apl: PASS -> FAIL [fdo#103191] / [fdo#103232]
* igt@kms_cursor_crc@cursor-64x21-sliding:
- shard-apl: PASS -> FAIL [fdo#103232] +2
* igt@kms_cursor_crc@cursor-alpha-opaque:
- shard-apl: PASS -> FAIL [fdo#109350]
- shard-glk: PASS -> FAIL [fdo#109350]
* igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic:
- shard-glk: NOTRUN -> FAIL [fdo#105454] / [fdo#106509]
* igt@kms_flip@2x-plain-flip-ts-check:
- shard-apl: NOTRUN -> SKIP [fdo#109271] +27
* igt@kms_flip@flip-vs-expired-vblank:
- shard-glk: PASS -> FAIL [fdo#102887] / [fdo#105363]
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-glk: PASS -> INCOMPLETE [fdo#103359] / [k.org#198133]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
- shard-apl: PASS -> FAIL [fdo#103167] +1
- shard-kbl: PASS -> FAIL [fdo#103167]
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff:
- shard-glk: PASS -> FAIL [fdo#103167] +7
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-cur-indfb-draw-render:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] +9
* igt@kms_plane@pixel-format-pipe-c-planes-source-clamping:
- shard-glk: PASS -> FAIL [fdo#108948]
* igt@kms_plane_alpha_blend@pipe-b-alpha-7efc:
- shard-apl: NOTRUN -> FAIL [fdo#108145]
* igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb:
- shard-snb: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +18
* igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
- shard-apl: PASS -> FAIL [fdo#103166] +3
* igt@kms_plane_multiple@atomic-pipe-c-tiling-none:
- shard-glk: PASS -> FAIL [fdo#103166] +3
* igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
- shard-kbl: PASS -> FAIL [fdo#103166]
* igt@kms_rotation_crc@multiplane-rotation-cropping-top:
- shard-kbl: PASS -> FAIL [fdo#109016]
* igt@kms_sysfs_edid_timing:
- shard-apl: NOTRUN -> FAIL [fdo#100047]
* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- shard-hsw: PASS -> FAIL [fdo#104894]
* igt@kms_vblank@pipe-c-ts-continuation-modeset:
- shard-apl: PASS -> FAIL [fdo#104894]
#### Possible fixes ####
* igt@i915_pm_rpm@system-suspend:
- shard-kbl: INCOMPLETE [fdo#103665] / [fdo#107807] -> PASS
* igt@kms_atomic_transition@plane-all-modeset-transition:
- shard-kbl: INCOMPLETE [fdo#103665] -> PASS
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
- shard-hsw: DMESG-WARN [fdo#107956] -> PASS
* igt@kms_cursor_crc@cursor-64x64-onscreen:
- shard-kbl: FAIL [fdo#103232] -> PASS
- shard-apl: FAIL [fdo#103232] -> PASS +2
* igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic:
- shard-glk: FAIL [fdo#105454] / [fdo#106509] -> PASS
* igt@kms_flip@plain-flip-fb-recreate-interruptible:
- shard-apl: INCOMPLETE [fdo#103927] -> PASS +1
* igt@kms_frontbuffer_tracking@fbc-1p-rte:
- shard-glk: FAIL [fdo#103167] / [fdo#105682] -> PASS
* igt@kms_plane@plane-position-covered-pipe-c-planes:
- shard-apl: FAIL [fdo#103166] -> PASS +2
- shard-kbl: FAIL [fdo#103166] -> PASS
* igt@kms_plane_multiple@atomic-pipe-b-tiling-none:
- shard-glk: FAIL [fdo#103166] -> PASS +2
* igt@kms_vblank@pipe-b-ts-continuation-dpms-rpm:
- shard-apl: FAIL [fdo#104894] -> PASS
- shard-kbl: FAIL [fdo#104894] -> PASS
* igt@perf_pmu@rc6:
- shard-kbl: SKIP [fdo#109271] -> PASS
#### Warnings ####
* igt@runner@aborted:
- shard-glk: FAIL [fdo#109373] / [k.org#202321] -> ( 2 FAIL ) [fdo#109373] / [k.org#202321]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047
[fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105454]: https://bugs.freedesktop.org/show_bug.cgi?id=105454
[fdo#105682]: https://bugs.freedesktop.org/show_bug.cgi?id=105682
[fdo#106509]: https://bugs.freedesktop.org/show_bug.cgi?id=106509
[fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
[fdo#108739]: https://bugs.freedesktop.org/show_bug.cgi?id=108739
[fdo#108948]: https://bugs.freedesktop.org/show_bug.cgi?id=108948
[fdo#109016]: https://bugs.freedesktop.org/show_bug.cgi?id=109016
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109350]: https://bugs.freedesktop.org/show_bug.cgi?id=109350
[fdo#109373]: https://bugs.freedesktop.org/show_bug.cgi?id=109373
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
[k.org#202321]: https://bugzilla.kernel.org/show_bug.cgi?id=202321
Participating hosts (6 -> 5)
------------------------------
Missing (1): shard-skl
Build changes
-------------
* IGT: IGT_4844 -> IGTPW_2463
* Piglit: piglit_4509 -> None
CI_DRM_5642: c35913ab36f318bf8981f9b3576035a95659591e @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2463: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2463/
IGT_4844: ee6e006202a50c5aef373c0b075027ed7177935a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2463/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 3/9] tests/kms_lease: invalid corner-cases for create-lease ioctl
2019-02-20 16:25 ` [igt-dev] [PATCH i-g-t 3/9] tests/kms_lease: invalid corner-cases for create-lease ioctl Daniel Vetter
2019-02-20 20:43 ` Lyude Paul
2019-02-20 21:23 ` [igt-dev] [PATCH i-g-t] " Daniel Vetter
@ 2019-02-21 3:08 ` Keith Packard
2019-02-21 9:16 ` Daniel Vetter
2 siblings, 1 reply; 42+ messages in thread
From: Keith Packard @ 2019-02-21 3:08 UTC (permalink / raw)
To: Daniel Vetter, IGT development
[-- Attachment #1.1: Type: text/plain, Size: 1730 bytes --]
Daniel Vetter <daniel.vetter@ffwll.ch> writes:
> Found a few things in the kernel that looks suspicious, separate
> patches on their way.
Thanks for adding more tests!
> + /* empty lease */
> + mcl.object_ids = 0;
> + mcl.object_count = 0;
> + mcl.flags = 0;
> + igt_assert_eq(create_lease(data->master.fd, &mcl), -EINVAL);
Not sure why this should be invalid? It's not useful, but then neither
are 0x0 windows and look at all the pain not allowing them has caused
over the years...
> +
> + /* NULL array pointer */
> + mcl.object_count = 1;
> + igt_assert_eq(create_lease(data->master.fd, &mcl), -EFAULT);
Should probably explicitly initialize the array pointer here, avoids any
dependency on the previous test.
> + /* no crtc, non-universal_plane */
> + drmSetClientCap(data->master.fd, DRM_CLIENT_CAP_UNIVERSAL_PLANES, 0);
> + object_ids[0] = data->master.display.outputs[0].id;
> + igt_assert_eq(create_lease(data->master.fd, &mcl), -EINVAL);
Similarly, initialize the object count and pointers explicitly.
> + /* no subleasing */
> + mcl.object_count = 3;
> + mcl.flags = 0;
> + igt_assert_eq(create_lease(data->master.fd, &mcl), 0);
> + tmp_fd = mcl.fd;
> + igt_assert_eq(create_lease(tmp_fd, &mcl), -EINVAL);
> + close(tmp_fd);
Just reminds me that we should probably enable sub-leasing -- useful in
a multi-head environment where you also want to run leased applications
under one of the heads.
All of these tests look OK to me; as usual, the precise errno values are
subject to interpretation, but it looks like you've made reasonable
choices here making me wonder how reasonable the kernel is :-)
Reviewed-by: Keith Packard <keithp@keithp.com>
--
-keith
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
[-- Attachment #2: Type: text/plain, Size: 153 bytes --]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 3/9] tests/kms_lease: invalid corner-cases for create-lease ioctl
2019-02-21 3:08 ` [igt-dev] [PATCH i-g-t 3/9] " Keith Packard
@ 2019-02-21 9:16 ` Daniel Vetter
0 siblings, 0 replies; 42+ messages in thread
From: Daniel Vetter @ 2019-02-21 9:16 UTC (permalink / raw)
To: Keith Packard; +Cc: IGT development
On Wed, Feb 20, 2019 at 07:08:30PM -0800, Keith Packard wrote:
> Daniel Vetter <daniel.vetter@ffwll.ch> writes:
>
> > Found a few things in the kernel that looks suspicious, separate
> > patches on their way.
>
> Thanks for adding more tests!
>
> > + /* empty lease */
> > + mcl.object_ids = 0;
> > + mcl.object_count = 0;
> > + mcl.flags = 0;
> > + igt_assert_eq(create_lease(data->master.fd, &mcl), -EINVAL);
>
> Not sure why this should be invalid? It's not useful, but then neither
> are 0x0 windows and look at all the pain not allowing them has caused
> over the years...
>
> > +
> > + /* NULL array pointer */
> > + mcl.object_count = 1;
> > + igt_assert_eq(create_lease(data->master.fd, &mcl), -EFAULT);
>
> Should probably explicitly initialize the array pointer here, avoids any
> dependency on the previous test.
>
> > + /* no crtc, non-universal_plane */
> > + drmSetClientCap(data->master.fd, DRM_CLIENT_CAP_UNIVERSAL_PLANES, 0);
> > + object_ids[0] = data->master.display.outputs[0].id;
> > + igt_assert_eq(create_lease(data->master.fd, &mcl), -EINVAL);
>
> Similarly, initialize the object count and pointers explicitly.
>
> > + /* no subleasing */
> > + mcl.object_count = 3;
> > + mcl.flags = 0;
> > + igt_assert_eq(create_lease(data->master.fd, &mcl), 0);
> > + tmp_fd = mcl.fd;
> > + igt_assert_eq(create_lease(tmp_fd, &mcl), -EINVAL);
> > + close(tmp_fd);
>
> Just reminds me that we should probably enable sub-leasing -- useful in
> a multi-head environment where you also want to run leased applications
> under one of the heads.
>
> All of these tests look OK to me; as usual, the precise errno values are
> subject to interpretation, but it looks like you've made reasonable
> choices here making me wonder how reasonable the kernel is :-)
All the test in the current series here reflect current kernel behaviour.
So I didn't pick the errno at all, it's all the kernel. And some took some
amount of digging until I've figured out where they're from.
Hence why I check for NULL/0 in the object_count/ids, later checks making
sure there's no subleasing, and the choice of errno.
> Reviewed-by: Keith Packard <keithp@keithp.com>
Thanks, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 42+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests (rev6)
2019-02-20 16:25 [igt-dev] [PATCH i-g-t 1/9] tests/kms_lease: Add invalid planes tests Daniel Vetter
` (16 preceding siblings ...)
2019-02-21 2:57 ` [igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests (rev5) Patchwork
@ 2019-02-21 12:57 ` Patchwork
2019-02-21 18:24 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
` (5 subsequent siblings)
23 siblings, 0 replies; 42+ messages in thread
From: Patchwork @ 2019-02-21 12:57 UTC (permalink / raw)
To: igt-dev
== Series Details ==
Series: series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests (rev6)
URL : https://patchwork.freedesktop.org/series/56970/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5646 -> IGTPW_2470
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/56970/revisions/6/mbox/
Known issues
------------
Here are the changes found in IGTPW_2470 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_create@basic-files:
- fi-gdg-551: NOTRUN -> SKIP [fdo#109271] +101
* igt@gem_exec_basic@readonly-bsd2:
- fi-pnv-d510: NOTRUN -> SKIP [fdo#109271] +71
* igt@i915_selftest@live_execlists:
- fi-apl-guc: PASS -> INCOMPLETE [fdo#103927]
* igt@kms_busy@basic-flip-a:
- fi-kbl-7567u: PASS -> SKIP [fdo#109271] / [fdo#109278] +2
* igt@kms_busy@basic-flip-b:
- fi-gdg-551: NOTRUN -> FAIL [fdo#103182]
* igt@kms_busy@basic-flip-c:
- fi-gdg-551: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
- fi-pnv-d510: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@runner@aborted:
- fi-apl-guc: NOTRUN -> FAIL [fdo#108622]
#### Possible fixes ####
* igt@i915_selftest@live_execlists:
- {fi-icl-y}: INCOMPLETE [fdo#109567] -> PASS
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: FAIL [fdo#109485] -> PASS
* igt@prime_vgem@basic-fence-flip:
- fi-kbl-7500u: SKIP [fdo#109271] -> PASS +31
#### Warnings ####
* igt@i915_selftest@live_contexts:
- fi-icl-u2: INCOMPLETE [fdo#108569] -> DMESG-FAIL [fdo#108569]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#108622]: https://bugs.freedesktop.org/show_bug.cgi?id=108622
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109485]: https://bugs.freedesktop.org/show_bug.cgi?id=109485
[fdo#109567]: https://bugs.freedesktop.org/show_bug.cgi?id=109567
Participating hosts (43 -> 39)
------------------------------
Additional (2): fi-gdg-551 fi-pnv-d510
Missing (6): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-bdw-samus
Build changes
-------------
* IGT: IGT_4847 -> IGTPW_2470
CI_DRM_5646: f3889cf632f706a356ed78c2197386cf7bc9a4f9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2470: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2470/
IGT_4847: ebf2d10a95fff590542808ec14c7bce74ad11b37 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Testlist changes ==
+igt@kms_lease@implicit-plane-lease
+igt@kms_lease@invalid-create-leases
+igt@kms_lease@lease-uevent
+igt@kms_lease@lease_invalid_plane
+igt@kms_lease@master-vs-lease
+igt@kms_lease@multimaster-lease
+igt@kms_lease@possible-crtcs-filtering
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2470/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 42+ messages in thread
* [igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests (rev6)
2019-02-20 16:25 [igt-dev] [PATCH i-g-t 1/9] tests/kms_lease: Add invalid planes tests Daniel Vetter
` (17 preceding siblings ...)
2019-02-21 12:57 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests (rev6) Patchwork
@ 2019-02-21 18:24 ` Patchwork
2019-02-21 19:28 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests (rev7) Patchwork
` (4 subsequent siblings)
23 siblings, 0 replies; 42+ messages in thread
From: Patchwork @ 2019-02-21 18:24 UTC (permalink / raw)
To: igt-dev
== Series Details ==
Series: series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests (rev6)
URL : https://patchwork.freedesktop.org/series/56970/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_5646_full -> IGTPW_2470_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_2470_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_2470_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/56970/revisions/6/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_2470_full:
### IGT changes ###
#### Possible regressions ####
* {igt@kms_lease@invalid-create-leases} (NEW):
- shard-kbl: NOTRUN -> DMESG-WARN
- shard-glk: NOTRUN -> DMESG-WARN
- shard-apl: NOTRUN -> DMESG-WARN
* igt@runner@aborted:
- shard-kbl: NOTRUN -> FAIL
- shard-apl: NOTRUN -> FAIL
New tests
---------
New tests have been introduced between CI_DRM_5646_full and IGTPW_2470_full:
### New IGT tests (7) ###
* igt@kms_lease@implicit-plane-lease:
- Statuses : 4 pass(s)
- Exec time: [0.0, 0.01] s
* igt@kms_lease@invalid-create-leases:
- Statuses : 3 dmesg-warn(s)
- Exec time: [0.00, 0.02] s
* igt@kms_lease@lease-uevent:
- Statuses : 4 pass(s)
- Exec time: [1.01, 1.11] s
* igt@kms_lease@lease_invalid_plane:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@kms_lease@master-vs-lease:
- Statuses : 4 pass(s)
- Exec time: [0.0, 0.00] s
* igt@kms_lease@multimaster-lease:
- Statuses : 3 pass(s)
- Exec time: [0.00, 0.01] s
* igt@kms_lease@possible-crtcs-filtering:
- Statuses : 4 pass(s)
- Exec time: [0.00, 0.01] s
Known issues
------------
Here are the changes found in IGTPW_2470_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_param@invalid-param-get:
- shard-apl: NOTRUN -> FAIL [fdo#109559]
* igt@gem_tiled_swapping@non-threaded:
- shard-kbl: PASS -> DMESG-WARN [fdo#108686]
* igt@gem_wait@wait-bsd2:
- shard-apl: NOTRUN -> SKIP [fdo#109271] +6
* igt@kms_atomic_transition@3x-modeset-transitions-nonblocking-fencing:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
- shard-glk: NOTRUN -> DMESG-WARN [fdo#107956]
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-f:
- shard-glk: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
- shard-glk: PASS -> FAIL [fdo#108145]
* igt@kms_color@pipe-a-ctm-max:
- shard-kbl: PASS -> FAIL [fdo#108147]
- shard-apl: PASS -> FAIL [fdo#108147]
- shard-glk: NOTRUN -> FAIL [fdo#108147]
* igt@kms_color@pipe-c-legacy-gamma:
- shard-apl: PASS -> FAIL [fdo#104782]
- shard-glk: PASS -> FAIL [fdo#104782]
* igt@kms_cursor_crc@cursor-128x128-sliding:
- shard-apl: PASS -> FAIL [fdo#103232] +2
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen:
- shard-glk: PASS -> FAIL [fdo#103167] +6
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-onoff:
- shard-apl: PASS -> FAIL [fdo#103167]
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-blt:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] +16
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
- shard-glk: NOTRUN -> FAIL [fdo#108145]
* igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb:
- shard-kbl: NOTRUN -> FAIL [fdo#108145]
* igt@kms_plane_multiple@atomic-pipe-b-tiling-none:
- shard-glk: PASS -> FAIL [fdo#103166] +3
* igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
- shard-apl: PASS -> FAIL [fdo#103166] +5
* igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend:
- shard-kbl: PASS -> INCOMPLETE [fdo#103665]
* igt@kms_vblank@pipe-a-ts-continuation-modeset-rpm:
- shard-apl: PASS -> FAIL [fdo#104894]
- shard-kbl: PASS -> FAIL [fdo#104894]
* igt@tools_test@sysfs_l3_parity:
- shard-glk: NOTRUN -> SKIP [fdo#109271] +4
#### Possible fixes ####
* igt@kms_ccs@pipe-b-crc-sprite-planes-basic:
- shard-glk: FAIL [fdo#108145] -> PASS
* igt@kms_color@pipe-b-degamma:
- shard-kbl: FAIL [fdo#104782] -> PASS
- shard-apl: FAIL [fdo#104782] -> PASS
* igt@kms_cursor_crc@cursor-128x128-onscreen:
- shard-kbl: FAIL [fdo#103232] -> PASS +1
* igt@kms_cursor_crc@cursor-128x128-suspend:
- shard-apl: FAIL [fdo#103191] / [fdo#103232] -> PASS
- shard-kbl: FAIL [fdo#103191] / [fdo#103232] -> PASS
* igt@kms_cursor_crc@cursor-256x85-random:
- shard-apl: FAIL [fdo#103232] -> PASS +4
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic:
- shard-hsw: FAIL [fdo#105767] -> PASS
* igt@kms_flip@2x-flip-vs-expired-vblank:
- shard-hsw: FAIL [fdo#102887] -> PASS
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
- shard-glk: FAIL [fdo#105363] -> PASS
* igt@kms_flip@flip-vs-suspend:
- shard-kbl: DMESG-WARN [fdo#108566] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
- shard-apl: FAIL [fdo#103167] -> PASS +1
- shard-kbl: FAIL [fdo#103167] -> PASS
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-pwrite:
- shard-glk: FAIL [fdo#103167] -> PASS +2
* igt@kms_plane_multiple@atomic-pipe-a-tiling-none:
- shard-glk: FAIL [fdo#103166] -> PASS
* igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
- shard-apl: FAIL [fdo#103166] -> PASS +2
* igt@kms_plane_multiple@atomic-pipe-c-tiling-y:
- shard-kbl: FAIL [fdo#103166] -> PASS
* igt@kms_rotation_crc@multiplane-rotation-cropping-top:
- shard-kbl: FAIL [fdo#109016] -> PASS
* igt@kms_setmode@basic:
- shard-hsw: FAIL [fdo#99912] -> PASS
* igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend:
- shard-apl: FAIL [fdo#104894] -> PASS +1
#### Warnings ####
* igt@runner@aborted:
- shard-glk: FAIL [fdo#109373] / [k.org#202321] -> ( 2 FAIL ) [fdo#109373] / [k.org#202321]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
[fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
[fdo#108739]: https://bugs.freedesktop.org/show_bug.cgi?id=108739
[fdo#109016]: https://bugs.freedesktop.org/show_bug.cgi?id=109016
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109373]: https://bugs.freedesktop.org/show_bug.cgi?id=109373
[fdo#109559]: https://bugs.freedesktop.org/show_bug.cgi?id=109559
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
[k.org#202321]: https://bugzilla.kernel.org/show_bug.cgi?id=202321
Participating hosts (6 -> 4)
------------------------------
Missing (2): shard-skl shard-iclb
Build changes
-------------
* IGT: IGT_4847 -> IGTPW_2470
* Piglit: piglit_4509 -> None
CI_DRM_5646: f3889cf632f706a356ed78c2197386cf7bc9a4f9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2470: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2470/
IGT_4847: ebf2d10a95fff590542808ec14c7bce74ad11b37 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2470/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 42+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests (rev7)
2019-02-20 16:25 [igt-dev] [PATCH i-g-t 1/9] tests/kms_lease: Add invalid planes tests Daniel Vetter
` (18 preceding siblings ...)
2019-02-21 18:24 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
@ 2019-02-21 19:28 ` Patchwork
2019-02-22 8:00 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
` (3 subsequent siblings)
23 siblings, 0 replies; 42+ messages in thread
From: Patchwork @ 2019-02-21 19:28 UTC (permalink / raw)
To: igt-dev
== Series Details ==
Series: series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests (rev7)
URL : https://patchwork.freedesktop.org/series/56970/
State : success
== Summary ==
CI Bug Log - changes from IGT_4850 -> IGTPW_2475
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/56970/revisions/7/mbox/
Known issues
------------
Here are the changes found in IGTPW_2475 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-bsw-kefka: PASS -> SKIP [fdo#109271]
* igt@i915_pm_rpm@basic-rte:
- fi-bsw-kefka: PASS -> FAIL [fdo#108800]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#105998]: https://bugs.freedesktop.org/show_bug.cgi?id=105998
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#108800]: https://bugs.freedesktop.org/show_bug.cgi?id=108800
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109294]: https://bugs.freedesktop.org/show_bug.cgi?id=109294
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109527]: https://bugs.freedesktop.org/show_bug.cgi?id=109527
[fdo#109528]: https://bugs.freedesktop.org/show_bug.cgi?id=109528
[fdo#109530]: https://bugs.freedesktop.org/show_bug.cgi?id=109530
Participating hosts (44 -> 35)
------------------------------
Additional (1): fi-icl-y
Missing (10): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-bwr-2160 fi-skl-6260u fi-apl-guc fi-pnv-d510 fi-bdw-samus
Build changes
-------------
* IGT: IGT_4850 -> IGTPW_2475
CI_DRM_5650: a4c5c4791699aeebfff694c222c76abb61900fca @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2475: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2475/
IGT_4850: 8ca0b308acdcf53fac3cf2ea3861f5f911b16986 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Testlist changes ==
+igt@kms_lease@implicit-plane-lease
+igt@kms_lease@invalid-create-leases
+igt@kms_lease@lease-uevent
+igt@kms_lease@lease_invalid_plane
+igt@kms_lease@master-vs-lease
+igt@kms_lease@multimaster-lease
+igt@kms_lease@possible-crtcs-filtering
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2475/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 42+ messages in thread
* [igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests (rev7)
2019-02-20 16:25 [igt-dev] [PATCH i-g-t 1/9] tests/kms_lease: Add invalid planes tests Daniel Vetter
` (19 preceding siblings ...)
2019-02-21 19:28 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests (rev7) Patchwork
@ 2019-02-22 8:00 ` Patchwork
2019-02-22 10:50 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests (rev8) Patchwork
` (2 subsequent siblings)
23 siblings, 0 replies; 42+ messages in thread
From: Patchwork @ 2019-02-22 8:00 UTC (permalink / raw)
To: igt-dev
== Series Details ==
Series: series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests (rev7)
URL : https://patchwork.freedesktop.org/series/56970/
State : failure
== Summary ==
CI Bug Log - changes from IGT_4850_full -> IGTPW_2475_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_2475_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_2475_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/56970/revisions/7/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_2475_full:
### IGT changes ###
#### Possible regressions ####
* {igt@kms_lease@invalid-create-leases} (NEW):
- shard-kbl: NOTRUN -> DMESG-WARN
- shard-hsw: NOTRUN -> DMESG-WARN
- shard-glk: NOTRUN -> DMESG-WARN
- shard-apl: NOTRUN -> DMESG-WARN
* igt@runner@aborted:
- shard-hsw: NOTRUN -> FAIL
- shard-kbl: NOTRUN -> FAIL
- shard-apl: NOTRUN -> FAIL
New tests
---------
New tests have been introduced between IGT_4850_full and IGTPW_2475_full:
### New IGT tests (7) ###
* igt@kms_lease@implicit-plane-lease:
- Statuses : 4 pass(s)
- Exec time: [0.0, 0.00] s
* igt@kms_lease@invalid-create-leases:
- Statuses : 4 dmesg-warn(s)
- Exec time: [0.00, 0.01] s
* igt@kms_lease@lease-uevent:
- Statuses : 4 pass(s)
- Exec time: [1.01, 1.02] s
* igt@kms_lease@lease_invalid_plane:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@kms_lease@master-vs-lease:
- Statuses : 4 pass(s)
- Exec time: [0.0, 0.01] s
* igt@kms_lease@multimaster-lease:
- Statuses : 4 pass(s)
- Exec time: [0.00, 0.01] s
* igt@kms_lease@possible-crtcs-filtering:
- Statuses : 4 pass(s)
- Exec time: [0.00, 0.01] s
Known issues
------------
Here are the changes found in IGTPW_2475_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_pm_backlight@fade:
- shard-glk: NOTRUN -> SKIP [fdo#109271] +11
* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-e:
- shard-hsw: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_ccs@pipe-b-crc-sprite-planes-basic:
- shard-glk: PASS -> FAIL [fdo#108145]
* igt@kms_cursor_crc@cursor-64x21-sliding:
- shard-apl: PASS -> FAIL [fdo#103232]
* igt@kms_cursor_crc@cursor-alpha-opaque:
- shard-glk: PASS -> FAIL [fdo#109350]
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-glk: PASS -> FAIL [fdo#102887] / [fdo#105363]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-wc:
- shard-glk: PASS -> FAIL [fdo#103167] +6
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu:
- shard-apl: PASS -> FAIL [fdo#103167] +2
* igt@kms_frontbuffer_tracking@fbc-2p-rte:
- shard-glk: PASS -> FAIL [fdo#103167] / [fdo#105682]
* igt@kms_plane@pixel-format-pipe-c-planes-source-clamping:
- shard-glk: PASS -> FAIL [fdo#108948]
* igt@kms_plane_alpha_blend@pipe-b-alpha-basic:
- shard-glk: NOTRUN -> FAIL [fdo#108145]
* igt@kms_plane_multiple@atomic-pipe-b-tiling-none:
- shard-glk: PASS -> FAIL [fdo#103166] +5
* igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
- shard-apl: PASS -> FAIL [fdo#103166] +2
- shard-kbl: PASS -> FAIL [fdo#103166]
* igt@kms_psr@primary_page_flip:
- shard-hsw: NOTRUN -> SKIP [fdo#109271] +12
* igt@kms_rotation_crc@multiplane-rotation:
- shard-kbl: PASS -> INCOMPLETE [fdo#103665]
* igt@kms_rotation_crc@multiplane-rotation-cropping-bottom:
- shard-kbl: PASS -> DMESG-FAIL [fdo#105763]
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: PASS -> FAIL [fdo#104894] +1
* igt@kms_vblank@pipe-c-ts-continuation-modeset-hang:
- shard-apl: PASS -> FAIL [fdo#104894] +2
* igt@perf_pmu@most-busy-idle-check-all-vcs1:
- shard-apl: NOTRUN -> SKIP [fdo#109271] +16
#### Possible fixes ####
* igt@i915_pm_rc6_residency@rc6-accuracy:
- shard-kbl: SKIP [fdo#109271] -> PASS
* igt@kms_atomic_transition@1x-modeset-transitions-nonblocking-fencing:
- shard-apl: FAIL [fdo#109660] -> PASS
- shard-kbl: FAIL [fdo#109660] -> PASS
* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-c:
- shard-hsw: DMESG-WARN [fdo#107956] -> PASS
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
- shard-kbl: FAIL [fdo#107725] / [fdo#108145] -> PASS
* igt@kms_color@pipe-c-ctm-max:
- shard-apl: FAIL [fdo#108147] -> PASS
* igt@kms_cursor_crc@cursor-128x128-random:
- shard-apl: FAIL [fdo#103232] -> PASS +6
* igt@kms_cursor_crc@cursor-256x256-suspend:
- shard-hsw: INCOMPLETE [fdo#103540] -> PASS
* igt@kms_cursor_crc@cursor-size-change:
- shard-glk: FAIL [fdo#103232] -> PASS
- shard-kbl: FAIL [fdo#103232] -> PASS +1
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
- shard-apl: FAIL [fdo#103167] -> PASS +3
- shard-kbl: FAIL [fdo#103167] -> PASS
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-move:
- shard-glk: FAIL [fdo#103167] -> PASS +2
* igt@kms_plane@pixel-format-pipe-a-planes-source-clamping:
- shard-apl: FAIL [fdo#108948] -> PASS
* igt@kms_plane@plane-position-covered-pipe-c-planes:
- shard-apl: FAIL [fdo#103166] -> PASS +4
* igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
- shard-glk: FAIL [fdo#108145] -> PASS
* igt@kms_plane_multiple@atomic-pipe-c-tiling-x:
- shard-glk: FAIL [fdo#103166] -> PASS +2
* igt@kms_setmode@basic:
- shard-apl: FAIL [fdo#99912] -> PASS
* igt@kms_universal_plane@universal-plane-pipe-c-functional:
- shard-kbl: FAIL [fdo#103166] -> PASS +2
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105682]: https://bugs.freedesktop.org/show_bug.cgi?id=105682
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#107725]: https://bugs.freedesktop.org/show_bug.cgi?id=107725
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
[fdo#108948]: https://bugs.freedesktop.org/show_bug.cgi?id=108948
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109350]: https://bugs.freedesktop.org/show_bug.cgi?id=109350
[fdo#109660]: https://bugs.freedesktop.org/show_bug.cgi?id=109660
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (6 -> 4)
------------------------------
Missing (2): shard-skl shard-iclb
Build changes
-------------
* IGT: IGT_4850 -> IGTPW_2475
CI_DRM_5650: a4c5c4791699aeebfff694c222c76abb61900fca @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2475: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2475/
IGT_4850: 8ca0b308acdcf53fac3cf2ea3861f5f911b16986 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2475/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 42+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests (rev8)
2019-02-20 16:25 [igt-dev] [PATCH i-g-t 1/9] tests/kms_lease: Add invalid planes tests Daniel Vetter
` (20 preceding siblings ...)
2019-02-22 8:00 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
@ 2019-02-22 10:50 ` Patchwork
2019-02-22 20:23 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-03-14 9:26 ` [igt-dev] [PATCH i-g-t 1/9] tests/kms_lease: Add invalid planes tests Boris Brezillon
23 siblings, 0 replies; 42+ messages in thread
From: Patchwork @ 2019-02-22 10:50 UTC (permalink / raw)
To: igt-dev
== Series Details ==
Series: series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests (rev8)
URL : https://patchwork.freedesktop.org/series/56970/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5653 -> IGTPW_2485
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/56970/revisions/8/mbox/
Known issues
------------
Here are the changes found in IGTPW_2485 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_cs_nop@fork-gfx0:
- fi-icl-u2: NOTRUN -> SKIP [fdo#109315] +17
* igt@amdgpu/amd_cs_nop@sync-fork-compute0:
- fi-icl-u3: NOTRUN -> SKIP [fdo#109315] +17
* igt@gem_exec_basic@gtt-bsd1:
- fi-icl-u3: NOTRUN -> SKIP [fdo#109276] +7
* igt@gem_exec_basic@readonly-bsd1:
- fi-icl-u2: NOTRUN -> SKIP [fdo#109276] +7
* igt@gem_exec_parse@basic-allowed:
- fi-icl-u2: NOTRUN -> SKIP [fdo#109289] +1
* igt@gem_exec_parse@basic-rejected:
- fi-icl-u3: NOTRUN -> SKIP [fdo#109289] +1
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-bsw-kefka: PASS -> SKIP [fdo#109271]
* igt@i915_pm_rpm@basic-rte:
- fi-bsw-kefka: PASS -> FAIL [fdo#108800]
* igt@i915_selftest@live_contexts:
- fi-icl-u3: NOTRUN -> DMESG-FAIL [fdo#108569]
- fi-icl-u2: NOTRUN -> DMESG-FAIL [fdo#108569]
* igt@i915_selftest@live_evict:
- fi-bsw-kefka: PASS -> DMESG-WARN [fdo#107709]
* igt@kms_chamelium@dp-edid-read:
- fi-icl-u2: NOTRUN -> SKIP [fdo#109316] +2
* igt@kms_chamelium@hdmi-crc-fast:
- fi-icl-u2: NOTRUN -> FAIL [fdo#109635 ]
* igt@kms_chamelium@hdmi-edid-read:
- fi-icl-u3: NOTRUN -> SKIP [fdo#109284] +8
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: PASS -> FAIL [fdo#109485]
* igt@kms_chamelium@vga-hpd-fast:
- fi-icl-u2: NOTRUN -> SKIP [fdo#109309] +1
* igt@kms_force_connector_basic@prune-stale-modes:
- fi-icl-u2: NOTRUN -> SKIP [fdo#109285] +3
- fi-icl-u3: NOTRUN -> SKIP [fdo#109285] +3
* igt@kms_frontbuffer_tracking@basic:
- fi-icl-u3: NOTRUN -> FAIL [fdo#103167]
- fi-icl-u2: NOTRUN -> FAIL [fdo#103167]
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- fi-blb-e6850: PASS -> INCOMPLETE [fdo#107718]
* igt@runner@aborted:
- fi-bsw-kefka: NOTRUN -> FAIL [fdo#107709]
#### Possible fixes ####
* igt@i915_selftest@live_execlists:
- fi-apl-guc: INCOMPLETE [fdo#103927] / [fdo#109720] -> PASS
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#107709]: https://bugs.freedesktop.org/show_bug.cgi?id=107709
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#108800]: https://bugs.freedesktop.org/show_bug.cgi?id=108800
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109316]: https://bugs.freedesktop.org/show_bug.cgi?id=109316
[fdo#109485]: https://bugs.freedesktop.org/show_bug.cgi?id=109485
[fdo#109635 ]: https://bugs.freedesktop.org/show_bug.cgi?id=109635
[fdo#109720]: https://bugs.freedesktop.org/show_bug.cgi?id=109720
Participating hosts (43 -> 38)
------------------------------
Additional (2): fi-icl-u2 fi-icl-u3
Missing (7): fi-kbl-soraka fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-pnv-d510 fi-bdw-samus
Build changes
-------------
* IGT: IGT_4851 -> IGTPW_2485
CI_DRM_5653: 4fcf2e7e31b812965e59ccd9787076c7c7a52b78 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2485: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2485/
IGT_4851: 2b7dd10a4e2ea0cabff68421fd15e96c99be3cad @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Testlist changes ==
+igt@kms_lease@implicit-plane-lease
+igt@kms_lease@invalid-create-leases
+igt@kms_lease@lease-uevent
+igt@kms_lease@lease_invalid_plane
+igt@kms_lease@master-vs-lease
+igt@kms_lease@multimaster-lease
+igt@kms_lease@possible-crtcs-filtering
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2485/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 42+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests (rev8)
2019-02-20 16:25 [igt-dev] [PATCH i-g-t 1/9] tests/kms_lease: Add invalid planes tests Daniel Vetter
` (21 preceding siblings ...)
2019-02-22 10:50 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests (rev8) Patchwork
@ 2019-02-22 20:23 ` Patchwork
2019-03-14 9:26 ` [igt-dev] [PATCH i-g-t 1/9] tests/kms_lease: Add invalid planes tests Boris Brezillon
23 siblings, 0 replies; 42+ messages in thread
From: Patchwork @ 2019-02-22 20:23 UTC (permalink / raw)
To: igt-dev
== Series Details ==
Series: series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests (rev8)
URL : https://patchwork.freedesktop.org/series/56970/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5653_full -> IGTPW_2485_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/56970/revisions/8/mbox/
New tests
---------
New tests have been introduced between CI_DRM_5653_full and IGTPW_2485_full:
### New IGT tests (7) ###
* igt@kms_lease@implicit-plane-lease:
- Statuses : 5 pass(s)
- Exec time: [0.0, 0.01] s
* igt@kms_lease@invalid-create-leases:
- Statuses : 5 pass(s)
- Exec time: [0.00, 0.01] s
* igt@kms_lease@lease-uevent:
- Statuses : 5 pass(s)
- Exec time: [1.01, 1.02] s
* igt@kms_lease@lease_invalid_plane:
- Statuses : 5 pass(s)
- Exec time: [0.0] s
* igt@kms_lease@master-vs-lease:
- Statuses : 5 pass(s)
- Exec time: [0.0, 0.00] s
* igt@kms_lease@multimaster-lease:
- Statuses : 5 pass(s)
- Exec time: [0.00] s
* igt@kms_lease@possible-crtcs-filtering:
- Statuses : 5 pass(s)
- Exec time: [0.00, 0.01] s
Known issues
------------
Here are the changes found in IGTPW_2485_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_schedule@preemptive-hang-bsd:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] +6
* igt@gem_tiled_fence_blits@normal:
- shard-snb: PASS -> INCOMPLETE [fdo#105411]
* igt@gem_userptr_blits@process-exit-gtt:
- shard-glk: NOTRUN -> SKIP [fdo#109271] +20
* igt@kms_busy@extended-pageflip-hang-newfb-render-e:
- shard-glk: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +1
* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-a:
- shard-hsw: NOTRUN -> DMESG-WARN [fdo#107956]
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
- shard-kbl: PASS -> FAIL [fdo#107725] / [fdo#108145]
* igt@kms_color@pipe-a-ctm-max:
- shard-apl: PASS -> FAIL [fdo#108147]
* igt@kms_concurrent@pipe-d:
- shard-snb: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +4
* igt@kms_content_protection@atomic:
- shard-snb: NOTRUN -> SKIP [fdo#109271] +33
* igt@kms_cursor_crc@cursor-128x128-random:
- shard-apl: PASS -> FAIL [fdo#103232] +4
* igt@kms_cursor_crc@cursor-256x256-suspend:
- shard-kbl: PASS -> FAIL [fdo#103191] / [fdo#103232]
- shard-apl: PASS -> FAIL [fdo#103191] / [fdo#103232]
* igt@kms_cursor_crc@cursor-64x21-onscreen:
- shard-kbl: PASS -> FAIL [fdo#103232] +3
* igt@kms_cursor_crc@cursor-64x64-random:
- shard-apl: NOTRUN -> FAIL [fdo#103232]
* igt@kms_cursor_crc@cursor-alpha-opaque:
- shard-apl: PASS -> FAIL [fdo#109350]
- shard-glk: PASS -> FAIL [fdo#109350]
* igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic:
- shard-glk: PASS -> FAIL [fdo#105454] / [fdo#106509]
* igt@kms_flip@2x-plain-flip-ts-check:
- shard-apl: NOTRUN -> SKIP [fdo#109271] +17
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-cpu:
- shard-kbl: PASS -> FAIL [fdo#103167]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render:
- shard-apl: PASS -> FAIL [fdo#103167] +2
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff:
- shard-glk: PASS -> FAIL [fdo#103167] +6
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-indfb-draw-mmap-cpu:
- shard-hsw: NOTRUN -> SKIP [fdo#109271] +2
* igt@kms_plane@pixel-format-pipe-a-planes-source-clamping:
- shard-kbl: PASS -> FAIL [fdo#108948]
* igt@kms_plane@pixel-format-pipe-b-planes-source-clamping:
- shard-apl: PASS -> FAIL [fdo#108948] +1
* igt@kms_plane_multiple@atomic-pipe-b-tiling-none:
- shard-apl: PASS -> FAIL [fdo#103166] +4
* igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
- shard-glk: PASS -> FAIL [fdo#103166] +6
#### Possible fixes ####
* igt@gem_exec_flush@basic-uc-rw-default:
- shard-hsw: INCOMPLETE [fdo#103540] -> PASS
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
- shard-snb: DMESG-WARN [fdo#107956] -> PASS
* igt@kms_color@pipe-a-degamma:
- shard-kbl: FAIL [fdo#104782] / [fdo#108145] -> PASS
* igt@kms_color@pipe-a-gamma:
- shard-kbl: FAIL [fdo#104782] -> PASS
* igt@kms_cursor_crc@cursor-128x128-dpms:
- shard-kbl: FAIL [fdo#103232] -> PASS +2
* igt@kms_cursor_crc@cursor-256x256-random:
- shard-apl: FAIL [fdo#103232] -> PASS +3
* igt@kms_cursor_crc@cursor-64x64-suspend:
- shard-apl: FAIL [fdo#103191] / [fdo#103232] -> PASS
* igt@kms_flip@modeset-vs-vblank-race:
- shard-glk: FAIL [fdo#103060] -> PASS +1
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt:
- shard-kbl: FAIL [fdo#103167] -> PASS +1
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
- shard-apl: FAIL [fdo#103167] -> PASS +4
* igt@kms_frontbuffer_tracking@fbc-1p-rte:
- shard-snb: INCOMPLETE [fdo#105411] / [fdo#107469] -> PASS
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-blt:
- shard-glk: FAIL [fdo#103167] -> PASS +2
* igt@kms_plane@plane-position-covered-pipe-c-planes:
- shard-apl: FAIL [fdo#103166] -> PASS +1
* igt@kms_rotation_crc@multiplane-rotation-cropping-bottom:
- shard-kbl: DMESG-FAIL [fdo#105763] -> PASS
* igt@kms_setmode@basic:
- shard-kbl: FAIL [fdo#99912] -> PASS
* igt@testdisplay:
- shard-kbl: INCOMPLETE [fdo#103665] -> PASS +1
- shard-apl: INCOMPLETE [fdo#103927] -> PASS
[fdo#103060]: https://bugs.freedesktop.org/show_bug.cgi?id=103060
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#105454]: https://bugs.freedesktop.org/show_bug.cgi?id=105454
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#106509]: https://bugs.freedesktop.org/show_bug.cgi?id=106509
[fdo#107469]: https://bugs.freedesktop.org/show_bug.cgi?id=107469
[fdo#107725]: https://bugs.freedesktop.org/show_bug.cgi?id=107725
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
[fdo#108948]: https://bugs.freedesktop.org/show_bug.cgi?id=108948
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109350]: https://bugs.freedesktop.org/show_bug.cgi?id=109350
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (7 -> 5)
------------------------------
Missing (2): shard-skl shard-iclb
Build changes
-------------
* IGT: IGT_4851 -> IGTPW_2485
* Piglit: piglit_4509 -> None
CI_DRM_5653: 4fcf2e7e31b812965e59ccd9787076c7c7a52b78 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2485: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2485/
IGT_4851: 2b7dd10a4e2ea0cabff68421fd15e96c99be3cad @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2485/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 1/9] tests/kms_lease: Add invalid planes tests
2019-02-20 16:25 [igt-dev] [PATCH i-g-t 1/9] tests/kms_lease: Add invalid planes tests Daniel Vetter
` (22 preceding siblings ...)
2019-02-22 20:23 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
@ 2019-03-14 9:26 ` Boris Brezillon
23 siblings, 0 replies; 42+ messages in thread
From: Boris Brezillon @ 2019-03-14 9:26 UTC (permalink / raw)
To: Daniel Vetter; +Cc: IGT development, Keith Packard
On Wed, 20 Feb 2019 17:25:22 +0100
Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> Test gap because we're using universal planes by default. Fix that.
>
> Cc: Keith Packard <keithp@keithp.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
> ---
> tests/kms_lease.c | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/tests/kms_lease.c b/tests/kms_lease.c
> index cca424598ea7..70a96362d77a 100644
> --- a/tests/kms_lease.c
> +++ b/tests/kms_lease.c
> @@ -573,6 +573,20 @@ static void lease_invalid_crtc(data_t *data)
> igt_assert_eq(ret, -EINVAL);
> }
>
> +static void lease_invalid_plane(data_t *data)
> +{
> + lease_t lease;
> + uint32_t save_plane_id;
> + int ret;
> +
> + /* Create an invalid lease */
> + save_plane_id = data->plane_id;
> + data->plane_id = 0xbaadf00d;
> + ret = make_lease(data, &lease);
> + data->plane_id = save_plane_id;
> + igt_assert_eq(ret, -EINVAL);
> +}
> +
>
> static void run_test(data_t *data, void (*testfunc)(data_t *))
> {
> @@ -625,6 +639,7 @@ igt_main
> { "lease_again", lease_again },
> { "lease_invalid_connector", lease_invalid_connector },
> { "lease_invalid_crtc", lease_invalid_crtc },
> + { "lease_invalid_plane", lease_invalid_plane },
> { }
> }, *f;
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 2/9] tests/kms_lease: Run on simulation
2019-02-20 16:25 ` [igt-dev] [PATCH i-g-t 2/9] tests/kms_lease: Run on simulation Daniel Vetter
@ 2019-03-14 9:29 ` Boris Brezillon
0 siblings, 0 replies; 42+ messages in thread
From: Boris Brezillon @ 2019-03-14 9:29 UTC (permalink / raw)
To: Daniel Vetter; +Cc: IGT development, Keith Packard
On Wed, 20 Feb 2019 17:25:23 +0100
Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> It's all kernel code that's being tested here, no reason not to run
> in simulated environments ...
>
> Cc: Keith Packard <keithp@keithp.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
> ---
> tests/kms_lease.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/tests/kms_lease.c b/tests/kms_lease.c
> index 70a96362d77a..fa97f6e11334 100644
> --- a/tests/kms_lease.c
> +++ b/tests/kms_lease.c
> @@ -643,8 +643,6 @@ igt_main
> { }
> }, *f;
>
> - igt_skip_on_simulation();
> -
> igt_fixture {
> data.master.fd = drm_open_driver_master(DRIVER_ANY);
> kmstest_set_vt_graphics_mode();
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 4/9] tests/kms_release: invalid checks for revoke-lease ioctl
2019-02-20 16:25 ` [igt-dev] [PATCH i-g-t 4/9] tests/kms_release: invalid checks for revoke-lease ioctl Daniel Vetter
@ 2019-03-14 9:35 ` Boris Brezillon
0 siblings, 0 replies; 42+ messages in thread
From: Boris Brezillon @ 2019-03-14 9:35 UTC (permalink / raw)
To: Daniel Vetter; +Cc: IGT development, Daniel Vetter, Keith Packard
On Wed, 20 Feb 2019 17:25:25 +0100
Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> Found a few corner cases to validate. Put them into the existing
> testcase.
>
> Cc: Keith Packard <keithp@keithp.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
> ---
> tests/kms_lease.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/tests/kms_lease.c b/tests/kms_lease.c
> index 4062a0b365c9..298d81c71ba9 100644
> --- a/tests/kms_lease.c
> +++ b/tests/kms_lease.c
> @@ -511,6 +511,14 @@ static void lease_revoke(data_t *data)
>
> igt_display_require(&lease.display, lease.fd);
>
> + /* try to revoke an invalid lease */
> + mrl.lessee_id = 0;
> + igt_assert_eq(revoke_lease(data->master.fd, &mrl), -ENOENT);
> +
> + /* try to revoke with the wrong fd */
> + mrl.lessee_id = lease.lessee_id;
> + igt_assert_eq(revoke_lease(lease.fd, &mrl), -EACCES);
> +
> /* Revoke the lease using the master fd */
> mrl.lessee_id = lease.lessee_id;
> igt_assert_eq(revoke_lease(data->master.fd, &mrl), 0);
> @@ -522,6 +530,10 @@ static void lease_revoke(data_t *data)
> igt_assert_eq(ret, -ENOENT);
>
> terminate_lease(&lease);
> +
> + /* make sure the lease is gone */
> + mrl.lessee_id = lease.lessee_id;
> + igt_assert_eq(revoke_lease(data->master.fd, &mrl), -ENOENT);
> }
>
> /* Test leasing objects more than once */
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 42+ messages in thread
end of thread, other threads:[~2019-03-14 9:35 UTC | newest]
Thread overview: 42+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-20 16:25 [igt-dev] [PATCH i-g-t 1/9] tests/kms_lease: Add invalid planes tests Daniel Vetter
2019-02-20 16:25 ` [igt-dev] [PATCH i-g-t 2/9] tests/kms_lease: Run on simulation Daniel Vetter
2019-03-14 9:29 ` Boris Brezillon
2019-02-20 16:25 ` [igt-dev] [PATCH i-g-t 3/9] tests/kms_lease: invalid corner-cases for create-lease ioctl Daniel Vetter
2019-02-20 20:43 ` Lyude Paul
2019-02-20 21:20 ` Daniel Vetter
2019-02-20 21:23 ` [igt-dev] [PATCH i-g-t] " Daniel Vetter
2019-02-21 3:08 ` [igt-dev] [PATCH i-g-t 3/9] " Keith Packard
2019-02-21 9:16 ` Daniel Vetter
2019-02-20 16:25 ` [igt-dev] [PATCH i-g-t 4/9] tests/kms_release: invalid checks for revoke-lease ioctl Daniel Vetter
2019-03-14 9:35 ` Boris Brezillon
2019-02-20 16:25 ` [igt-dev] [PATCH i-g-t 5/9] tests/kms_lease: validate the possible_crtcs filtering Daniel Vetter
2019-02-20 16:25 ` [igt-dev] [PATCH i-g-t 6/9] tests/kms_lease: Test drop/set_master interactions Daniel Vetter
2019-02-20 16:25 ` [igt-dev] [PATCH i-g-t 7/9] tests/kms_lease: multimaster testcase Daniel Vetter
2019-02-20 16:25 ` [igt-dev] [PATCH i-g-t 8/9] tests/kms_lease: validate implicitly added planes Daniel Vetter
2019-02-20 16:25 ` [igt-dev] [PATCH i-g-t 9/9] tests/kms_lease: exercise uevent Daniel Vetter
2019-02-20 20:33 ` [igt-dev] [PATCH i-g-t] " Daniel Vetter
2019-02-20 22:25 ` Lyude Paul
2019-02-20 23:33 ` Daniel Vetter
2019-02-20 23:34 ` Lyude Paul
2019-02-20 21:01 ` Daniel Vetter
2019-02-20 21:17 ` Daniel Vetter
2019-02-20 23:42 ` Lyude Paul
2019-02-20 23:48 ` Daniel Vetter
2019-02-21 0:16 ` Lyude Paul
2019-02-20 17:00 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests Patchwork
2019-02-20 19:51 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2019-02-20 20:42 ` Daniel Vetter
2019-02-20 21:11 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests (rev2) Patchwork
2019-02-20 21:51 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests (rev3) Patchwork
2019-02-20 22:02 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests (rev5) Patchwork
2019-02-20 22:26 ` [igt-dev] [PATCH i-g-t 1/9] tests/kms_lease: Add invalid planes tests Lyude Paul
2019-02-21 1:25 ` [igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests (rev2) Patchwork
2019-02-21 1:52 ` [igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests (rev3) Patchwork
2019-02-21 2:57 ` [igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests (rev5) Patchwork
2019-02-21 12:57 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests (rev6) Patchwork
2019-02-21 18:24 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2019-02-21 19:28 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests (rev7) Patchwork
2019-02-22 8:00 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2019-02-22 10:50 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/9] tests/kms_lease: Add invalid planes tests (rev8) Patchwork
2019-02-22 20:23 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-03-14 9:26 ` [igt-dev] [PATCH i-g-t 1/9] tests/kms_lease: Add invalid planes tests Boris Brezillon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.