From: Dave Martin <Dave.Martin@arm.com> To: Andrew Jones <drjones@redhat.com> Cc: Okamoto Takayuki <tokamoto@jp.fujitsu.com>, Christoffer Dall <cdall@kernel.org>, Ard Biesheuvel <ard.biesheuvel@linaro.org>, Marc Zyngier <marc.zyngier@arm.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will.deacon@arm.com>, Zhang Lei <zhang.lei@jp.fujitsu.com>, Julien Grall <julien.grall@arm.com>, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v7 13/27] KVM: arm64/sve: Context switch the SVE registers Date: Thu, 4 Apr 2019 09:10:08 +0100 [thread overview] Message-ID: <20190404081008.GY3567@e103592.cambridge.arm.com> (raw) In-Reply-To: <20190403200145.c2oep2hbugl7db5t@kamzik.brq.redhat.com> On Wed, Apr 03, 2019 at 10:01:45PM +0200, Andrew Jones wrote: > On Fri, Mar 29, 2019 at 01:00:38PM +0000, Dave Martin wrote: > > In order to give each vcpu its own view of the SVE registers, this > > patch adds context storage via a new sve_state pointer in struct > > vcpu_arch. An additional member sve_max_vl is also added for each > > vcpu, to determine the maximum vector length visible to the guest > > and thus the value to be configured in ZCR_EL2.LEN while the vcpu > > is active. This also determines the layout and size of the storage > > in sve_state, which is read and written by the same backend > > functions that are used for context-switching the SVE state for > > host tasks. > > > > On SVE-enabled vcpus, SVE access traps are now handled by switching > > in the vcpu's SVE context and disabling the trap before returning > > to the guest. On other vcpus, the trap is not handled and an exit > > back to the host occurs, where the handle_sve() fallback path > > reflects an undefined instruction exception back to the guest, > > consistently with the behaviour of non-SVE-capable hardware (as was > > done unconditionally prior to this patch). > > > > No SVE handling is added on non-VHE-only paths, since VHE is an > > architectural and Kconfig prerequisite of SVE. > > > > Signed-off-by: Dave Martin <Dave.Martin@arm.com> > > Reviewed-by: Julien Thierry <julien.thierry@arm.com> > > Tested-by: zhang.lei <zhang.lei@jp.fujitsu.com> > > > > --- > > > > Changes since v5: > > > > * [Julien Thierry, Julien Grall] Commit message typo fixes > > > > * [Mark Rutland] Rename trap_class to hsr_ec, for consistency with > > existing code. > > > > * [Mark Rutland] Simplify condition for refusing to handle an > > FPSIMD/SVE trap, using multiple if () statements for clarity. The > > previous condition was a bit tortuous, and how that the static_key > > checks have been hoisted out, it makes little difference to the > > compiler how we express the condition here. > > --- > > arch/arm64/include/asm/kvm_host.h | 6 ++++ > > arch/arm64/kvm/fpsimd.c | 5 +-- > > arch/arm64/kvm/hyp/switch.c | 75 +++++++++++++++++++++++++++++---------- > > 3 files changed, 66 insertions(+), 20 deletions(-) > > > > diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm_host.h > > index 22cf484..4fabfd2 100644 > > --- a/arch/arm64/include/asm/kvm_host.h > > +++ b/arch/arm64/include/asm/kvm_host.h > > @@ -228,6 +228,8 @@ struct vcpu_reset_state { > > > > struct kvm_vcpu_arch { > > struct kvm_cpu_context ctxt; > > + void *sve_state; > > + unsigned int sve_max_vl; > > > > /* HYP configuration */ > > u64 hcr_el2; > > @@ -323,6 +325,10 @@ struct kvm_vcpu_arch { > > bool sysregs_loaded_on_cpu; > > }; > > > > +/* Pointer to the vcpu's SVE FFR for sve_{save,load}_state() */ > > +#define vcpu_sve_pffr(vcpu) ((void *)((char *)((vcpu)->arch.sve_state) + \ > > + sve_ffr_offset((vcpu)->arch.sve_max_vl))) > > Maybe an inline function instead? I tried, but that requires the definition of struct kvm_vcpu to be visible. I failed to get that here without circular #include problems, and it looked tricky to fix. Since this is a small bit of code which is unlikely to get used by accident, I decided it was OK to keep it as a macro. Can you see another way around this? [...] > Reviewed-by: Andrew Jones <drjones@redhat.com> Thanks ---Dave
WARNING: multiple messages have this Message-ID (diff)
From: Dave Martin <Dave.Martin@arm.com> To: Andrew Jones <drjones@redhat.com> Cc: Okamoto Takayuki <tokamoto@jp.fujitsu.com>, Christoffer Dall <cdall@kernel.org>, Ard Biesheuvel <ard.biesheuvel@linaro.org>, Marc Zyngier <marc.zyngier@arm.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will.deacon@arm.com>, Zhang Lei <zhang.lei@jp.fujitsu.com>, Julien Grall <julien.grall@arm.com>, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v7 13/27] KVM: arm64/sve: Context switch the SVE registers Date: Thu, 4 Apr 2019 09:10:08 +0100 [thread overview] Message-ID: <20190404081008.GY3567@e103592.cambridge.arm.com> (raw) In-Reply-To: <20190403200145.c2oep2hbugl7db5t@kamzik.brq.redhat.com> On Wed, Apr 03, 2019 at 10:01:45PM +0200, Andrew Jones wrote: > On Fri, Mar 29, 2019 at 01:00:38PM +0000, Dave Martin wrote: > > In order to give each vcpu its own view of the SVE registers, this > > patch adds context storage via a new sve_state pointer in struct > > vcpu_arch. An additional member sve_max_vl is also added for each > > vcpu, to determine the maximum vector length visible to the guest > > and thus the value to be configured in ZCR_EL2.LEN while the vcpu > > is active. This also determines the layout and size of the storage > > in sve_state, which is read and written by the same backend > > functions that are used for context-switching the SVE state for > > host tasks. > > > > On SVE-enabled vcpus, SVE access traps are now handled by switching > > in the vcpu's SVE context and disabling the trap before returning > > to the guest. On other vcpus, the trap is not handled and an exit > > back to the host occurs, where the handle_sve() fallback path > > reflects an undefined instruction exception back to the guest, > > consistently with the behaviour of non-SVE-capable hardware (as was > > done unconditionally prior to this patch). > > > > No SVE handling is added on non-VHE-only paths, since VHE is an > > architectural and Kconfig prerequisite of SVE. > > > > Signed-off-by: Dave Martin <Dave.Martin@arm.com> > > Reviewed-by: Julien Thierry <julien.thierry@arm.com> > > Tested-by: zhang.lei <zhang.lei@jp.fujitsu.com> > > > > --- > > > > Changes since v5: > > > > * [Julien Thierry, Julien Grall] Commit message typo fixes > > > > * [Mark Rutland] Rename trap_class to hsr_ec, for consistency with > > existing code. > > > > * [Mark Rutland] Simplify condition for refusing to handle an > > FPSIMD/SVE trap, using multiple if () statements for clarity. The > > previous condition was a bit tortuous, and how that the static_key > > checks have been hoisted out, it makes little difference to the > > compiler how we express the condition here. > > --- > > arch/arm64/include/asm/kvm_host.h | 6 ++++ > > arch/arm64/kvm/fpsimd.c | 5 +-- > > arch/arm64/kvm/hyp/switch.c | 75 +++++++++++++++++++++++++++++---------- > > 3 files changed, 66 insertions(+), 20 deletions(-) > > > > diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm_host.h > > index 22cf484..4fabfd2 100644 > > --- a/arch/arm64/include/asm/kvm_host.h > > +++ b/arch/arm64/include/asm/kvm_host.h > > @@ -228,6 +228,8 @@ struct vcpu_reset_state { > > > > struct kvm_vcpu_arch { > > struct kvm_cpu_context ctxt; > > + void *sve_state; > > + unsigned int sve_max_vl; > > > > /* HYP configuration */ > > u64 hcr_el2; > > @@ -323,6 +325,10 @@ struct kvm_vcpu_arch { > > bool sysregs_loaded_on_cpu; > > }; > > > > +/* Pointer to the vcpu's SVE FFR for sve_{save,load}_state() */ > > +#define vcpu_sve_pffr(vcpu) ((void *)((char *)((vcpu)->arch.sve_state) + \ > > + sve_ffr_offset((vcpu)->arch.sve_max_vl))) > > Maybe an inline function instead? I tried, but that requires the definition of struct kvm_vcpu to be visible. I failed to get that here without circular #include problems, and it looked tricky to fix. Since this is a small bit of code which is unlikely to get used by accident, I decided it was OK to keep it as a macro. Can you see another way around this? [...] > Reviewed-by: Andrew Jones <drjones@redhat.com> Thanks ---Dave _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-04-04 8:10 UTC|newest] Thread overview: 224+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-29 13:00 [PATCH v7 00/27] KVM: arm64: SVE guest support Dave Martin 2019-03-29 13:00 ` Dave Martin 2019-03-29 13:00 ` [PATCH v7 01/27] KVM: Documentation: Document arm64 core registers in detail Dave Martin 2019-03-29 13:00 ` Dave Martin 2019-04-24 9:25 ` Alex Bennée 2019-04-24 9:25 ` Alex Bennée 2019-03-29 13:00 ` [PATCH v7 02/27] arm64: fpsimd: Always set TIF_FOREIGN_FPSTATE on task state flush Dave Martin 2019-03-29 13:00 ` Dave Martin 2019-03-29 13:00 ` [PATCH v7 03/27] KVM: arm64: Delete orphaned declaration for __fpsimd_enabled() Dave Martin 2019-03-29 13:00 ` Dave Martin 2019-03-29 13:00 ` [PATCH v7 04/27] KVM: arm64: Refactor kvm_arm_num_regs() for easier maintenance Dave Martin 2019-03-29 13:00 ` Dave Martin 2019-03-29 13:00 ` [PATCH v7 05/27] KVM: arm64: Add missing #includes to kvm_host.h Dave Martin 2019-03-29 13:00 ` Dave Martin 2019-03-29 13:00 ` [PATCH v7 06/27] arm64/sve: Clarify role of the VQ map maintenance functions Dave Martin 2019-03-29 13:00 ` Dave Martin 2019-04-04 21:21 ` Andrew Jones 2019-04-04 21:21 ` Andrew Jones 2019-03-29 13:00 ` [PATCH v7 07/27] arm64/sve: Check SVE virtualisability Dave Martin 2019-03-29 13:00 ` Dave Martin 2019-04-04 21:21 ` Andrew Jones 2019-04-04 21:21 ` Andrew Jones 2019-04-05 9:35 ` Dave Martin 2019-04-05 9:35 ` Dave Martin 2019-03-29 13:00 ` [PATCH v7 08/27] arm64/sve: Enable SVE state tracking for non-task contexts Dave Martin 2019-03-29 13:00 ` Dave Martin 2019-03-29 13:00 ` [PATCH v7 09/27] KVM: arm64: Add a vcpu flag to control SVE visibility for the guest Dave Martin 2019-03-29 13:00 ` Dave Martin 2019-04-03 19:14 ` Andrew Jones 2019-04-03 19:14 ` Andrew Jones 2019-04-04 3:17 ` Marc Zyngier 2019-04-04 3:17 ` Marc Zyngier 2019-04-04 7:53 ` Dave Martin 2019-04-04 7:53 ` Dave Martin 2019-04-04 21:15 ` Andrew Jones 2019-04-04 21:15 ` Andrew Jones 2019-03-29 13:00 ` [PATCH v7 10/27] KVM: arm64: Propagate vcpu into read_id_reg() Dave Martin 2019-03-29 13:00 ` Dave Martin 2019-04-04 21:15 ` Andrew Jones 2019-04-04 21:15 ` Andrew Jones 2019-03-29 13:00 ` [PATCH v7 11/27] KVM: arm64: Support runtime sysreg visibility filtering Dave Martin 2019-03-29 13:00 ` Dave Martin 2019-04-03 19:17 ` Andrew Jones 2019-04-03 19:17 ` Andrew Jones 2019-04-24 9:39 ` Alex Bennée 2019-04-24 9:39 ` Alex Bennée 2019-04-24 13:47 ` Dave Martin 2019-04-24 13:47 ` Dave Martin 2019-04-24 13:47 ` Dave Martin 2019-03-29 13:00 ` [PATCH v7 12/27] KVM: arm64/sve: System register context switch and access support Dave Martin 2019-03-29 13:00 ` Dave Martin 2019-04-03 19:39 ` Andrew Jones 2019-04-03 19:39 ` Andrew Jones 2019-04-04 8:06 ` Dave Martin 2019-04-04 8:06 ` Dave Martin 2019-04-04 8:32 ` Andrew Jones 2019-04-04 8:32 ` Andrew Jones 2019-04-04 8:47 ` Dave Martin 2019-04-04 8:47 ` Dave Martin 2019-04-04 8:59 ` Andrew Jones 2019-04-04 8:59 ` Andrew Jones 2019-04-24 15:21 ` Alex Bennée 2019-04-24 15:21 ` Alex Bennée 2019-04-25 13:28 ` Dave Martin 2019-04-25 13:28 ` Dave Martin 2019-04-25 13:28 ` Dave Martin 2019-03-29 13:00 ` [PATCH v7 13/27] KVM: arm64/sve: Context switch the SVE registers Dave Martin 2019-03-29 13:00 ` Dave Martin 2019-04-03 20:01 ` Andrew Jones 2019-04-03 20:01 ` Andrew Jones 2019-04-04 8:10 ` Dave Martin [this message] 2019-04-04 8:10 ` Dave Martin 2019-04-04 8:35 ` Andrew Jones 2019-04-04 8:35 ` Andrew Jones 2019-04-04 8:36 ` Dave Martin 2019-04-04 8:36 ` Dave Martin 2019-04-24 14:51 ` Alex Bennée 2019-04-24 14:51 ` Alex Bennée 2019-04-25 13:35 ` Dave Martin 2019-04-25 13:35 ` Dave Martin 2019-04-25 13:35 ` Dave Martin 2019-03-29 13:00 ` [PATCH v7 14/27] KVM: Allow 2048-bit register access via ioctl interface Dave Martin 2019-03-29 13:00 ` Dave Martin 2019-04-04 21:11 ` Andrew Jones 2019-04-04 21:11 ` Andrew Jones 2019-03-29 13:00 ` [PATCH v7 15/27] KVM: arm64: Add missing #include of <linux/string.h> in guest.c Dave Martin 2019-03-29 13:00 ` Dave Martin 2019-03-29 13:00 ` [PATCH v7 16/27] KVM: arm64: Factor out core register ID enumeration Dave Martin 2019-03-29 13:00 ` Dave Martin 2019-04-02 2:41 ` Marc Zyngier 2019-04-02 2:41 ` Marc Zyngier 2019-04-02 8:59 ` Dave Martin 2019-04-02 8:59 ` Dave Martin 2019-04-02 9:32 ` Marc Zyngier 2019-04-02 9:32 ` Marc Zyngier 2019-04-02 9:54 ` Dave P Martin 2019-04-02 9:54 ` Dave P Martin 2019-03-29 13:00 ` [PATCH v7 17/27] KVM: arm64: Reject ioctl access to FPSIMD V-regs on SVE vcpus Dave Martin 2019-03-29 13:00 ` Dave Martin 2019-04-03 20:15 ` Andrew Jones 2019-04-03 20:15 ` Andrew Jones 2019-04-24 13:45 ` Alex Bennée 2019-04-24 13:45 ` Alex Bennée 2019-03-29 13:00 ` [PATCH v7 18/27] KVM: arm64/sve: Add SVE support to register access ioctl interface Dave Martin 2019-03-29 13:00 ` Dave Martin 2019-04-04 13:57 ` Andrew Jones 2019-04-04 13:57 ` Andrew Jones 2019-04-04 14:50 ` Dave Martin 2019-04-04 14:50 ` Dave Martin 2019-04-04 16:25 ` Andrew Jones 2019-04-04 16:25 ` Andrew Jones 2019-04-04 16:56 ` Dave Martin 2019-04-04 16:56 ` Dave Martin 2019-03-29 13:00 ` [PATCH v7 19/27] KVM: arm64: Enumerate SVE register indices for KVM_GET_REG_LIST Dave Martin 2019-03-29 13:00 ` Dave Martin 2019-04-04 14:08 ` Andrew Jones 2019-04-04 14:08 ` Andrew Jones 2019-04-05 9:35 ` Dave Martin 2019-04-05 9:35 ` Dave Martin 2019-04-05 9:45 ` Andrew Jones 2019-04-05 9:45 ` Andrew Jones 2019-04-05 11:11 ` Dave Martin 2019-04-05 11:11 ` Dave Martin 2019-03-29 13:00 ` [PATCH v7 20/27] arm64/sve: In-kernel vector length availability query interface Dave Martin 2019-03-29 13:00 ` Dave Martin 2019-04-04 14:20 ` Andrew Jones 2019-04-04 14:20 ` Andrew Jones 2019-04-05 9:35 ` Dave Martin 2019-04-05 9:35 ` Dave Martin 2019-04-05 9:54 ` Andrew Jones 2019-04-05 9:54 ` Andrew Jones 2019-04-05 11:13 ` Dave Martin 2019-04-05 11:13 ` Dave Martin 2019-03-29 13:00 ` [PATCH v7 21/27] KVM: arm/arm64: Add hook for arch-specific KVM initialisation Dave Martin 2019-03-29 13:00 ` Dave Martin 2019-04-04 14:25 ` Andrew Jones 2019-04-04 14:25 ` Andrew Jones 2019-04-04 14:53 ` Dave Martin 2019-04-04 14:53 ` Dave Martin 2019-04-04 16:33 ` Andrew Jones 2019-04-04 16:33 ` Andrew Jones 2019-04-05 9:36 ` Dave Martin 2019-04-05 9:36 ` Dave Martin 2019-04-05 10:40 ` Andrew Jones 2019-04-05 10:40 ` Andrew Jones 2019-04-05 11:14 ` Dave Martin 2019-04-05 11:14 ` Dave Martin 2019-03-29 13:00 ` [PATCH v7 22/27] KVM: arm/arm64: Add KVM_ARM_VCPU_FINALIZE ioctl Dave Martin 2019-03-29 13:00 ` Dave Martin 2019-04-04 15:07 ` Andrew Jones 2019-04-04 15:07 ` Andrew Jones 2019-04-04 16:47 ` Dave Martin 2019-04-04 16:47 ` Dave Martin 2019-03-29 13:00 ` [PATCH v7 23/27] KVM: arm64/sve: Add pseudo-register for the guest's vector lengths Dave Martin 2019-03-29 13:00 ` Dave Martin 2019-04-04 20:18 ` Andrew Jones 2019-04-04 20:18 ` Andrew Jones 2019-04-05 9:36 ` Dave Martin 2019-04-05 9:36 ` Dave Martin 2019-04-05 10:14 ` Andrew Jones 2019-04-05 10:14 ` Andrew Jones 2019-04-05 12:54 ` Dave Martin 2019-04-05 12:54 ` Dave Martin 2019-04-05 15:33 ` Andrew Jones 2019-04-05 15:33 ` Andrew Jones 2019-04-10 12:42 ` Dave Martin 2019-04-10 12:42 ` Dave Martin 2019-04-10 12:42 ` Dave Martin 2019-04-04 20:31 ` Andrew Jones 2019-04-04 20:31 ` Andrew Jones 2019-04-05 9:36 ` Dave Martin 2019-04-05 9:36 ` Dave Martin 2019-04-05 10:22 ` Andrew Jones 2019-04-05 10:22 ` Andrew Jones 2019-04-05 14:06 ` Dave Martin 2019-04-05 14:06 ` Dave Martin 2019-04-05 15:41 ` Andrew Jones 2019-04-05 15:41 ` Andrew Jones 2019-04-10 12:35 ` Dave Martin 2019-04-10 12:35 ` Dave Martin 2019-04-10 12:35 ` Dave Martin 2019-03-29 13:00 ` [PATCH v7 24/27] KVM: arm64/sve: Allow userspace to enable SVE for vcpus Dave Martin 2019-03-29 13:00 ` Dave Martin 2019-04-04 20:36 ` Andrew Jones 2019-04-04 20:36 ` Andrew Jones 2019-03-29 13:00 ` [PATCH v7 25/27] KVM: arm64: Add a capability to advertise SVE support Dave Martin 2019-03-29 13:00 ` Dave Martin 2019-04-04 20:39 ` Andrew Jones 2019-04-04 20:39 ` Andrew Jones 2019-03-29 13:00 ` [PATCH v7 26/27] KVM: Document errors for KVM_GET_ONE_REG and KVM_SET_ONE_REG Dave Martin 2019-03-29 13:00 ` Dave Martin 2019-04-03 20:27 ` Andrew Jones 2019-04-03 20:27 ` Andrew Jones 2019-04-04 8:35 ` Dave Martin 2019-04-04 8:35 ` Dave Martin 2019-04-04 9:34 ` Andrew Jones 2019-04-04 9:34 ` Andrew Jones 2019-04-04 9:38 ` Dave P Martin 2019-04-04 9:38 ` Dave P Martin 2019-04-04 9:45 ` Andrew Jones 2019-04-04 9:45 ` Andrew Jones 2019-03-29 13:00 ` [PATCH v7 27/27] KVM: arm64/sve: Document KVM API extensions for SVE Dave Martin 2019-03-29 13:00 ` Dave Martin 2019-04-04 21:09 ` Andrew Jones 2019-04-04 21:09 ` Andrew Jones 2019-04-05 9:36 ` Dave Martin 2019-04-05 9:36 ` Dave Martin 2019-04-05 10:39 ` Andrew Jones 2019-04-05 10:39 ` Andrew Jones 2019-04-05 13:00 ` Dave Martin 2019-04-05 13:00 ` Dave Martin 2019-04-05 15:38 ` Andrew Jones 2019-04-05 15:38 ` Andrew Jones 2019-04-10 12:34 ` Dave Martin 2019-04-10 12:34 ` Dave Martin 2019-04-10 12:34 ` Dave Martin 2019-03-29 14:56 ` [PATCH v7 00/27] KVM: arm64: SVE guest support Marc Zyngier 2019-03-29 14:56 ` Marc Zyngier 2019-03-29 15:06 ` Dave Martin 2019-03-29 15:06 ` Dave Martin 2019-04-05 16:41 ` Dave Martin 2019-04-05 16:41 ` Dave Martin 2019-04-25 10:33 ` Alex Bennée 2019-04-25 10:33 ` Alex Bennée
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190404081008.GY3567@e103592.cambridge.arm.com \ --to=dave.martin@arm.com \ --cc=ard.biesheuvel@linaro.org \ --cc=catalin.marinas@arm.com \ --cc=cdall@kernel.org \ --cc=drjones@redhat.com \ --cc=julien.grall@arm.com \ --cc=kvmarm@lists.cs.columbia.edu \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=marc.zyngier@arm.com \ --cc=tokamoto@jp.fujitsu.com \ --cc=will.deacon@arm.com \ --cc=zhang.lei@jp.fujitsu.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.