From: Dave Martin <Dave.Martin@arm.com> To: Andrew Jones <drjones@redhat.com> Cc: Okamoto Takayuki <tokamoto@jp.fujitsu.com>, Christoffer Dall <cdall@kernel.org>, Ard Biesheuvel <ard.biesheuvel@linaro.org>, Marc Zyngier <marc.zyngier@arm.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will.deacon@arm.com>, Zhang Lei <zhang.lei@jp.fujitsu.com>, Julien Grall <julien.grall@arm.com>, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v7 19/27] KVM: arm64: Enumerate SVE register indices for KVM_GET_REG_LIST Date: Fri, 5 Apr 2019 12:11:15 +0100 [thread overview] Message-ID: <20190405111115.GX3567@e103592.cambridge.arm.com> (raw) In-Reply-To: <20190405094556.6hp24jkjcrfnirsb@kamzik.brq.redhat.com> On Fri, Apr 05, 2019 at 11:45:56AM +0200, Andrew Jones wrote: > On Fri, Apr 05, 2019 at 10:35:45AM +0100, Dave Martin wrote: > > On Thu, Apr 04, 2019 at 04:08:32PM +0200, Andrew Jones wrote: > > > On Fri, Mar 29, 2019 at 01:00:44PM +0000, Dave Martin wrote: > > > > This patch includes the SVE register IDs in the list returned by > > > > KVM_GET_REG_LIST, as appropriate. > > > > > > > > On a non-SVE-enabled vcpu, no new IDs are added. > > > > > > > > On an SVE-enabled vcpu, IDs for the FPSIMD V-registers are removed > > > > from the list, since userspace is required to access the Z- > > > > registers instead in order to access the V-register content. For > > > > the variably-sized SVE registers, the appropriate set of slice IDs > > > > are enumerated, depending on the maximum vector length for the > > > > vcpu. > > > > > > > > As it currently stands, the SVE architecture never requires more > > > > than one slice to exist per register, so this patch adds no > > > > explicit support for enumerating multiple slices. The code can be > > > > extended straightforwardly to support this in the future, if > > > > needed. > > > > > > > > Signed-off-by: Dave Martin <Dave.Martin@arm.com> > > > > Reviewed-by: Julien Thierry <julien.thierry@arm.com> > > > > Tested-by: zhang.lei <zhang.lei@jp.fujitsu.com> > > > > > > > > --- [...] > > > > diff --git a/arch/arm64/kvm/guest.c b/arch/arm64/kvm/guest.c [...] > > > > +static int copy_sve_reg_indices(const struct kvm_vcpu *vcpu, > > > > + u64 __user *uindices) > > > > +{ > > > > + /* Only the first slice ever exists, for now */ [...] > > > > + const unsigned int slices = vcpu_sve_slices(vcpu); > > > > + u64 reg; > > > > + unsigned int i, n; > > > > + int num_regs = 0; > > > > + > > > > + if (!vcpu_has_sve(vcpu)) > > > > + return 0; > > > > + > > > > + for (i = 0; i < slices; i++) { > > > > + for (n = 0; n < SVE_NUM_ZREGS; n++) { > > > > + reg = KVM_REG_ARM64_SVE_ZREG(n, i); > > > > + if (put_user(reg, uindices++)) > > > > + return -EFAULT; > > > > + > > > > + num_regs++; > > > > + } > > > > + > > > > + for (n = 0; n < SVE_NUM_PREGS; n++) { > > > > + reg = KVM_REG_ARM64_SVE_PREG(n, i); > > > > + if (put_user(reg, uindices++)) > > > > + return -EFAULT; > > > > + > > > > + num_regs++; > > > > + } > > > > + > > > > + reg = KVM_REG_ARM64_SVE_FFR(i); > > > > + if (put_user(reg, uindices++)) > > > > + return -EFAULT; > > > > + > > > > + num_regs++; > > > > + } > > > > > > nit: the extra blank lines above the num_regs++'s give the code an odd > > > look (to me) > > > > There's no guaranteed fall-through onto the increments: the blank line > > was there to highlight the fact that we may jump out using a return > > instead. > > > > But I'm happy enough to change it if you have a strong preference or > > you feel the code is equally clear without. > > It's just a nit, so I don't have a strong preference :) OK, well given that you mentioned it and there are other tweaks to make on top of this patch anyway, I'll go ahead and make the change. This saves a few lines, if nothing else. Cheers ---Dave
WARNING: multiple messages have this Message-ID (diff)
From: Dave Martin <Dave.Martin@arm.com> To: Andrew Jones <drjones@redhat.com> Cc: Okamoto Takayuki <tokamoto@jp.fujitsu.com>, Christoffer Dall <cdall@kernel.org>, Ard Biesheuvel <ard.biesheuvel@linaro.org>, Marc Zyngier <marc.zyngier@arm.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will.deacon@arm.com>, Zhang Lei <zhang.lei@jp.fujitsu.com>, Julien Grall <julien.grall@arm.com>, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v7 19/27] KVM: arm64: Enumerate SVE register indices for KVM_GET_REG_LIST Date: Fri, 5 Apr 2019 12:11:15 +0100 [thread overview] Message-ID: <20190405111115.GX3567@e103592.cambridge.arm.com> (raw) In-Reply-To: <20190405094556.6hp24jkjcrfnirsb@kamzik.brq.redhat.com> On Fri, Apr 05, 2019 at 11:45:56AM +0200, Andrew Jones wrote: > On Fri, Apr 05, 2019 at 10:35:45AM +0100, Dave Martin wrote: > > On Thu, Apr 04, 2019 at 04:08:32PM +0200, Andrew Jones wrote: > > > On Fri, Mar 29, 2019 at 01:00:44PM +0000, Dave Martin wrote: > > > > This patch includes the SVE register IDs in the list returned by > > > > KVM_GET_REG_LIST, as appropriate. > > > > > > > > On a non-SVE-enabled vcpu, no new IDs are added. > > > > > > > > On an SVE-enabled vcpu, IDs for the FPSIMD V-registers are removed > > > > from the list, since userspace is required to access the Z- > > > > registers instead in order to access the V-register content. For > > > > the variably-sized SVE registers, the appropriate set of slice IDs > > > > are enumerated, depending on the maximum vector length for the > > > > vcpu. > > > > > > > > As it currently stands, the SVE architecture never requires more > > > > than one slice to exist per register, so this patch adds no > > > > explicit support for enumerating multiple slices. The code can be > > > > extended straightforwardly to support this in the future, if > > > > needed. > > > > > > > > Signed-off-by: Dave Martin <Dave.Martin@arm.com> > > > > Reviewed-by: Julien Thierry <julien.thierry@arm.com> > > > > Tested-by: zhang.lei <zhang.lei@jp.fujitsu.com> > > > > > > > > --- [...] > > > > diff --git a/arch/arm64/kvm/guest.c b/arch/arm64/kvm/guest.c [...] > > > > +static int copy_sve_reg_indices(const struct kvm_vcpu *vcpu, > > > > + u64 __user *uindices) > > > > +{ > > > > + /* Only the first slice ever exists, for now */ [...] > > > > + const unsigned int slices = vcpu_sve_slices(vcpu); > > > > + u64 reg; > > > > + unsigned int i, n; > > > > + int num_regs = 0; > > > > + > > > > + if (!vcpu_has_sve(vcpu)) > > > > + return 0; > > > > + > > > > + for (i = 0; i < slices; i++) { > > > > + for (n = 0; n < SVE_NUM_ZREGS; n++) { > > > > + reg = KVM_REG_ARM64_SVE_ZREG(n, i); > > > > + if (put_user(reg, uindices++)) > > > > + return -EFAULT; > > > > + > > > > + num_regs++; > > > > + } > > > > + > > > > + for (n = 0; n < SVE_NUM_PREGS; n++) { > > > > + reg = KVM_REG_ARM64_SVE_PREG(n, i); > > > > + if (put_user(reg, uindices++)) > > > > + return -EFAULT; > > > > + > > > > + num_regs++; > > > > + } > > > > + > > > > + reg = KVM_REG_ARM64_SVE_FFR(i); > > > > + if (put_user(reg, uindices++)) > > > > + return -EFAULT; > > > > + > > > > + num_regs++; > > > > + } > > > > > > nit: the extra blank lines above the num_regs++'s give the code an odd > > > look (to me) > > > > There's no guaranteed fall-through onto the increments: the blank line > > was there to highlight the fact that we may jump out using a return > > instead. > > > > But I'm happy enough to change it if you have a strong preference or > > you feel the code is equally clear without. > > It's just a nit, so I don't have a strong preference :) OK, well given that you mentioned it and there are other tweaks to make on top of this patch anyway, I'll go ahead and make the change. This saves a few lines, if nothing else. Cheers ---Dave _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-04-05 11:11 UTC|newest] Thread overview: 224+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-29 13:00 [PATCH v7 00/27] KVM: arm64: SVE guest support Dave Martin 2019-03-29 13:00 ` Dave Martin 2019-03-29 13:00 ` [PATCH v7 01/27] KVM: Documentation: Document arm64 core registers in detail Dave Martin 2019-03-29 13:00 ` Dave Martin 2019-04-24 9:25 ` Alex Bennée 2019-04-24 9:25 ` Alex Bennée 2019-03-29 13:00 ` [PATCH v7 02/27] arm64: fpsimd: Always set TIF_FOREIGN_FPSTATE on task state flush Dave Martin 2019-03-29 13:00 ` Dave Martin 2019-03-29 13:00 ` [PATCH v7 03/27] KVM: arm64: Delete orphaned declaration for __fpsimd_enabled() Dave Martin 2019-03-29 13:00 ` Dave Martin 2019-03-29 13:00 ` [PATCH v7 04/27] KVM: arm64: Refactor kvm_arm_num_regs() for easier maintenance Dave Martin 2019-03-29 13:00 ` Dave Martin 2019-03-29 13:00 ` [PATCH v7 05/27] KVM: arm64: Add missing #includes to kvm_host.h Dave Martin 2019-03-29 13:00 ` Dave Martin 2019-03-29 13:00 ` [PATCH v7 06/27] arm64/sve: Clarify role of the VQ map maintenance functions Dave Martin 2019-03-29 13:00 ` Dave Martin 2019-04-04 21:21 ` Andrew Jones 2019-04-04 21:21 ` Andrew Jones 2019-03-29 13:00 ` [PATCH v7 07/27] arm64/sve: Check SVE virtualisability Dave Martin 2019-03-29 13:00 ` Dave Martin 2019-04-04 21:21 ` Andrew Jones 2019-04-04 21:21 ` Andrew Jones 2019-04-05 9:35 ` Dave Martin 2019-04-05 9:35 ` Dave Martin 2019-03-29 13:00 ` [PATCH v7 08/27] arm64/sve: Enable SVE state tracking for non-task contexts Dave Martin 2019-03-29 13:00 ` Dave Martin 2019-03-29 13:00 ` [PATCH v7 09/27] KVM: arm64: Add a vcpu flag to control SVE visibility for the guest Dave Martin 2019-03-29 13:00 ` Dave Martin 2019-04-03 19:14 ` Andrew Jones 2019-04-03 19:14 ` Andrew Jones 2019-04-04 3:17 ` Marc Zyngier 2019-04-04 3:17 ` Marc Zyngier 2019-04-04 7:53 ` Dave Martin 2019-04-04 7:53 ` Dave Martin 2019-04-04 21:15 ` Andrew Jones 2019-04-04 21:15 ` Andrew Jones 2019-03-29 13:00 ` [PATCH v7 10/27] KVM: arm64: Propagate vcpu into read_id_reg() Dave Martin 2019-03-29 13:00 ` Dave Martin 2019-04-04 21:15 ` Andrew Jones 2019-04-04 21:15 ` Andrew Jones 2019-03-29 13:00 ` [PATCH v7 11/27] KVM: arm64: Support runtime sysreg visibility filtering Dave Martin 2019-03-29 13:00 ` Dave Martin 2019-04-03 19:17 ` Andrew Jones 2019-04-03 19:17 ` Andrew Jones 2019-04-24 9:39 ` Alex Bennée 2019-04-24 9:39 ` Alex Bennée 2019-04-24 13:47 ` Dave Martin 2019-04-24 13:47 ` Dave Martin 2019-04-24 13:47 ` Dave Martin 2019-03-29 13:00 ` [PATCH v7 12/27] KVM: arm64/sve: System register context switch and access support Dave Martin 2019-03-29 13:00 ` Dave Martin 2019-04-03 19:39 ` Andrew Jones 2019-04-03 19:39 ` Andrew Jones 2019-04-04 8:06 ` Dave Martin 2019-04-04 8:06 ` Dave Martin 2019-04-04 8:32 ` Andrew Jones 2019-04-04 8:32 ` Andrew Jones 2019-04-04 8:47 ` Dave Martin 2019-04-04 8:47 ` Dave Martin 2019-04-04 8:59 ` Andrew Jones 2019-04-04 8:59 ` Andrew Jones 2019-04-24 15:21 ` Alex Bennée 2019-04-24 15:21 ` Alex Bennée 2019-04-25 13:28 ` Dave Martin 2019-04-25 13:28 ` Dave Martin 2019-04-25 13:28 ` Dave Martin 2019-03-29 13:00 ` [PATCH v7 13/27] KVM: arm64/sve: Context switch the SVE registers Dave Martin 2019-03-29 13:00 ` Dave Martin 2019-04-03 20:01 ` Andrew Jones 2019-04-03 20:01 ` Andrew Jones 2019-04-04 8:10 ` Dave Martin 2019-04-04 8:10 ` Dave Martin 2019-04-04 8:35 ` Andrew Jones 2019-04-04 8:35 ` Andrew Jones 2019-04-04 8:36 ` Dave Martin 2019-04-04 8:36 ` Dave Martin 2019-04-24 14:51 ` Alex Bennée 2019-04-24 14:51 ` Alex Bennée 2019-04-25 13:35 ` Dave Martin 2019-04-25 13:35 ` Dave Martin 2019-04-25 13:35 ` Dave Martin 2019-03-29 13:00 ` [PATCH v7 14/27] KVM: Allow 2048-bit register access via ioctl interface Dave Martin 2019-03-29 13:00 ` Dave Martin 2019-04-04 21:11 ` Andrew Jones 2019-04-04 21:11 ` Andrew Jones 2019-03-29 13:00 ` [PATCH v7 15/27] KVM: arm64: Add missing #include of <linux/string.h> in guest.c Dave Martin 2019-03-29 13:00 ` Dave Martin 2019-03-29 13:00 ` [PATCH v7 16/27] KVM: arm64: Factor out core register ID enumeration Dave Martin 2019-03-29 13:00 ` Dave Martin 2019-04-02 2:41 ` Marc Zyngier 2019-04-02 2:41 ` Marc Zyngier 2019-04-02 8:59 ` Dave Martin 2019-04-02 8:59 ` Dave Martin 2019-04-02 9:32 ` Marc Zyngier 2019-04-02 9:32 ` Marc Zyngier 2019-04-02 9:54 ` Dave P Martin 2019-04-02 9:54 ` Dave P Martin 2019-03-29 13:00 ` [PATCH v7 17/27] KVM: arm64: Reject ioctl access to FPSIMD V-regs on SVE vcpus Dave Martin 2019-03-29 13:00 ` Dave Martin 2019-04-03 20:15 ` Andrew Jones 2019-04-03 20:15 ` Andrew Jones 2019-04-24 13:45 ` Alex Bennée 2019-04-24 13:45 ` Alex Bennée 2019-03-29 13:00 ` [PATCH v7 18/27] KVM: arm64/sve: Add SVE support to register access ioctl interface Dave Martin 2019-03-29 13:00 ` Dave Martin 2019-04-04 13:57 ` Andrew Jones 2019-04-04 13:57 ` Andrew Jones 2019-04-04 14:50 ` Dave Martin 2019-04-04 14:50 ` Dave Martin 2019-04-04 16:25 ` Andrew Jones 2019-04-04 16:25 ` Andrew Jones 2019-04-04 16:56 ` Dave Martin 2019-04-04 16:56 ` Dave Martin 2019-03-29 13:00 ` [PATCH v7 19/27] KVM: arm64: Enumerate SVE register indices for KVM_GET_REG_LIST Dave Martin 2019-03-29 13:00 ` Dave Martin 2019-04-04 14:08 ` Andrew Jones 2019-04-04 14:08 ` Andrew Jones 2019-04-05 9:35 ` Dave Martin 2019-04-05 9:35 ` Dave Martin 2019-04-05 9:45 ` Andrew Jones 2019-04-05 9:45 ` Andrew Jones 2019-04-05 11:11 ` Dave Martin [this message] 2019-04-05 11:11 ` Dave Martin 2019-03-29 13:00 ` [PATCH v7 20/27] arm64/sve: In-kernel vector length availability query interface Dave Martin 2019-03-29 13:00 ` Dave Martin 2019-04-04 14:20 ` Andrew Jones 2019-04-04 14:20 ` Andrew Jones 2019-04-05 9:35 ` Dave Martin 2019-04-05 9:35 ` Dave Martin 2019-04-05 9:54 ` Andrew Jones 2019-04-05 9:54 ` Andrew Jones 2019-04-05 11:13 ` Dave Martin 2019-04-05 11:13 ` Dave Martin 2019-03-29 13:00 ` [PATCH v7 21/27] KVM: arm/arm64: Add hook for arch-specific KVM initialisation Dave Martin 2019-03-29 13:00 ` Dave Martin 2019-04-04 14:25 ` Andrew Jones 2019-04-04 14:25 ` Andrew Jones 2019-04-04 14:53 ` Dave Martin 2019-04-04 14:53 ` Dave Martin 2019-04-04 16:33 ` Andrew Jones 2019-04-04 16:33 ` Andrew Jones 2019-04-05 9:36 ` Dave Martin 2019-04-05 9:36 ` Dave Martin 2019-04-05 10:40 ` Andrew Jones 2019-04-05 10:40 ` Andrew Jones 2019-04-05 11:14 ` Dave Martin 2019-04-05 11:14 ` Dave Martin 2019-03-29 13:00 ` [PATCH v7 22/27] KVM: arm/arm64: Add KVM_ARM_VCPU_FINALIZE ioctl Dave Martin 2019-03-29 13:00 ` Dave Martin 2019-04-04 15:07 ` Andrew Jones 2019-04-04 15:07 ` Andrew Jones 2019-04-04 16:47 ` Dave Martin 2019-04-04 16:47 ` Dave Martin 2019-03-29 13:00 ` [PATCH v7 23/27] KVM: arm64/sve: Add pseudo-register for the guest's vector lengths Dave Martin 2019-03-29 13:00 ` Dave Martin 2019-04-04 20:18 ` Andrew Jones 2019-04-04 20:18 ` Andrew Jones 2019-04-05 9:36 ` Dave Martin 2019-04-05 9:36 ` Dave Martin 2019-04-05 10:14 ` Andrew Jones 2019-04-05 10:14 ` Andrew Jones 2019-04-05 12:54 ` Dave Martin 2019-04-05 12:54 ` Dave Martin 2019-04-05 15:33 ` Andrew Jones 2019-04-05 15:33 ` Andrew Jones 2019-04-10 12:42 ` Dave Martin 2019-04-10 12:42 ` Dave Martin 2019-04-10 12:42 ` Dave Martin 2019-04-04 20:31 ` Andrew Jones 2019-04-04 20:31 ` Andrew Jones 2019-04-05 9:36 ` Dave Martin 2019-04-05 9:36 ` Dave Martin 2019-04-05 10:22 ` Andrew Jones 2019-04-05 10:22 ` Andrew Jones 2019-04-05 14:06 ` Dave Martin 2019-04-05 14:06 ` Dave Martin 2019-04-05 15:41 ` Andrew Jones 2019-04-05 15:41 ` Andrew Jones 2019-04-10 12:35 ` Dave Martin 2019-04-10 12:35 ` Dave Martin 2019-04-10 12:35 ` Dave Martin 2019-03-29 13:00 ` [PATCH v7 24/27] KVM: arm64/sve: Allow userspace to enable SVE for vcpus Dave Martin 2019-03-29 13:00 ` Dave Martin 2019-04-04 20:36 ` Andrew Jones 2019-04-04 20:36 ` Andrew Jones 2019-03-29 13:00 ` [PATCH v7 25/27] KVM: arm64: Add a capability to advertise SVE support Dave Martin 2019-03-29 13:00 ` Dave Martin 2019-04-04 20:39 ` Andrew Jones 2019-04-04 20:39 ` Andrew Jones 2019-03-29 13:00 ` [PATCH v7 26/27] KVM: Document errors for KVM_GET_ONE_REG and KVM_SET_ONE_REG Dave Martin 2019-03-29 13:00 ` Dave Martin 2019-04-03 20:27 ` Andrew Jones 2019-04-03 20:27 ` Andrew Jones 2019-04-04 8:35 ` Dave Martin 2019-04-04 8:35 ` Dave Martin 2019-04-04 9:34 ` Andrew Jones 2019-04-04 9:34 ` Andrew Jones 2019-04-04 9:38 ` Dave P Martin 2019-04-04 9:38 ` Dave P Martin 2019-04-04 9:45 ` Andrew Jones 2019-04-04 9:45 ` Andrew Jones 2019-03-29 13:00 ` [PATCH v7 27/27] KVM: arm64/sve: Document KVM API extensions for SVE Dave Martin 2019-03-29 13:00 ` Dave Martin 2019-04-04 21:09 ` Andrew Jones 2019-04-04 21:09 ` Andrew Jones 2019-04-05 9:36 ` Dave Martin 2019-04-05 9:36 ` Dave Martin 2019-04-05 10:39 ` Andrew Jones 2019-04-05 10:39 ` Andrew Jones 2019-04-05 13:00 ` Dave Martin 2019-04-05 13:00 ` Dave Martin 2019-04-05 15:38 ` Andrew Jones 2019-04-05 15:38 ` Andrew Jones 2019-04-10 12:34 ` Dave Martin 2019-04-10 12:34 ` Dave Martin 2019-04-10 12:34 ` Dave Martin 2019-03-29 14:56 ` [PATCH v7 00/27] KVM: arm64: SVE guest support Marc Zyngier 2019-03-29 14:56 ` Marc Zyngier 2019-03-29 15:06 ` Dave Martin 2019-03-29 15:06 ` Dave Martin 2019-04-05 16:41 ` Dave Martin 2019-04-05 16:41 ` Dave Martin 2019-04-25 10:33 ` Alex Bennée 2019-04-25 10:33 ` Alex Bennée
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190405111115.GX3567@e103592.cambridge.arm.com \ --to=dave.martin@arm.com \ --cc=ard.biesheuvel@linaro.org \ --cc=catalin.marinas@arm.com \ --cc=cdall@kernel.org \ --cc=drjones@redhat.com \ --cc=julien.grall@arm.com \ --cc=kvmarm@lists.cs.columbia.edu \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=marc.zyngier@arm.com \ --cc=tokamoto@jp.fujitsu.com \ --cc=will.deacon@arm.com \ --cc=zhang.lei@jp.fujitsu.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.