[igt-dev] [PATCH i-g-t] lib/igt_halffloat: fix compilation with Clang

[igt-dev] [PATCH i-g-t] lib/igt_halffloat: fix compilation with Clang

[Simon Ser]

The source file contains a special code-path for Clang, however this path fails
to compile:

  ../lib/igt_halffloat.c:227:7: error: conflicting types for 'igt_half_to_float'
  float igt_half_to_float(const uint16_t *h, float *f, unsigned int num)
        ^
  ../lib/igt_halffloat.h:26:6: note: previous declaration is here
  void igt_half_to_float(const uint16_t *h, float *f, unsigned int num);
       ^
  1 error generated.

This commit fixes this mismatch.

Signed-off-by: Simon Ser <simon.ser@intel.com>
---
 lib/igt_halffloat.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/igt_halffloat.c b/lib/igt_halffloat.c
index 263b28c1..08ab05fc 100644
--- a/lib/igt_halffloat.c
+++ b/lib/igt_halffloat.c
@@ -224,7 +224,7 @@ void igt_float_to_half(const float *f, uint16_t *h, unsigned int num)
 		h[i] = _float_to_half(f[i]);
 }
 
-float igt_half_to_float(const uint16_t *h, float *f, unsigned int num)
+void igt_half_to_float(const uint16_t *h, float *f, unsigned int num)
 {
 	for (int i = 0; i < num; i++)
 		f[i] = _half_to_float(h[i]);
-- 
2.21.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for lib/igt_halffloat: fix compilation with Clang

[Patchwork]

== Series Details ==

Series: lib/igt_halffloat: fix compilation with Clang
URL   : https://patchwork.freedesktop.org/series/59858/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5982 -> IGTPW_2908
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/59858/revisions/1/mbox/

Known issues
------------

  Here are the changes found in IGTPW_2908 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@amdgpu/amd_basic@cs-sdma:
    - fi-skl-6770hq:      NOTRUN -> [SKIP][1] ([fdo#109271]) +37 similar issues
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2908/fi-skl-6770hq/igt@amdgpu/amd_basic@cs-sdma.html

  * igt@amdgpu/amd_cs_nop@sync-fork-compute0:
    - fi-icl-u3:          NOTRUN -> [SKIP][2] ([fdo#109315]) +17 similar issues
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2908/fi-icl-u3/igt@amdgpu/amd_cs_nop@sync-fork-compute0.html

  * igt@amdgpu/amd_prime@amd-to-i915:
    - fi-kbl-x1275:       NOTRUN -> [SKIP][3] ([fdo#109271]) +45 similar issues
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2908/fi-kbl-x1275/igt@amdgpu/amd_prime@amd-to-i915.html

  * igt@gem_exec_basic@gtt-bsd:
    - fi-bwr-2160:        NOTRUN -> [SKIP][4] ([fdo#109271]) +98 similar issues
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2908/fi-bwr-2160/igt@gem_exec_basic@gtt-bsd.html

  * igt@gem_exec_basic@gtt-bsd1:
    - fi-icl-u3:          NOTRUN -> [SKIP][5] ([fdo#109276]) +7 similar issues
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2908/fi-icl-u3/igt@gem_exec_basic@gtt-bsd1.html

  * igt@gem_exec_basic@gtt-bsd2:
    - fi-byt-clapper:     NOTRUN -> [SKIP][6] ([fdo#109271]) +52 similar issues
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2908/fi-byt-clapper/igt@gem_exec_basic@gtt-bsd2.html

  * igt@gem_exec_parse@basic-rejected:
    - fi-icl-u3:          NOTRUN -> [SKIP][7] ([fdo#109289]) +1 similar issue
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2908/fi-icl-u3/igt@gem_exec_parse@basic-rejected.html

  * igt@gem_exec_store@basic-bsd2:
    - fi-bxt-dsi:         NOTRUN -> [SKIP][8] ([fdo#109271]) +47 similar issues
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2908/fi-bxt-dsi/igt@gem_exec_store@basic-bsd2.html

  * igt@kms_busy@basic-flip-a:
    - fi-bsw-n3050:       NOTRUN -> [SKIP][9] ([fdo#109271] / [fdo#109278]) +1 similar issue
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2908/fi-bsw-n3050/igt@kms_busy@basic-flip-a.html

  * igt@kms_busy@basic-flip-c:
    - fi-bwr-2160:        NOTRUN -> [SKIP][10] ([fdo#109271] / [fdo#109278])
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2908/fi-bwr-2160/igt@kms_busy@basic-flip-c.html
    - fi-byt-j1900:       NOTRUN -> [SKIP][11] ([fdo#109271] / [fdo#109278])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2908/fi-byt-j1900/igt@kms_busy@basic-flip-c.html
    - fi-byt-clapper:     NOTRUN -> [SKIP][12] ([fdo#109271] / [fdo#109278])
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2908/fi-byt-clapper/igt@kms_busy@basic-flip-c.html

  * igt@kms_chamelium@hdmi-crc-fast:
    - fi-bsw-n3050:       NOTRUN -> [SKIP][13] ([fdo#109271]) +57 similar issues
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2908/fi-bsw-n3050/igt@kms_chamelium@hdmi-crc-fast.html
    - fi-byt-j1900:       NOTRUN -> [SKIP][14] ([fdo#109271]) +47 similar issues
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2908/fi-byt-j1900/igt@kms_chamelium@hdmi-crc-fast.html

  * igt@kms_chamelium@hdmi-edid-read:
    - fi-icl-u3:          NOTRUN -> [SKIP][15] ([fdo#109284]) +8 similar issues
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2908/fi-icl-u3/igt@kms_chamelium@hdmi-edid-read.html

  * igt@kms_force_connector_basic@force-load-detect:
    - fi-bxt-j4205:       NOTRUN -> [SKIP][16] ([fdo#109271]) +47 similar issues
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2908/fi-bxt-j4205/igt@kms_force_connector_basic@force-load-detect.html

  * igt@kms_force_connector_basic@prune-stale-modes:
    - fi-icl-u3:          NOTRUN -> [SKIP][17] ([fdo#109285]) +3 similar issues
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2908/fi-icl-u3/igt@kms_force_connector_basic@prune-stale-modes.html

  * igt@kms_frontbuffer_tracking@basic:
    - fi-byt-clapper:     NOTRUN -> [FAIL][18] ([fdo#103167])
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2908/fi-byt-clapper/igt@kms_frontbuffer_tracking@basic.html

  * igt@kms_psr@primary_page_flip:
    - fi-skl-lmem:        NOTRUN -> [SKIP][19] ([fdo#109271]) +37 similar issues
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2908/fi-skl-lmem/igt@kms_psr@primary_page_flip.html

  
#### Possible fixes ####

  * igt@i915_selftest@live_execlists:
    - fi-apl-guc:         [INCOMPLETE][20] ([fdo#103927] / [fdo#109720]) -> [PASS][21]
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5982/fi-apl-guc/igt@i915_selftest@live_execlists.html
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2908/fi-apl-guc/igt@i915_selftest@live_execlists.html

  * igt@i915_selftest@live_hangcheck:
    - fi-icl-u2:          [INCOMPLETE][22] ([fdo#107713] / [fdo#108569]) -> [PASS][23]
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5982/fi-icl-u2/igt@i915_selftest@live_hangcheck.html
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2908/fi-icl-u2/igt@i915_selftest@live_hangcheck.html

  
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
  [fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
  [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
  [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
  [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
  [fdo#109720]: https://bugs.freedesktop.org/show_bug.cgi?id=109720


Participating hosts (39 -> 43)
------------------------------

  Additional (10): fi-bxt-dsi fi-bsw-n3050 fi-byt-j1900 fi-skl-6770hq fi-bwr-2160 fi-kbl-x1275 fi-bxt-j4205 fi-icl-u3 fi-skl-lmem fi-byt-clapper 
  Missing    (6): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus 


Build changes
-------------

  * IGT: IGT_4959 -> IGTPW_2908

  CI_DRM_5982: f3a1d370072adb90dc695995d70941341d276797 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2908: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2908/
  IGT_4959: 504367d33b787de2ba8e007a5b620cfd6f0b3074 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2908/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] lib/igt_halffloat: fix compilation with Clang

[Petri Latvala]

On Wed, Apr 24, 2019 at 10:01:29AM +0300, Simon Ser wrote:
> The source file contains a special code-path for Clang, however this path fails
> to compile:
> 
>   ../lib/igt_halffloat.c:227:7: error: conflicting types for 'igt_half_to_float'
>   float igt_half_to_float(const uint16_t *h, float *f, unsigned int num)
>         ^
>   ../lib/igt_halffloat.h:26:6: note: previous declaration is here
>   void igt_half_to_float(const uint16_t *h, float *f, unsigned int num);
>        ^
>   1 error generated.
> 
> This commit fixes this mismatch.
> 
> Signed-off-by: Simon Ser <simon.ser@intel.com>

Same clang path is also used for !x86_64, as shown in the gitlab CI
build failure.


Reviewed-by: Petri Latvala <petri.latvala@intel.com>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for lib/igt_halffloat: fix compilation with Clang

[Patchwork]

== Series Details ==

Series: lib/igt_halffloat: fix compilation with Clang
URL   : https://patchwork.freedesktop.org/series/59858/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5982_full -> IGTPW_2908_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/59858/revisions/1/mbox/

Known issues
------------

  Here are the changes found in IGTPW_2908_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_eio@in-flight-suspend:
    - shard-apl:          [PASS][1] -> [DMESG-WARN][2] ([fdo#108566]) +2 similar issues
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5982/shard-apl3/igt@gem_eio@in-flight-suspend.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2908/shard-apl7/igt@gem_eio@in-flight-suspend.html

  * igt@gem_tiled_swapping@non-threaded:
    - shard-iclb:         [PASS][3] -> [FAIL][4] ([fdo#108686])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5982/shard-iclb5/igt@gem_tiled_swapping@non-threaded.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2908/shard-iclb6/igt@gem_tiled_swapping@non-threaded.html
    - shard-hsw:          [PASS][5] -> [FAIL][6] ([fdo#108686])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5982/shard-hsw6/igt@gem_tiled_swapping@non-threaded.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2908/shard-hsw8/igt@gem_tiled_swapping@non-threaded.html

  * igt@i915_suspend@forcewake:
    - shard-iclb:         [PASS][7] -> [INCOMPLETE][8] ([fdo#107713])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5982/shard-iclb2/igt@i915_suspend@forcewake.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2908/shard-iclb5/igt@i915_suspend@forcewake.html

  * igt@kms_cursor_crc@cursor-256x256-onscreen:
    - shard-kbl:          [PASS][9] -> [FAIL][10] ([fdo#103232])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5982/shard-kbl7/igt@kms_cursor_crc@cursor-256x256-onscreen.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2908/shard-kbl1/igt@kms_cursor_crc@cursor-256x256-onscreen.html
    - shard-apl:          [PASS][11] -> [FAIL][12] ([fdo#103232])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5982/shard-apl6/igt@kms_cursor_crc@cursor-256x256-onscreen.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2908/shard-apl7/igt@kms_cursor_crc@cursor-256x256-onscreen.html

  * igt@kms_cursor_crc@cursor-alpha-opaque:
    - shard-kbl:          [PASS][13] -> [FAIL][14] ([fdo#109350])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5982/shard-kbl3/igt@kms_cursor_crc@cursor-alpha-opaque.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2908/shard-kbl2/igt@kms_cursor_crc@cursor-alpha-opaque.html
    - shard-apl:          [PASS][15] -> [FAIL][16] ([fdo#109350])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5982/shard-apl1/igt@kms_cursor_crc@cursor-alpha-opaque.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2908/shard-apl2/igt@kms_cursor_crc@cursor-alpha-opaque.html
    - shard-glk:          [PASS][17] -> [FAIL][18] ([fdo#109350])
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5982/shard-glk8/igt@kms_cursor_crc@cursor-alpha-opaque.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2908/shard-glk9/igt@kms_cursor_crc@cursor-alpha-opaque.html

  * igt@kms_flip@flip-vs-expired-vblank-interruptible:
    - shard-glk:          [PASS][19] -> [FAIL][20] ([fdo#105363])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5982/shard-glk2/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2908/shard-glk8/igt@kms_flip@flip-vs-expired-vblank-interruptible.html

  * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-blt:
    - shard-glk:          [PASS][21] -> [FAIL][22] ([fdo#103167])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5982/shard-glk6/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-blt.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2908/shard-glk9/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-blt.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite:
    - shard-iclb:         [PASS][23] -> [FAIL][24] ([fdo#103167]) +7 similar issues
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5982/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2908/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html

  * igt@kms_psr@psr2_sprite_plane_move:
    - shard-iclb:         [PASS][25] -> [SKIP][26] ([fdo#109441]) +2 similar issues
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5982/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2908/shard-iclb1/igt@kms_psr@psr2_sprite_plane_move.html

  * igt@kms_rotation_crc@multiplane-rotation:
    - shard-kbl:          [PASS][27] -> [DMESG-FAIL][28] ([fdo#105763])
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5982/shard-kbl5/igt@kms_rotation_crc@multiplane-rotation.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2908/shard-kbl6/igt@kms_rotation_crc@multiplane-rotation.html

  * igt@kms_setmode@basic:
    - shard-iclb:         [PASS][29] -> [FAIL][30] ([fdo#99912])
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5982/shard-iclb6/igt@kms_setmode@basic.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2908/shard-iclb5/igt@kms_setmode@basic.html

  
#### Possible fixes ####

  * igt@i915_pm_rpm@i2c:
    - shard-iclb:         [FAIL][31] ([fdo#104097]) -> [PASS][32]
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5982/shard-iclb1/igt@i915_pm_rpm@i2c.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2908/shard-iclb6/igt@i915_pm_rpm@i2c.html

  * igt@i915_suspend@forcewake:
    - shard-apl:          [DMESG-WARN][33] ([fdo#108566]) -> [PASS][34] +2 similar issues
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5982/shard-apl8/igt@i915_suspend@forcewake.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2908/shard-apl8/igt@i915_suspend@forcewake.html

  * igt@kms_flip@flip-vs-suspend:
    - shard-kbl:          [DMESG-WARN][35] ([fdo#103313]) -> [PASS][36]
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5982/shard-kbl7/igt@kms_flip@flip-vs-suspend.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2908/shard-kbl1/igt@kms_flip@flip-vs-suspend.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-onoff:
    - shard-iclb:         [FAIL][37] ([fdo#103167]) -> [PASS][38] +1 similar issue
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5982/shard-iclb5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-onoff.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2908/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-onoff.html

  * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-pwrite:
    - shard-glk:          [FAIL][39] ([fdo#103167]) -> [PASS][40]
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5982/shard-glk7/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-pwrite.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2908/shard-glk8/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-pwrite.html

  * igt@kms_psr@psr2_primary_mmap_cpu:
    - shard-iclb:         [SKIP][41] ([fdo#109441]) -> [PASS][42] +2 similar issues
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5982/shard-iclb3/igt@kms_psr@psr2_primary_mmap_cpu.html
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2908/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html

  * igt@kms_rotation_crc@multiplane-rotation-cropping-top:
    - shard-kbl:          [FAIL][43] ([fdo#109016]) -> [PASS][44]
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5982/shard-kbl3/igt@kms_rotation_crc@multiplane-rotation-cropping-top.html
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2908/shard-kbl1/igt@kms_rotation_crc@multiplane-rotation-cropping-top.html

  * igt@kms_vblank@pipe-a-ts-continuation-suspend:
    - shard-kbl:          [DMESG-WARN][45] ([fdo#108566]) -> [PASS][46] +1 similar issue
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5982/shard-kbl2/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2908/shard-kbl5/igt@kms_vblank@pipe-a-ts-continuation-suspend.html

  * igt@perf@oa-exponents:
    - shard-glk:          [FAIL][47] ([fdo#105483]) -> [PASS][48]
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5982/shard-glk4/igt@perf@oa-exponents.html
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2908/shard-glk7/igt@perf@oa-exponents.html

  
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
  [fdo#103313]: https://bugs.freedesktop.org/show_bug.cgi?id=103313
  [fdo#104097]: https://bugs.freedesktop.org/show_bug.cgi?id=104097
  [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
  [fdo#105483]: https://bugs.freedesktop.org/show_bug.cgi?id=105483
  [fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
  [fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
  [fdo#109016]: https://bugs.freedesktop.org/show_bug.cgi?id=109016
  [fdo#109350]: https://bugs.freedesktop.org/show_bug.cgi?id=109350
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912


Participating hosts (10 -> 6)
------------------------------

  Missing    (4): pig-skl-6260u shard-skl pig-hsw-4770r pig-glk-j5005 


Build changes
-------------

  * IGT: IGT_4959 -> IGTPW_2908
  * Piglit: piglit_4509 -> None

  CI_DRM_5982: f3a1d370072adb90dc695995d70941341d276797 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2908: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2908/
  IGT_4959: 504367d33b787de2ba8e007a5b620cfd6f0b3074 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2908/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] lib/igt_halffloat: fix compilation with Clang

[Petri Latvala]

On Wed, Apr 24, 2019 at 12:28:42PM +0300, Petri Latvala wrote:
> On Wed, Apr 24, 2019 at 10:01:29AM +0300, Simon Ser wrote:
> > The source file contains a special code-path for Clang, however this path fails
> > to compile:
> > 
> >   ../lib/igt_halffloat.c:227:7: error: conflicting types for 'igt_half_to_float'
> >   float igt_half_to_float(const uint16_t *h, float *f, unsigned int num)
> >         ^
> >   ../lib/igt_halffloat.h:26:6: note: previous declaration is here
> >   void igt_half_to_float(const uint16_t *h, float *f, unsigned int num);
> >        ^
> >   1 error generated.
> > 
> > This commit fixes this mismatch.
> > 
> > Signed-off-by: Simon Ser <simon.ser@intel.com>
> 
> Same clang path is also used for !x86_64, as shown in the gitlab CI
> build failure.
> 
> 
> Reviewed-by: Petri Latvala <petri.latvala@intel.com>


And merged now, thanks.
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] lib/igt_halffloat: fix compilation with Clang

[Daniel Vetter]

On Wed, Apr 24, 2019 at 04:26:55PM +0300, Petri Latvala wrote:
> On Wed, Apr 24, 2019 at 12:28:42PM +0300, Petri Latvala wrote:
> > On Wed, Apr 24, 2019 at 10:01:29AM +0300, Simon Ser wrote:
> > > The source file contains a special code-path for Clang, however this path fails
> > > to compile:
> > > 
> > >   ../lib/igt_halffloat.c:227:7: error: conflicting types for 'igt_half_to_float'
> > >   float igt_half_to_float(const uint16_t *h, float *f, unsigned int num)
> > >         ^
> > >   ../lib/igt_halffloat.h:26:6: note: previous declaration is here
> > >   void igt_half_to_float(const uint16_t *h, float *f, unsigned int num);
> > >        ^
> > >   1 error generated.
> > > 
> > > This commit fixes this mismatch.
> > > 
> > > Signed-off-by: Simon Ser <simon.ser@intel.com>
> > 
> > Same clang path is also used for !x86_64, as shown in the gitlab CI
> > build failure.
> > 
> > 
> > Reviewed-by: Petri Latvala <petri.latvala@intel.com>
> 
> 
> And merged now, thanks.

For next time for regressions: Please cc the folks who broke things (or
reviewed that breakage), and quote the offending commit with Fixes: lines.

Also I'm kinda wondering whether we should enforce gitlab CI build success
going forward ... Stuff not compiling isn't awesome.

Thanks, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] lib/igt_halffloat: fix compilation with Clang

[Daniel Vetter]

On Wed, Apr 24, 2019 at 10:06:41PM +0200, Daniel Vetter wrote:
> On Wed, Apr 24, 2019 at 04:26:55PM +0300, Petri Latvala wrote:
> > On Wed, Apr 24, 2019 at 12:28:42PM +0300, Petri Latvala wrote:
> > > On Wed, Apr 24, 2019 at 10:01:29AM +0300, Simon Ser wrote:
> > > > The source file contains a special code-path for Clang, however this path fails
> > > > to compile:
> > > > 
> > > >   ../lib/igt_halffloat.c:227:7: error: conflicting types for 'igt_half_to_float'
> > > >   float igt_half_to_float(const uint16_t *h, float *f, unsigned int num)
> > > >         ^
> > > >   ../lib/igt_halffloat.h:26:6: note: previous declaration is here
> > > >   void igt_half_to_float(const uint16_t *h, float *f, unsigned int num);
> > > >        ^
> > > >   1 error generated.
> > > > 
> > > > This commit fixes this mismatch.
> > > > 
> > > > Signed-off-by: Simon Ser <simon.ser@intel.com>
> > > 
> > > Same clang path is also used for !x86_64, as shown in the gitlab CI
> > > build failure.
> > > 
> > > 
> > > Reviewed-by: Petri Latvala <petri.latvala@intel.com>
> > 
> > 
> > And merged now, thanks.
> 
> For next time for regressions: Please cc the folks who broke things (or
> reviewed that breakage), and quote the offending commit with Fixes: lines.
> 
> Also I'm kinda wondering whether we should enforce gitlab CI build success
> going forward ... Stuff not compiling isn't awesome.

btw one more: What broke is the non-x86 builds, those we care about. We
don't really care about clang (I think at least), so commit message is a
bit confusing ...
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] lib/igt_halffloat: fix compilation with Clang

[Ser, Simon]

On Thu, 2019-04-25 at 09:36 +0200, Daniel Vetter wrote:
> On Wed, Apr 24, 2019 at 10:06:41PM +0200, Daniel Vetter wrote:
> > On Wed, Apr 24, 2019 at 04:26:55PM +0300, Petri Latvala wrote:
> > > On Wed, Apr 24, 2019 at 12:28:42PM +0300, Petri Latvala wrote:
> > > > On Wed, Apr 24, 2019 at 10:01:29AM +0300, Simon Ser wrote:
> > > > > The source file contains a special code-path for Clang,
> > > > > however this path fails
> > > > > to compile:
> > > > > 
> > > > >   ../lib/igt_halffloat.c:227:7: error: conflicting types for
> > > > > 'igt_half_to_float'
> > > > >   float igt_half_to_float(const uint16_t *h, float *f,
> > > > > unsigned int num)
> > > > >         ^
> > > > >   ../lib/igt_halffloat.h:26:6: note: previous declaration is
> > > > > here
> > > > >   void igt_half_to_float(const uint16_t *h, float *f,
> > > > > unsigned int num);
> > > > >        ^
> > > > >   1 error generated.
> > > > > 
> > > > > This commit fixes this mismatch.
> > > > > 
> > > > > Signed-off-by: Simon Ser <simon.ser@intel.com>
> > > > 
> > > > Same clang path is also used for !x86_64, as shown in the
> > > > gitlab CI
> > > > build failure.
> > > > 
> > > > 
> > > > Reviewed-by: Petri Latvala <petri.latvala@intel.com>
> > > 
> > > And merged now, thanks.
> > 
> > For next time for regressions: Please cc the folks who broke things
> > (or
> > reviewed that breakage), and quote the offending commit with Fixes:
> > lines.

Indeed that would be better, ACK.

> > Also I'm kinda wondering whether we should enforce gitlab CI build
> > success
> > going forward ... Stuff not compiling isn't awesome.
> 
> btw one more: What broke is the non-x86 builds, those we care about.
> We
> don't really care about clang (I think at least), so commit message
> is a
> bit confusing ...

(Just re-posting it here in case someone reads this thread and not the
other one: I sent this patch because I use Clang and it broke on my
system, not because it broke CI, hence the commit message)
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev