All of lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] lib/igt_halffloat: fix compilation with Clang
@ 2019-04-24  7:01 Simon Ser
  2019-04-24  8:03 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
                   ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Simon Ser @ 2019-04-24  7:01 UTC (permalink / raw)
  To: igt-dev

The source file contains a special code-path for Clang, however this path fails
to compile:

  ../lib/igt_halffloat.c:227:7: error: conflicting types for 'igt_half_to_float'
  float igt_half_to_float(const uint16_t *h, float *f, unsigned int num)
        ^
  ../lib/igt_halffloat.h:26:6: note: previous declaration is here
  void igt_half_to_float(const uint16_t *h, float *f, unsigned int num);
       ^
  1 error generated.

This commit fixes this mismatch.

Signed-off-by: Simon Ser <simon.ser@intel.com>
---
 lib/igt_halffloat.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/igt_halffloat.c b/lib/igt_halffloat.c
index 263b28c1..08ab05fc 100644
--- a/lib/igt_halffloat.c
+++ b/lib/igt_halffloat.c
@@ -224,7 +224,7 @@ void igt_float_to_half(const float *f, uint16_t *h, unsigned int num)
 		h[i] = _float_to_half(f[i]);
 }
 
-float igt_half_to_float(const uint16_t *h, float *f, unsigned int num)
+void igt_half_to_float(const uint16_t *h, float *f, unsigned int num)
 {
 	for (int i = 0; i < num; i++)
 		f[i] = _half_to_float(h[i]);
-- 
2.21.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2019-04-25 11:28 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-24  7:01 [igt-dev] [PATCH i-g-t] lib/igt_halffloat: fix compilation with Clang Simon Ser
2019-04-24  8:03 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-04-24  9:28 ` [igt-dev] [PATCH i-g-t] " Petri Latvala
2019-04-24 13:26   ` Petri Latvala
2019-04-24 20:06     ` Daniel Vetter
2019-04-25  7:36       ` Daniel Vetter
2019-04-25 11:28         ` Ser, Simon
2019-04-24 13:18 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.