* [PATCH 0/2] drm/i915: C8 fix
@ 2019-05-13 13:39 Ville Syrjala
2019-05-13 13:39 ` [PATCH 1/2] drm/i915: Update pipe gamma enable bits when C8 planes are getting enabled/disabled Ville Syrjala
` (3 more replies)
0 siblings, 4 replies; 8+ messages in thread
From: Ville Syrjala @ 2019-05-13 13:39 UTC (permalink / raw)
To: intel-gfx
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Fix toggling between no C8 planes vs. at least one C8 plane.
Test-with: 20190510171900.29593-1-ville.syrjala@linux.intel.com
Ville Syrjälä (2):
drm/i915: Update pipe gamma enable bits when C8 planes are getting
enabled/disabled
drm/i915: Add debugs for the C8 vs. legacy LUT case
drivers/gpu/drm/i915/intel_color.c | 4 +++-
drivers/gpu/drm/i915/intel_display.c | 18 ++++++++++++++++++
2 files changed, 21 insertions(+), 1 deletion(-)
--
2.21.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/2] drm/i915: Update pipe gamma enable bits when C8 planes are getting enabled/disabled
2019-05-13 13:39 [PATCH 0/2] drm/i915: C8 fix Ville Syrjala
@ 2019-05-13 13:39 ` Ville Syrjala
2019-05-13 13:39 ` [PATCH 2/2] drm/i915: Add debugs for the C8 vs. legacy LUT case Ville Syrjala
` (2 subsequent siblings)
3 siblings, 0 replies; 8+ messages in thread
From: Ville Syrjala @ 2019-05-13 13:39 UTC (permalink / raw)
To: intel-gfx
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
When the first C8 plane gets enabled, or the last one gets disabled we
may need to enable/disable the pipe gamma for the other active planes.
Check for that and run through the normal intel_color_check() path.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/intel_display.c | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 05177f37181b..01c5c07bc7ea 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -11176,6 +11176,17 @@ static int icl_check_nv12_planes(struct intel_crtc_state *crtc_state)
return 0;
}
+static bool c8_planes_changed(const struct intel_crtc_state *new_crtc_state)
+{
+ struct intel_crtc *crtc = to_intel_crtc(new_crtc_state->base.crtc);
+ struct intel_atomic_state *state =
+ to_intel_atomic_state(new_crtc_state->base.state);
+ const struct intel_crtc_state *old_crtc_state =
+ intel_atomic_get_old_crtc_state(state, crtc);
+
+ return !old_crtc_state->c8_planes != !new_crtc_state->c8_planes;
+}
+
static int intel_crtc_atomic_check(struct drm_crtc *crtc,
struct drm_crtc_state *crtc_state)
{
@@ -11199,6 +11210,13 @@ static int intel_crtc_atomic_check(struct drm_crtc *crtc,
return ret;
}
+ /*
+ * May need to update pipe gamma enable bits
+ * when C8 planes are getting enabled/disabled.
+ */
+ if (c8_planes_changed(pipe_config))
+ crtc_state->color_mgmt_changed = true;
+
if (mode_changed || pipe_config->update_pipe ||
crtc_state->color_mgmt_changed) {
ret = intel_color_check(pipe_config);
--
2.21.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/2] drm/i915: Add debugs for the C8 vs. legacy LUT case
2019-05-13 13:39 [PATCH 0/2] drm/i915: C8 fix Ville Syrjala
2019-05-13 13:39 ` [PATCH 1/2] drm/i915: Update pipe gamma enable bits when C8 planes are getting enabled/disabled Ville Syrjala
@ 2019-05-13 13:39 ` Ville Syrjala
2019-05-28 10:51 ` Maarten Lankhorst
2019-05-13 16:20 ` ✓ Fi.CI.BAT: success for drm/i915: C8 fix Patchwork
2019-05-13 21:40 ` ✗ Fi.CI.IGT: failure " Patchwork
3 siblings, 1 reply; 8+ messages in thread
From: Ville Syrjala @ 2019-05-13 13:39 UTC (permalink / raw)
To: intel-gfx
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Leave a hint in dmesg when we reject a configuration attempting
to use C8 planes without the legacy LUT loaded.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/intel_color.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_color.c b/drivers/gpu/drm/i915/intel_color.c
index 962db1236970..45649904ba5c 100644
--- a/drivers/gpu/drm/i915/intel_color.c
+++ b/drivers/gpu/drm/i915/intel_color.c
@@ -959,8 +959,10 @@ static int check_luts(const struct intel_crtc_state *crtc_state)
return 0;
/* C8 relies on its palette being stored in the legacy LUT */
- if (crtc_state->c8_planes)
+ if (crtc_state->c8_planes) {
+ DRM_DEBUG_KMS("C8 pixelformat requires the legacy LUT\n");
return -EINVAL;
+ }
degamma_length = INTEL_INFO(dev_priv)->color.degamma_lut_size;
gamma_length = INTEL_INFO(dev_priv)->color.gamma_lut_size;
--
2.21.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 8+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: C8 fix
2019-05-13 13:39 [PATCH 0/2] drm/i915: C8 fix Ville Syrjala
2019-05-13 13:39 ` [PATCH 1/2] drm/i915: Update pipe gamma enable bits when C8 planes are getting enabled/disabled Ville Syrjala
2019-05-13 13:39 ` [PATCH 2/2] drm/i915: Add debugs for the C8 vs. legacy LUT case Ville Syrjala
@ 2019-05-13 16:20 ` Patchwork
2019-05-13 21:40 ` ✗ Fi.CI.IGT: failure " Patchwork
3 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2019-05-13 16:20 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: C8 fix
URL : https://patchwork.freedesktop.org/series/60583/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6077 -> Patchwork_13008
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13008/
Known issues
------------
Here are the changes found in Patchwork_13008 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s3:
- fi-blb-e6850: [PASS][1] -> [INCOMPLETE][2] ([fdo#107718])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/fi-blb-e6850/igt@gem_exec_suspend@basic-s3.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13008/fi-blb-e6850/igt@gem_exec_suspend@basic-s3.html
* igt@i915_selftest@live_contexts:
- fi-skl-gvtdvm: [PASS][3] -> [DMESG-FAIL][4] ([fdo#110235])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/fi-skl-gvtdvm/igt@i915_selftest@live_contexts.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13008/fi-skl-gvtdvm/igt@i915_selftest@live_contexts.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#110235]: https://bugs.freedesktop.org/show_bug.cgi?id=110235
Participating hosts (53 -> 46)
------------------------------
Missing (7): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus
Build changes
-------------
* IGT: IGT_4984 -> IGTPW_2967
* Linux: CI_DRM_6077 -> Patchwork_13008
CI_DRM_6077: f175074b17cfeb7d64cfcfd6b2641641a10d4deb @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2967: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2967/
IGT_4984: 66c887d2f7a92a4a97acd9611d5342afc5d4f815 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_13008: c635cd2d1c0913c4acf850bbc222a974b3ce87e6 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
c635cd2d1c09 drm/i915: Add debugs for the C8 vs. legacy LUT case
dc3ed486fae1 drm/i915: Update pipe gamma enable bits when C8 planes are getting enabled/disabled
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13008/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* ✗ Fi.CI.IGT: failure for drm/i915: C8 fix
2019-05-13 13:39 [PATCH 0/2] drm/i915: C8 fix Ville Syrjala
` (2 preceding siblings ...)
2019-05-13 16:20 ` ✓ Fi.CI.BAT: success for drm/i915: C8 fix Patchwork
@ 2019-05-13 21:40 ` Patchwork
2019-05-28 13:03 ` Ville Syrjälä
3 siblings, 1 reply; 8+ messages in thread
From: Patchwork @ 2019-05-13 21:40 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: C8 fix
URL : https://patchwork.freedesktop.org/series/60583/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_6077_full -> Patchwork_13008_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_13008_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_13008_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_13008_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_available_modes_crc@available_mode_test_crc:
- shard-apl: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/shard-apl6/igt@kms_available_modes_crc@available_mode_test_crc.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13008/shard-apl1/igt@kms_available_modes_crc@available_mode_test_crc.html
- shard-glk: [PASS][3] -> [FAIL][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/shard-glk7/igt@kms_available_modes_crc@available_mode_test_crc.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13008/shard-glk7/igt@kms_available_modes_crc@available_mode_test_crc.html
- shard-hsw: [PASS][5] -> [FAIL][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/shard-hsw6/igt@kms_available_modes_crc@available_mode_test_crc.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13008/shard-hsw5/igt@kms_available_modes_crc@available_mode_test_crc.html
- shard-snb: [PASS][7] -> [FAIL][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/shard-snb4/igt@kms_available_modes_crc@available_mode_test_crc.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13008/shard-snb6/igt@kms_available_modes_crc@available_mode_test_crc.html
Known issues
------------
Here are the changes found in Patchwork_13008_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_tiled_swapping@non-threaded:
- shard-hsw: [PASS][9] -> [FAIL][10] ([fdo#108686])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/shard-hsw5/igt@gem_tiled_swapping@non-threaded.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13008/shard-hsw4/igt@gem_tiled_swapping@non-threaded.html
* igt@i915_pm_rpm@basic-rte:
- shard-skl: [PASS][11] -> [INCOMPLETE][12] ([fdo#107807]) +2 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/shard-skl5/igt@i915_pm_rpm@basic-rte.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13008/shard-skl6/igt@i915_pm_rpm@basic-rte.html
* igt@i915_suspend@debugfs-reader:
- shard-apl: [PASS][13] -> [DMESG-WARN][14] ([fdo#108566]) +3 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/shard-apl3/igt@i915_suspend@debugfs-reader.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13008/shard-apl5/igt@i915_suspend@debugfs-reader.html
* igt@kms_available_modes_crc@available_mode_test_crc:
- shard-skl: [PASS][15] -> [FAIL][16] ([fdo#109052])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/shard-skl5/igt@kms_available_modes_crc@available_mode_test_crc.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13008/shard-skl8/igt@kms_available_modes_crc@available_mode_test_crc.html
- shard-iclb: [PASS][17] -> [FAIL][18] ([fdo#109052])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/shard-iclb7/igt@kms_available_modes_crc@available_mode_test_crc.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13008/shard-iclb5/igt@kms_available_modes_crc@available_mode_test_crc.html
- shard-kbl: [PASS][19] -> [FAIL][20] ([fdo#109052])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/shard-kbl4/igt@kms_available_modes_crc@available_mode_test_crc.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13008/shard-kbl7/igt@kms_available_modes_crc@available_mode_test_crc.html
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic:
- shard-hsw: [PASS][21] -> [FAIL][22] ([fdo#105767])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/shard-hsw5/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13008/shard-hsw6/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html
* igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions:
- shard-hsw: [PASS][23] -> [FAIL][24] ([fdo#103355])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/shard-hsw6/igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13008/shard-hsw8/igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions.html
* igt@kms_flip@flip-vs-expired-vblank:
- shard-glk: [PASS][25] -> [FAIL][26] ([fdo#102887] / [fdo#105363])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/shard-glk1/igt@kms_flip@flip-vs-expired-vblank.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13008/shard-glk1/igt@kms_flip@flip-vs-expired-vblank.html
* igt@kms_frontbuffer_tracking@fbc-1p-rte:
- shard-iclb: [PASS][27] -> [FAIL][28] ([fdo#103167] / [fdo#110378])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-1p-rte.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13008/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-1p-rte.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-msflip-blt:
- shard-iclb: [PASS][29] -> [FAIL][30] ([fdo#103167]) +4 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-msflip-blt.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13008/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-msflip-blt.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-skl: [PASS][31] -> [INCOMPLETE][32] ([fdo#104108] / [fdo#107773])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/shard-skl6/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13008/shard-skl7/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
* igt@kms_plane_lowres@pipe-a-tiling-x:
- shard-iclb: [PASS][33] -> [FAIL][34] ([fdo#103166])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/shard-iclb4/igt@kms_plane_lowres@pipe-a-tiling-x.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13008/shard-iclb2/igt@kms_plane_lowres@pipe-a-tiling-x.html
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [PASS][35] -> [SKIP][36] ([fdo#109441]) +1 similar issue
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13008/shard-iclb7/igt@kms_psr@psr2_cursor_render.html
* igt@perf@oa-exponents:
- shard-kbl: [PASS][37] -> [FAIL][38] ([fdo#105483])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/shard-kbl3/igt@perf@oa-exponents.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13008/shard-kbl1/igt@perf@oa-exponents.html
* igt@perf_pmu@rc6:
- shard-kbl: [PASS][39] -> [SKIP][40] ([fdo#109271])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/shard-kbl1/igt@perf_pmu@rc6.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13008/shard-kbl7/igt@perf_pmu@rc6.html
#### Possible fixes ####
* igt@i915_pm_rpm@i2c:
- shard-skl: [INCOMPLETE][41] ([fdo#107807]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/shard-skl1/igt@i915_pm_rpm@i2c.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13008/shard-skl10/igt@i915_pm_rpm@i2c.html
* igt@i915_pm_rps@waitboost:
- shard-apl: [FAIL][43] ([fdo#102250]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/shard-apl6/igt@i915_pm_rps@waitboost.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13008/shard-apl7/igt@i915_pm_rps@waitboost.html
* igt@i915_suspend@fence-restore-untiled:
- shard-apl: [DMESG-WARN][45] ([fdo#108566]) -> [PASS][46] +3 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/shard-apl5/igt@i915_suspend@fence-restore-untiled.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13008/shard-apl2/igt@i915_suspend@fence-restore-untiled.html
* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: [SKIP][47] ([fdo#109349]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/shard-iclb8/igt@kms_dp_dsc@basic-dsc-enable-edp.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13008/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html
* igt@kms_flip@flip-vs-suspend:
- shard-skl: [INCOMPLETE][49] ([fdo#109507]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/shard-skl6/igt@kms_flip@flip-vs-suspend.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13008/shard-skl7/igt@kms_flip@flip-vs-suspend.html
* igt@kms_flip_tiling@flip-changes-tiling-y:
- shard-skl: [FAIL][51] ([fdo#107931] / [fdo#108303]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/shard-skl6/igt@kms_flip_tiling@flip-changes-tiling-y.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13008/shard-skl6/igt@kms_flip_tiling@flip-changes-tiling-y.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-pwrite:
- shard-iclb: [FAIL][53] ([fdo#103167]) -> [PASS][54] +3 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-pwrite.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13008/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-pwrite.html
* igt@kms_psr2_su@page_flip:
- shard-iclb: [SKIP][55] ([fdo#109642]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/shard-iclb8/igt@kms_psr2_su@page_flip.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13008/shard-iclb2/igt@kms_psr2_su@page_flip.html
* igt@kms_psr@psr2_cursor_plane_move:
- shard-iclb: [SKIP][57] ([fdo#109441]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/shard-iclb4/igt@kms_psr@psr2_cursor_plane_move.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13008/shard-iclb2/igt@kms_psr@psr2_cursor_plane_move.html
* igt@kms_setmode@basic:
- shard-apl: [FAIL][59] ([fdo#99912]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/shard-apl8/igt@kms_setmode@basic.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13008/shard-apl1/igt@kms_setmode@basic.html
- shard-kbl: [FAIL][61] ([fdo#99912]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/shard-kbl7/igt@kms_setmode@basic.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13008/shard-kbl7/igt@kms_setmode@basic.html
* igt@kms_sysfs_edid_timing:
- shard-iclb: [FAIL][63] ([fdo#100047]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/shard-iclb3/igt@kms_sysfs_edid_timing.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13008/shard-iclb4/igt@kms_sysfs_edid_timing.html
[fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047
[fdo#102250]: https://bugs.freedesktop.org/show_bug.cgi?id=102250
[fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105483]: https://bugs.freedesktop.org/show_bug.cgi?id=105483
[fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
[fdo#107773]: https://bugs.freedesktop.org/show_bug.cgi?id=107773
[fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
[fdo#107931]: https://bugs.freedesktop.org/show_bug.cgi?id=107931
[fdo#108303]: https://bugs.freedesktop.org/show_bug.cgi?id=108303
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
[fdo#109052]: https://bugs.freedesktop.org/show_bug.cgi?id=109052
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109507]: https://bugs.freedesktop.org/show_bug.cgi?id=109507
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110378]: https://bugs.freedesktop.org/show_bug.cgi?id=110378
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* IGT: IGT_4984 -> IGTPW_2967
* Linux: CI_DRM_6077 -> Patchwork_13008
CI_DRM_6077: f175074b17cfeb7d64cfcfd6b2641641a10d4deb @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2967: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2967/
IGT_4984: 66c887d2f7a92a4a97acd9611d5342afc5d4f815 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_13008: c635cd2d1c0913c4acf850bbc222a974b3ce87e6 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13008/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] drm/i915: Add debugs for the C8 vs. legacy LUT case
2019-05-13 13:39 ` [PATCH 2/2] drm/i915: Add debugs for the C8 vs. legacy LUT case Ville Syrjala
@ 2019-05-28 10:51 ` Maarten Lankhorst
2019-05-28 17:49 ` Ville Syrjälä
0 siblings, 1 reply; 8+ messages in thread
From: Maarten Lankhorst @ 2019-05-28 10:51 UTC (permalink / raw)
To: Ville Syrjala, intel-gfx
Op 13-05-2019 om 15:39 schreef Ville Syrjala:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Leave a hint in dmesg when we reject a configuration attempting
> to use C8 planes without the legacy LUT loaded.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_color.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_color.c b/drivers/gpu/drm/i915/intel_color.c
> index 962db1236970..45649904ba5c 100644
> --- a/drivers/gpu/drm/i915/intel_color.c
> +++ b/drivers/gpu/drm/i915/intel_color.c
> @@ -959,8 +959,10 @@ static int check_luts(const struct intel_crtc_state *crtc_state)
> return 0;
>
> /* C8 relies on its palette being stored in the legacy LUT */
> - if (crtc_state->c8_planes)
> + if (crtc_state->c8_planes) {
> + DRM_DEBUG_KMS("C8 pixelformat requires the legacy LUT\n");
> return -EINVAL;
> + }
>
> degamma_length = INTEL_INFO(dev_priv)->color.degamma_lut_size;
> gamma_length = INTEL_INFO(dev_priv)->color.gamma_lut_size;
For the series:
Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: ✗ Fi.CI.IGT: failure for drm/i915: C8 fix
2019-05-13 21:40 ` ✗ Fi.CI.IGT: failure " Patchwork
@ 2019-05-28 13:03 ` Ville Syrjälä
0 siblings, 0 replies; 8+ messages in thread
From: Ville Syrjälä @ 2019-05-28 13:03 UTC (permalink / raw)
To: intel-gfx
On Mon, May 13, 2019 at 09:40:47PM -0000, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915: C8 fix
> URL : https://patchwork.freedesktop.org/series/60583/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_6077_full -> Patchwork_13008_full
> ====================================================
>
> Summary
> -------
>
> **FAILURE**
>
> Serious unknown changes coming with Patchwork_13008_full absolutely need to be
> verified manually.
>
> If you think the reported changes have nothing to do with the changes
> introduced in Patchwork_13008_full, please notify your bug team to allow them
> to document this new failure mode, which will reduce false positives in CI.
>
>
>
> Possible new issues
> -------------------
>
> Here are the unknown changes that may have been introduced in Patchwork_13008_full:
>
> ### IGT changes ###
>
> #### Possible regressions ####
>
> * igt@kms_available_modes_crc@available_mode_test_crc:
> - shard-apl: [PASS][1] -> [FAIL][2]
> [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/shard-apl6/igt@kms_available_modes_crc@available_mode_test_crc.html
> [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13008/shard-apl1/igt@kms_available_modes_crc@available_mode_test_crc.html
> - shard-glk: [PASS][3] -> [FAIL][4]
> [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/shard-glk7/igt@kms_available_modes_crc@available_mode_test_crc.html
> [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13008/shard-glk7/igt@kms_available_modes_crc@available_mode_test_crc.html
> - shard-hsw: [PASS][5] -> [FAIL][6]
> [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/shard-hsw6/igt@kms_available_modes_crc@available_mode_test_crc.html
> [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13008/shard-hsw5/igt@kms_available_modes_crc@available_mode_test_crc.html
> - shard-snb: [PASS][7] -> [FAIL][8]
> [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6077/shard-snb4/igt@kms_available_modes_crc@available_mode_test_crc.html
> [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13008/shard-snb6/igt@kms_available_modes_crc@available_mode_test_crc.html
Going to be fixed by removing the semi-busted C8 test:
https://patchwork.freedesktop.org/patch/305298/?series=60729&rev=1
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] drm/i915: Add debugs for the C8 vs. legacy LUT case
2019-05-28 10:51 ` Maarten Lankhorst
@ 2019-05-28 17:49 ` Ville Syrjälä
0 siblings, 0 replies; 8+ messages in thread
From: Ville Syrjälä @ 2019-05-28 17:49 UTC (permalink / raw)
To: Maarten Lankhorst; +Cc: intel-gfx
On Tue, May 28, 2019 at 12:51:04PM +0200, Maarten Lankhorst wrote:
> Op 13-05-2019 om 15:39 schreef Ville Syrjala:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Leave a hint in dmesg when we reject a configuration attempting
> > to use C8 planes without the legacy LUT loaded.
> >
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> > drivers/gpu/drm/i915/intel_color.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_color.c b/drivers/gpu/drm/i915/intel_color.c
> > index 962db1236970..45649904ba5c 100644
> > --- a/drivers/gpu/drm/i915/intel_color.c
> > +++ b/drivers/gpu/drm/i915/intel_color.c
> > @@ -959,8 +959,10 @@ static int check_luts(const struct intel_crtc_state *crtc_state)
> > return 0;
> >
> > /* C8 relies on its palette being stored in the legacy LUT */
> > - if (crtc_state->c8_planes)
> > + if (crtc_state->c8_planes) {
> > + DRM_DEBUG_KMS("C8 pixelformat requires the legacy LUT\n");
> > return -EINVAL;
> > + }
> >
> > degamma_length = INTEL_INFO(dev_priv)->color.degamma_lut_size;
> > gamma_length = INTEL_INFO(dev_priv)->color.gamma_lut_size;
>
> For the series:
>
> Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Thanks. Pushed.
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-05-28 17:49 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-13 13:39 [PATCH 0/2] drm/i915: C8 fix Ville Syrjala
2019-05-13 13:39 ` [PATCH 1/2] drm/i915: Update pipe gamma enable bits when C8 planes are getting enabled/disabled Ville Syrjala
2019-05-13 13:39 ` [PATCH 2/2] drm/i915: Add debugs for the C8 vs. legacy LUT case Ville Syrjala
2019-05-28 10:51 ` Maarten Lankhorst
2019-05-28 17:49 ` Ville Syrjälä
2019-05-13 16:20 ` ✓ Fi.CI.BAT: success for drm/i915: C8 fix Patchwork
2019-05-13 21:40 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-05-28 13:03 ` Ville Syrjälä
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.