[Qemu-devel] [PATCH] migration: remove unused field bytes_xfer

[Qemu-devel] [PATCH] migration: remove unused field bytes_xfer

[Wei Yang]

MigrationState->bytes_xfer is only set to 0 in migrate_init().

Remove this unnecessary field.

Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
---
 migration/migration.c | 1 -
 migration/migration.h | 1 -
 2 files changed, 2 deletions(-)

diff --git a/migration/migration.c b/migration/migration.c
index dea7078bf4..c929cf8d0f 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -1681,7 +1681,6 @@ void migrate_init(MigrationState *s)
      * parameters/capabilities that the user set, and
      * locks.
      */
-    s->bytes_xfer = 0;
     s->cleanup_bh = 0;
     s->to_dst_file = NULL;
     s->rp_state.from_dst_file = NULL;
diff --git a/migration/migration.h b/migration/migration.h
index 852eb3c4e9..b9efbe9168 100644
--- a/migration/migration.h
+++ b/migration/migration.h
@@ -116,7 +116,6 @@ struct MigrationState
     DeviceState parent_obj;
 
     /*< public >*/
-    size_t bytes_xfer;
     QemuThread thread;
     QEMUBH *cleanup_bh;
     QEMUFile *to_dst_file;
-- 
2.19.1

Re: [Qemu-devel] [PATCH] migration: remove unused field bytes_xfer

[Wei Yang]

On Tue, Apr 02, 2019 at 08:31:06AM +0800, Wei Yang wrote:
>MigrationState->bytes_xfer is only set to 0 in migrate_init().
>
>Remove this unnecessary field.
>
>Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>

Hi, David

Are you willing to pick up this one?

>---
> migration/migration.c | 1 -
> migration/migration.h | 1 -
> 2 files changed, 2 deletions(-)
>
>diff --git a/migration/migration.c b/migration/migration.c
>index dea7078bf4..c929cf8d0f 100644
>--- a/migration/migration.c
>+++ b/migration/migration.c
>@@ -1681,7 +1681,6 @@ void migrate_init(MigrationState *s)
>      * parameters/capabilities that the user set, and
>      * locks.
>      */
>-    s->bytes_xfer = 0;
>     s->cleanup_bh = 0;
>     s->to_dst_file = NULL;
>     s->rp_state.from_dst_file = NULL;
>diff --git a/migration/migration.h b/migration/migration.h
>index 852eb3c4e9..b9efbe9168 100644
>--- a/migration/migration.h
>+++ b/migration/migration.h
>@@ -116,7 +116,6 @@ struct MigrationState
>     DeviceState parent_obj;
> 
>     /*< public >*/
>-    size_t bytes_xfer;
>     QemuThread thread;
>     QEMUBH *cleanup_bh;
>     QEMUFile *to_dst_file;
>-- 
>2.19.1

-- 
Wei Yang
Help you, Help me

Re: [Qemu-devel] [PATCH] migration: remove unused field bytes_xfer

[Juan Quintela]

Wei Yang <richardw.yang@linux.intel.com> wrote:
> On Tue, Apr 02, 2019 at 08:31:06AM +0800, Wei Yang wrote:
>>MigrationState->bytes_xfer is only set to 0 in migrate_init().
>>
>>Remove this unnecessary field.
>>
>>Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
>
> Hi, David

Hi

I am on duty this week, will get it.

>
> Are you willing to pick up this one?
>
>>---
>> migration/migration.c | 1 -
>> migration/migration.h | 1 -
>> 2 files changed, 2 deletions(-)
>>
>>diff --git a/migration/migration.c b/migration/migration.c
>>index dea7078bf4..c929cf8d0f 100644
>>--- a/migration/migration.c
>>+++ b/migration/migration.c
>>@@ -1681,7 +1681,6 @@ void migrate_init(MigrationState *s)
>>      * parameters/capabilities that the user set, and
>>      * locks.
>>      */
>>-    s->bytes_xfer = 0;
>>     s->cleanup_bh = 0;
>>     s->to_dst_file = NULL;
>>     s->rp_state.from_dst_file = NULL;
>>diff --git a/migration/migration.h b/migration/migration.h
>>index 852eb3c4e9..b9efbe9168 100644
>>--- a/migration/migration.h
>>+++ b/migration/migration.h
>>@@ -116,7 +116,6 @@ struct MigrationState
>>     DeviceState parent_obj;
>> 
>>     /*< public >*/
>>-    size_t bytes_xfer;
>>     QemuThread thread;
>>     QEMUBH *cleanup_bh;
>>     QEMUFile *to_dst_file;
>>-- 
>>2.19.1

Re: [Qemu-devel] [PATCH] migration: remove unused field bytes_xfer

[Wei Yang]

On Tue, Jun 11, 2019 at 10:33:29AM +0200, Juan Quintela wrote:
>Wei Yang <richardw.yang@linux.intel.com> wrote:
>> On Tue, Apr 02, 2019 at 08:31:06AM +0800, Wei Yang wrote:
>>>MigrationState->bytes_xfer is only set to 0 in migrate_init().
>>>
>>>Remove this unnecessary field.
>>>
>>>Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
>>
>> Hi, David
>
>Hi
>
>I am on duty this week, will get it.

Thanks :-)

>
>>
>> Are you willing to pick up this one?
>>
>>>---
>>> migration/migration.c | 1 -
>>> migration/migration.h | 1 -
>>> 2 files changed, 2 deletions(-)
>>>
>>>diff --git a/migration/migration.c b/migration/migration.c
>>>index dea7078bf4..c929cf8d0f 100644
>>>--- a/migration/migration.c
>>>+++ b/migration/migration.c
>>>@@ -1681,7 +1681,6 @@ void migrate_init(MigrationState *s)
>>>      * parameters/capabilities that the user set, and
>>>      * locks.
>>>      */
>>>-    s->bytes_xfer = 0;
>>>     s->cleanup_bh = 0;
>>>     s->to_dst_file = NULL;
>>>     s->rp_state.from_dst_file = NULL;
>>>diff --git a/migration/migration.h b/migration/migration.h
>>>index 852eb3c4e9..b9efbe9168 100644
>>>--- a/migration/migration.h
>>>+++ b/migration/migration.h
>>>@@ -116,7 +116,6 @@ struct MigrationState
>>>     DeviceState parent_obj;
>>> 
>>>     /*< public >*/
>>>-    size_t bytes_xfer;
>>>     QemuThread thread;
>>>     QEMUBH *cleanup_bh;
>>>     QEMUFile *to_dst_file;
>>>-- 
>>>2.19.1

-- 
Wei Yang
Help you, Help me

Re: [Qemu-devel] [PATCH] migration: remove unused field bytes_xfer

[Wei Yang]

On Tue, Jun 11, 2019 at 10:33:29AM +0200, Juan Quintela wrote:
>Wei Yang <richardw.yang@linux.intel.com> wrote:
>> On Tue, Apr 02, 2019 at 08:31:06AM +0800, Wei Yang wrote:
>>>MigrationState->bytes_xfer is only set to 0 in migrate_init().
>>>
>>>Remove this unnecessary field.
>>>
>>>Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
>>
>> Hi, David
>
>Hi
>
>I am on duty this week, will get it.
>

Hi, Juan,

May I ask when you are willing to pick it up?

>>
>> Are you willing to pick up this one?
>>
>>>---
>>> migration/migration.c | 1 -
>>> migration/migration.h | 1 -
>>> 2 files changed, 2 deletions(-)
>>>
>>>diff --git a/migration/migration.c b/migration/migration.c
>>>index dea7078bf4..c929cf8d0f 100644
>>>--- a/migration/migration.c
>>>+++ b/migration/migration.c
>>>@@ -1681,7 +1681,6 @@ void migrate_init(MigrationState *s)
>>>      * parameters/capabilities that the user set, and
>>>      * locks.
>>>      */
>>>-    s->bytes_xfer = 0;
>>>     s->cleanup_bh = 0;
>>>     s->to_dst_file = NULL;
>>>     s->rp_state.from_dst_file = NULL;
>>>diff --git a/migration/migration.h b/migration/migration.h
>>>index 852eb3c4e9..b9efbe9168 100644
>>>--- a/migration/migration.h
>>>+++ b/migration/migration.h
>>>@@ -116,7 +116,6 @@ struct MigrationState
>>>     DeviceState parent_obj;
>>> 
>>>     /*< public >*/
>>>-    size_t bytes_xfer;
>>>     QemuThread thread;
>>>     QEMUBH *cleanup_bh;
>>>     QEMUFile *to_dst_file;
>>>-- 
>>>2.19.1

-- 
Wei Yang
Help you, Help me

Re: [Qemu-devel] [PATCH] migration: remove unused field bytes_xfer

[Wei Yang]

On Tue, Jun 11, 2019 at 10:33:29AM +0200, Juan Quintela wrote:
>Wei Yang <richardw.yang@linux.intel.com> wrote:
>> On Tue, Apr 02, 2019 at 08:31:06AM +0800, Wei Yang wrote:
>>>MigrationState->bytes_xfer is only set to 0 in migrate_init().
>>>
>>>Remove this unnecessary field.
>>>
>>>Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
>>
>> Hi, David
>
>Hi
>
>I am on duty this week, will get it.
>

Hi, Juan

Sounds we lost this one and the one above this :-)


-- 
Wei Yang
Help you, Help me

Re: [Qemu-devel] [PATCH] migration: remove unused field bytes_xfer

[Dr. David Alan Gilbert]

* Wei Yang (richardw.yang@linux.intel.com) wrote:
> On Tue, Jun 11, 2019 at 10:33:29AM +0200, Juan Quintela wrote:
> >Wei Yang <richardw.yang@linux.intel.com> wrote:
> >> On Tue, Apr 02, 2019 at 08:31:06AM +0800, Wei Yang wrote:
> >>>MigrationState->bytes_xfer is only set to 0 in migrate_init().
> >>>
> >>>Remove this unnecessary field.
> >>>
> >>>Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
> >>
> >> Hi, David
> >
> >Hi
> >
> >I am on duty this week, will get it.
> >
> 
> Hi, Juan
> 
> Sounds we lost this one and the one above this :-)
> 

We're in freeze at the moment; we'll pick it up as soon
as it opens up again; I've got quite a list of your clean-up patches!

Dave

> -- 
> Wei Yang
> Help you, Help me
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK

Re: [Qemu-devel] [PATCH] migration: remove unused field bytes_xfer

[Wei Yang]

On Fri, Jul 19, 2019 at 07:05:44PM +0100, Dr. David Alan Gilbert wrote:
>* Wei Yang (richardw.yang@linux.intel.com) wrote:
>> On Tue, Jun 11, 2019 at 10:33:29AM +0200, Juan Quintela wrote:
>> >Wei Yang <richardw.yang@linux.intel.com> wrote:
>> >> On Tue, Apr 02, 2019 at 08:31:06AM +0800, Wei Yang wrote:
>> >>>MigrationState->bytes_xfer is only set to 0 in migrate_init().
>> >>>
>> >>>Remove this unnecessary field.
>> >>>
>> >>>Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
>> >>
>> >> Hi, David
>> >
>> >Hi
>> >
>> >I am on duty this week, will get it.
>> >
>> 
>> Hi, Juan
>> 
>> Sounds we lost this one and the one above this :-)
>> 
>
>We're in freeze at the moment; we'll pick it up as soon
>as it opens up again; I've got quite a list of your clean-up patches!
>

Thanks for your reply.

Have a good weekend. :-)

>Dave
>
>> -- 
>> Wei Yang
>> Help you, Help me
>--
>Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK

-- 
Wei Yang
Help you, Help me

Re: [Qemu-devel] [PATCH] migration: remove unused field bytes_xfer

[Dr. David Alan Gilbert]

* Wei Yang (richardw.yang@linux.intel.com) wrote:
> MigrationState->bytes_xfer is only set to 0 in migrate_init().
> 
> Remove this unnecessary field.
> 
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>

Queued (finally!)

> ---
>  migration/migration.c | 1 -
>  migration/migration.h | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/migration/migration.c b/migration/migration.c
> index dea7078bf4..c929cf8d0f 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -1681,7 +1681,6 @@ void migrate_init(MigrationState *s)
>       * parameters/capabilities that the user set, and
>       * locks.
>       */
> -    s->bytes_xfer = 0;
>      s->cleanup_bh = 0;
>      s->to_dst_file = NULL;
>      s->rp_state.from_dst_file = NULL;
> diff --git a/migration/migration.h b/migration/migration.h
> index 852eb3c4e9..b9efbe9168 100644
> --- a/migration/migration.h
> +++ b/migration/migration.h
> @@ -116,7 +116,6 @@ struct MigrationState
>      DeviceState parent_obj;
>  
>      /*< public >*/
> -    size_t bytes_xfer;
>      QemuThread thread;
>      QEMUBH *cleanup_bh;
>      QEMUFile *to_dst_file;
> -- 
> 2.19.1
> 
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK