* Re: [Qemu-devel] [PATCH] migration: remove unused field bytes_xfer
2019-06-11 8:33 ` Juan Quintela
@ 2019-06-11 8:50 ` Wei Yang
2019-06-21 7:43 ` Wei Yang
2019-07-17 1:14 ` Wei Yang
2 siblings, 0 replies; 9+ messages in thread
From: Wei Yang @ 2019-06-11 8:50 UTC (permalink / raw)
To: Juan Quintela; +Cc: Wei Yang, dgilbert, qemu-devel
On Tue, Jun 11, 2019 at 10:33:29AM +0200, Juan Quintela wrote:
>Wei Yang <richardw.yang@linux.intel.com> wrote:
>> On Tue, Apr 02, 2019 at 08:31:06AM +0800, Wei Yang wrote:
>>>MigrationState->bytes_xfer is only set to 0 in migrate_init().
>>>
>>>Remove this unnecessary field.
>>>
>>>Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
>>
>> Hi, David
>
>Hi
>
>I am on duty this week, will get it.
Thanks :-)
>
>>
>> Are you willing to pick up this one?
>>
>>>---
>>> migration/migration.c | 1 -
>>> migration/migration.h | 1 -
>>> 2 files changed, 2 deletions(-)
>>>
>>>diff --git a/migration/migration.c b/migration/migration.c
>>>index dea7078bf4..c929cf8d0f 100644
>>>--- a/migration/migration.c
>>>+++ b/migration/migration.c
>>>@@ -1681,7 +1681,6 @@ void migrate_init(MigrationState *s)
>>> * parameters/capabilities that the user set, and
>>> * locks.
>>> */
>>>- s->bytes_xfer = 0;
>>> s->cleanup_bh = 0;
>>> s->to_dst_file = NULL;
>>> s->rp_state.from_dst_file = NULL;
>>>diff --git a/migration/migration.h b/migration/migration.h
>>>index 852eb3c4e9..b9efbe9168 100644
>>>--- a/migration/migration.h
>>>+++ b/migration/migration.h
>>>@@ -116,7 +116,6 @@ struct MigrationState
>>> DeviceState parent_obj;
>>>
>>> /*< public >*/
>>>- size_t bytes_xfer;
>>> QemuThread thread;
>>> QEMUBH *cleanup_bh;
>>> QEMUFile *to_dst_file;
>>>--
>>>2.19.1
--
Wei Yang
Help you, Help me
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Qemu-devel] [PATCH] migration: remove unused field bytes_xfer
2019-06-11 8:33 ` Juan Quintela
2019-06-11 8:50 ` Wei Yang
@ 2019-06-21 7:43 ` Wei Yang
2019-07-17 1:14 ` Wei Yang
2 siblings, 0 replies; 9+ messages in thread
From: Wei Yang @ 2019-06-21 7:43 UTC (permalink / raw)
To: Juan Quintela; +Cc: Wei Yang, dgilbert, qemu-devel
On Tue, Jun 11, 2019 at 10:33:29AM +0200, Juan Quintela wrote:
>Wei Yang <richardw.yang@linux.intel.com> wrote:
>> On Tue, Apr 02, 2019 at 08:31:06AM +0800, Wei Yang wrote:
>>>MigrationState->bytes_xfer is only set to 0 in migrate_init().
>>>
>>>Remove this unnecessary field.
>>>
>>>Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
>>
>> Hi, David
>
>Hi
>
>I am on duty this week, will get it.
>
Hi, Juan,
May I ask when you are willing to pick it up?
>>
>> Are you willing to pick up this one?
>>
>>>---
>>> migration/migration.c | 1 -
>>> migration/migration.h | 1 -
>>> 2 files changed, 2 deletions(-)
>>>
>>>diff --git a/migration/migration.c b/migration/migration.c
>>>index dea7078bf4..c929cf8d0f 100644
>>>--- a/migration/migration.c
>>>+++ b/migration/migration.c
>>>@@ -1681,7 +1681,6 @@ void migrate_init(MigrationState *s)
>>> * parameters/capabilities that the user set, and
>>> * locks.
>>> */
>>>- s->bytes_xfer = 0;
>>> s->cleanup_bh = 0;
>>> s->to_dst_file = NULL;
>>> s->rp_state.from_dst_file = NULL;
>>>diff --git a/migration/migration.h b/migration/migration.h
>>>index 852eb3c4e9..b9efbe9168 100644
>>>--- a/migration/migration.h
>>>+++ b/migration/migration.h
>>>@@ -116,7 +116,6 @@ struct MigrationState
>>> DeviceState parent_obj;
>>>
>>> /*< public >*/
>>>- size_t bytes_xfer;
>>> QemuThread thread;
>>> QEMUBH *cleanup_bh;
>>> QEMUFile *to_dst_file;
>>>--
>>>2.19.1
--
Wei Yang
Help you, Help me
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Qemu-devel] [PATCH] migration: remove unused field bytes_xfer
2019-06-11 8:33 ` Juan Quintela
2019-06-11 8:50 ` Wei Yang
2019-06-21 7:43 ` Wei Yang
@ 2019-07-17 1:14 ` Wei Yang
2019-07-19 18:05 ` Dr. David Alan Gilbert
2 siblings, 1 reply; 9+ messages in thread
From: Wei Yang @ 2019-07-17 1:14 UTC (permalink / raw)
To: Juan Quintela; +Cc: Wei Yang, dgilbert, qemu-devel
On Tue, Jun 11, 2019 at 10:33:29AM +0200, Juan Quintela wrote:
>Wei Yang <richardw.yang@linux.intel.com> wrote:
>> On Tue, Apr 02, 2019 at 08:31:06AM +0800, Wei Yang wrote:
>>>MigrationState->bytes_xfer is only set to 0 in migrate_init().
>>>
>>>Remove this unnecessary field.
>>>
>>>Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
>>
>> Hi, David
>
>Hi
>
>I am on duty this week, will get it.
>
Hi, Juan
Sounds we lost this one and the one above this :-)
--
Wei Yang
Help you, Help me
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Qemu-devel] [PATCH] migration: remove unused field bytes_xfer
2019-07-17 1:14 ` Wei Yang
@ 2019-07-19 18:05 ` Dr. David Alan Gilbert
2019-07-20 1:36 ` Wei Yang
0 siblings, 1 reply; 9+ messages in thread
From: Dr. David Alan Gilbert @ 2019-07-19 18:05 UTC (permalink / raw)
To: Wei Yang; +Cc: qemu-devel, Juan Quintela
* Wei Yang (richardw.yang@linux.intel.com) wrote:
> On Tue, Jun 11, 2019 at 10:33:29AM +0200, Juan Quintela wrote:
> >Wei Yang <richardw.yang@linux.intel.com> wrote:
> >> On Tue, Apr 02, 2019 at 08:31:06AM +0800, Wei Yang wrote:
> >>>MigrationState->bytes_xfer is only set to 0 in migrate_init().
> >>>
> >>>Remove this unnecessary field.
> >>>
> >>>Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
> >>
> >> Hi, David
> >
> >Hi
> >
> >I am on duty this week, will get it.
> >
>
> Hi, Juan
>
> Sounds we lost this one and the one above this :-)
>
We're in freeze at the moment; we'll pick it up as soon
as it opens up again; I've got quite a list of your clean-up patches!
Dave
> --
> Wei Yang
> Help you, Help me
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Qemu-devel] [PATCH] migration: remove unused field bytes_xfer
2019-07-19 18:05 ` Dr. David Alan Gilbert
@ 2019-07-20 1:36 ` Wei Yang
0 siblings, 0 replies; 9+ messages in thread
From: Wei Yang @ 2019-07-20 1:36 UTC (permalink / raw)
To: Dr. David Alan Gilbert; +Cc: Juan Quintela, Wei Yang, qemu-devel
On Fri, Jul 19, 2019 at 07:05:44PM +0100, Dr. David Alan Gilbert wrote:
>* Wei Yang (richardw.yang@linux.intel.com) wrote:
>> On Tue, Jun 11, 2019 at 10:33:29AM +0200, Juan Quintela wrote:
>> >Wei Yang <richardw.yang@linux.intel.com> wrote:
>> >> On Tue, Apr 02, 2019 at 08:31:06AM +0800, Wei Yang wrote:
>> >>>MigrationState->bytes_xfer is only set to 0 in migrate_init().
>> >>>
>> >>>Remove this unnecessary field.
>> >>>
>> >>>Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
>> >>
>> >> Hi, David
>> >
>> >Hi
>> >
>> >I am on duty this week, will get it.
>> >
>>
>> Hi, Juan
>>
>> Sounds we lost this one and the one above this :-)
>>
>
>We're in freeze at the moment; we'll pick it up as soon
>as it opens up again; I've got quite a list of your clean-up patches!
>
Thanks for your reply.
Have a good weekend. :-)
>Dave
>
>> --
>> Wei Yang
>> Help you, Help me
>--
>Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
--
Wei Yang
Help you, Help me
^ permalink raw reply [flat|nested] 9+ messages in thread