From: Tony Lindgren <tony@atomide.com> To: Keerthy <j-keerthy@ti.com> Cc: Suman Anna <s-anna@ti.com>, linux-omap@vger.kernel.org, Jyri Sarha <jsarha@ti.com>, Dave Gerlach <d-gerlach@ti.com>, Faiz Abbas <faiz_abbas@ti.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Nishanth Menon <nm@ti.com>, Peter Ujfalusi <peter.ujfalusi@ti.com>, Roger Quadros <rogerq@ti.com>, Tero Kristo <t-kristo@ti.com>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/8] ARM: OMAP2+: Remove unconfigured midlemode for am3 lcdc Date: Tue, 23 Jul 2019 23:31:10 -0700 [thread overview] Message-ID: <20190724063110.GT5447@atomide.com> (raw) In-Reply-To: <52328e14-58b2-2ea1-8b0a-33548a1c6a7a@ti.com> * Keerthy <j-keerthy@ti.com> [190724 05:50]: > > On 24/07/19 12:33 AM, Suman Anna wrote: > > + Jyri > > > > On 7/23/19 6:28 AM, Tony Lindgren wrote: > > > We currently get a warning for lcdc because of a difference > > > with dts provided configuration compared to the legacy platform > > > data. This is because lcdc has SYSC_HAS_MIDLEMODE configured in > > > the platform data without configuring the modes. > > > > Hi Tony, > > While I understand that you are trying to match the DT data with the > > existing legacy data, do you know if there was a reason why this was > > omitted in the first place? Should we be really adding the MSTANDBY_ > > flags and fix up the DTS node accordingly? I tried looking through the > > git log, and the initial commit itself didn't add the MSTANDBY_ flags > > but used the SYSC_HAS_MIDLEMODE. Yes the goal is to get rid of all errors and warnings in dmesg output so we can spot the real issues. > > Jyri, > > Do you know the history? > > Tony/Suman, > > This patch breaks DS0 on am3. OK thanks for testing. Let's drop this for now, sounds like there is some midlemode configuration happening even with no flags set. Probably the right fix is to configure the usable midlemodes instead both for platform data and dts data and then drop the platform data. Regards, Tony > > > Let's fix the warning by removing SYSC_HAS_MIDLEMODE. Note that > > > the am335x TRM lists SYSC_HAS_MIDLEMODE, but it is unused. > > > > > > > > > > > > Signed-off-by: Tony Lindgren <tony@atomide.com> > > > --- > > > arch/arm/mach-omap2/omap_hwmod_33xx_data.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c > > > --- a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c > > > +++ b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c > > > @@ -231,7 +231,7 @@ static struct omap_hwmod am33xx_control_hwmod = { > > > static struct omap_hwmod_class_sysconfig lcdc_sysc = { > > > .rev_offs = 0x0, > > > .sysc_offs = 0x54, > > > - .sysc_flags = (SYSC_HAS_SIDLEMODE | SYSC_HAS_MIDLEMODE), > > > + .sysc_flags = SYSC_HAS_SIDLEMODE, > > > .idlemodes = (SIDLE_FORCE | SIDLE_NO | SIDLE_SMART), > > > .sysc_fields = &omap_hwmod_sysc_type2, > > > }; > > > > >
WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com> To: Keerthy <j-keerthy@ti.com> Cc: Nishanth Menon <nm@ti.com>, Tero Kristo <t-kristo@ti.com>, Dave Gerlach <d-gerlach@ti.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-kernel@vger.kernel.org, Jyri Sarha <jsarha@ti.com>, Peter Ujfalusi <peter.ujfalusi@ti.com>, Faiz Abbas <faiz_abbas@ti.com>, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Roger Quadros <rogerq@ti.com> Subject: Re: [PATCH 2/8] ARM: OMAP2+: Remove unconfigured midlemode for am3 lcdc Date: Tue, 23 Jul 2019 23:31:10 -0700 [thread overview] Message-ID: <20190724063110.GT5447@atomide.com> (raw) In-Reply-To: <52328e14-58b2-2ea1-8b0a-33548a1c6a7a@ti.com> * Keerthy <j-keerthy@ti.com> [190724 05:50]: > > On 24/07/19 12:33 AM, Suman Anna wrote: > > + Jyri > > > > On 7/23/19 6:28 AM, Tony Lindgren wrote: > > > We currently get a warning for lcdc because of a difference > > > with dts provided configuration compared to the legacy platform > > > data. This is because lcdc has SYSC_HAS_MIDLEMODE configured in > > > the platform data without configuring the modes. > > > > Hi Tony, > > While I understand that you are trying to match the DT data with the > > existing legacy data, do you know if there was a reason why this was > > omitted in the first place? Should we be really adding the MSTANDBY_ > > flags and fix up the DTS node accordingly? I tried looking through the > > git log, and the initial commit itself didn't add the MSTANDBY_ flags > > but used the SYSC_HAS_MIDLEMODE. Yes the goal is to get rid of all errors and warnings in dmesg output so we can spot the real issues. > > Jyri, > > Do you know the history? > > Tony/Suman, > > This patch breaks DS0 on am3. OK thanks for testing. Let's drop this for now, sounds like there is some midlemode configuration happening even with no flags set. Probably the right fix is to configure the usable midlemodes instead both for platform data and dts data and then drop the platform data. Regards, Tony > > > Let's fix the warning by removing SYSC_HAS_MIDLEMODE. Note that > > > the am335x TRM lists SYSC_HAS_MIDLEMODE, but it is unused. > > > > > > > > > > > > Signed-off-by: Tony Lindgren <tony@atomide.com> > > > --- > > > arch/arm/mach-omap2/omap_hwmod_33xx_data.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c > > > --- a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c > > > +++ b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c > > > @@ -231,7 +231,7 @@ static struct omap_hwmod am33xx_control_hwmod = { > > > static struct omap_hwmod_class_sysconfig lcdc_sysc = { > > > .rev_offs = 0x0, > > > .sysc_offs = 0x54, > > > - .sysc_flags = (SYSC_HAS_SIDLEMODE | SYSC_HAS_MIDLEMODE), > > > + .sysc_flags = SYSC_HAS_SIDLEMODE, > > > .idlemodes = (SIDLE_FORCE | SIDLE_NO | SIDLE_SMART), > > > .sysc_fields = &omap_hwmod_sysc_type2, > > > }; > > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-07-24 6:31 UTC|newest] Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-07-23 11:28 [PATCH 0/8] ti-sysc related warning fixes for v5.3-rc cycle Tony Lindgren 2019-07-23 11:28 ` Tony Lindgren 2019-07-23 11:28 ` [PATCH 1/8] ARM: OMAP2+: Fix missing SYSC_HAS_RESET_STATUS for dra7 epwmss Tony Lindgren 2019-07-23 11:28 ` Tony Lindgren 2019-07-23 11:28 ` Tony Lindgren 2019-07-23 18:16 ` Suman Anna 2019-07-23 18:16 ` Suman Anna 2019-07-23 18:16 ` Suman Anna 2019-07-23 11:28 ` [PATCH 2/8] ARM: OMAP2+: Remove unconfigured midlemode for am3 lcdc Tony Lindgren 2019-07-23 11:28 ` Tony Lindgren 2019-07-23 19:03 ` Suman Anna 2019-07-23 19:03 ` Suman Anna 2019-07-23 19:03 ` Suman Anna 2019-07-24 5:50 ` Keerthy 2019-07-24 5:50 ` Keerthy 2019-07-24 5:50 ` Keerthy 2019-07-24 6:31 ` Tony Lindgren [this message] 2019-07-24 6:31 ` Tony Lindgren 2019-07-24 18:28 ` Suman Anna 2019-07-24 18:28 ` Suman Anna 2019-07-24 18:28 ` Suman Anna 2019-08-13 10:47 ` Tony Lindgren 2019-08-13 10:47 ` Tony Lindgren 2019-08-13 10:47 ` Tony Lindgren 2019-08-13 11:04 ` Jyri Sarha 2019-08-13 11:04 ` Jyri Sarha 2019-08-13 11:04 ` Jyri Sarha 2019-08-13 11:29 ` Tony Lindgren 2019-08-13 11:29 ` Tony Lindgren 2019-07-23 11:28 ` [PATCH 3/8] bus: ti-sysc: Fix handling of forced idle Tony Lindgren 2019-07-23 11:28 ` Tony Lindgren 2019-07-23 18:31 ` Suman Anna 2019-07-23 18:31 ` Suman Anna 2019-07-23 18:31 ` Suman Anna 2019-07-23 11:28 ` [PATCH 4/8] bus: ti-sysc: Fix using configured sysc mask value Tony Lindgren 2019-07-23 11:28 ` Tony Lindgren 2019-07-23 11:28 ` [PATCH 5/8] ARM: dts: Drop bogus ahclkr clocks for dra7 mcasp 3 to 8 Tony Lindgren 2019-07-23 11:28 ` Tony Lindgren 2019-07-23 21:01 ` Suman Anna 2019-07-23 21:01 ` Suman Anna 2019-07-23 21:01 ` Suman Anna 2019-07-24 6:47 ` Tony Lindgren 2019-07-24 6:47 ` Tony Lindgren 2019-09-17 7:21 ` Tero Kristo 2019-09-17 7:21 ` Tero Kristo 2019-09-17 7:21 ` Tero Kristo 2019-09-18 15:51 ` Tony Lindgren 2019-09-18 15:51 ` Tony Lindgren 2019-07-23 11:28 ` [PATCH 6/8] ARM: dts: Fix flags for gpio7 Tony Lindgren 2019-07-23 11:28 ` Tony Lindgren 2019-07-23 21:58 ` Suman Anna 2019-07-23 21:58 ` Suman Anna 2019-07-23 21:58 ` Suman Anna 2019-07-23 11:28 ` [PATCH 7/8] ARM: dts: Fix incorrect dcan register mapping for am3, am4 and dra7 Tony Lindgren 2019-07-23 11:28 ` Tony Lindgren 2019-07-23 11:28 ` [PATCH 8/8] ARM: dts: Fix lcdc sysc flags for am3 Tony Lindgren 2019-07-23 11:28 ` Tony Lindgren 2019-07-24 5:52 ` [PATCH 0/8] ti-sysc related warning fixes for v5.3-rc cycle Keerthy 2019-07-24 5:52 ` Keerthy 2019-07-24 5:52 ` Keerthy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190724063110.GT5447@atomide.com \ --to=tony@atomide.com \ --cc=d-gerlach@ti.com \ --cc=faiz_abbas@ti.com \ --cc=gregkh@linuxfoundation.org \ --cc=j-keerthy@ti.com \ --cc=jsarha@ti.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=nm@ti.com \ --cc=peter.ujfalusi@ti.com \ --cc=rogerq@ti.com \ --cc=s-anna@ti.com \ --cc=t-kristo@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.