From: Schrempf Frieder <frieder.schrempf@kontron.de>
To: "u.kleine-koenig@pengutronix.de" <u.kleine-koenig@pengutronix.de>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
"linux-imx@nxp.com" <linux-imx@nxp.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"geert+renesas@glider.be" <geert+renesas@glider.be>,
Schrempf Frieder <frieder.schrempf@kontron.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH v3 4/4] serial: 8250: Don't check for mctrl_gpio_init() returning -ENOSYS
Date: Fri, 2 Aug 2019 10:04:11 +0000 [thread overview]
Message-ID: <20190802100349.8659-4-frieder.schrempf@kontron.de> (raw)
In-Reply-To: <20190802100349.8659-1-frieder.schrempf@kontron.de>
From: Frieder Schrempf <frieder.schrempf@kontron.de>
Now that the mctrl_gpio code returns NULL instead of ERR_PTR(-ENOSYS)
if CONFIG_GPIOLIB is disabled, we can safely remove this check.
Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
---
Changes in v3
=============
* Adjust the commit message and subject line
Changes in v2
=============
* Add a patch for the 8250 driver
---
drivers/tty/serial/8250/8250_core.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c
index df3bcc0b2d74..e682390ce0de 100644
--- a/drivers/tty/serial/8250/8250_core.c
+++ b/drivers/tty/serial/8250/8250_core.c
@@ -1026,10 +1026,8 @@ int serial8250_register_8250_port(struct uart_8250_port *up)
if (!has_acpi_companion(uart->port.dev)) {
gpios = mctrl_gpio_init(&uart->port, 0);
if (IS_ERR(gpios)) {
- if (PTR_ERR(gpios) != -ENOSYS) {
- ret = PTR_ERR(gpios);
- goto out_unlock;
- }
+ ret = PTR_ERR(gpios);
+ goto out_unlock;
} else {
uart->gpios = gpios;
}
--
2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Schrempf Frieder <frieder.schrempf@kontron.de>
To: "u.kleine-koenig@pengutronix.de" <u.kleine-koenig@pengutronix.de>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
"linux-imx@nxp.com" <linux-imx@nxp.com>
Cc: "geert+renesas@glider.be" <geert+renesas@glider.be>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Schrempf Frieder <frieder.schrempf@kontron.de>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
Jiri Slaby <jslaby@suse.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: [PATCH v3 4/4] serial: 8250: Don't check for mctrl_gpio_init() returning -ENOSYS
Date: Fri, 2 Aug 2019 10:04:11 +0000 [thread overview]
Message-ID: <20190802100349.8659-4-frieder.schrempf@kontron.de> (raw)
In-Reply-To: <20190802100349.8659-1-frieder.schrempf@kontron.de>
From: Frieder Schrempf <frieder.schrempf@kontron.de>
Now that the mctrl_gpio code returns NULL instead of ERR_PTR(-ENOSYS)
if CONFIG_GPIOLIB is disabled, we can safely remove this check.
Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
---
Changes in v3
=============
* Adjust the commit message and subject line
Changes in v2
=============
* Add a patch for the 8250 driver
---
drivers/tty/serial/8250/8250_core.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c
index df3bcc0b2d74..e682390ce0de 100644
--- a/drivers/tty/serial/8250/8250_core.c
+++ b/drivers/tty/serial/8250/8250_core.c
@@ -1026,10 +1026,8 @@ int serial8250_register_8250_port(struct uart_8250_port *up)
if (!has_acpi_companion(uart->port.dev)) {
gpios = mctrl_gpio_init(&uart->port, 0);
if (IS_ERR(gpios)) {
- if (PTR_ERR(gpios) != -ENOSYS) {
- ret = PTR_ERR(gpios);
- goto out_unlock;
- }
+ ret = PTR_ERR(gpios);
+ goto out_unlock;
} else {
uart->gpios = gpios;
}
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-08-02 10:04 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-02 10:04 [PATCH v3 1/4] serial: mctrl_gpio: Avoid probe failures in case of missing gpiolib Schrempf Frieder
2019-08-02 10:04 ` Schrempf Frieder
2019-08-02 10:04 ` Schrempf Frieder
2019-08-02 10:04 ` [PATCH v3 2/4] serial: mctrl_gpio: Add a NULL check to mctrl_gpio_to_gpiod() Schrempf Frieder
2019-08-02 10:04 ` Schrempf Frieder
2019-08-02 10:04 ` Schrempf Frieder
2019-08-02 12:12 ` Uwe Kleine-König
2019-08-02 12:12 ` Uwe Kleine-König
2019-08-02 12:12 ` Uwe Kleine-König
2019-08-05 9:01 ` Schrempf Frieder
2019-08-05 9:01 ` Schrempf Frieder
2019-08-05 9:01 ` Schrempf Frieder
2019-08-06 7:45 ` Uwe Kleine-König
2019-08-06 7:45 ` Uwe Kleine-König
2019-08-06 7:45 ` Uwe Kleine-König
2019-08-06 8:02 ` Schrempf Frieder
2019-08-06 8:02 ` Schrempf Frieder
2019-08-06 8:02 ` Schrempf Frieder
2019-08-02 10:04 ` [PATCH v3 3/4] serial: sh-sci: Don't check for mctrl_gpio_init() returning -ENOSYS Schrempf Frieder
2019-08-02 10:04 ` Schrempf Frieder
2019-08-02 10:04 ` Schrempf Frieder
2019-08-02 12:13 ` Uwe Kleine-König
2019-08-02 12:13 ` Uwe Kleine-König
2019-08-02 12:13 ` Uwe Kleine-König
2019-08-06 8:09 ` Geert Uytterhoeven
2019-08-06 8:09 ` Geert Uytterhoeven
2019-08-06 8:09 ` Geert Uytterhoeven
2019-08-02 10:04 ` Schrempf Frieder [this message]
2019-08-02 10:04 ` [PATCH v3 4/4] serial: 8250: " Schrempf Frieder
2019-08-02 10:04 ` Schrempf Frieder
2019-08-02 12:15 ` Uwe Kleine-König
2019-08-02 12:15 ` Uwe Kleine-König
2019-08-02 12:15 ` Uwe Kleine-König
2019-08-02 12:26 ` Greg Kroah-Hartman
2019-08-02 12:26 ` Greg Kroah-Hartman
2019-08-02 12:26 ` Greg Kroah-Hartman
2019-08-06 7:44 ` Uwe Kleine-König
2019-08-06 7:44 ` Uwe Kleine-König
2019-08-06 7:44 ` Uwe Kleine-König
2019-08-02 12:08 ` [PATCH v3 1/4] serial: mctrl_gpio: Avoid probe failures in case of missing gpiolib Uwe Kleine-König
2019-08-02 12:08 ` Uwe Kleine-König
2019-08-02 12:08 ` Uwe Kleine-König
2019-08-06 8:09 ` Geert Uytterhoeven
2019-08-06 8:09 ` Geert Uytterhoeven
2019-08-06 8:09 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190802100349.8659-4-frieder.schrempf@kontron.de \
--to=frieder.schrempf@kontron.de \
--cc=festevam@gmail.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.