All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Schrempf Frieder <frieder.schrempf@kontron.de>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	"festevam@gmail.com" <festevam@gmail.com>,
	"linux-imx@nxp.com" <linux-imx@nxp.com>,
	"geert+renesas@glider.be" <geert+renesas@glider.be>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
	Jiri Slaby <jslaby@suse.com>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 4/4] serial: 8250: Don't check for mctrl_gpio_init() returning -ENOSYS
Date: Fri, 2 Aug 2019 14:26:23 +0200	[thread overview]
Message-ID: <20190802122623.GA25281@kroah.com> (raw)
In-Reply-To: <20190802121555.dl6rpjphgaxdvcke@pengutronix.de>

On Fri, Aug 02, 2019 at 02:15:55PM +0200, Uwe Kleine-König wrote:
> On Fri, Aug 02, 2019 at 10:04:11AM +0000, Schrempf Frieder wrote:
> > From: Frieder Schrempf <frieder.schrempf@kontron.de>
> > 
> > Now that the mctrl_gpio code returns NULL instead of ERR_PTR(-ENOSYS)
> > if CONFIG_GPIOLIB is disabled, we can safely remove this check.
> > 
> > Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
> 
> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> 
> @greg: This patch doesn't depend on patch 2; ditto for patch 3. So only
> taking patches 1, 3 and 4 should be fine. This way Frieder's v4 only
> have to care for patch 2. (Assuming noone objects to 1, 3 and 4 of
> course.)

Sounds good, I'll do that, thanks.

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: "linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
	"geert+renesas@glider.be" <geert+renesas@glider.be>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Schrempf Frieder <frieder.schrempf@kontron.de>,
	"linux-imx@nxp.com" <linux-imx@nxp.com>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	Jiri Slaby <jslaby@suse.com>,
	"festevam@gmail.com" <festevam@gmail.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 4/4] serial: 8250: Don't check for mctrl_gpio_init() returning -ENOSYS
Date: Fri, 2 Aug 2019 14:26:23 +0200	[thread overview]
Message-ID: <20190802122623.GA25281@kroah.com> (raw)
In-Reply-To: <20190802121555.dl6rpjphgaxdvcke@pengutronix.de>

On Fri, Aug 02, 2019 at 02:15:55PM +0200, Uwe Kleine-König wrote:
> On Fri, Aug 02, 2019 at 10:04:11AM +0000, Schrempf Frieder wrote:
> > From: Frieder Schrempf <frieder.schrempf@kontron.de>
> > 
> > Now that the mctrl_gpio code returns NULL instead of ERR_PTR(-ENOSYS)
> > if CONFIG_GPIOLIB is disabled, we can safely remove this check.
> > 
> > Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
> 
> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> 
> @greg: This patch doesn't depend on patch 2; ditto for patch 3. So only
> taking patches 1, 3 and 4 should be fine. This way Frieder's v4 only
> have to care for patch 2. (Assuming noone objects to 1, 3 and 4 of
> course.)

Sounds good, I'll do that, thanks.

greg k-h

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-08-02 12:26 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-02 10:04 [PATCH v3 1/4] serial: mctrl_gpio: Avoid probe failures in case of missing gpiolib Schrempf Frieder
2019-08-02 10:04 ` Schrempf Frieder
2019-08-02 10:04 ` Schrempf Frieder
2019-08-02 10:04 ` [PATCH v3 2/4] serial: mctrl_gpio: Add a NULL check to mctrl_gpio_to_gpiod() Schrempf Frieder
2019-08-02 10:04   ` Schrempf Frieder
2019-08-02 10:04   ` Schrempf Frieder
2019-08-02 12:12   ` Uwe Kleine-König
2019-08-02 12:12     ` Uwe Kleine-König
2019-08-02 12:12     ` Uwe Kleine-König
2019-08-05  9:01     ` Schrempf Frieder
2019-08-05  9:01       ` Schrempf Frieder
2019-08-05  9:01       ` Schrempf Frieder
2019-08-06  7:45       ` Uwe Kleine-König
2019-08-06  7:45         ` Uwe Kleine-König
2019-08-06  7:45         ` Uwe Kleine-König
2019-08-06  8:02         ` Schrempf Frieder
2019-08-06  8:02           ` Schrempf Frieder
2019-08-06  8:02           ` Schrempf Frieder
2019-08-02 10:04 ` [PATCH v3 3/4] serial: sh-sci: Don't check for mctrl_gpio_init() returning -ENOSYS Schrempf Frieder
2019-08-02 10:04   ` Schrempf Frieder
2019-08-02 10:04   ` Schrempf Frieder
2019-08-02 12:13   ` Uwe Kleine-König
2019-08-02 12:13     ` Uwe Kleine-König
2019-08-02 12:13     ` Uwe Kleine-König
2019-08-06  8:09   ` Geert Uytterhoeven
2019-08-06  8:09     ` Geert Uytterhoeven
2019-08-06  8:09     ` Geert Uytterhoeven
2019-08-02 10:04 ` [PATCH v3 4/4] serial: 8250: " Schrempf Frieder
2019-08-02 10:04   ` Schrempf Frieder
2019-08-02 10:04   ` Schrempf Frieder
2019-08-02 12:15   ` Uwe Kleine-König
2019-08-02 12:15     ` Uwe Kleine-König
2019-08-02 12:15     ` Uwe Kleine-König
2019-08-02 12:26     ` Greg Kroah-Hartman [this message]
2019-08-02 12:26       ` Greg Kroah-Hartman
2019-08-02 12:26       ` Greg Kroah-Hartman
2019-08-06  7:44       ` Uwe Kleine-König
2019-08-06  7:44         ` Uwe Kleine-König
2019-08-06  7:44         ` Uwe Kleine-König
2019-08-02 12:08 ` [PATCH v3 1/4] serial: mctrl_gpio: Avoid probe failures in case of missing gpiolib Uwe Kleine-König
2019-08-02 12:08   ` Uwe Kleine-König
2019-08-02 12:08   ` Uwe Kleine-König
2019-08-06  8:09 ` Geert Uytterhoeven
2019-08-06  8:09   ` Geert Uytterhoeven
2019-08-06  8:09   ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190802122623.GA25281@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=festevam@gmail.com \
    --cc=frieder.schrempf@kontron.de \
    --cc=geert+renesas@glider.be \
    --cc=jslaby@suse.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.