From: Nathan Chancellor <natechancellor@gmail.com>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: mpe@ellerman.id.au, christophe.leroy@c-s.fr,
segher@kernel.crashing.org, arnd@arndb.de,
kbuild test robot <lkp@intel.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
clang-built-linux@googlegroups.com
Subject: Re: [PATCH] powerpc: fix inline asm constraints for dcbz
Date: Fri, 9 Aug 2019 13:36:45 -0700 [thread overview]
Message-ID: <20190809203645.GA85763@archlinux-threadripper> (raw)
In-Reply-To: <20190809182106.62130-1-ndesaulniers@google.com>
[-- Attachment #1: Type: text/plain, Size: 1151 bytes --]
On Fri, Aug 09, 2019 at 11:21:05AM -0700, Nick Desaulniers wrote:
> The input parameter is modified, so it should be an output parameter
> with "=" to make it so that a copy of the input is not made by Clang.
>
> Link: https://bugs.llvm.org/show_bug.cgi?id=42762
> Link: https://gcc.gnu.org/onlinedocs/gcc/Modifiers.html#Modifiers
> Link: https://github.com/ClangBuiltLinux/linux/issues/593
> Link: https://godbolt.org/z/QwhZXi
> Link: https://lore.kernel.org/lkml/20190721075846.GA97701@archlinux-threadripper/
> Fixes: 6c5875843b87 ("powerpc: slightly improve cache helpers")
> Debugged-by: Nathan Chancellor <natechancellor@gmail.com>
> Reported-by: Nathan Chancellor <natechancellor@gmail.com>
> Reported-by: kbuild test robot <lkp@intel.com>
> Suggested-by: Arnd Bergmann <arnd@arndb.de>
> Suggested-by: Nathan Chancellor <natechancellor@gmail.com>
> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
I applied this patch as well as a revert of the original patch and both
clang and GCC appear to generate the same code; I think a straight
revert would be better.
Crude testing script and the generated files attached.
Cheers,
Nathan
[-- Attachment #2: tmp.bRmcRT0jd0.sh --]
[-- Type: application/x-sh, Size: 2707 bytes --]
[-- Attachment #3: testing-output.tar.gz --]
[-- Type: application/gzip, Size: 16412 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Nathan Chancellor <natechancellor@gmail.com>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: arnd@arndb.de, linux-kernel@vger.kernel.org,
clang-built-linux@googlegroups.com,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org, kbuild test robot <lkp@intel.com>
Subject: Re: [PATCH] powerpc: fix inline asm constraints for dcbz
Date: Fri, 9 Aug 2019 13:36:45 -0700 [thread overview]
Message-ID: <20190809203645.GA85763@archlinux-threadripper> (raw)
In-Reply-To: <20190809182106.62130-1-ndesaulniers@google.com>
[-- Attachment #1: Type: text/plain, Size: 1151 bytes --]
On Fri, Aug 09, 2019 at 11:21:05AM -0700, Nick Desaulniers wrote:
> The input parameter is modified, so it should be an output parameter
> with "=" to make it so that a copy of the input is not made by Clang.
>
> Link: https://bugs.llvm.org/show_bug.cgi?id=42762
> Link: https://gcc.gnu.org/onlinedocs/gcc/Modifiers.html#Modifiers
> Link: https://github.com/ClangBuiltLinux/linux/issues/593
> Link: https://godbolt.org/z/QwhZXi
> Link: https://lore.kernel.org/lkml/20190721075846.GA97701@archlinux-threadripper/
> Fixes: 6c5875843b87 ("powerpc: slightly improve cache helpers")
> Debugged-by: Nathan Chancellor <natechancellor@gmail.com>
> Reported-by: Nathan Chancellor <natechancellor@gmail.com>
> Reported-by: kbuild test robot <lkp@intel.com>
> Suggested-by: Arnd Bergmann <arnd@arndb.de>
> Suggested-by: Nathan Chancellor <natechancellor@gmail.com>
> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
I applied this patch as well as a revert of the original patch and both
clang and GCC appear to generate the same code; I think a straight
revert would be better.
Crude testing script and the generated files attached.
Cheers,
Nathan
[-- Attachment #2: tmp.bRmcRT0jd0.sh --]
[-- Type: application/x-sh, Size: 2707 bytes --]
[-- Attachment #3: testing-output.tar.gz --]
[-- Type: application/gzip, Size: 16412 bytes --]
next prev parent reply other threads:[~2019-08-09 20:36 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 20:25 [PATCH] powerpc: workaround clang codegen bug in dcbz Nick Desaulniers
2019-07-29 20:25 ` Nick Desaulniers
2019-07-29 20:32 ` Nathan Chancellor
2019-07-29 20:32 ` Nathan Chancellor
2019-07-29 20:45 ` Nick Desaulniers
2019-07-29 20:45 ` Nick Desaulniers
2019-07-29 20:47 ` Nathan Chancellor
2019-07-29 20:47 ` Nathan Chancellor
2019-07-29 20:49 ` Nick Desaulniers
2019-07-29 20:49 ` Nick Desaulniers
2019-07-29 21:52 ` Segher Boessenkool
2019-07-29 21:52 ` Segher Boessenkool
2019-07-30 7:34 ` Arnd Bergmann
2019-07-30 7:34 ` Arnd Bergmann
2019-07-30 11:17 ` Michael Ellerman
2019-07-30 11:17 ` Michael Ellerman
2019-08-09 18:21 ` [PATCH] powerpc: fix inline asm constraints for dcbz Nick Desaulniers
2019-08-09 18:21 ` Nick Desaulniers
2019-08-09 18:28 ` Arnd Bergmann
2019-08-09 18:28 ` Arnd Bergmann
2019-08-09 20:03 ` Christophe Leroy
2019-08-09 20:03 ` Christophe Leroy
2019-08-09 20:12 ` Arnd Bergmann
2019-08-09 20:12 ` Arnd Bergmann
2019-08-09 22:03 ` Nick Desaulniers
2019-08-09 22:03 ` Nick Desaulniers
2019-08-09 22:10 ` Segher Boessenkool
2019-08-09 22:10 ` Segher Boessenkool
2019-08-09 22:00 ` Segher Boessenkool
2019-08-09 22:00 ` Segher Boessenkool
2019-08-09 22:03 ` [PATCH v3] Revert "powerpc: slightly improve cache helpers" Nick Desaulniers
2019-08-09 22:03 ` Nick Desaulniers
2019-08-10 9:09 ` Michael Ellerman
2019-08-10 9:09 ` Michael Ellerman
2019-08-09 21:55 ` [PATCH] powerpc: fix inline asm constraints for dcbz Segher Boessenkool
2019-08-09 21:55 ` Segher Boessenkool
2019-08-09 20:36 ` Nathan Chancellor [this message]
2019-08-09 20:36 ` Nathan Chancellor
2019-07-30 13:48 ` [PATCH] powerpc: workaround clang codegen bug in dcbz Segher Boessenkool
2019-07-30 13:48 ` Segher Boessenkool
2019-07-30 14:30 ` Arnd Bergmann
2019-07-30 14:30 ` Arnd Bergmann
2019-07-30 16:16 ` Segher Boessenkool
2019-07-30 16:16 ` Segher Boessenkool
2019-07-30 17:07 ` Segher Boessenkool
2019-07-30 18:24 ` Arnd Bergmann
2019-07-30 18:24 ` Arnd Bergmann
2019-07-30 18:24 ` Arnd Bergmann
2019-07-30 19:35 ` Segher Boessenkool
2019-07-30 19:35 ` Segher Boessenkool
2019-07-30 5:31 ` Christophe Leroy
2019-07-30 5:31 ` Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190809203645.GA85763@archlinux-threadripper \
--to=natechancellor@gmail.com \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=christophe.leroy@c-s.fr \
--cc=clang-built-linux@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lkp@intel.com \
--cc=mpe@ellerman.id.au \
--cc=ndesaulniers@google.com \
--cc=paulus@samba.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.