All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nick Desaulniers <ndesaulniers@google.com>
To: Nathan Chancellor <natechancellor@gmail.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
	Christophe Leroy <christophe.leroy@c-s.fr>,
	Segher Boessenkool <segher@kernel.crashing.org>,
	Arnd Bergmann <arnd@arndb.de>, kbuild test robot <lkp@intel.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	linuxppc-dev@lists.ozlabs.org,
	LKML <linux-kernel@vger.kernel.org>,
	clang-built-linux <clang-built-linux@googlegroups.com>
Subject: Re: [PATCH] powerpc: workaround clang codegen bug in dcbz
Date: Mon, 29 Jul 2019 13:45:35 -0700	[thread overview]
Message-ID: <CAKwvOdm7GRBWYhPy4Ni2jbsXJp8gDF-AqaAxeLbZ03+LvHxADQ@mail.gmail.com> (raw)
In-Reply-To: <20190729203246.GA117371@archlinux-threadripper>

On Mon, Jul 29, 2019 at 1:32 PM Nathan Chancellor
<natechancellor@gmail.com> wrote:
>
> On Mon, Jul 29, 2019 at 01:25:41PM -0700, Nick Desaulniers wrote:
> > But I'm not sure how the inlined code generated would be affected.
>
> For the record:
>
> https://godbolt.org/z/z57VU7
>
> This seems consistent with what Michael found so I don't think a revert
> is entirely unreasonable.

Thanks for debugging/reporting/testing and the Godbolt link which
clearly shows that the codegen for out of line versions is no
different.  The case I can't comment on is what happens when those
`static inline` functions get inlined (maybe the original patch
improves those cases?).
-- 
Thanks,
~Nick Desaulniers

WARNING: multiple messages have this Message-ID (diff)
From: Nick Desaulniers <ndesaulniers@google.com>
To: Nathan Chancellor <natechancellor@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
	LKML <linux-kernel@vger.kernel.org>,
	clang-built-linux <clang-built-linux@googlegroups.com>,
	Paul Mackerras <paulus@samba.org>,
	linuxppc-dev@lists.ozlabs.org, kbuild test robot <lkp@intel.com>
Subject: Re: [PATCH] powerpc: workaround clang codegen bug in dcbz
Date: Mon, 29 Jul 2019 13:45:35 -0700	[thread overview]
Message-ID: <CAKwvOdm7GRBWYhPy4Ni2jbsXJp8gDF-AqaAxeLbZ03+LvHxADQ@mail.gmail.com> (raw)
In-Reply-To: <20190729203246.GA117371@archlinux-threadripper>

On Mon, Jul 29, 2019 at 1:32 PM Nathan Chancellor
<natechancellor@gmail.com> wrote:
>
> On Mon, Jul 29, 2019 at 01:25:41PM -0700, Nick Desaulniers wrote:
> > But I'm not sure how the inlined code generated would be affected.
>
> For the record:
>
> https://godbolt.org/z/z57VU7
>
> This seems consistent with what Michael found so I don't think a revert
> is entirely unreasonable.

Thanks for debugging/reporting/testing and the Godbolt link which
clearly shows that the codegen for out of line versions is no
different.  The case I can't comment on is what happens when those
`static inline` functions get inlined (maybe the original patch
improves those cases?).
-- 
Thanks,
~Nick Desaulniers

  reply	other threads:[~2019-07-29 20:45 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-29 20:25 [PATCH] powerpc: workaround clang codegen bug in dcbz Nick Desaulniers
2019-07-29 20:25 ` Nick Desaulniers
2019-07-29 20:32 ` Nathan Chancellor
2019-07-29 20:32   ` Nathan Chancellor
2019-07-29 20:45   ` Nick Desaulniers [this message]
2019-07-29 20:45     ` Nick Desaulniers
2019-07-29 20:47     ` Nathan Chancellor
2019-07-29 20:47       ` Nathan Chancellor
2019-07-29 20:49       ` Nick Desaulniers
2019-07-29 20:49         ` Nick Desaulniers
2019-07-29 21:52   ` Segher Boessenkool
2019-07-29 21:52     ` Segher Boessenkool
2019-07-30  7:34     ` Arnd Bergmann
2019-07-30  7:34       ` Arnd Bergmann
2019-07-30 11:17       ` Michael Ellerman
2019-07-30 11:17         ` Michael Ellerman
2019-08-09 18:21         ` [PATCH] powerpc: fix inline asm constraints for dcbz Nick Desaulniers
2019-08-09 18:21           ` Nick Desaulniers
2019-08-09 18:28           ` Arnd Bergmann
2019-08-09 18:28             ` Arnd Bergmann
2019-08-09 20:03             ` Christophe Leroy
2019-08-09 20:03               ` Christophe Leroy
2019-08-09 20:12               ` Arnd Bergmann
2019-08-09 20:12                 ` Arnd Bergmann
2019-08-09 22:03                 ` Nick Desaulniers
2019-08-09 22:03                   ` Nick Desaulniers
2019-08-09 22:10                 ` Segher Boessenkool
2019-08-09 22:10                   ` Segher Boessenkool
2019-08-09 22:00               ` Segher Boessenkool
2019-08-09 22:00                 ` Segher Boessenkool
2019-08-09 22:03               ` [PATCH v3] Revert "powerpc: slightly improve cache helpers" Nick Desaulniers
2019-08-09 22:03                 ` Nick Desaulniers
2019-08-10  9:09                 ` Michael Ellerman
2019-08-10  9:09                   ` Michael Ellerman
2019-08-09 21:55             ` [PATCH] powerpc: fix inline asm constraints for dcbz Segher Boessenkool
2019-08-09 21:55               ` Segher Boessenkool
2019-08-09 20:36           ` Nathan Chancellor
2019-08-09 20:36             ` Nathan Chancellor
2019-07-30 13:48       ` [PATCH] powerpc: workaround clang codegen bug in dcbz Segher Boessenkool
2019-07-30 13:48         ` Segher Boessenkool
2019-07-30 14:30         ` Arnd Bergmann
2019-07-30 14:30           ` Arnd Bergmann
2019-07-30 16:16           ` Segher Boessenkool
2019-07-30 16:16             ` Segher Boessenkool
2019-07-30 17:07             ` Segher Boessenkool
2019-07-30 18:24               ` Arnd Bergmann
2019-07-30 18:24             ` Arnd Bergmann
2019-07-30 18:24               ` Arnd Bergmann
2019-07-30 19:35               ` Segher Boessenkool
2019-07-30 19:35                 ` Segher Boessenkool
2019-07-30  5:31   ` Christophe Leroy
2019-07-30  5:31     ` Christophe Leroy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKwvOdm7GRBWYhPy4Ni2jbsXJp8gDF-AqaAxeLbZ03+LvHxADQ@mail.gmail.com \
    --to=ndesaulniers@google.com \
    --cc=arnd@arndb.de \
    --cc=benh@kernel.crashing.org \
    --cc=christophe.leroy@c-s.fr \
    --cc=clang-built-linux@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=lkp@intel.com \
    --cc=mpe@ellerman.id.au \
    --cc=natechancellor@gmail.com \
    --cc=paulus@samba.org \
    --cc=segher@kernel.crashing.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.