All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] x86/platform/uv: move kmalloc() NULL check routine
@ 2019-09-05 23:29 ` Austin Kim
  0 siblings, 0 replies; 5+ messages in thread
From: Austin Kim @ 2019-09-05 23:29 UTC (permalink / raw)
  To: tglx, mingo, bp, x86
  Cc: dvhart, andy, hpa, x86, gregkh, allison, armijn, kjlu,
	platform-driver-x86, linux-kernel

The result of kmalloc should have been checked ahead of below statement:
	pqp = (struct bau_pq_entry *)vp;

Move BUG_ON(!vp) before above statement.

Signed-off-by: Austin Kim <austindh.kim@gmail.com>
---
 arch/x86/platform/uv/tlb_uv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/platform/uv/tlb_uv.c b/arch/x86/platform/uv/tlb_uv.c
index 20c389a..5f0a96bf 100644
--- a/arch/x86/platform/uv/tlb_uv.c
+++ b/arch/x86/platform/uv/tlb_uv.c
@@ -1804,9 +1804,9 @@ static void pq_init(int node, int pnode)
 
 	plsize = (DEST_Q_SIZE + 1) * sizeof(struct bau_pq_entry);
 	vp = kmalloc_node(plsize, GFP_KERNEL, node);
-	pqp = (struct bau_pq_entry *)vp;
-	BUG_ON(!pqp);
+	BUG_ON(!vp);
 
+	pqp = (struct bau_pq_entry *)vp;
 	cp = (char *)pqp + 31;
 	pqp = (struct bau_pq_entry *)(((unsigned long)cp >> 5) << 5);
 
-- 
2.6.2


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2019-09-06 10:53 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-05 23:29 [PATCH] x86/platform/uv: move kmalloc() NULL check routine Austin Kim
2019-09-05 23:29 ` Austin Kim
2019-09-06  9:32 ` Greg KH
2019-09-06 10:43   ` Peter Zijlstra
2019-09-06 10:53     ` Greg KH

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.