* [Qemu-devel] [PULL 0/3] Tracing patches
@ 2019-09-18 13:21 Stefan Hajnoczi
2019-09-18 13:21 ` [Qemu-devel] [PULL 1/3] loader: Trace loaded images Stefan Hajnoczi
` (3 more replies)
0 siblings, 4 replies; 19+ messages in thread
From: Stefan Hajnoczi @ 2019-09-18 13:21 UTC (permalink / raw)
To: qemu-devel
Cc: Fam Zheng, Peter Maydell, qemu-block, Jason Wang,
Stefan Hajnoczi, Paolo Bonzini
The following changes since commit f8c3db33a5e863291182f8862ddf81618a7c6194:
target/sparc: Switch to do_transaction_failed() hook (2019-09-17 12:01:00 +0100)
are available in the Git repository at:
https://github.com/stefanha/qemu.git tags/tracing-pull-request
for you to fetch changes up to 9f7ad79c16ede0da01902b18fb32929cfbd20f87:
trace: Forbid event format ending with newline character (2019-09-18 10:20:15 +0100)
----------------------------------------------------------------
Pull request
----------------------------------------------------------------
Alexey Kardashevskiy (1):
loader: Trace loaded images
Philippe Mathieu-Daudé (2):
trace: Remove trailing newline in events
trace: Forbid event format ending with newline character
docs/devel/tracing.txt | 2 ++
Makefile.objs | 1 +
hw/core/loader.c | 3 +++
hw/core/trace-events | 2 ++
hw/misc/trace-events | 10 +++++-----
hw/scsi/trace-events | 2 +-
hw/sd/trace-events | 2 +-
nbd/trace-events | 4 ++--
net/trace-events | 6 +++---
scripts/tracetool/__init__.py | 3 +++
10 files changed, 23 insertions(+), 12 deletions(-)
create mode 100644 hw/core/trace-events
--
2.21.0
^ permalink raw reply [flat|nested] 19+ messages in thread* [Qemu-devel] [PULL 1/3] loader: Trace loaded images 2019-09-18 13:21 [Qemu-devel] [PULL 0/3] Tracing patches Stefan Hajnoczi @ 2019-09-18 13:21 ` Stefan Hajnoczi 2019-09-18 13:21 ` [Qemu-devel] [PULL 2/3] trace: Remove trailing newline in events Stefan Hajnoczi ` (2 subsequent siblings) 3 siblings, 0 replies; 19+ messages in thread From: Stefan Hajnoczi @ 2019-09-18 13:21 UTC (permalink / raw) To: qemu-devel Cc: Fam Zheng, Peter Maydell, qemu-block, Alexey Kardashevskiy, Philippe Mathieu-Daudé, Jason Wang, Stefan Hajnoczi, Paolo Bonzini From: Alexey Kardashevskiy <aik@ozlabs.ru> This adds a trace point which prints every loaded image. This includes bios/firmware/kernel/initradmdisk/pcirom. Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> Message-Id: <20190613050937.124903-1-aik@ozlabs.ru> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> --- Makefile.objs | 1 + hw/core/loader.c | 3 +++ hw/core/trace-events | 2 ++ 3 files changed, 6 insertions(+) create mode 100644 hw/core/trace-events diff --git a/Makefile.objs b/Makefile.objs index 6a143dcd57..abcbd89654 100644 --- a/Makefile.objs +++ b/Makefile.objs @@ -203,6 +203,7 @@ trace-events-subdirs += target/riscv trace-events-subdirs += target/s390x trace-events-subdirs += target/sparc trace-events-subdirs += util +trace-events-subdirs += hw/core trace-events-files = $(SRC_PATH)/trace-events $(trace-events-subdirs:%=$(SRC_PATH)/%/trace-events) diff --git a/hw/core/loader.c b/hw/core/loader.c index 75eb56ddbb..0d60219364 100644 --- a/hw/core/loader.c +++ b/hw/core/loader.c @@ -45,6 +45,7 @@ #include "qemu/osdep.h" #include "qemu-common.h" #include "qapi/error.h" +#include "trace.h" #include "hw/hw.h" #include "disas/disas.h" #include "migration/vmstate.h" @@ -1151,6 +1152,8 @@ static void rom_reset(void *unused) * CPU definitely fetches its instructions from the just written data. */ cpu_flush_icache_range(rom->addr, rom->datasize); + + trace_loader_write_rom(rom->name, rom->addr, rom->datasize, rom->isrom); } } diff --git a/hw/core/trace-events b/hw/core/trace-events new file mode 100644 index 0000000000..fe47a9c8cb --- /dev/null +++ b/hw/core/trace-events @@ -0,0 +1,2 @@ +# loader.c +loader_write_rom(const char *name, uint64_t gpa, uint64_t size, bool isrom) "%s: @0x%"PRIx64" size=0x%"PRIx64" ROM=%d" -- 2.21.0 ^ permalink raw reply related [flat|nested] 19+ messages in thread
* [Qemu-devel] [PULL 2/3] trace: Remove trailing newline in events 2019-09-18 13:21 [Qemu-devel] [PULL 0/3] Tracing patches Stefan Hajnoczi 2019-09-18 13:21 ` [Qemu-devel] [PULL 1/3] loader: Trace loaded images Stefan Hajnoczi @ 2019-09-18 13:21 ` Stefan Hajnoczi 2019-09-18 15:51 ` Philippe Mathieu-Daudé 2019-09-18 13:21 ` [Qemu-devel] [PULL 3/3] trace: Forbid event format ending with newline character Stefan Hajnoczi 2019-09-19 13:37 ` [Qemu-devel] [PULL 0/3] Tracing patches Peter Maydell 3 siblings, 1 reply; 19+ messages in thread From: Stefan Hajnoczi @ 2019-09-18 13:21 UTC (permalink / raw) To: qemu-devel Cc: Fam Zheng, Peter Maydell, qemu-block, Philippe Mathieu-Daudé, Jason Wang, John Snow, Stefan Hajnoczi, Paolo Bonzini, Kevin Wolf From: Philippe Mathieu-Daudé <philmd@redhat.com> While the tracing framework does not forbid trailing newline in events format string, using them lead to confuse output. It is the responsibility of the backend to properly end an event line. Some of our formats have trailing newlines, remove them. [Fixed typo in commit description reported by Eric Blake <eblake@redhat.com> --Stefan] Reviewed-by: John Snow <jsnow@redhat.com> Reviewed-by: Kevin Wolf <kwolf@redhat.com> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> Message-id: 20190916095121.29506-2-philmd@redhat.com Message-Id: <20190916095121.29506-2-philmd@redhat.com> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> --- hw/misc/trace-events | 10 +++++----- hw/scsi/trace-events | 2 +- hw/sd/trace-events | 2 +- nbd/trace-events | 4 ++-- net/trace-events | 6 +++--- 5 files changed, 12 insertions(+), 12 deletions(-) diff --git a/hw/misc/trace-events b/hw/misc/trace-events index c1ea1aa437..74276225f8 100644 --- a/hw/misc/trace-events +++ b/hw/misc/trace-events @@ -118,11 +118,11 @@ iotkit_secctl_ns_read(uint32_t offset, uint64_t data, unsigned size) "IoTKit Sec iotkit_secctl_ns_write(uint32_t offset, uint64_t data, unsigned size) "IoTKit SecCtl NS regs write: offset 0x%x data 0x%" PRIx64 " size %u" # imx6ul_ccm.c -ccm_entry(void) "\n" -ccm_freq(uint32_t freq) "freq = %d\n" -ccm_clock_freq(uint32_t clock, uint32_t freq) "(Clock = %d) = %d\n" -ccm_read_reg(const char *reg_name, uint32_t value) "reg[%s] <= 0x%" PRIx32 "\n" -ccm_write_reg(const char *reg_name, uint32_t value) "reg[%s] => 0x%" PRIx32 "\n" +ccm_entry(void) "" +ccm_freq(uint32_t freq) "freq = %d" +ccm_clock_freq(uint32_t clock, uint32_t freq) "(Clock = %d) = %d" +ccm_read_reg(const char *reg_name, uint32_t value) "reg[%s] <= 0x%" PRIx32 +ccm_write_reg(const char *reg_name, uint32_t value) "reg[%s] => 0x%" PRIx32 # iotkit-sysinfo.c iotkit_sysinfo_read(uint64_t offset, uint64_t data, unsigned size) "IoTKit SysInfo read: offset 0x%" PRIx64 " data 0x%" PRIx64 " size %u" diff --git a/hw/scsi/trace-events b/hw/scsi/trace-events index 452b5994e6..b0820052f8 100644 --- a/hw/scsi/trace-events +++ b/hw/scsi/trace-events @@ -28,7 +28,7 @@ mptsas_mmio_read(void *dev, uint32_t addr, uint32_t val) "dev %p addr 0x%08x val mptsas_mmio_unhandled_read(void *dev, uint32_t addr) "dev %p addr 0x%08x" mptsas_mmio_unhandled_write(void *dev, uint32_t addr, uint32_t val) "dev %p addr 0x%08x value 0x%x" mptsas_mmio_write(void *dev, uint32_t addr, uint32_t val) "dev %p addr 0x%08x value 0x%x" -mptsas_process_message(void *dev, int msg, uint32_t ctx) "dev %p cmd %d context 0x%08x\n" +mptsas_process_message(void *dev, int msg, uint32_t ctx) "dev %p cmd %d context 0x%08x" mptsas_process_scsi_io_request(void *dev, int bus, int target, int lun, uint64_t len) "dev %p dev %d:%d:%d length %"PRIu64"" mptsas_reset(void *dev) "dev %p " mptsas_scsi_overflow(void *dev, uint32_t ctx, uint64_t req, uint64_t found) "dev %p context 0x%08x: %"PRIu64"/%"PRIu64"" diff --git a/hw/sd/trace-events b/hw/sd/trace-events index 52971dc033..efcff666a2 100644 --- a/hw/sd/trace-events +++ b/hw/sd/trace-events @@ -4,7 +4,7 @@ bcm2835_sdhost_read(uint64_t offset, uint64_t data, unsigned size) "offset 0x%" PRIx64 " data 0x%" PRIx64 " size %u" bcm2835_sdhost_write(uint64_t offset, uint64_t data, unsigned size) "offset 0x%" PRIx64 " data 0x%" PRIx64 " size %u" bcm2835_sdhost_edm_change(const char *why, uint32_t edm) "(%s) EDM now 0x%x" -bcm2835_sdhost_update_irq(uint32_t irq) "IRQ bits 0x%x\n" +bcm2835_sdhost_update_irq(uint32_t irq) "IRQ bits 0x%x" # core.c sdbus_command(const char *bus_name, uint8_t cmd, uint32_t arg) "@%s CMD%02d arg 0x%08x" diff --git a/nbd/trace-events b/nbd/trace-events index f6cde96790..a955918e97 100644 --- a/nbd/trace-events +++ b/nbd/trace-events @@ -61,8 +61,8 @@ nbd_negotiate_begin(void) "Beginning negotiation" nbd_negotiate_new_style_size_flags(uint64_t size, unsigned flags) "advertising size %" PRIu64 " and flags 0x%x" nbd_negotiate_success(void) "Negotiation succeeded" nbd_receive_request(uint32_t magic, uint16_t flags, uint16_t type, uint64_t from, uint32_t len) "Got request: { magic = 0x%" PRIx32 ", .flags = 0x%" PRIx16 ", .type = 0x%" PRIx16 ", from = %" PRIu64 ", len = %" PRIu32 " }" -nbd_blk_aio_attached(const char *name, void *ctx) "Export %s: Attaching clients to AIO context %p\n" -nbd_blk_aio_detach(const char *name, void *ctx) "Export %s: Detaching clients from AIO context %p\n" +nbd_blk_aio_attached(const char *name, void *ctx) "Export %s: Attaching clients to AIO context %p" +nbd_blk_aio_detach(const char *name, void *ctx) "Export %s: Detaching clients from AIO context %p" nbd_co_send_simple_reply(uint64_t handle, uint32_t error, const char *errname, int len) "Send simple reply: handle = %" PRIu64 ", error = %" PRIu32 " (%s), len = %d" nbd_co_send_structured_done(uint64_t handle) "Send structured reply done: handle = %" PRIu64 nbd_co_send_structured_read(uint64_t handle, uint64_t offset, void *data, size_t size) "Send structured read data reply: handle = %" PRIu64 ", offset = %" PRIu64 ", data = %p, len = %zu" diff --git a/net/trace-events b/net/trace-events index ac57056497..02c13fd0ba 100644 --- a/net/trace-events +++ b/net/trace-events @@ -17,9 +17,9 @@ colo_compare_icmp_miscompare(const char *sta, int size) ": %s = %d" colo_compare_ip_info(int psize, const char *sta, const char *stb, int ssize, const char *stc, const char *std) "ppkt size = %d, ip_src = %s, ip_dst = %s, spkt size = %d, ip_src = %s, ip_dst = %s" colo_old_packet_check_found(int64_t old_time) "%" PRId64 colo_compare_miscompare(void) "" -colo_compare_tcp_info(const char *pkt, uint32_t seq, uint32_t ack, int hdlen, int pdlen, int offset, int flags) "%s: seq/ack= %u/%u hdlen= %d pdlen= %d offset= %d flags=%d\n" +colo_compare_tcp_info(const char *pkt, uint32_t seq, uint32_t ack, int hdlen, int pdlen, int offset, int flags) "%s: seq/ack= %u/%u hdlen= %d pdlen= %d offset= %d flags=%d" # filter-rewriter.c colo_filter_rewriter_debug(void) "" -colo_filter_rewriter_pkt_info(const char *func, const char *src, const char *dst, uint32_t seq, uint32_t ack, uint32_t flag) "%s: src/dst: %s/%s p: seq/ack=%u/%u flags=0x%x\n" -colo_filter_rewriter_conn_offset(uint32_t offset) ": offset=%u\n" +colo_filter_rewriter_pkt_info(const char *func, const char *src, const char *dst, uint32_t seq, uint32_t ack, uint32_t flag) "%s: src/dst: %s/%s p: seq/ack=%u/%u flags=0x%x" +colo_filter_rewriter_conn_offset(uint32_t offset) ": offset=%u" -- 2.21.0 ^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: [Qemu-devel] [PULL 2/3] trace: Remove trailing newline in events 2019-09-18 13:21 ` [Qemu-devel] [PULL 2/3] trace: Remove trailing newline in events Stefan Hajnoczi @ 2019-09-18 15:51 ` Philippe Mathieu-Daudé 2019-09-19 9:31 ` Stefan Hajnoczi 0 siblings, 1 reply; 19+ messages in thread From: Philippe Mathieu-Daudé @ 2019-09-18 15:51 UTC (permalink / raw) To: Stefan Hajnoczi, qemu-devel Cc: Fam Zheng, Peter Maydell, qemu-block, John Snow, Jason Wang, Kevin Wolf, Paolo Bonzini On 9/18/19 3:21 PM, Stefan Hajnoczi wrote: > From: Philippe Mathieu-Daudé <philmd@redhat.com> > > While the tracing framework does not forbid trailing newline in > events format string, using them lead to confuse output. > It is the responsibility of the backend to properly end an event > line. > > Some of our formats have trailing newlines, remove them. > > [Fixed typo in commit description reported by Eric Blake Thanks for this! > <eblake@redhat.com> > --Stefan] > > Reviewed-by: John Snow <jsnow@redhat.com> > Reviewed-by: Kevin Wolf <kwolf@redhat.com> > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > Message-id: 20190916095121.29506-2-philmd@redhat.com > Message-Id: <20190916095121.29506-2-philmd@redhat.com> Out of curiosity, how do you end up with 2 slightly different message-id? Using two different tools in series? (Thinking about unifying these tools format). > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> > --- > hw/misc/trace-events | 10 +++++----- > hw/scsi/trace-events | 2 +- > hw/sd/trace-events | 2 +- > nbd/trace-events | 4 ++-- > net/trace-events | 6 +++--- > 5 files changed, 12 insertions(+), 12 deletions(-) > > diff --git a/hw/misc/trace-events b/hw/misc/trace-events > index c1ea1aa437..74276225f8 100644 > --- a/hw/misc/trace-events > +++ b/hw/misc/trace-events > @@ -118,11 +118,11 @@ iotkit_secctl_ns_read(uint32_t offset, uint64_t data, unsigned size) "IoTKit Sec > iotkit_secctl_ns_write(uint32_t offset, uint64_t data, unsigned size) "IoTKit SecCtl NS regs write: offset 0x%x data 0x%" PRIx64 " size %u" > > # imx6ul_ccm.c > -ccm_entry(void) "\n" > -ccm_freq(uint32_t freq) "freq = %d\n" > -ccm_clock_freq(uint32_t clock, uint32_t freq) "(Clock = %d) = %d\n" > -ccm_read_reg(const char *reg_name, uint32_t value) "reg[%s] <= 0x%" PRIx32 "\n" > -ccm_write_reg(const char *reg_name, uint32_t value) "reg[%s] => 0x%" PRIx32 "\n" > +ccm_entry(void) "" > +ccm_freq(uint32_t freq) "freq = %d" > +ccm_clock_freq(uint32_t clock, uint32_t freq) "(Clock = %d) = %d" > +ccm_read_reg(const char *reg_name, uint32_t value) "reg[%s] <= 0x%" PRIx32 > +ccm_write_reg(const char *reg_name, uint32_t value) "reg[%s] => 0x%" PRIx32 > > # iotkit-sysinfo.c > iotkit_sysinfo_read(uint64_t offset, uint64_t data, unsigned size) "IoTKit SysInfo read: offset 0x%" PRIx64 " data 0x%" PRIx64 " size %u" > diff --git a/hw/scsi/trace-events b/hw/scsi/trace-events > index 452b5994e6..b0820052f8 100644 > --- a/hw/scsi/trace-events > +++ b/hw/scsi/trace-events > @@ -28,7 +28,7 @@ mptsas_mmio_read(void *dev, uint32_t addr, uint32_t val) "dev %p addr 0x%08x val > mptsas_mmio_unhandled_read(void *dev, uint32_t addr) "dev %p addr 0x%08x" > mptsas_mmio_unhandled_write(void *dev, uint32_t addr, uint32_t val) "dev %p addr 0x%08x value 0x%x" > mptsas_mmio_write(void *dev, uint32_t addr, uint32_t val) "dev %p addr 0x%08x value 0x%x" > -mptsas_process_message(void *dev, int msg, uint32_t ctx) "dev %p cmd %d context 0x%08x\n" > +mptsas_process_message(void *dev, int msg, uint32_t ctx) "dev %p cmd %d context 0x%08x" > mptsas_process_scsi_io_request(void *dev, int bus, int target, int lun, uint64_t len) "dev %p dev %d:%d:%d length %"PRIu64"" > mptsas_reset(void *dev) "dev %p " > mptsas_scsi_overflow(void *dev, uint32_t ctx, uint64_t req, uint64_t found) "dev %p context 0x%08x: %"PRIu64"/%"PRIu64"" > diff --git a/hw/sd/trace-events b/hw/sd/trace-events > index 52971dc033..efcff666a2 100644 > --- a/hw/sd/trace-events > +++ b/hw/sd/trace-events > @@ -4,7 +4,7 @@ > bcm2835_sdhost_read(uint64_t offset, uint64_t data, unsigned size) "offset 0x%" PRIx64 " data 0x%" PRIx64 " size %u" > bcm2835_sdhost_write(uint64_t offset, uint64_t data, unsigned size) "offset 0x%" PRIx64 " data 0x%" PRIx64 " size %u" > bcm2835_sdhost_edm_change(const char *why, uint32_t edm) "(%s) EDM now 0x%x" > -bcm2835_sdhost_update_irq(uint32_t irq) "IRQ bits 0x%x\n" > +bcm2835_sdhost_update_irq(uint32_t irq) "IRQ bits 0x%x" > > # core.c > sdbus_command(const char *bus_name, uint8_t cmd, uint32_t arg) "@%s CMD%02d arg 0x%08x" > diff --git a/nbd/trace-events b/nbd/trace-events > index f6cde96790..a955918e97 100644 > --- a/nbd/trace-events > +++ b/nbd/trace-events > @@ -61,8 +61,8 @@ nbd_negotiate_begin(void) "Beginning negotiation" > nbd_negotiate_new_style_size_flags(uint64_t size, unsigned flags) "advertising size %" PRIu64 " and flags 0x%x" > nbd_negotiate_success(void) "Negotiation succeeded" > nbd_receive_request(uint32_t magic, uint16_t flags, uint16_t type, uint64_t from, uint32_t len) "Got request: { magic = 0x%" PRIx32 ", .flags = 0x%" PRIx16 ", .type = 0x%" PRIx16 ", from = %" PRIu64 ", len = %" PRIu32 " }" > -nbd_blk_aio_attached(const char *name, void *ctx) "Export %s: Attaching clients to AIO context %p\n" > -nbd_blk_aio_detach(const char *name, void *ctx) "Export %s: Detaching clients from AIO context %p\n" > +nbd_blk_aio_attached(const char *name, void *ctx) "Export %s: Attaching clients to AIO context %p" > +nbd_blk_aio_detach(const char *name, void *ctx) "Export %s: Detaching clients from AIO context %p" > nbd_co_send_simple_reply(uint64_t handle, uint32_t error, const char *errname, int len) "Send simple reply: handle = %" PRIu64 ", error = %" PRIu32 " (%s), len = %d" > nbd_co_send_structured_done(uint64_t handle) "Send structured reply done: handle = %" PRIu64 > nbd_co_send_structured_read(uint64_t handle, uint64_t offset, void *data, size_t size) "Send structured read data reply: handle = %" PRIu64 ", offset = %" PRIu64 ", data = %p, len = %zu" > diff --git a/net/trace-events b/net/trace-events > index ac57056497..02c13fd0ba 100644 > --- a/net/trace-events > +++ b/net/trace-events > @@ -17,9 +17,9 @@ colo_compare_icmp_miscompare(const char *sta, int size) ": %s = %d" > colo_compare_ip_info(int psize, const char *sta, const char *stb, int ssize, const char *stc, const char *std) "ppkt size = %d, ip_src = %s, ip_dst = %s, spkt size = %d, ip_src = %s, ip_dst = %s" > colo_old_packet_check_found(int64_t old_time) "%" PRId64 > colo_compare_miscompare(void) "" > -colo_compare_tcp_info(const char *pkt, uint32_t seq, uint32_t ack, int hdlen, int pdlen, int offset, int flags) "%s: seq/ack= %u/%u hdlen= %d pdlen= %d offset= %d flags=%d\n" > +colo_compare_tcp_info(const char *pkt, uint32_t seq, uint32_t ack, int hdlen, int pdlen, int offset, int flags) "%s: seq/ack= %u/%u hdlen= %d pdlen= %d offset= %d flags=%d" > > # filter-rewriter.c > colo_filter_rewriter_debug(void) "" > -colo_filter_rewriter_pkt_info(const char *func, const char *src, const char *dst, uint32_t seq, uint32_t ack, uint32_t flag) "%s: src/dst: %s/%s p: seq/ack=%u/%u flags=0x%x\n" > -colo_filter_rewriter_conn_offset(uint32_t offset) ": offset=%u\n" > +colo_filter_rewriter_pkt_info(const char *func, const char *src, const char *dst, uint32_t seq, uint32_t ack, uint32_t flag) "%s: src/dst: %s/%s p: seq/ack=%u/%u flags=0x%x" > +colo_filter_rewriter_conn_offset(uint32_t offset) ": offset=%u" > ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [Qemu-devel] [PULL 2/3] trace: Remove trailing newline in events 2019-09-18 15:51 ` Philippe Mathieu-Daudé @ 2019-09-19 9:31 ` Stefan Hajnoczi 0 siblings, 0 replies; 19+ messages in thread From: Stefan Hajnoczi @ 2019-09-19 9:31 UTC (permalink / raw) To: Philippe Mathieu-Daudé Cc: Fam Zheng, Peter Maydell, qemu-block, John Snow, Jason Wang, qemu-devel, Kevin Wolf, Paolo Bonzini [-- Attachment #1: Type: text/plain, Size: 614 bytes --] On Wed, Sep 18, 2019 at 05:51:16PM +0200, Philippe Mathieu-Daudé wrote: > On 9/18/19 3:21 PM, Stefan Hajnoczi wrote: > > Reviewed-by: John Snow <jsnow@redhat.com> > > Reviewed-by: Kevin Wolf <kwolf@redhat.com> > > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > > Message-id: 20190916095121.29506-2-philmd@redhat.com > > Message-Id: <20190916095121.29506-2-philmd@redhat.com> > > Out of curiosity, how do you end up with 2 slightly different > message-id? Using two different tools in series? (Thinking about > unifying these tools format). I'm not sure what happened here :P. Stefan [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 19+ messages in thread
* [Qemu-devel] [PULL 3/3] trace: Forbid event format ending with newline character 2019-09-18 13:21 [Qemu-devel] [PULL 0/3] Tracing patches Stefan Hajnoczi 2019-09-18 13:21 ` [Qemu-devel] [PULL 1/3] loader: Trace loaded images Stefan Hajnoczi 2019-09-18 13:21 ` [Qemu-devel] [PULL 2/3] trace: Remove trailing newline in events Stefan Hajnoczi @ 2019-09-18 13:21 ` Stefan Hajnoczi 2019-09-19 13:37 ` [Qemu-devel] [PULL 0/3] Tracing patches Peter Maydell 3 siblings, 0 replies; 19+ messages in thread From: Stefan Hajnoczi @ 2019-09-18 13:21 UTC (permalink / raw) To: qemu-devel Cc: Fam Zheng, Peter Maydell, qemu-block, Philippe Mathieu-Daudé, Jason Wang, John Snow, Stefan Hajnoczi, Paolo Bonzini, Kevin Wolf From: Philippe Mathieu-Daudé <philmd@redhat.com> Event format ending with newlines confuse the trace reports. Forbid them. Add a check to refuse new format added with trailing newline: $ make [...] GEN hw/misc/trace.h Traceback (most recent call last): File "scripts/tracetool.py", line 152, in <module> main(sys.argv) File "scripts/tracetool.py", line 143, in main events.extend(tracetool.read_events(fh, arg)) File "scripts/tracetool/__init__.py", line 367, in read_events event = Event.build(line) File "scripts/tracetool/__init__.py", line 281, in build raise ValueError("Event format can not end with a newline character") ValueError: Error at hw/misc/trace-events:121: Event format can not end with a newline character Reviewed-by: John Snow <jsnow@redhat.com> Reviewed-by: Kevin Wolf <kwolf@redhat.com> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> Message-id: 20190916095121.29506-3-philmd@redhat.com Message-Id: <20190916095121.29506-3-philmd@redhat.com> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> --- docs/devel/tracing.txt | 2 ++ scripts/tracetool/__init__.py | 3 +++ 2 files changed, 5 insertions(+) diff --git a/docs/devel/tracing.txt b/docs/devel/tracing.txt index 76e492a489..8231bbf5d1 100644 --- a/docs/devel/tracing.txt +++ b/docs/devel/tracing.txt @@ -112,6 +112,8 @@ Trace events should use types as follows: Format strings should reflect the types defined in the trace event. Take special care to use PRId64 and PRIu64 for int64_t and uint64_t types, respectively. This ensures portability between 32- and 64-bit platforms. +Format strings must not end with a newline character. It is the responsibility +of backends to adapt line ending for proper logging. Each event declaration will start with the event name, then its arguments, finally a format string for pretty-printing. For example: diff --git a/scripts/tracetool/__init__.py b/scripts/tracetool/__init__.py index 6fca674936..04279fa62e 100644 --- a/scripts/tracetool/__init__.py +++ b/scripts/tracetool/__init__.py @@ -277,6 +277,9 @@ class Event(object): if fmt.find("%m") != -1 or fmt_trans.find("%m") != -1: raise ValueError("Event format '%m' is forbidden, pass the error " "as an explicit trace argument") + if fmt.endswith(r'\n"'): + raise ValueError("Event format must not end with a newline " + "character") if len(fmt_trans) > 0: fmt = [fmt_trans, fmt] -- 2.21.0 ^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: [Qemu-devel] [PULL 0/3] Tracing patches 2019-09-18 13:21 [Qemu-devel] [PULL 0/3] Tracing patches Stefan Hajnoczi ` (2 preceding siblings ...) 2019-09-18 13:21 ` [Qemu-devel] [PULL 3/3] trace: Forbid event format ending with newline character Stefan Hajnoczi @ 2019-09-19 13:37 ` Peter Maydell 3 siblings, 0 replies; 19+ messages in thread From: Peter Maydell @ 2019-09-19 13:37 UTC (permalink / raw) To: Stefan Hajnoczi Cc: Fam Zheng, Qemu-block, Jason Wang, QEMU Developers, Paolo Bonzini On Wed, 18 Sep 2019 at 14:21, Stefan Hajnoczi <stefanha@redhat.com> wrote: > > The following changes since commit f8c3db33a5e863291182f8862ddf81618a7c6194: > > target/sparc: Switch to do_transaction_failed() hook (2019-09-17 12:01:00 +0100) > > are available in the Git repository at: > > https://github.com/stefanha/qemu.git tags/tracing-pull-request > > for you to fetch changes up to 9f7ad79c16ede0da01902b18fb32929cfbd20f87: > > trace: Forbid event format ending with newline character (2019-09-18 10:20:15 +0100) > > ---------------------------------------------------------------- > Pull request > > ---------------------------------------------------------------- > > Alexey Kardashevskiy (1): > loader: Trace loaded images > > Philippe Mathieu-Daudé (2): > trace: Remove trailing newline in events > trace: Forbid event format ending with newline character Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/4.2 for any user-visible changes. -- PMM ^ permalink raw reply [flat|nested] 19+ messages in thread
* [Qemu-devel] [PULL 0/3] Tracing patches @ 2018-02-19 16:19 Stefan Hajnoczi 2018-02-19 18:40 ` Peter Maydell 0 siblings, 1 reply; 19+ messages in thread From: Stefan Hajnoczi @ 2018-02-19 16:19 UTC (permalink / raw) To: qemu-devel; +Cc: Peter Maydell, Stefan Hajnoczi The following changes since commit e5ecc287a7bd24a1364e23e263cb60cfc8d21eb5: Merge remote-tracking branch 'remotes/dgilbert/tags/pull-hmp-20180216' into staging (2018-02-16 18:39:05 +0000) are available in the Git repository at: git://github.com/stefanha/qemu.git tags/tracing-pull-request for you to fetch changes up to 7f1d87ab0fd94cef5086e2879716958303281054: trace: avoid SystemTap "char const" warnings (2018-02-19 13:09:44 +0000) ---------------------------------------------------------------- ---------------------------------------------------------------- Jon Emil Jahren (2): tracetool: Update argument format regex to non-greedy star tracetool: For ust trace bool type as ctf_integer Stefan Hajnoczi (1): trace: avoid SystemTap "char const" warnings hw/block/trace-events | 4 ++-- scripts/tracetool/__init__.py | 5 +++-- scripts/tracetool/format/ust_events_h.py | 3 ++- trace-events | 12 ++++++------ 4 files changed, 13 insertions(+), 11 deletions(-) -- 2.14.3 ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [Qemu-devel] [PULL 0/3] Tracing patches 2018-02-19 16:19 Stefan Hajnoczi @ 2018-02-19 18:40 ` Peter Maydell 0 siblings, 0 replies; 19+ messages in thread From: Peter Maydell @ 2018-02-19 18:40 UTC (permalink / raw) To: Stefan Hajnoczi; +Cc: QEMU Developers On 19 February 2018 at 16:19, Stefan Hajnoczi <stefanha@redhat.com> wrote: > The following changes since commit e5ecc287a7bd24a1364e23e263cb60cfc8d21eb5: > > Merge remote-tracking branch 'remotes/dgilbert/tags/pull-hmp-20180216' into staging (2018-02-16 18:39:05 +0000) > > are available in the Git repository at: > > git://github.com/stefanha/qemu.git tags/tracing-pull-request > > for you to fetch changes up to 7f1d87ab0fd94cef5086e2879716958303281054: > > trace: avoid SystemTap "char const" warnings (2018-02-19 13:09:44 +0000) > > ---------------------------------------------------------------- > > ---------------------------------------------------------------- > > Jon Emil Jahren (2): > tracetool: Update argument format regex to non-greedy star > tracetool: For ust trace bool type as ctf_integer > > Stefan Hajnoczi (1): > trace: avoid SystemTap "char const" warnings Applied, thanks. -- PMM ^ permalink raw reply [flat|nested] 19+ messages in thread
* [Qemu-devel] [PULL 0/3] Tracing patches @ 2018-01-29 16:07 Stefan Hajnoczi 2018-01-29 16:14 ` no-reply 2018-01-30 10:50 ` Peter Maydell 0 siblings, 2 replies; 19+ messages in thread From: Stefan Hajnoczi @ 2018-01-29 16:07 UTC (permalink / raw) To: qemu-devel; +Cc: Peter Maydell, Stefan Hajnoczi The following changes since commit 6233b4a8c2a32ef6955a921246fa08705bbb3676: Merge remote-tracking branch 'remotes/ericb/tags/pull-nbd-2018-01-26' into staging (2018-01-26 17:29:14 +0000) are available in the Git repository at: git://github.com/stefanha/qemu.git tags/tracing-pull-request for you to fetch changes up to 24f4d3d3aeabf83445839099d6d66cbb3089c37a: tracetool: report error on foo() instead of foo(void) (2018-01-29 10:34:55 +0000) ---------------------------------------------------------------- ---------------------------------------------------------------- Stefan Hajnoczi (3): tracetool: prefix parse errors with line numbers tracetool: clarify that "formats" means "format strings" tracetool: report error on foo() instead of foo(void) scripts/tracetool/__init__.py | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) -- 2.14.3 ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [Qemu-devel] [PULL 0/3] Tracing patches 2018-01-29 16:07 Stefan Hajnoczi @ 2018-01-29 16:14 ` no-reply 2018-01-30 11:58 ` Stefan Hajnoczi 2018-01-30 10:50 ` Peter Maydell 1 sibling, 1 reply; 19+ messages in thread From: no-reply @ 2018-01-29 16:14 UTC (permalink / raw) To: stefanha; +Cc: famz, qemu-devel, peter.maydell Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180129160740.1195-1-stefanha@redhat.com Subject: [Qemu-devel] [PULL 0/3] Tracing patches === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu fccfcc6328..0d1442912b master -> master t [tag update] patchew/20171130164750.47320-1-vsementsov@virtuozzo.com -> patchew/20171130164750.47320-1-vsementsov@virtuozzo.com * [new tag] patchew/20180129160740.1195-1-stefanha@redhat.com -> patchew/20180129160740.1195-1-stefanha@redhat.com Switched to a new branch 'test' 8224c195a1 tracetool: report error on foo() instead of foo(void) 511aad4f63 tracetool: clarify that "formats" means "format strings" cda21c769c tracetool: prefix parse errors with line numbers === OUTPUT BEGIN === Checking PATCH 1/3: tracetool: prefix parse errors with line numbers... Checking PATCH 2/3: tracetool: clarify that "formats" means "format strings"... ERROR: line over 90 characters #39: FILE: scripts/tracetool/__init__.py:240: + raise ValueError("Only events with 'tcg' property can have two format strings") WARNING: line over 80 characters #42: FILE: scripts/tracetool/__init__.py:242: + raise ValueError("Events with 'tcg' property must have two format strings") total: 1 errors, 1 warnings, 27 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 3/3: tracetool: report error on foo() instead of foo(void)... WARNING: line over 80 characters #26: FILE: scripts/tracetool/__init__.py:79: + raise ValueError("Empty argument (did you forget to use 'void'?)") total: 0 errors, 1 warnings, 8 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@freelists.org ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [Qemu-devel] [PULL 0/3] Tracing patches 2018-01-29 16:14 ` no-reply @ 2018-01-30 11:58 ` Stefan Hajnoczi 0 siblings, 0 replies; 19+ messages in thread From: Stefan Hajnoczi @ 2018-01-30 11:58 UTC (permalink / raw) To: qemu-devel; +Cc: famz, peter.maydell [-- Attachment #1: Type: text/plain, Size: 1413 bytes --] On Mon, Jan 29, 2018 at 08:14:46AM -0800, no-reply@patchew.org wrote: > === OUTPUT BEGIN === > Checking PATCH 1/3: tracetool: prefix parse errors with line numbers... > Checking PATCH 2/3: tracetool: clarify that "formats" means "format strings"... > ERROR: line over 90 characters > #39: FILE: scripts/tracetool/__init__.py:240: > + raise ValueError("Only events with 'tcg' property can have two format strings") > > WARNING: line over 80 characters > #42: FILE: scripts/tracetool/__init__.py:242: > + raise ValueError("Events with 'tcg' property must have two format strings") > > total: 1 errors, 1 warnings, 27 lines checked > > Your patch has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > > Checking PATCH 3/3: tracetool: report error on foo() instead of foo(void)... > WARNING: line over 80 characters > #26: FILE: scripts/tracetool/__init__.py:79: > + raise ValueError("Empty argument (did you forget to use 'void'?)") > > total: 0 errors, 1 warnings, 8 lines checked > > Your patch has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > === OUTPUT END === For the record, I didn't wrap these error messages so that grep(1) works. Stefan [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 455 bytes --] ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [Qemu-devel] [PULL 0/3] Tracing patches 2018-01-29 16:07 Stefan Hajnoczi 2018-01-29 16:14 ` no-reply @ 2018-01-30 10:50 ` Peter Maydell 1 sibling, 0 replies; 19+ messages in thread From: Peter Maydell @ 2018-01-30 10:50 UTC (permalink / raw) To: Stefan Hajnoczi; +Cc: QEMU Developers On 29 January 2018 at 16:07, Stefan Hajnoczi <stefanha@redhat.com> wrote: > The following changes since commit 6233b4a8c2a32ef6955a921246fa08705bbb3676: > > Merge remote-tracking branch 'remotes/ericb/tags/pull-nbd-2018-01-26' into staging (2018-01-26 17:29:14 +0000) > > are available in the Git repository at: > > git://github.com/stefanha/qemu.git tags/tracing-pull-request > > for you to fetch changes up to 24f4d3d3aeabf83445839099d6d66cbb3089c37a: > > tracetool: report error on foo() instead of foo(void) (2018-01-29 10:34:55 +0000) > > ---------------------------------------------------------------- > > ---------------------------------------------------------------- > > Stefan Hajnoczi (3): > tracetool: prefix parse errors with line numbers > tracetool: clarify that "formats" means "format strings" > tracetool: report error on foo() instead of foo(void) > > scripts/tracetool/__init__.py | 19 +++++++++++++------ > 1 file changed, 13 insertions(+), 6 deletions(-) Applied, thanks. -- PMM ^ permalink raw reply [flat|nested] 19+ messages in thread
* [Qemu-devel] [PULL 0/3] Tracing patches @ 2017-03-16 7:04 Stefan Hajnoczi 2017-03-16 15:31 ` Peter Maydell 0 siblings, 1 reply; 19+ messages in thread From: Stefan Hajnoczi @ 2017-03-16 7:04 UTC (permalink / raw) To: qemu-devel; +Cc: Peter Maydell, Stefan Hajnoczi The following changes since commit 1883ff34b540daacae948f493b0ba525edf5f642: Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2017-03-15 18:44:05 +0000) are available in the git repository at: git://github.com/stefanha/qemu.git tags/tracing-pull-request for you to fetch changes up to 8755b4afbdcf1c274cab7545a9f76d3d6c7f5c29: trace: ensure $(tracetool-y) is defined in top level makefile (2017-03-16 11:51:26 +0800) ---------------------------------------------------------------- Pull request Tracing makefile fixes for QEMU 2.9. ---------------------------------------------------------------- Daniel P. Berrange (3): makefile: merge GENERATED_HEADERS & GENERATED_SOURCES variables makefile: generate trace-events-all upfront trace: ensure $(tracetool-y) is defined in top level makefile Makefile | 42 ++++++++++++++++++++++-------------------- Makefile.target | 6 +++--- target/s390x/Makefile.objs | 2 +- tests/Makefile.include | 2 +- trace/Makefile.objs | 8 -------- 5 files changed, 27 insertions(+), 33 deletions(-) -- 2.9.3 ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [Qemu-devel] [PULL 0/3] Tracing patches 2017-03-16 7:04 Stefan Hajnoczi @ 2017-03-16 15:31 ` Peter Maydell 0 siblings, 0 replies; 19+ messages in thread From: Peter Maydell @ 2017-03-16 15:31 UTC (permalink / raw) To: Stefan Hajnoczi; +Cc: QEMU Developers On 16 March 2017 at 07:04, Stefan Hajnoczi <stefanha@redhat.com> wrote: > The following changes since commit 1883ff34b540daacae948f493b0ba525edf5f642: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2017-03-15 18:44:05 +0000) > > are available in the git repository at: > > git://github.com/stefanha/qemu.git tags/tracing-pull-request > > for you to fetch changes up to 8755b4afbdcf1c274cab7545a9f76d3d6c7f5c29: > > trace: ensure $(tracetool-y) is defined in top level makefile (2017-03-16 11:51:26 +0800) > > ---------------------------------------------------------------- > Pull request > > Tracing makefile fixes for QEMU 2.9. > > ---------------------------------------------------------------- > > Daniel P. Berrange (3): > makefile: merge GENERATED_HEADERS & GENERATED_SOURCES variables > makefile: generate trace-events-all upfront > trace: ensure $(tracetool-y) is defined in top level makefile > > Makefile | 42 ++++++++++++++++++++++-------------------- > Makefile.target | 6 +++--- > target/s390x/Makefile.objs | 2 +- > tests/Makefile.include | 2 +- > trace/Makefile.objs | 8 -------- > 5 files changed, 27 insertions(+), 33 deletions(-) Applied, thanks. -- PMM ^ permalink raw reply [flat|nested] 19+ messages in thread
* [Qemu-devel] [PULL 0/3] Tracing patches @ 2016-09-05 19:42 Stefan Hajnoczi 2016-09-06 12:32 ` Peter Maydell 0 siblings, 1 reply; 19+ messages in thread From: Stefan Hajnoczi @ 2016-09-05 19:42 UTC (permalink / raw) To: qemu-devel; +Cc: Peter Maydell, Stefan Hajnoczi The following changes since commit e87d397e5ef66276ccc49b829527d605ca07d0ad: Open 2.8 development tree (2016-09-05 11:38:54 +0100) are available in the git repository at: git://github.com/stefanha/qemu.git tags/tracing-pull-request for you to fetch changes up to 8eb1b9db559e243043aaeac3a0aa97e1f4a403c4: trace: Avoid implicit bool->integer conversions (2016-09-05 13:47:02 -0400) ---------------------------------------------------------------- ---------------------------------------------------------------- Lluís Vilanova (2): trace: Remove 'trace_events_dstate_init' trace: Avoid implicit bool->integer conversions Paul Durrant (1): trace: add syslog tracing backend configure | 19 ++++++++++++++++ docs/tracing.txt | 12 ++++++++++ scripts/tracetool/backend/syslog.py | 45 +++++++++++++++++++++++++++++++++++++ stubs/trace-control.c | 22 ++++++++++++++++-- trace/control-target.c | 34 ++++++++++++++++++++++++++-- trace/control.c | 28 ++++++++++++++--------- trace/control.h | 3 +++ trace/event-internal.h | 1 + 8 files changed, 149 insertions(+), 15 deletions(-) create mode 100644 scripts/tracetool/backend/syslog.py -- 2.7.4 ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [Qemu-devel] [PULL 0/3] Tracing patches 2016-09-05 19:42 Stefan Hajnoczi @ 2016-09-06 12:32 ` Peter Maydell 0 siblings, 0 replies; 19+ messages in thread From: Peter Maydell @ 2016-09-06 12:32 UTC (permalink / raw) To: Stefan Hajnoczi; +Cc: QEMU Developers On 5 September 2016 at 20:42, Stefan Hajnoczi <stefanha@redhat.com> wrote: > The following changes since commit e87d397e5ef66276ccc49b829527d605ca07d0ad: > > Open 2.8 development tree (2016-09-05 11:38:54 +0100) > > are available in the git repository at: > > git://github.com/stefanha/qemu.git tags/tracing-pull-request > > for you to fetch changes up to 8eb1b9db559e243043aaeac3a0aa97e1f4a403c4: > > trace: Avoid implicit bool->integer conversions (2016-09-05 13:47:02 -0400) > > ---------------------------------------------------------------- > > ---------------------------------------------------------------- > > Lluís Vilanova (2): > trace: Remove 'trace_events_dstate_init' > trace: Avoid implicit bool->integer conversions > > Paul Durrant (1): > trace: add syslog tracing backend Applied, thanks. -- PMM ^ permalink raw reply [flat|nested] 19+ messages in thread
* [Qemu-devel] [PULL 0/3] Tracing patches @ 2012-03-30 10:58 Stefan Hajnoczi 2012-04-02 15:52 ` Anthony Liguori 0 siblings, 1 reply; 19+ messages in thread From: Stefan Hajnoczi @ 2012-03-30 10:58 UTC (permalink / raw) To: Anthony Liguori; +Cc: qemu-devel, Stefan Hajnoczi The latest tracing fixes. Alon Levy (2): Makefile.target: code stp dependency on trace-events tracetool: dtrace: handle in and next reserved words Lee Essen (1): tracetool: dtrace disabled-events fix Makefile.target | 2 +- scripts/tracetool | 22 ++++++++++++++++++---- 2 files changed, 19 insertions(+), 5 deletions(-) -- 1.7.9.1 ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [Qemu-devel] [PULL 0/3] Tracing patches 2012-03-30 10:58 Stefan Hajnoczi @ 2012-04-02 15:52 ` Anthony Liguori 0 siblings, 0 replies; 19+ messages in thread From: Anthony Liguori @ 2012-04-02 15:52 UTC (permalink / raw) To: Stefan Hajnoczi; +Cc: qemu-devel On 03/30/2012 05:58 AM, Stefan Hajnoczi wrote: > The latest tracing fixes. > > Alon Levy (2): > Makefile.target: code stp dependency on trace-events > tracetool: dtrace: handle in and next reserved words > > Lee Essen (1): > tracetool: dtrace disabled-events fix Pulled. Thanks. Regards, Anthony Liguori > > Makefile.target | 2 +- > scripts/tracetool | 22 ++++++++++++++++++---- > 2 files changed, 19 insertions(+), 5 deletions(-) > ^ permalink raw reply [flat|nested] 19+ messages in thread
end of thread, other threads:[~2019-09-19 13:55 UTC | newest] Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-09-18 13:21 [Qemu-devel] [PULL 0/3] Tracing patches Stefan Hajnoczi 2019-09-18 13:21 ` [Qemu-devel] [PULL 1/3] loader: Trace loaded images Stefan Hajnoczi 2019-09-18 13:21 ` [Qemu-devel] [PULL 2/3] trace: Remove trailing newline in events Stefan Hajnoczi 2019-09-18 15:51 ` Philippe Mathieu-Daudé 2019-09-19 9:31 ` Stefan Hajnoczi 2019-09-18 13:21 ` [Qemu-devel] [PULL 3/3] trace: Forbid event format ending with newline character Stefan Hajnoczi 2019-09-19 13:37 ` [Qemu-devel] [PULL 0/3] Tracing patches Peter Maydell -- strict thread matches above, loose matches on Subject: below -- 2018-02-19 16:19 Stefan Hajnoczi 2018-02-19 18:40 ` Peter Maydell 2018-01-29 16:07 Stefan Hajnoczi 2018-01-29 16:14 ` no-reply 2018-01-30 11:58 ` Stefan Hajnoczi 2018-01-30 10:50 ` Peter Maydell 2017-03-16 7:04 Stefan Hajnoczi 2017-03-16 15:31 ` Peter Maydell 2016-09-05 19:42 Stefan Hajnoczi 2016-09-06 12:32 ` Peter Maydell 2012-03-30 10:58 Stefan Hajnoczi 2012-04-02 15:52 ` Anthony Liguori
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.