* [Qemu-devel] [PULL 0/3] Tracing patches
@ 2016-09-05 19:42 Stefan Hajnoczi
2016-09-05 19:42 ` [Qemu-devel] [PULL 1/3] trace: add syslog tracing backend Stefan Hajnoczi
` (3 more replies)
0 siblings, 4 replies; 17+ messages in thread
From: Stefan Hajnoczi @ 2016-09-05 19:42 UTC (permalink / raw)
To: qemu-devel; +Cc: Peter Maydell, Stefan Hajnoczi
The following changes since commit e87d397e5ef66276ccc49b829527d605ca07d0ad:
Open 2.8 development tree (2016-09-05 11:38:54 +0100)
are available in the git repository at:
git://github.com/stefanha/qemu.git tags/tracing-pull-request
for you to fetch changes up to 8eb1b9db559e243043aaeac3a0aa97e1f4a403c4:
trace: Avoid implicit bool->integer conversions (2016-09-05 13:47:02 -0400)
----------------------------------------------------------------
----------------------------------------------------------------
Lluís Vilanova (2):
trace: Remove 'trace_events_dstate_init'
trace: Avoid implicit bool->integer conversions
Paul Durrant (1):
trace: add syslog tracing backend
configure | 19 ++++++++++++++++
docs/tracing.txt | 12 ++++++++++
scripts/tracetool/backend/syslog.py | 45 +++++++++++++++++++++++++++++++++++++
stubs/trace-control.c | 22 ++++++++++++++++--
trace/control-target.c | 34 ++++++++++++++++++++++++++--
trace/control.c | 28 ++++++++++++++---------
trace/control.h | 3 +++
trace/event-internal.h | 1 +
8 files changed, 149 insertions(+), 15 deletions(-)
create mode 100644 scripts/tracetool/backend/syslog.py
--
2.7.4
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Qemu-devel] [PULL 1/3] trace: add syslog tracing backend
2016-09-05 19:42 [Qemu-devel] [PULL 0/3] Tracing patches Stefan Hajnoczi
@ 2016-09-05 19:42 ` Stefan Hajnoczi
2016-09-05 19:42 ` [Qemu-devel] [PULL 2/3] trace: Remove 'trace_events_dstate_init' Stefan Hajnoczi
` (2 subsequent siblings)
3 siblings, 0 replies; 17+ messages in thread
From: Stefan Hajnoczi @ 2016-09-05 19:42 UTC (permalink / raw)
To: qemu-devel; +Cc: Peter Maydell, Paul Durrant, Stefan Hajnoczi
From: Paul Durrant <paul.durrant@citrix.com>
This patch adds a tracing backend which sends output using syslog().
The syslog backend is limited to POSIX compliant systems.
openlog() is called with facility set to LOG_DAEMON, with the LOG_PID
option. Trace events are logged at level LOG_INFO.
Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
Message-id: 1470318254-29989-1-git-send-email-paul.durrant@citrix.com
Cc: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
configure | 19 ++++++++++++++++
docs/tracing.txt | 12 ++++++++++
scripts/tracetool/backend/syslog.py | 45 +++++++++++++++++++++++++++++++++++++
trace/control.c | 7 ++++++
4 files changed, 83 insertions(+)
create mode 100644 scripts/tracetool/backend/syslog.py
diff --git a/configure b/configure
index 4b808f9..5a9bda1 100755
--- a/configure
+++ b/configure
@@ -4192,6 +4192,18 @@ if compile_prog "" "" ; then
fi
##########################################
+# check if we have posix_syslog
+
+posix_syslog=no
+cat > $TMPC << EOF
+#include <syslog.h>
+int main(void) { openlog("qemu", LOG_PID, LOG_DAEMON); syslog(LOG_INFO, "configure"); return 0; }
+EOF
+if compile_prog "" "" ; then
+ posix_syslog=yes
+fi
+
+##########################################
# check if trace backend exists
$python "$source_path/scripts/tracetool.py" "--backends=$trace_backends" --check-backends > /dev/null 2> /dev/null
@@ -5468,6 +5480,13 @@ if have_backend "ftrace"; then
feature_not_found "ftrace(trace backend)" "ftrace requires Linux"
fi
fi
+if have_backend "syslog"; then
+ if test "$posix_syslog" = "yes" ; then
+ echo "CONFIG_TRACE_SYSLOG=y" >> $config_host_mak
+ else
+ feature_not_found "syslog(trace backend)" "syslog not available"
+ fi
+fi
echo "CONFIG_TRACE_FILE=$trace_file" >> $config_host_mak
if test "$rdma" = "yes" ; then
diff --git a/docs/tracing.txt b/docs/tracing.txt
index 29f2f9a..e62444c 100644
--- a/docs/tracing.txt
+++ b/docs/tracing.txt
@@ -192,6 +192,18 @@ After running qemu by root user, you can get the trace:
Restriction: "ftrace" backend is restricted to Linux only.
+=== Syslog ===
+
+The "syslog" backend sends trace events using the POSIX syslog API. The log
+is opened specifying the LOG_DAEMON facility and LOG_PID option (so events
+are tagged with the pid of the particular QEMU process that generated
+them). All events are logged at LOG_INFO level.
+
+NOTE: syslog may squash duplicate consecutive trace events and apply rate
+ limiting.
+
+Restriction: "syslog" backend is restricted to POSIX compliant OS.
+
==== Monitor commands ====
* trace-file on|off|flush|set <path>
diff --git a/scripts/tracetool/backend/syslog.py b/scripts/tracetool/backend/syslog.py
new file mode 100644
index 0000000..89019bc
--- /dev/null
+++ b/scripts/tracetool/backend/syslog.py
@@ -0,0 +1,45 @@
+#!/usr/bin/env python
+# -*- coding: utf-8 -*-
+
+"""
+Syslog built-in backend.
+"""
+
+__author__ = "Paul Durrant <paul.durrant@citrix.com>"
+__copyright__ = "Copyright 2016, Citrix Systems Inc."
+__license__ = "GPL version 2 or (at your option) any later version"
+
+__maintainer__ = "Stefan Hajnoczi"
+__email__ = "stefanha@redhat.com"
+
+
+from tracetool import out
+
+
+PUBLIC = True
+
+
+def generate_h_begin(events):
+ out('#include <syslog.h>',
+ '#include "trace/control.h"',
+ '')
+
+
+def generate_h(event):
+ argnames = ", ".join(event.args.names())
+ if len(event.args) > 0:
+ argnames = ", " + argnames
+
+ if "vcpu" in event.properties:
+ # already checked on the generic format code
+ cond = "true"
+ else:
+ cond = "trace_event_get_state(%s)" % ("TRACE_" + event.name.upper())
+
+ out(' if (%(cond)s) {',
+ ' syslog(LOG_INFO, "%(name)s " %(fmt)s %(argnames)s);',
+ ' }',
+ cond=cond,
+ name=event.name,
+ fmt=event.fmt.rstrip("\n"),
+ argnames=argnames)
diff --git a/trace/control.c b/trace/control.c
index d173c09..b179cde 100644
--- a/trace/control.c
+++ b/trace/control.c
@@ -19,6 +19,9 @@
#ifdef CONFIG_TRACE_LOG
#include "qemu/log.h"
#endif
+#ifdef CONFIG_TRACE_SYSLOG
+#include <syslog.h>
+#endif
#include "qapi/error.h"
#include "qemu/error-report.h"
#include "qemu/config-file.h"
@@ -250,6 +253,10 @@ bool trace_init_backends(void)
}
#endif
+#ifdef CONFIG_TRACE_SYSLOG
+ openlog(NULL, LOG_PID, LOG_DAEMON);
+#endif
+
return true;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [Qemu-devel] [PULL 2/3] trace: Remove 'trace_events_dstate_init'
2016-09-05 19:42 [Qemu-devel] [PULL 0/3] Tracing patches Stefan Hajnoczi
2016-09-05 19:42 ` [Qemu-devel] [PULL 1/3] trace: add syslog tracing backend Stefan Hajnoczi
@ 2016-09-05 19:42 ` Stefan Hajnoczi
2016-09-05 19:42 ` [Qemu-devel] [PULL 3/3] trace: Avoid implicit bool->integer conversions Stefan Hajnoczi
2016-09-06 12:32 ` [Qemu-devel] [PULL 0/3] Tracing patches Peter Maydell
3 siblings, 0 replies; 17+ messages in thread
From: Stefan Hajnoczi @ 2016-09-05 19:42 UTC (permalink / raw)
To: qemu-devel; +Cc: Peter Maydell, Lluís Vilanova, Stefan Hajnoczi
From: Lluís Vilanova <vilanova@ac.upc.edu>
Removes the event state array used for early initialization. Since only
events with the "vcpu" property need a late initialization fixup,
threats their initialization specially.
Assumes that the user won't touch the state of "vcpu" events between
early and late initialization (e.g., through QMP).
Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
Message-id: 147194273191.26836.14423079546263831356.stgit@fimbulvetr.bsc.es
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
stubs/trace-control.c | 5 +++++
trace/control-target.c | 9 +++++++++
trace/control.c | 21 ++++++++++-----------
trace/control.h | 3 +++
trace/event-internal.h | 1 +
5 files changed, 28 insertions(+), 11 deletions(-)
diff --git a/stubs/trace-control.c b/stubs/trace-control.c
index fe59836..3740c38 100644
--- a/stubs/trace-control.c
+++ b/stubs/trace-control.c
@@ -11,6 +11,11 @@
#include "trace/control.h"
+void trace_event_set_state_dynamic_init(TraceEvent *ev, bool state)
+{
+ trace_event_set_state_dynamic(ev, state);
+}
+
void trace_event_set_state_dynamic(TraceEvent *ev, bool state)
{
TraceEventID id;
diff --git a/trace/control-target.c b/trace/control-target.c
index 74c029a..4ee3733 100644
--- a/trace/control-target.c
+++ b/trace/control-target.c
@@ -13,6 +13,15 @@
#include "translate-all.h"
+void trace_event_set_state_dynamic_init(TraceEvent *ev, bool state)
+{
+ TraceEventID id = trace_event_get_id(ev);
+ assert(trace_event_get_state_static(ev));
+ /* Ignore "vcpu" property, since no vCPUs have been created yet */
+ trace_events_enabled_count += state - trace_events_dstate[id];
+ trace_events_dstate[id] = state;
+}
+
void trace_event_set_state_dynamic(TraceEvent *ev, bool state)
{
CPUState *vcpu;
diff --git a/trace/control.c b/trace/control.c
index b179cde..05d85ac 100644
--- a/trace/control.c
+++ b/trace/control.c
@@ -34,8 +34,6 @@ int trace_events_enabled_count;
* - true : Integral counting the number of vCPUs that have this event enabled.
*/
uint16_t trace_events_dstate[TRACE_EVENT_COUNT];
-/* Marks events for late vCPU state init */
-static bool trace_events_dstate_init[TRACE_EVENT_COUNT];
QemuOptsList qemu_trace_opts = {
.name = "trace",
@@ -145,10 +143,7 @@ static void do_trace_enable_events(const char *line_buf)
TraceEvent *ev = NULL;
while ((ev = trace_event_pattern(line_ptr, ev)) != NULL) {
if (trace_event_get_state_static(ev)) {
- /* start tracing */
- trace_event_set_state_dynamic(ev, enable);
- /* mark for late vCPU init */
- trace_events_dstate_init[ev->id] = true;
+ trace_event_set_state_dynamic_init(ev, enable);
}
}
} else {
@@ -160,10 +155,7 @@ static void do_trace_enable_events(const char *line_buf)
error_report("WARNING: trace event '%s' is not traceable",
line_ptr);
} else {
- /* start tracing */
- trace_event_set_state_dynamic(ev, enable);
- /* mark for late vCPU init */
- trace_events_dstate_init[ev->id] = true;
+ trace_event_set_state_dynamic_init(ev, enable);
}
}
}
@@ -284,7 +276,14 @@ void trace_init_vcpu_events(void)
while ((ev = trace_event_pattern("*", ev)) != NULL) {
if (trace_event_is_vcpu(ev) &&
trace_event_get_state_static(ev) &&
- trace_events_dstate_init[ev->id]) {
+ trace_event_get_state_dynamic(ev)) {
+ TraceEventID id = trace_event_get_id(ev);
+ /* check preconditions */
+ assert(trace_events_dstate[id] == 1);
+ /* disable early-init state ... */
+ trace_events_dstate[id] = 0;
+ trace_events_enabled_count--;
+ /* ... and properly re-enable */
trace_event_set_state_dynamic(ev, true);
}
}
diff --git a/trace/control.h b/trace/control.h
index 0413b28..27a16fc 100644
--- a/trace/control.h
+++ b/trace/control.h
@@ -274,6 +274,9 @@ char *trace_opt_parse(const char *optarg);
*
* Re-synchronize initial event state with vCPUs (which can be created after
* trace_init_events()).
+ *
+ * Precondition: event states won't be changed between trace_enable_events() and
+ * trace_init_vcpu_events() (e.g., through QMP).
*/
void trace_init_vcpu_events(void);
diff --git a/trace/event-internal.h b/trace/event-internal.h
index 5d8fa97..074faf6 100644
--- a/trace/event-internal.h
+++ b/trace/event-internal.h
@@ -29,5 +29,6 @@ typedef struct TraceEvent {
const bool sstate;
} TraceEvent;
+void trace_event_set_state_dynamic_init(TraceEvent *ev, bool state);
#endif /* TRACE__EVENT_INTERNAL_H */
--
2.7.4
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [Qemu-devel] [PULL 3/3] trace: Avoid implicit bool->integer conversions
2016-09-05 19:42 [Qemu-devel] [PULL 0/3] Tracing patches Stefan Hajnoczi
2016-09-05 19:42 ` [Qemu-devel] [PULL 1/3] trace: add syslog tracing backend Stefan Hajnoczi
2016-09-05 19:42 ` [Qemu-devel] [PULL 2/3] trace: Remove 'trace_events_dstate_init' Stefan Hajnoczi
@ 2016-09-05 19:42 ` Stefan Hajnoczi
2016-09-06 12:32 ` [Qemu-devel] [PULL 0/3] Tracing patches Peter Maydell
3 siblings, 0 replies; 17+ messages in thread
From: Stefan Hajnoczi @ 2016-09-05 19:42 UTC (permalink / raw)
To: qemu-devel; +Cc: Peter Maydell, Lluís Vilanova, Stefan Hajnoczi
From: Lluís Vilanova <vilanova@ac.upc.edu>
An explicit if/else is clearer than arithmetic assuming #true is 1,
while the compiler should be able to generate just as optimal code.
Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
Message-id: 147194273830.26836.5875729707953474838.stgit@fimbulvetr.bsc.es
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
stubs/trace-control.c | 17 +++++++++++++++--
trace/control-target.c | 31 ++++++++++++++++++++++++++-----
2 files changed, 41 insertions(+), 7 deletions(-)
diff --git a/stubs/trace-control.c b/stubs/trace-control.c
index 3740c38..2dfcd9f 100644
--- a/stubs/trace-control.c
+++ b/stubs/trace-control.c
@@ -19,10 +19,23 @@ void trace_event_set_state_dynamic_init(TraceEvent *ev, bool state)
void trace_event_set_state_dynamic(TraceEvent *ev, bool state)
{
TraceEventID id;
+ bool state_pre;
assert(trace_event_get_state_static(ev));
id = trace_event_get_id(ev);
- trace_events_enabled_count += state - trace_events_dstate[id];
- trace_events_dstate[id] = state;
+ /*
+ * We ignore the "vcpu" property here, since there's no target code. Then
+ * dstate can only be 1 or 0.
+ */
+ state_pre = trace_events_dstate[id];
+ if (state_pre != state) {
+ if (state) {
+ trace_events_enabled_count++;
+ trace_events_dstate[id] = 1;
+ } else {
+ trace_events_enabled_count--;
+ trace_events_dstate[id] = 0;
+ }
+ }
}
void trace_event_set_vcpu_state_dynamic(CPUState *vcpu,
diff --git a/trace/control-target.c b/trace/control-target.c
index 4ee3733..72081e2 100644
--- a/trace/control-target.c
+++ b/trace/control-target.c
@@ -16,10 +16,22 @@
void trace_event_set_state_dynamic_init(TraceEvent *ev, bool state)
{
TraceEventID id = trace_event_get_id(ev);
+ bool state_pre;
assert(trace_event_get_state_static(ev));
- /* Ignore "vcpu" property, since no vCPUs have been created yet */
- trace_events_enabled_count += state - trace_events_dstate[id];
- trace_events_dstate[id] = state;
+ /*
+ * We ignore the "vcpu" property here, since no vCPUs have been created
+ * yet. Then dstate can only be 1 or 0.
+ */
+ state_pre = trace_events_dstate[id];
+ if (state_pre != state) {
+ if (state) {
+ trace_events_enabled_count++;
+ trace_events_dstate[id] = 1;
+ } else {
+ trace_events_enabled_count--;
+ trace_events_dstate[id] = 0;
+ }
+ }
}
void trace_event_set_state_dynamic(TraceEvent *ev, bool state)
@@ -31,9 +43,18 @@ void trace_event_set_state_dynamic(TraceEvent *ev, bool state)
trace_event_set_vcpu_state_dynamic(vcpu, ev, state);
}
} else {
+ /* Without the "vcpu" property, dstate can only be 1 or 0 */
TraceEventID id = trace_event_get_id(ev);
- trace_events_enabled_count += state - trace_events_dstate[id];
- trace_events_dstate[id] = state;
+ bool state_pre = trace_events_dstate[id];
+ if (state_pre != state) {
+ if (state) {
+ trace_events_enabled_count++;
+ trace_events_dstate[id] = 1;
+ } else {
+ trace_events_enabled_count--;
+ trace_events_dstate[id] = 0;
+ }
+ }
}
}
--
2.7.4
^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [Qemu-devel] [PULL 0/3] Tracing patches
2016-09-05 19:42 [Qemu-devel] [PULL 0/3] Tracing patches Stefan Hajnoczi
` (2 preceding siblings ...)
2016-09-05 19:42 ` [Qemu-devel] [PULL 3/3] trace: Avoid implicit bool->integer conversions Stefan Hajnoczi
@ 2016-09-06 12:32 ` Peter Maydell
3 siblings, 0 replies; 17+ messages in thread
From: Peter Maydell @ 2016-09-06 12:32 UTC (permalink / raw)
To: Stefan Hajnoczi; +Cc: QEMU Developers
On 5 September 2016 at 20:42, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> The following changes since commit e87d397e5ef66276ccc49b829527d605ca07d0ad:
>
> Open 2.8 development tree (2016-09-05 11:38:54 +0100)
>
> are available in the git repository at:
>
> git://github.com/stefanha/qemu.git tags/tracing-pull-request
>
> for you to fetch changes up to 8eb1b9db559e243043aaeac3a0aa97e1f4a403c4:
>
> trace: Avoid implicit bool->integer conversions (2016-09-05 13:47:02 -0400)
>
> ----------------------------------------------------------------
>
> ----------------------------------------------------------------
>
> Lluís Vilanova (2):
> trace: Remove 'trace_events_dstate_init'
> trace: Avoid implicit bool->integer conversions
>
> Paul Durrant (1):
> trace: add syslog tracing backend
Applied, thanks.
-- PMM
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Qemu-devel] [PULL 0/3] Tracing patches
@ 2019-09-18 13:21 Stefan Hajnoczi
2019-09-19 13:37 ` Peter Maydell
0 siblings, 1 reply; 17+ messages in thread
From: Stefan Hajnoczi @ 2019-09-18 13:21 UTC (permalink / raw)
To: qemu-devel
Cc: Fam Zheng, Peter Maydell, qemu-block, Jason Wang,
Stefan Hajnoczi, Paolo Bonzini
The following changes since commit f8c3db33a5e863291182f8862ddf81618a7c6194:
target/sparc: Switch to do_transaction_failed() hook (2019-09-17 12:01:00 +0100)
are available in the Git repository at:
https://github.com/stefanha/qemu.git tags/tracing-pull-request
for you to fetch changes up to 9f7ad79c16ede0da01902b18fb32929cfbd20f87:
trace: Forbid event format ending with newline character (2019-09-18 10:20:15 +0100)
----------------------------------------------------------------
Pull request
----------------------------------------------------------------
Alexey Kardashevskiy (1):
loader: Trace loaded images
Philippe Mathieu-Daudé (2):
trace: Remove trailing newline in events
trace: Forbid event format ending with newline character
docs/devel/tracing.txt | 2 ++
Makefile.objs | 1 +
hw/core/loader.c | 3 +++
hw/core/trace-events | 2 ++
hw/misc/trace-events | 10 +++++-----
hw/scsi/trace-events | 2 +-
hw/sd/trace-events | 2 +-
nbd/trace-events | 4 ++--
net/trace-events | 6 +++---
scripts/tracetool/__init__.py | 3 +++
10 files changed, 23 insertions(+), 12 deletions(-)
create mode 100644 hw/core/trace-events
--
2.21.0
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [Qemu-devel] [PULL 0/3] Tracing patches
2019-09-18 13:21 Stefan Hajnoczi
@ 2019-09-19 13:37 ` Peter Maydell
0 siblings, 0 replies; 17+ messages in thread
From: Peter Maydell @ 2019-09-19 13:37 UTC (permalink / raw)
To: Stefan Hajnoczi
Cc: Fam Zheng, Qemu-block, Jason Wang, QEMU Developers, Paolo Bonzini
On Wed, 18 Sep 2019 at 14:21, Stefan Hajnoczi <stefanha@redhat.com> wrote:
>
> The following changes since commit f8c3db33a5e863291182f8862ddf81618a7c6194:
>
> target/sparc: Switch to do_transaction_failed() hook (2019-09-17 12:01:00 +0100)
>
> are available in the Git repository at:
>
> https://github.com/stefanha/qemu.git tags/tracing-pull-request
>
> for you to fetch changes up to 9f7ad79c16ede0da01902b18fb32929cfbd20f87:
>
> trace: Forbid event format ending with newline character (2019-09-18 10:20:15 +0100)
>
> ----------------------------------------------------------------
> Pull request
>
> ----------------------------------------------------------------
>
> Alexey Kardashevskiy (1):
> loader: Trace loaded images
>
> Philippe Mathieu-Daudé (2):
> trace: Remove trailing newline in events
> trace: Forbid event format ending with newline character
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/4.2
for any user-visible changes.
-- PMM
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Qemu-devel] [PULL 0/3] Tracing patches
@ 2018-02-19 16:19 Stefan Hajnoczi
2018-02-19 18:40 ` Peter Maydell
0 siblings, 1 reply; 17+ messages in thread
From: Stefan Hajnoczi @ 2018-02-19 16:19 UTC (permalink / raw)
To: qemu-devel; +Cc: Peter Maydell, Stefan Hajnoczi
The following changes since commit e5ecc287a7bd24a1364e23e263cb60cfc8d21eb5:
Merge remote-tracking branch 'remotes/dgilbert/tags/pull-hmp-20180216' into staging (2018-02-16 18:39:05 +0000)
are available in the Git repository at:
git://github.com/stefanha/qemu.git tags/tracing-pull-request
for you to fetch changes up to 7f1d87ab0fd94cef5086e2879716958303281054:
trace: avoid SystemTap "char const" warnings (2018-02-19 13:09:44 +0000)
----------------------------------------------------------------
----------------------------------------------------------------
Jon Emil Jahren (2):
tracetool: Update argument format regex to non-greedy star
tracetool: For ust trace bool type as ctf_integer
Stefan Hajnoczi (1):
trace: avoid SystemTap "char const" warnings
hw/block/trace-events | 4 ++--
scripts/tracetool/__init__.py | 5 +++--
scripts/tracetool/format/ust_events_h.py | 3 ++-
trace-events | 12 ++++++------
4 files changed, 13 insertions(+), 11 deletions(-)
--
2.14.3
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [Qemu-devel] [PULL 0/3] Tracing patches
2018-02-19 16:19 Stefan Hajnoczi
@ 2018-02-19 18:40 ` Peter Maydell
0 siblings, 0 replies; 17+ messages in thread
From: Peter Maydell @ 2018-02-19 18:40 UTC (permalink / raw)
To: Stefan Hajnoczi; +Cc: QEMU Developers
On 19 February 2018 at 16:19, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> The following changes since commit e5ecc287a7bd24a1364e23e263cb60cfc8d21eb5:
>
> Merge remote-tracking branch 'remotes/dgilbert/tags/pull-hmp-20180216' into staging (2018-02-16 18:39:05 +0000)
>
> are available in the Git repository at:
>
> git://github.com/stefanha/qemu.git tags/tracing-pull-request
>
> for you to fetch changes up to 7f1d87ab0fd94cef5086e2879716958303281054:
>
> trace: avoid SystemTap "char const" warnings (2018-02-19 13:09:44 +0000)
>
> ----------------------------------------------------------------
>
> ----------------------------------------------------------------
>
> Jon Emil Jahren (2):
> tracetool: Update argument format regex to non-greedy star
> tracetool: For ust trace bool type as ctf_integer
>
> Stefan Hajnoczi (1):
> trace: avoid SystemTap "char const" warnings
Applied, thanks.
-- PMM
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Qemu-devel] [PULL 0/3] Tracing patches
@ 2018-01-29 16:07 Stefan Hajnoczi
2018-01-29 16:14 ` no-reply
2018-01-30 10:50 ` Peter Maydell
0 siblings, 2 replies; 17+ messages in thread
From: Stefan Hajnoczi @ 2018-01-29 16:07 UTC (permalink / raw)
To: qemu-devel; +Cc: Peter Maydell, Stefan Hajnoczi
The following changes since commit 6233b4a8c2a32ef6955a921246fa08705bbb3676:
Merge remote-tracking branch 'remotes/ericb/tags/pull-nbd-2018-01-26' into staging (2018-01-26 17:29:14 +0000)
are available in the Git repository at:
git://github.com/stefanha/qemu.git tags/tracing-pull-request
for you to fetch changes up to 24f4d3d3aeabf83445839099d6d66cbb3089c37a:
tracetool: report error on foo() instead of foo(void) (2018-01-29 10:34:55 +0000)
----------------------------------------------------------------
----------------------------------------------------------------
Stefan Hajnoczi (3):
tracetool: prefix parse errors with line numbers
tracetool: clarify that "formats" means "format strings"
tracetool: report error on foo() instead of foo(void)
scripts/tracetool/__init__.py | 19 +++++++++++++------
1 file changed, 13 insertions(+), 6 deletions(-)
--
2.14.3
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [Qemu-devel] [PULL 0/3] Tracing patches
2018-01-29 16:07 Stefan Hajnoczi
@ 2018-01-29 16:14 ` no-reply
2018-01-30 11:58 ` Stefan Hajnoczi
2018-01-30 10:50 ` Peter Maydell
1 sibling, 1 reply; 17+ messages in thread
From: no-reply @ 2018-01-29 16:14 UTC (permalink / raw)
To: stefanha; +Cc: famz, qemu-devel, peter.maydell
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180129160740.1195-1-stefanha@redhat.com
Subject: [Qemu-devel] [PULL 0/3] Tracing patches
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
fccfcc6328..0d1442912b master -> master
t [tag update] patchew/20171130164750.47320-1-vsementsov@virtuozzo.com -> patchew/20171130164750.47320-1-vsementsov@virtuozzo.com
* [new tag] patchew/20180129160740.1195-1-stefanha@redhat.com -> patchew/20180129160740.1195-1-stefanha@redhat.com
Switched to a new branch 'test'
8224c195a1 tracetool: report error on foo() instead of foo(void)
511aad4f63 tracetool: clarify that "formats" means "format strings"
cda21c769c tracetool: prefix parse errors with line numbers
=== OUTPUT BEGIN ===
Checking PATCH 1/3: tracetool: prefix parse errors with line numbers...
Checking PATCH 2/3: tracetool: clarify that "formats" means "format strings"...
ERROR: line over 90 characters
#39: FILE: scripts/tracetool/__init__.py:240:
+ raise ValueError("Only events with 'tcg' property can have two format strings")
WARNING: line over 80 characters
#42: FILE: scripts/tracetool/__init__.py:242:
+ raise ValueError("Events with 'tcg' property must have two format strings")
total: 1 errors, 1 warnings, 27 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 3/3: tracetool: report error on foo() instead of foo(void)...
WARNING: line over 80 characters
#26: FILE: scripts/tracetool/__init__.py:79:
+ raise ValueError("Empty argument (did you forget to use 'void'?)")
total: 0 errors, 1 warnings, 8 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [Qemu-devel] [PULL 0/3] Tracing patches
2018-01-29 16:14 ` no-reply
@ 2018-01-30 11:58 ` Stefan Hajnoczi
0 siblings, 0 replies; 17+ messages in thread
From: Stefan Hajnoczi @ 2018-01-30 11:58 UTC (permalink / raw)
To: qemu-devel; +Cc: famz, peter.maydell
[-- Attachment #1: Type: text/plain, Size: 1413 bytes --]
On Mon, Jan 29, 2018 at 08:14:46AM -0800, no-reply@patchew.org wrote:
> === OUTPUT BEGIN ===
> Checking PATCH 1/3: tracetool: prefix parse errors with line numbers...
> Checking PATCH 2/3: tracetool: clarify that "formats" means "format strings"...
> ERROR: line over 90 characters
> #39: FILE: scripts/tracetool/__init__.py:240:
> + raise ValueError("Only events with 'tcg' property can have two format strings")
>
> WARNING: line over 80 characters
> #42: FILE: scripts/tracetool/__init__.py:242:
> + raise ValueError("Events with 'tcg' property must have two format strings")
>
> total: 1 errors, 1 warnings, 27 lines checked
>
> Your patch has style problems, please review. If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
>
> Checking PATCH 3/3: tracetool: report error on foo() instead of foo(void)...
> WARNING: line over 80 characters
> #26: FILE: scripts/tracetool/__init__.py:79:
> + raise ValueError("Empty argument (did you forget to use 'void'?)")
>
> total: 0 errors, 1 warnings, 8 lines checked
>
> Your patch has style problems, please review. If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> === OUTPUT END ===
For the record, I didn't wrap these error messages so that grep(1)
works.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [Qemu-devel] [PULL 0/3] Tracing patches
2018-01-29 16:07 Stefan Hajnoczi
2018-01-29 16:14 ` no-reply
@ 2018-01-30 10:50 ` Peter Maydell
1 sibling, 0 replies; 17+ messages in thread
From: Peter Maydell @ 2018-01-30 10:50 UTC (permalink / raw)
To: Stefan Hajnoczi; +Cc: QEMU Developers
On 29 January 2018 at 16:07, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> The following changes since commit 6233b4a8c2a32ef6955a921246fa08705bbb3676:
>
> Merge remote-tracking branch 'remotes/ericb/tags/pull-nbd-2018-01-26' into staging (2018-01-26 17:29:14 +0000)
>
> are available in the Git repository at:
>
> git://github.com/stefanha/qemu.git tags/tracing-pull-request
>
> for you to fetch changes up to 24f4d3d3aeabf83445839099d6d66cbb3089c37a:
>
> tracetool: report error on foo() instead of foo(void) (2018-01-29 10:34:55 +0000)
>
> ----------------------------------------------------------------
>
> ----------------------------------------------------------------
>
> Stefan Hajnoczi (3):
> tracetool: prefix parse errors with line numbers
> tracetool: clarify that "formats" means "format strings"
> tracetool: report error on foo() instead of foo(void)
>
> scripts/tracetool/__init__.py | 19 +++++++++++++------
> 1 file changed, 13 insertions(+), 6 deletions(-)
Applied, thanks.
-- PMM
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Qemu-devel] [PULL 0/3] Tracing patches
@ 2017-03-16 7:04 Stefan Hajnoczi
2017-03-16 15:31 ` Peter Maydell
0 siblings, 1 reply; 17+ messages in thread
From: Stefan Hajnoczi @ 2017-03-16 7:04 UTC (permalink / raw)
To: qemu-devel; +Cc: Peter Maydell, Stefan Hajnoczi
The following changes since commit 1883ff34b540daacae948f493b0ba525edf5f642:
Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2017-03-15 18:44:05 +0000)
are available in the git repository at:
git://github.com/stefanha/qemu.git tags/tracing-pull-request
for you to fetch changes up to 8755b4afbdcf1c274cab7545a9f76d3d6c7f5c29:
trace: ensure $(tracetool-y) is defined in top level makefile (2017-03-16 11:51:26 +0800)
----------------------------------------------------------------
Pull request
Tracing makefile fixes for QEMU 2.9.
----------------------------------------------------------------
Daniel P. Berrange (3):
makefile: merge GENERATED_HEADERS & GENERATED_SOURCES variables
makefile: generate trace-events-all upfront
trace: ensure $(tracetool-y) is defined in top level makefile
Makefile | 42 ++++++++++++++++++++++--------------------
Makefile.target | 6 +++---
target/s390x/Makefile.objs | 2 +-
tests/Makefile.include | 2 +-
trace/Makefile.objs | 8 --------
5 files changed, 27 insertions(+), 33 deletions(-)
--
2.9.3
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [Qemu-devel] [PULL 0/3] Tracing patches
2017-03-16 7:04 Stefan Hajnoczi
@ 2017-03-16 15:31 ` Peter Maydell
0 siblings, 0 replies; 17+ messages in thread
From: Peter Maydell @ 2017-03-16 15:31 UTC (permalink / raw)
To: Stefan Hajnoczi; +Cc: QEMU Developers
On 16 March 2017 at 07:04, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> The following changes since commit 1883ff34b540daacae948f493b0ba525edf5f642:
>
> Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2017-03-15 18:44:05 +0000)
>
> are available in the git repository at:
>
> git://github.com/stefanha/qemu.git tags/tracing-pull-request
>
> for you to fetch changes up to 8755b4afbdcf1c274cab7545a9f76d3d6c7f5c29:
>
> trace: ensure $(tracetool-y) is defined in top level makefile (2017-03-16 11:51:26 +0800)
>
> ----------------------------------------------------------------
> Pull request
>
> Tracing makefile fixes for QEMU 2.9.
>
> ----------------------------------------------------------------
>
> Daniel P. Berrange (3):
> makefile: merge GENERATED_HEADERS & GENERATED_SOURCES variables
> makefile: generate trace-events-all upfront
> trace: ensure $(tracetool-y) is defined in top level makefile
>
> Makefile | 42 ++++++++++++++++++++++--------------------
> Makefile.target | 6 +++---
> target/s390x/Makefile.objs | 2 +-
> tests/Makefile.include | 2 +-
> trace/Makefile.objs | 8 --------
> 5 files changed, 27 insertions(+), 33 deletions(-)
Applied, thanks.
-- PMM
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Qemu-devel] [PULL 0/3] Tracing patches
@ 2012-03-30 10:58 Stefan Hajnoczi
2012-04-02 15:52 ` Anthony Liguori
0 siblings, 1 reply; 17+ messages in thread
From: Stefan Hajnoczi @ 2012-03-30 10:58 UTC (permalink / raw)
To: Anthony Liguori; +Cc: qemu-devel, Stefan Hajnoczi
The latest tracing fixes.
Alon Levy (2):
Makefile.target: code stp dependency on trace-events
tracetool: dtrace: handle in and next reserved words
Lee Essen (1):
tracetool: dtrace disabled-events fix
Makefile.target | 2 +-
scripts/tracetool | 22 ++++++++++++++++++----
2 files changed, 19 insertions(+), 5 deletions(-)
--
1.7.9.1
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [Qemu-devel] [PULL 0/3] Tracing patches
2012-03-30 10:58 Stefan Hajnoczi
@ 2012-04-02 15:52 ` Anthony Liguori
0 siblings, 0 replies; 17+ messages in thread
From: Anthony Liguori @ 2012-04-02 15:52 UTC (permalink / raw)
To: Stefan Hajnoczi; +Cc: qemu-devel
On 03/30/2012 05:58 AM, Stefan Hajnoczi wrote:
> The latest tracing fixes.
>
> Alon Levy (2):
> Makefile.target: code stp dependency on trace-events
> tracetool: dtrace: handle in and next reserved words
>
> Lee Essen (1):
> tracetool: dtrace disabled-events fix
Pulled. Thanks.
Regards,
Anthony Liguori
>
> Makefile.target | 2 +-
> scripts/tracetool | 22 ++++++++++++++++++----
> 2 files changed, 19 insertions(+), 5 deletions(-)
>
^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2019-09-19 13:55 UTC | newest]
Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-05 19:42 [Qemu-devel] [PULL 0/3] Tracing patches Stefan Hajnoczi
2016-09-05 19:42 ` [Qemu-devel] [PULL 1/3] trace: add syslog tracing backend Stefan Hajnoczi
2016-09-05 19:42 ` [Qemu-devel] [PULL 2/3] trace: Remove 'trace_events_dstate_init' Stefan Hajnoczi
2016-09-05 19:42 ` [Qemu-devel] [PULL 3/3] trace: Avoid implicit bool->integer conversions Stefan Hajnoczi
2016-09-06 12:32 ` [Qemu-devel] [PULL 0/3] Tracing patches Peter Maydell
-- strict thread matches above, loose matches on Subject: below --
2019-09-18 13:21 Stefan Hajnoczi
2019-09-19 13:37 ` Peter Maydell
2018-02-19 16:19 Stefan Hajnoczi
2018-02-19 18:40 ` Peter Maydell
2018-01-29 16:07 Stefan Hajnoczi
2018-01-29 16:14 ` no-reply
2018-01-30 11:58 ` Stefan Hajnoczi
2018-01-30 10:50 ` Peter Maydell
2017-03-16 7:04 Stefan Hajnoczi
2017-03-16 15:31 ` Peter Maydell
2012-03-30 10:58 Stefan Hajnoczi
2012-04-02 15:52 ` Anthony Liguori
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.