* [Qemu-devel] [PULL 0/3] Tracing patches @ 2018-02-19 16:19 Stefan Hajnoczi 2018-02-19 16:19 ` [Qemu-devel] [PULL 1/3] tracetool: Update argument format regex to non-greedy star Stefan Hajnoczi ` (3 more replies) 0 siblings, 4 replies; 17+ messages in thread From: Stefan Hajnoczi @ 2018-02-19 16:19 UTC (permalink / raw) To: qemu-devel; +Cc: Peter Maydell, Stefan Hajnoczi The following changes since commit e5ecc287a7bd24a1364e23e263cb60cfc8d21eb5: Merge remote-tracking branch 'remotes/dgilbert/tags/pull-hmp-20180216' into staging (2018-02-16 18:39:05 +0000) are available in the Git repository at: git://github.com/stefanha/qemu.git tags/tracing-pull-request for you to fetch changes up to 7f1d87ab0fd94cef5086e2879716958303281054: trace: avoid SystemTap "char const" warnings (2018-02-19 13:09:44 +0000) ---------------------------------------------------------------- ---------------------------------------------------------------- Jon Emil Jahren (2): tracetool: Update argument format regex to non-greedy star tracetool: For ust trace bool type as ctf_integer Stefan Hajnoczi (1): trace: avoid SystemTap "char const" warnings hw/block/trace-events | 4 ++-- scripts/tracetool/__init__.py | 5 +++-- scripts/tracetool/format/ust_events_h.py | 3 ++- trace-events | 12 ++++++------ 4 files changed, 13 insertions(+), 11 deletions(-) -- 2.14.3 ^ permalink raw reply [flat|nested] 17+ messages in thread
* [Qemu-devel] [PULL 1/3] tracetool: Update argument format regex to non-greedy star 2018-02-19 16:19 [Qemu-devel] [PULL 0/3] Tracing patches Stefan Hajnoczi @ 2018-02-19 16:19 ` Stefan Hajnoczi 2018-02-19 16:19 ` [Qemu-devel] [PULL 2/3] tracetool: For ust trace bool type as ctf_integer Stefan Hajnoczi ` (2 subsequent siblings) 3 siblings, 0 replies; 17+ messages in thread From: Stefan Hajnoczi @ 2018-02-19 16:19 UTC (permalink / raw) To: qemu-devel; +Cc: Peter Maydell, Jon Emil Jahren, Stefan Hajnoczi From: Jon Emil Jahren <jonemilj@gmail.com> Using the greedy star matching, arguments like "...%"PRIx64 caused issues for functions with multiple PRI formats. The issue was only seen with the ust backend, as it is the only one using the format regex. The result for many functions was that the arguments coming after the greedy star end was left out of the tracepoint, and in some cases some of the arguments that was traced had the wrong format. Signed-off-by: Jon Emil Jahren <jonemilj@gmail.com> Message-id: 20180129041648.30884-2-jonemilj@gmail.com Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> --- scripts/tracetool/__init__.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/scripts/tracetool/__init__.py b/scripts/tracetool/__init__.py index 1a9733da9a..3646c2b9fc 100644 --- a/scripts/tracetool/__init__.py +++ b/scripts/tracetool/__init__.py @@ -261,8 +261,9 @@ class Event(object): self.name, self.args, fmt) - - _FMT = re.compile("(%[\d\.]*\w+|%.*PRI\S+)") + # Star matching on PRI is dangerous as one might have multiple + # arguments with that format, hence the non-greedy version of it. + _FMT = re.compile("(%[\d\.]*\w+|%.*?PRI\S+)") def formats(self): """List conversion specifiers in the argument print format string.""" -- 2.14.3 ^ permalink raw reply related [flat|nested] 17+ messages in thread
* [Qemu-devel] [PULL 2/3] tracetool: For ust trace bool type as ctf_integer 2018-02-19 16:19 [Qemu-devel] [PULL 0/3] Tracing patches Stefan Hajnoczi 2018-02-19 16:19 ` [Qemu-devel] [PULL 1/3] tracetool: Update argument format regex to non-greedy star Stefan Hajnoczi @ 2018-02-19 16:19 ` Stefan Hajnoczi 2018-02-19 16:19 ` [Qemu-devel] [PULL 3/3] trace: avoid SystemTap "char const" warnings Stefan Hajnoczi 2018-02-19 18:40 ` [Qemu-devel] [PULL 0/3] Tracing patches Peter Maydell 3 siblings, 0 replies; 17+ messages in thread From: Stefan Hajnoczi @ 2018-02-19 16:19 UTC (permalink / raw) To: qemu-devel; +Cc: Peter Maydell, Jon Emil Jahren, Stefan Hajnoczi From: Jon Emil Jahren <jonemilj@gmail.com> Previously functions having arguments of type bool was not traced properly. The bool arguments were missing from the trace. Signed-off-by: Jon Emil Jahren <jonemilj@gmail.com> Message-id: 20180129041648.30884-3-jonemilj@gmail.com Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> --- scripts/tracetool/format/ust_events_h.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/tracetool/format/ust_events_h.py b/scripts/tracetool/format/ust_events_h.py index 514294c2cc..4e95e9b3f9 100644 --- a/scripts/tracetool/format/ust_events_h.py +++ b/scripts/tracetool/format/ust_events_h.py @@ -79,7 +79,8 @@ def generate(events, backend, group): out(' ctf_integer_hex('+ t + ', ' + n + ', ' + n + ')') elif ("ptr" in t) or ("*" in t): out(' ctf_integer_hex('+ t + ', ' + n + ', ' + n + ')') - elif ('int' in t) or ('long' in t) or ('unsigned' in t) or ('size_t' in t): + elif ('int' in t) or ('long' in t) or ('unsigned' in t) \ + or ('size_t' in t) or ('bool' in t): out(' ctf_integer(' + t + ', ' + n + ', ' + n + ')') elif ('double' in t) or ('float' in t): out(' ctf_float(' + t + ', ' + n + ', ' + n + ')') -- 2.14.3 ^ permalink raw reply related [flat|nested] 17+ messages in thread
* [Qemu-devel] [PULL 3/3] trace: avoid SystemTap "char const" warnings 2018-02-19 16:19 [Qemu-devel] [PULL 0/3] Tracing patches Stefan Hajnoczi 2018-02-19 16:19 ` [Qemu-devel] [PULL 1/3] tracetool: Update argument format regex to non-greedy star Stefan Hajnoczi 2018-02-19 16:19 ` [Qemu-devel] [PULL 2/3] tracetool: For ust trace bool type as ctf_integer Stefan Hajnoczi @ 2018-02-19 16:19 ` Stefan Hajnoczi 2018-02-19 18:40 ` [Qemu-devel] [PULL 0/3] Tracing patches Peter Maydell 3 siblings, 0 replies; 17+ messages in thread From: Stefan Hajnoczi @ 2018-02-19 16:19 UTC (permalink / raw) To: qemu-devel; +Cc: Peter Maydell, Stefan Hajnoczi, Daniel P . Berrange SystemTap's dtrace(1) produces the following warning when it encounters "char const" instead of "const char": Warning: /usr/bin/dtrace:trace-dtrace-root.dtrace:66: syntax error near: probe flatview_destroy_rcu Warning: Proceeding as if --no-pyparsing was given. This is a limitation in current SystemTap releases. I have sent a patch upstream to accept "char const" since it is valid C: https://sourceware.org/ml/systemtap/2018-q1/msg00017.html In QEMU we still wish to avoid warnings in the current SystemTap release. It's simple enough to replace "char const" with "const char". I'm not changing the documentation or implementing checks to prevent this from occurring again in the future. The next release of SystemTap will hopefully resolve this issue. Cc: Daniel P. Berrange <berrange@redhat.com> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> Reviewed-by: Daniel P. Berrange <berrange@redhat.com> Message-id: 20180201162625.4276-1-stefanha@redhat.com Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> --- hw/block/trace-events | 4 ++-- trace-events | 12 ++++++------ 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/hw/block/trace-events b/hw/block/trace-events index 5acd495207..6b9e733412 100644 --- a/hw/block/trace-events +++ b/hw/block/trace-events @@ -17,7 +17,7 @@ nvme_irq_msix(uint32_t vector) "raising MSI-X IRQ vector %u" nvme_irq_pin(void) "pulsing IRQ pin" nvme_irq_masked(void) "IRQ is masked" nvme_dma_read(uint64_t prp1, uint64_t prp2) "DMA read, prp1=0x%"PRIx64" prp2=0x%"PRIx64"" -nvme_rw(char const *verb, uint32_t blk_count, uint64_t byte_count, uint64_t lba) "%s %"PRIu32" blocks (%"PRIu64" bytes) from LBA %"PRIu64"" +nvme_rw(const char *verb, uint32_t blk_count, uint64_t byte_count, uint64_t lba) "%s %"PRIu32" blocks (%"PRIu64" bytes) from LBA %"PRIu64"" nvme_create_sq(uint64_t addr, uint16_t sqid, uint16_t cqid, uint16_t qsize, uint16_t qflags) "create submission queue, addr=0x%"PRIx64", sqid=%"PRIu16", cqid=%"PRIu16", qsize=%"PRIu16", qflags=%"PRIu16"" nvme_create_cq(uint64_t addr, uint16_t cqid, uint16_t vector, uint16_t size, uint16_t qflags, int ien) "create completion queue, addr=0x%"PRIx64", cqid=%"PRIu16", vector=%"PRIu16", qsize=%"PRIu16", qflags=%"PRIu16", ien=%d" nvme_del_sq(uint16_t qid) "deleting submission queue sqid=%"PRIu16"" @@ -25,7 +25,7 @@ nvme_del_cq(uint16_t cqid) "deleted completion queue, sqid=%"PRIu16"" nvme_identify_ctrl(void) "identify controller" nvme_identify_ns(uint16_t ns) "identify namespace, nsid=%"PRIu16"" nvme_identify_nslist(uint16_t ns) "identify namespace list, nsid=%"PRIu16"" -nvme_getfeat_vwcache(char const* result) "get feature volatile write cache, result=%s" +nvme_getfeat_vwcache(const char* result) "get feature volatile write cache, result=%s" nvme_getfeat_numq(int result) "get feature number of queues, result=%d" nvme_setfeat_numq(int reqcq, int reqsq, int gotcq, int gotsq) "requested cq_count=%d sq_count=%d, responding with cq_count=%d sq_count=%d" nvme_mmio_intm_set(uint64_t data, uint64_t new_mask) "wrote MMIO, interrupt mask set, data=0x%"PRIx64", new_mask=0x%"PRIx64"" diff --git a/trace-events b/trace-events index ec95e67089..89fcad0fd1 100644 --- a/trace-events +++ b/trace-events @@ -73,13 +73,13 @@ flatview_destroy(FlatView *view, MemoryRegion *root) "%p (root %p)" flatview_destroy_rcu(FlatView *view, MemoryRegion *root) "%p (root %p)" # gdbstub.c -gdbstub_op_start(char const *device) "Starting gdbstub using device %s" +gdbstub_op_start(const char *device) "Starting gdbstub using device %s" gdbstub_op_exiting(uint8_t code) "notifying exit with code=0x%02x" gdbstub_op_continue(void) "Continuing all CPUs" gdbstub_op_continue_cpu(int cpu_index) "Continuing CPU %d" gdbstub_op_stepping(int cpu_index) "Stepping CPU %d" -gdbstub_op_extra_info(char const *info) "Thread extra info: %s" -gdbstub_hit_watchpoint(char const *type, int cpu_gdb_index, uint64_t vaddr) "Watchpoint hit, type=\"%s\" cpu=%d, vaddr=0x%" PRIx64 "" +gdbstub_op_extra_info(const char *info) "Thread extra info: %s" +gdbstub_hit_watchpoint(const char *type, int cpu_gdb_index, uint64_t vaddr) "Watchpoint hit, type=\"%s\" cpu=%d, vaddr=0x%" PRIx64 "" gdbstub_hit_internal_error(void) "RUN_STATE_INTERNAL_ERROR" gdbstub_hit_break(void) "RUN_STATE_DEBUG" gdbstub_hit_paused(void) "RUN_STATE_PAUSED" @@ -87,9 +87,9 @@ gdbstub_hit_shutdown(void) "RUN_STATE_SHUTDOWN" gdbstub_hit_io_error(void) "RUN_STATE_IO_ERROR" gdbstub_hit_watchdog(void) "RUN_STATE_WATCHDOG" gdbstub_hit_unknown(int state) "Unknown run state=0x%x" -gdbstub_io_reply(char const *message) "Sent: %s" -gdbstub_io_binaryreply(size_t ofs, char const *line) "0x%04zx: %s" -gdbstub_io_command(char const *command) "Received: %s" +gdbstub_io_reply(const char *message) "Sent: %s" +gdbstub_io_binaryreply(size_t ofs, const char *line) "0x%04zx: %s" +gdbstub_io_command(const char *command) "Received: %s" gdbstub_io_got_ack(void) "Got ACK" gdbstub_io_got_unexpected(uint8_t ch) "Got 0x%02x when expecting ACK/NACK" gdbstub_err_got_nack(void) "Got NACK, retransmitting" -- 2.14.3 ^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [Qemu-devel] [PULL 0/3] Tracing patches 2018-02-19 16:19 [Qemu-devel] [PULL 0/3] Tracing patches Stefan Hajnoczi ` (2 preceding siblings ...) 2018-02-19 16:19 ` [Qemu-devel] [PULL 3/3] trace: avoid SystemTap "char const" warnings Stefan Hajnoczi @ 2018-02-19 18:40 ` Peter Maydell 3 siblings, 0 replies; 17+ messages in thread From: Peter Maydell @ 2018-02-19 18:40 UTC (permalink / raw) To: Stefan Hajnoczi; +Cc: QEMU Developers On 19 February 2018 at 16:19, Stefan Hajnoczi <stefanha@redhat.com> wrote: > The following changes since commit e5ecc287a7bd24a1364e23e263cb60cfc8d21eb5: > > Merge remote-tracking branch 'remotes/dgilbert/tags/pull-hmp-20180216' into staging (2018-02-16 18:39:05 +0000) > > are available in the Git repository at: > > git://github.com/stefanha/qemu.git tags/tracing-pull-request > > for you to fetch changes up to 7f1d87ab0fd94cef5086e2879716958303281054: > > trace: avoid SystemTap "char const" warnings (2018-02-19 13:09:44 +0000) > > ---------------------------------------------------------------- > > ---------------------------------------------------------------- > > Jon Emil Jahren (2): > tracetool: Update argument format regex to non-greedy star > tracetool: For ust trace bool type as ctf_integer > > Stefan Hajnoczi (1): > trace: avoid SystemTap "char const" warnings Applied, thanks. -- PMM ^ permalink raw reply [flat|nested] 17+ messages in thread
* [Qemu-devel] [PULL 0/3] Tracing patches @ 2019-09-18 13:21 Stefan Hajnoczi 2019-09-19 13:37 ` Peter Maydell 0 siblings, 1 reply; 17+ messages in thread From: Stefan Hajnoczi @ 2019-09-18 13:21 UTC (permalink / raw) To: qemu-devel Cc: Fam Zheng, Peter Maydell, qemu-block, Jason Wang, Stefan Hajnoczi, Paolo Bonzini The following changes since commit f8c3db33a5e863291182f8862ddf81618a7c6194: target/sparc: Switch to do_transaction_failed() hook (2019-09-17 12:01:00 +0100) are available in the Git repository at: https://github.com/stefanha/qemu.git tags/tracing-pull-request for you to fetch changes up to 9f7ad79c16ede0da01902b18fb32929cfbd20f87: trace: Forbid event format ending with newline character (2019-09-18 10:20:15 +0100) ---------------------------------------------------------------- Pull request ---------------------------------------------------------------- Alexey Kardashevskiy (1): loader: Trace loaded images Philippe Mathieu-Daudé (2): trace: Remove trailing newline in events trace: Forbid event format ending with newline character docs/devel/tracing.txt | 2 ++ Makefile.objs | 1 + hw/core/loader.c | 3 +++ hw/core/trace-events | 2 ++ hw/misc/trace-events | 10 +++++----- hw/scsi/trace-events | 2 +- hw/sd/trace-events | 2 +- nbd/trace-events | 4 ++-- net/trace-events | 6 +++--- scripts/tracetool/__init__.py | 3 +++ 10 files changed, 23 insertions(+), 12 deletions(-) create mode 100644 hw/core/trace-events -- 2.21.0 ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [Qemu-devel] [PULL 0/3] Tracing patches 2019-09-18 13:21 Stefan Hajnoczi @ 2019-09-19 13:37 ` Peter Maydell 0 siblings, 0 replies; 17+ messages in thread From: Peter Maydell @ 2019-09-19 13:37 UTC (permalink / raw) To: Stefan Hajnoczi Cc: Fam Zheng, Qemu-block, Jason Wang, QEMU Developers, Paolo Bonzini On Wed, 18 Sep 2019 at 14:21, Stefan Hajnoczi <stefanha@redhat.com> wrote: > > The following changes since commit f8c3db33a5e863291182f8862ddf81618a7c6194: > > target/sparc: Switch to do_transaction_failed() hook (2019-09-17 12:01:00 +0100) > > are available in the Git repository at: > > https://github.com/stefanha/qemu.git tags/tracing-pull-request > > for you to fetch changes up to 9f7ad79c16ede0da01902b18fb32929cfbd20f87: > > trace: Forbid event format ending with newline character (2019-09-18 10:20:15 +0100) > > ---------------------------------------------------------------- > Pull request > > ---------------------------------------------------------------- > > Alexey Kardashevskiy (1): > loader: Trace loaded images > > Philippe Mathieu-Daudé (2): > trace: Remove trailing newline in events > trace: Forbid event format ending with newline character Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/4.2 for any user-visible changes. -- PMM ^ permalink raw reply [flat|nested] 17+ messages in thread
* [Qemu-devel] [PULL 0/3] Tracing patches @ 2018-01-29 16:07 Stefan Hajnoczi 2018-01-29 16:14 ` no-reply 2018-01-30 10:50 ` Peter Maydell 0 siblings, 2 replies; 17+ messages in thread From: Stefan Hajnoczi @ 2018-01-29 16:07 UTC (permalink / raw) To: qemu-devel; +Cc: Peter Maydell, Stefan Hajnoczi The following changes since commit 6233b4a8c2a32ef6955a921246fa08705bbb3676: Merge remote-tracking branch 'remotes/ericb/tags/pull-nbd-2018-01-26' into staging (2018-01-26 17:29:14 +0000) are available in the Git repository at: git://github.com/stefanha/qemu.git tags/tracing-pull-request for you to fetch changes up to 24f4d3d3aeabf83445839099d6d66cbb3089c37a: tracetool: report error on foo() instead of foo(void) (2018-01-29 10:34:55 +0000) ---------------------------------------------------------------- ---------------------------------------------------------------- Stefan Hajnoczi (3): tracetool: prefix parse errors with line numbers tracetool: clarify that "formats" means "format strings" tracetool: report error on foo() instead of foo(void) scripts/tracetool/__init__.py | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) -- 2.14.3 ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [Qemu-devel] [PULL 0/3] Tracing patches 2018-01-29 16:07 Stefan Hajnoczi @ 2018-01-29 16:14 ` no-reply 2018-01-30 11:58 ` Stefan Hajnoczi 2018-01-30 10:50 ` Peter Maydell 1 sibling, 1 reply; 17+ messages in thread From: no-reply @ 2018-01-29 16:14 UTC (permalink / raw) To: stefanha; +Cc: famz, qemu-devel, peter.maydell Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180129160740.1195-1-stefanha@redhat.com Subject: [Qemu-devel] [PULL 0/3] Tracing patches === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu fccfcc6328..0d1442912b master -> master t [tag update] patchew/20171130164750.47320-1-vsementsov@virtuozzo.com -> patchew/20171130164750.47320-1-vsementsov@virtuozzo.com * [new tag] patchew/20180129160740.1195-1-stefanha@redhat.com -> patchew/20180129160740.1195-1-stefanha@redhat.com Switched to a new branch 'test' 8224c195a1 tracetool: report error on foo() instead of foo(void) 511aad4f63 tracetool: clarify that "formats" means "format strings" cda21c769c tracetool: prefix parse errors with line numbers === OUTPUT BEGIN === Checking PATCH 1/3: tracetool: prefix parse errors with line numbers... Checking PATCH 2/3: tracetool: clarify that "formats" means "format strings"... ERROR: line over 90 characters #39: FILE: scripts/tracetool/__init__.py:240: + raise ValueError("Only events with 'tcg' property can have two format strings") WARNING: line over 80 characters #42: FILE: scripts/tracetool/__init__.py:242: + raise ValueError("Events with 'tcg' property must have two format strings") total: 1 errors, 1 warnings, 27 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 3/3: tracetool: report error on foo() instead of foo(void)... WARNING: line over 80 characters #26: FILE: scripts/tracetool/__init__.py:79: + raise ValueError("Empty argument (did you forget to use 'void'?)") total: 0 errors, 1 warnings, 8 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@freelists.org ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [Qemu-devel] [PULL 0/3] Tracing patches 2018-01-29 16:14 ` no-reply @ 2018-01-30 11:58 ` Stefan Hajnoczi 0 siblings, 0 replies; 17+ messages in thread From: Stefan Hajnoczi @ 2018-01-30 11:58 UTC (permalink / raw) To: qemu-devel; +Cc: famz, peter.maydell [-- Attachment #1: Type: text/plain, Size: 1413 bytes --] On Mon, Jan 29, 2018 at 08:14:46AM -0800, no-reply@patchew.org wrote: > === OUTPUT BEGIN === > Checking PATCH 1/3: tracetool: prefix parse errors with line numbers... > Checking PATCH 2/3: tracetool: clarify that "formats" means "format strings"... > ERROR: line over 90 characters > #39: FILE: scripts/tracetool/__init__.py:240: > + raise ValueError("Only events with 'tcg' property can have two format strings") > > WARNING: line over 80 characters > #42: FILE: scripts/tracetool/__init__.py:242: > + raise ValueError("Events with 'tcg' property must have two format strings") > > total: 1 errors, 1 warnings, 27 lines checked > > Your patch has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > > Checking PATCH 3/3: tracetool: report error on foo() instead of foo(void)... > WARNING: line over 80 characters > #26: FILE: scripts/tracetool/__init__.py:79: > + raise ValueError("Empty argument (did you forget to use 'void'?)") > > total: 0 errors, 1 warnings, 8 lines checked > > Your patch has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > === OUTPUT END === For the record, I didn't wrap these error messages so that grep(1) works. Stefan [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 455 bytes --] ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [Qemu-devel] [PULL 0/3] Tracing patches 2018-01-29 16:07 Stefan Hajnoczi 2018-01-29 16:14 ` no-reply @ 2018-01-30 10:50 ` Peter Maydell 1 sibling, 0 replies; 17+ messages in thread From: Peter Maydell @ 2018-01-30 10:50 UTC (permalink / raw) To: Stefan Hajnoczi; +Cc: QEMU Developers On 29 January 2018 at 16:07, Stefan Hajnoczi <stefanha@redhat.com> wrote: > The following changes since commit 6233b4a8c2a32ef6955a921246fa08705bbb3676: > > Merge remote-tracking branch 'remotes/ericb/tags/pull-nbd-2018-01-26' into staging (2018-01-26 17:29:14 +0000) > > are available in the Git repository at: > > git://github.com/stefanha/qemu.git tags/tracing-pull-request > > for you to fetch changes up to 24f4d3d3aeabf83445839099d6d66cbb3089c37a: > > tracetool: report error on foo() instead of foo(void) (2018-01-29 10:34:55 +0000) > > ---------------------------------------------------------------- > > ---------------------------------------------------------------- > > Stefan Hajnoczi (3): > tracetool: prefix parse errors with line numbers > tracetool: clarify that "formats" means "format strings" > tracetool: report error on foo() instead of foo(void) > > scripts/tracetool/__init__.py | 19 +++++++++++++------ > 1 file changed, 13 insertions(+), 6 deletions(-) Applied, thanks. -- PMM ^ permalink raw reply [flat|nested] 17+ messages in thread
* [Qemu-devel] [PULL 0/3] Tracing patches @ 2017-03-16 7:04 Stefan Hajnoczi 2017-03-16 15:31 ` Peter Maydell 0 siblings, 1 reply; 17+ messages in thread From: Stefan Hajnoczi @ 2017-03-16 7:04 UTC (permalink / raw) To: qemu-devel; +Cc: Peter Maydell, Stefan Hajnoczi The following changes since commit 1883ff34b540daacae948f493b0ba525edf5f642: Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2017-03-15 18:44:05 +0000) are available in the git repository at: git://github.com/stefanha/qemu.git tags/tracing-pull-request for you to fetch changes up to 8755b4afbdcf1c274cab7545a9f76d3d6c7f5c29: trace: ensure $(tracetool-y) is defined in top level makefile (2017-03-16 11:51:26 +0800) ---------------------------------------------------------------- Pull request Tracing makefile fixes for QEMU 2.9. ---------------------------------------------------------------- Daniel P. Berrange (3): makefile: merge GENERATED_HEADERS & GENERATED_SOURCES variables makefile: generate trace-events-all upfront trace: ensure $(tracetool-y) is defined in top level makefile Makefile | 42 ++++++++++++++++++++++-------------------- Makefile.target | 6 +++--- target/s390x/Makefile.objs | 2 +- tests/Makefile.include | 2 +- trace/Makefile.objs | 8 -------- 5 files changed, 27 insertions(+), 33 deletions(-) -- 2.9.3 ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [Qemu-devel] [PULL 0/3] Tracing patches 2017-03-16 7:04 Stefan Hajnoczi @ 2017-03-16 15:31 ` Peter Maydell 0 siblings, 0 replies; 17+ messages in thread From: Peter Maydell @ 2017-03-16 15:31 UTC (permalink / raw) To: Stefan Hajnoczi; +Cc: QEMU Developers On 16 March 2017 at 07:04, Stefan Hajnoczi <stefanha@redhat.com> wrote: > The following changes since commit 1883ff34b540daacae948f493b0ba525edf5f642: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2017-03-15 18:44:05 +0000) > > are available in the git repository at: > > git://github.com/stefanha/qemu.git tags/tracing-pull-request > > for you to fetch changes up to 8755b4afbdcf1c274cab7545a9f76d3d6c7f5c29: > > trace: ensure $(tracetool-y) is defined in top level makefile (2017-03-16 11:51:26 +0800) > > ---------------------------------------------------------------- > Pull request > > Tracing makefile fixes for QEMU 2.9. > > ---------------------------------------------------------------- > > Daniel P. Berrange (3): > makefile: merge GENERATED_HEADERS & GENERATED_SOURCES variables > makefile: generate trace-events-all upfront > trace: ensure $(tracetool-y) is defined in top level makefile > > Makefile | 42 ++++++++++++++++++++++-------------------- > Makefile.target | 6 +++--- > target/s390x/Makefile.objs | 2 +- > tests/Makefile.include | 2 +- > trace/Makefile.objs | 8 -------- > 5 files changed, 27 insertions(+), 33 deletions(-) Applied, thanks. -- PMM ^ permalink raw reply [flat|nested] 17+ messages in thread
* [Qemu-devel] [PULL 0/3] Tracing patches @ 2016-09-05 19:42 Stefan Hajnoczi 2016-09-06 12:32 ` Peter Maydell 0 siblings, 1 reply; 17+ messages in thread From: Stefan Hajnoczi @ 2016-09-05 19:42 UTC (permalink / raw) To: qemu-devel; +Cc: Peter Maydell, Stefan Hajnoczi The following changes since commit e87d397e5ef66276ccc49b829527d605ca07d0ad: Open 2.8 development tree (2016-09-05 11:38:54 +0100) are available in the git repository at: git://github.com/stefanha/qemu.git tags/tracing-pull-request for you to fetch changes up to 8eb1b9db559e243043aaeac3a0aa97e1f4a403c4: trace: Avoid implicit bool->integer conversions (2016-09-05 13:47:02 -0400) ---------------------------------------------------------------- ---------------------------------------------------------------- Lluís Vilanova (2): trace: Remove 'trace_events_dstate_init' trace: Avoid implicit bool->integer conversions Paul Durrant (1): trace: add syslog tracing backend configure | 19 ++++++++++++++++ docs/tracing.txt | 12 ++++++++++ scripts/tracetool/backend/syslog.py | 45 +++++++++++++++++++++++++++++++++++++ stubs/trace-control.c | 22 ++++++++++++++++-- trace/control-target.c | 34 ++++++++++++++++++++++++++-- trace/control.c | 28 ++++++++++++++--------- trace/control.h | 3 +++ trace/event-internal.h | 1 + 8 files changed, 149 insertions(+), 15 deletions(-) create mode 100644 scripts/tracetool/backend/syslog.py -- 2.7.4 ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [Qemu-devel] [PULL 0/3] Tracing patches 2016-09-05 19:42 Stefan Hajnoczi @ 2016-09-06 12:32 ` Peter Maydell 0 siblings, 0 replies; 17+ messages in thread From: Peter Maydell @ 2016-09-06 12:32 UTC (permalink / raw) To: Stefan Hajnoczi; +Cc: QEMU Developers On 5 September 2016 at 20:42, Stefan Hajnoczi <stefanha@redhat.com> wrote: > The following changes since commit e87d397e5ef66276ccc49b829527d605ca07d0ad: > > Open 2.8 development tree (2016-09-05 11:38:54 +0100) > > are available in the git repository at: > > git://github.com/stefanha/qemu.git tags/tracing-pull-request > > for you to fetch changes up to 8eb1b9db559e243043aaeac3a0aa97e1f4a403c4: > > trace: Avoid implicit bool->integer conversions (2016-09-05 13:47:02 -0400) > > ---------------------------------------------------------------- > > ---------------------------------------------------------------- > > Lluís Vilanova (2): > trace: Remove 'trace_events_dstate_init' > trace: Avoid implicit bool->integer conversions > > Paul Durrant (1): > trace: add syslog tracing backend Applied, thanks. -- PMM ^ permalink raw reply [flat|nested] 17+ messages in thread
* [Qemu-devel] [PULL 0/3] Tracing patches @ 2012-03-30 10:58 Stefan Hajnoczi 2012-04-02 15:52 ` Anthony Liguori 0 siblings, 1 reply; 17+ messages in thread From: Stefan Hajnoczi @ 2012-03-30 10:58 UTC (permalink / raw) To: Anthony Liguori; +Cc: qemu-devel, Stefan Hajnoczi The latest tracing fixes. Alon Levy (2): Makefile.target: code stp dependency on trace-events tracetool: dtrace: handle in and next reserved words Lee Essen (1): tracetool: dtrace disabled-events fix Makefile.target | 2 +- scripts/tracetool | 22 ++++++++++++++++++---- 2 files changed, 19 insertions(+), 5 deletions(-) -- 1.7.9.1 ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [Qemu-devel] [PULL 0/3] Tracing patches 2012-03-30 10:58 Stefan Hajnoczi @ 2012-04-02 15:52 ` Anthony Liguori 0 siblings, 0 replies; 17+ messages in thread From: Anthony Liguori @ 2012-04-02 15:52 UTC (permalink / raw) To: Stefan Hajnoczi; +Cc: qemu-devel On 03/30/2012 05:58 AM, Stefan Hajnoczi wrote: > The latest tracing fixes. > > Alon Levy (2): > Makefile.target: code stp dependency on trace-events > tracetool: dtrace: handle in and next reserved words > > Lee Essen (1): > tracetool: dtrace disabled-events fix Pulled. Thanks. Regards, Anthony Liguori > > Makefile.target | 2 +- > scripts/tracetool | 22 ++++++++++++++++++---- > 2 files changed, 19 insertions(+), 5 deletions(-) > ^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2019-09-19 13:55 UTC | newest] Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-02-19 16:19 [Qemu-devel] [PULL 0/3] Tracing patches Stefan Hajnoczi 2018-02-19 16:19 ` [Qemu-devel] [PULL 1/3] tracetool: Update argument format regex to non-greedy star Stefan Hajnoczi 2018-02-19 16:19 ` [Qemu-devel] [PULL 2/3] tracetool: For ust trace bool type as ctf_integer Stefan Hajnoczi 2018-02-19 16:19 ` [Qemu-devel] [PULL 3/3] trace: avoid SystemTap "char const" warnings Stefan Hajnoczi 2018-02-19 18:40 ` [Qemu-devel] [PULL 0/3] Tracing patches Peter Maydell -- strict thread matches above, loose matches on Subject: below -- 2019-09-18 13:21 Stefan Hajnoczi 2019-09-19 13:37 ` Peter Maydell 2018-01-29 16:07 Stefan Hajnoczi 2018-01-29 16:14 ` no-reply 2018-01-30 11:58 ` Stefan Hajnoczi 2018-01-30 10:50 ` Peter Maydell 2017-03-16 7:04 Stefan Hajnoczi 2017-03-16 15:31 ` Peter Maydell 2016-09-05 19:42 Stefan Hajnoczi 2016-09-06 12:32 ` Peter Maydell 2012-03-30 10:58 Stefan Hajnoczi 2012-04-02 15:52 ` Anthony Liguori
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.