From: Rob Herring <robh@kernel.org> To: Andreas Kemnade <andreas@kemnade.info> Cc: Marco Felsch <m.felsch@pengutronix.de>, mark.rutland@arm.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, manivannan.sadhasivam@linaro.org, andrew.smirnov@gmail.com, marex@denx.de, angus@akkea.ca, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, j.neuschaefer@gmx.net, Discussions about the Letux Kernel <letux-kernel@openphoenux.org> Subject: Re: [PATCH v3 2/3] ARM: dts: add Netronix E60K02 board common file Date: Fri, 11 Oct 2019 09:29:27 -0500 [thread overview] Message-ID: <20191011142927.GA11490@bogus> (raw) In-Reply-To: <20191011094148.1376430e@aktux> On Fri, Oct 11, 2019 at 09:41:48AM +0200, Andreas Kemnade wrote: > On Fri, 11 Oct 2019 08:56:09 +0200 > Marco Felsch <m.felsch@pengutronix.de> wrote: > > > Hi Andreas, > > > > On 19-10-10 21:23, Andreas Kemnade wrote: > > > The Netronix board E60K02 can be found some several Ebook-Readers, > > > at least the Kobo Clara HD and the Tolino Shine 3. The board > > > is equipped with different SoCs requiring different pinmuxes. > > > > > > For now the following peripherals are included: > > > - LED > > > - Power Key > > > - Cover (gpio via hall sensor) > > > - RC5T619 PMIC (the kernel misses support for rtc and charger > > > subdevices). > > > - Backlight via lm3630a > > > - Wifi sdio chip detection (mmc-powerseq and stuff) > > > > > > It is based on vendor kernel but heavily reworked due to many > > > changed bindings. > > > > > > Signed-off-by: Andreas Kemnade <andreas@kemnade.info> > > > --- > > > Changes in v3: > > > - better led name > > > - correct memory size > > > - comments about missing devices > > > > > > Changes in v2: > > > - reordered, was 1/3 > > > - moved pinmuxes to their actual users, not the parents > > > of them > > > - removed some already-disabled stuff > > > - minor cleanups > > > > You won't change the muxing, so a this dtsi can be self contained? > > > So you want me to put a big > #if defined(MX6SLL) Not sure what the comment meant, but no, don't do this. C defines in dts files are for symbolic names for numbers and assembling bitfields and that's it. > [...] > pinctrl_i2c1: i2c1grp { > fsl,pins = < > MX6SLL_PAD_I2C1_SCL__I2C1_SCL 0x4001f8b1 > MX6SLL_PAD_I2C1_SDA__I2C1_SDA 0x4001f8b1 > >; > }; > > #elif (MX6SL) > [...] > pinctrl_i2c1: i2c1grp { > fsl,pins = < > MX6SL_PAD_I2C1_SCL__I2C1_SCL 0x4001f8b1 > MX6SL_PAD_I2C1_SDA__I2C1_SDA 0x4001f8b1 > >; > }; > > #endif > in the dtsi? > > Regards, > Andreas
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org> To: Andreas Kemnade <andreas@kemnade.info> Cc: mark.rutland@arm.com, marex@denx.de, devicetree@vger.kernel.org, andrew.smirnov@gmail.com, shawnguo@kernel.org, s.hauer@pengutronix.de, angus@akkea.ca, Marco Felsch <m.felsch@pengutronix.de>, linux-kernel@vger.kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, manivannan.sadhasivam@linaro.org, j.neuschaefer@gmx.net, Discussions about the Letux Kernel <letux-kernel@openphoenux.org>, festevam@gmail.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 2/3] ARM: dts: add Netronix E60K02 board common file Date: Fri, 11 Oct 2019 09:29:27 -0500 [thread overview] Message-ID: <20191011142927.GA11490@bogus> (raw) In-Reply-To: <20191011094148.1376430e@aktux> On Fri, Oct 11, 2019 at 09:41:48AM +0200, Andreas Kemnade wrote: > On Fri, 11 Oct 2019 08:56:09 +0200 > Marco Felsch <m.felsch@pengutronix.de> wrote: > > > Hi Andreas, > > > > On 19-10-10 21:23, Andreas Kemnade wrote: > > > The Netronix board E60K02 can be found some several Ebook-Readers, > > > at least the Kobo Clara HD and the Tolino Shine 3. The board > > > is equipped with different SoCs requiring different pinmuxes. > > > > > > For now the following peripherals are included: > > > - LED > > > - Power Key > > > - Cover (gpio via hall sensor) > > > - RC5T619 PMIC (the kernel misses support for rtc and charger > > > subdevices). > > > - Backlight via lm3630a > > > - Wifi sdio chip detection (mmc-powerseq and stuff) > > > > > > It is based on vendor kernel but heavily reworked due to many > > > changed bindings. > > > > > > Signed-off-by: Andreas Kemnade <andreas@kemnade.info> > > > --- > > > Changes in v3: > > > - better led name > > > - correct memory size > > > - comments about missing devices > > > > > > Changes in v2: > > > - reordered, was 1/3 > > > - moved pinmuxes to their actual users, not the parents > > > of them > > > - removed some already-disabled stuff > > > - minor cleanups > > > > You won't change the muxing, so a this dtsi can be self contained? > > > So you want me to put a big > #if defined(MX6SLL) Not sure what the comment meant, but no, don't do this. C defines in dts files are for symbolic names for numbers and assembling bitfields and that's it. > [...] > pinctrl_i2c1: i2c1grp { > fsl,pins = < > MX6SLL_PAD_I2C1_SCL__I2C1_SCL 0x4001f8b1 > MX6SLL_PAD_I2C1_SDA__I2C1_SDA 0x4001f8b1 > >; > }; > > #elif (MX6SL) > [...] > pinctrl_i2c1: i2c1grp { > fsl,pins = < > MX6SL_PAD_I2C1_SCL__I2C1_SCL 0x4001f8b1 > MX6SL_PAD_I2C1_SDA__I2C1_SDA 0x4001f8b1 > >; > }; > > #endif > in the dtsi? > > Regards, > Andreas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-11 14:29 UTC|newest] Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-10-10 19:23 [PATCH v3 0/3] dts: ARM: add Kobo Clara HD eBook reader Andreas Kemnade 2019-10-10 19:23 ` Andreas Kemnade 2019-10-10 19:23 ` Andreas Kemnade 2019-10-10 19:23 ` [PATCH v3 1/3] dt-bindings: arm: fsl: add compatible string for Kobo Clara HD Andreas Kemnade 2019-10-10 19:23 ` Andreas Kemnade 2019-10-10 19:23 ` Andreas Kemnade 2019-10-11 14:29 ` Rob Herring 2019-10-11 14:29 ` Rob Herring 2019-10-11 14:29 ` Rob Herring 2019-10-10 19:23 ` [PATCH v3 2/3] ARM: dts: add Netronix E60K02 board common file Andreas Kemnade 2019-10-10 19:23 ` Andreas Kemnade 2019-10-10 19:23 ` Andreas Kemnade 2019-10-11 6:56 ` Marco Felsch 2019-10-11 6:56 ` Marco Felsch 2019-10-11 6:56 ` Marco Felsch 2019-10-11 7:41 ` Andreas Kemnade 2019-10-11 7:41 ` Andreas Kemnade 2019-10-11 7:41 ` Andreas Kemnade 2019-10-11 14:29 ` Rob Herring [this message] 2019-10-11 14:29 ` Rob Herring 2019-10-11 14:29 ` Rob Herring 2019-10-11 15:05 ` Andreas Kemnade 2019-10-11 15:05 ` Andreas Kemnade 2019-10-11 15:05 ` Andreas Kemnade 2019-10-11 15:22 ` Marco Felsch 2019-10-11 15:22 ` Marco Felsch 2019-10-11 15:22 ` Marco Felsch 2019-10-11 16:19 ` Andreas Kemnade 2019-10-11 16:19 ` Andreas Kemnade 2019-10-11 16:19 ` Andreas Kemnade 2019-10-11 16:56 ` Marco Felsch 2019-10-11 16:56 ` Marco Felsch 2019-10-11 16:56 ` Marco Felsch 2019-10-13 15:56 ` Andreas Kemnade 2019-10-13 15:56 ` Andreas Kemnade 2019-10-13 15:56 ` Andreas Kemnade 2019-10-25 9:14 ` Shawn Guo 2019-10-25 9:14 ` Shawn Guo 2019-10-25 10:09 ` Andreas Kemnade 2019-10-25 10:09 ` Andreas Kemnade 2019-10-25 13:06 ` Shawn Guo 2019-10-25 13:06 ` Shawn Guo 2019-10-10 19:23 ` [PATCH v3 3/3] ARM: dts: imx: add devicetree for Kobo Clara HD Andreas Kemnade 2019-10-10 19:23 ` Andreas Kemnade 2019-10-10 19:23 ` Andreas Kemnade 2019-10-25 13:46 ` Shawn Guo 2019-10-25 13:46 ` Shawn Guo 2019-10-25 18:07 ` Andreas Kemnade 2019-10-25 18:07 ` Andreas Kemnade 2019-10-26 8:12 ` Shawn Guo 2019-10-26 8:12 ` Shawn Guo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191011142927.GA11490@bogus \ --to=robh@kernel.org \ --cc=andreas@kemnade.info \ --cc=andrew.smirnov@gmail.com \ --cc=angus@akkea.ca \ --cc=devicetree@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=j.neuschaefer@gmx.net \ --cc=kernel@pengutronix.de \ --cc=letux-kernel@openphoenux.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=m.felsch@pengutronix.de \ --cc=manivannan.sadhasivam@linaro.org \ --cc=marex@denx.de \ --cc=mark.rutland@arm.com \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.