From: Andreas Kemnade <andreas@kemnade.info> To: Shawn Guo <shawnguo@kernel.org> Cc: robh+dt@kernel.org, mark.rutland@arm.com, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, manivannan.sadhasivam@linaro.org, andrew.smirnov@gmail.com, marex@denx.de, angus@akkea.ca, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, j.neuschaefer@gmx.net, Discussions about the Letux Kernel <letux-kernel@openphoenux.org>, Marco Felsch <m.felsch@pengutronix.de> Subject: Re: [PATCH v3 3/3] ARM: dts: imx: add devicetree for Kobo Clara HD Date: Fri, 25 Oct 2019 20:07:43 +0200 [thread overview] Message-ID: <20191025200743.48455cc9@aktux> (raw) In-Reply-To: <20191025134621.GN3208@dragon> Hi, On Fri, 25 Oct 2019 21:46:24 +0800 Shawn Guo <shawnguo@kernel.org> wrote: [...] > > + > > + pinctrl_wifi_reset: wifi_reset_grp { > > + fsl,pins = < > > + MX6SLL_PAD_SD2_DATA7__GPIO5_IO00 0x10059 /* WIFI_RST */ > > + >; > > + }; > > + > > + pinctrl_wifi_power: wifi_power_grp { > > I guess you can have one pinctrl node to include both reset and power > pins? Also, to be consistent with other pinctrl nodes on naming, the > node name should probably be wifigrp. > well, the problems they are used in different nodes, so I cannot do that: reg_wifi: regulator-wifi { compatible = "regulator-fixed"; pinctrl-names = "default"; pinctrl-0 = <&pinctrl_wifi_power>; regulator-name = "SD3_SPWR"; regulator-min-microvolt = <3000000>; regulator-max-microvolt = <3000000>; gpio = <&gpio4 29 GPIO_ACTIVE_HIGH>; enable-active-high; }; wifi_pwrseq: wifi_pwrseq { compatible = "mmc-pwrseq-simple"; pinctrl-names = "default"; pinctrl-0 = <&pinctrl_wifi_reset>; post-power-on-delay-ms = <20>; reset-gpios = <&gpio5 0 GPIO_ACTIVE_LOW>; }; So having them combined breaks the mux where you use it rule. I got in earlier mails: > > + wifi_pwrseq: wifi_pwrseq { > > + compatible = "mmc-pwrseq-simple"; > > + post-power-on-delay-ms = <20>; > > + reset-gpios = <&gpio5 0 GPIO_ACTIVE_LOW>; > Can you add a pinctrl-entry here please? The general rule is to mux > things where you use it [...] > > + compatible = "regulator-fixed"; > > + regulator-name = "SD3_SPWR"; > > + regulator-min-microvolt = <3000000>; > > + regulator-max-microvolt = <3000000>; > > + > > + gpio = <&gpio4 29 GPIO_ACTIVE_HIGH>; > Please add a pinctrl here to mux this gpio. Regards, Andreas
WARNING: multiple messages have this Message-ID (diff)
From: Andreas Kemnade <andreas@kemnade.info> To: Shawn Guo <shawnguo@kernel.org> Cc: mark.rutland@arm.com, marex@denx.de, Marco Felsch <m.felsch@pengutronix.de>, devicetree@vger.kernel.org, andrew.smirnov@gmail.com, s.hauer@pengutronix.de, angus@akkea.ca, linux-kernel@vger.kernel.org, j.neuschaefer@gmx.net, robh+dt@kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, manivannan.sadhasivam@linaro.org, Discussions about the Letux Kernel <letux-kernel@openphoenux.org>, festevam@gmail.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 3/3] ARM: dts: imx: add devicetree for Kobo Clara HD Date: Fri, 25 Oct 2019 20:07:43 +0200 [thread overview] Message-ID: <20191025200743.48455cc9@aktux> (raw) In-Reply-To: <20191025134621.GN3208@dragon> Hi, On Fri, 25 Oct 2019 21:46:24 +0800 Shawn Guo <shawnguo@kernel.org> wrote: [...] > > + > > + pinctrl_wifi_reset: wifi_reset_grp { > > + fsl,pins = < > > + MX6SLL_PAD_SD2_DATA7__GPIO5_IO00 0x10059 /* WIFI_RST */ > > + >; > > + }; > > + > > + pinctrl_wifi_power: wifi_power_grp { > > I guess you can have one pinctrl node to include both reset and power > pins? Also, to be consistent with other pinctrl nodes on naming, the > node name should probably be wifigrp. > well, the problems they are used in different nodes, so I cannot do that: reg_wifi: regulator-wifi { compatible = "regulator-fixed"; pinctrl-names = "default"; pinctrl-0 = <&pinctrl_wifi_power>; regulator-name = "SD3_SPWR"; regulator-min-microvolt = <3000000>; regulator-max-microvolt = <3000000>; gpio = <&gpio4 29 GPIO_ACTIVE_HIGH>; enable-active-high; }; wifi_pwrseq: wifi_pwrseq { compatible = "mmc-pwrseq-simple"; pinctrl-names = "default"; pinctrl-0 = <&pinctrl_wifi_reset>; post-power-on-delay-ms = <20>; reset-gpios = <&gpio5 0 GPIO_ACTIVE_LOW>; }; So having them combined breaks the mux where you use it rule. I got in earlier mails: > > + wifi_pwrseq: wifi_pwrseq { > > + compatible = "mmc-pwrseq-simple"; > > + post-power-on-delay-ms = <20>; > > + reset-gpios = <&gpio5 0 GPIO_ACTIVE_LOW>; > Can you add a pinctrl-entry here please? The general rule is to mux > things where you use it [...] > > + compatible = "regulator-fixed"; > > + regulator-name = "SD3_SPWR"; > > + regulator-min-microvolt = <3000000>; > > + regulator-max-microvolt = <3000000>; > > + > > + gpio = <&gpio4 29 GPIO_ACTIVE_HIGH>; > Please add a pinctrl here to mux this gpio. Regards, Andreas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-25 18:10 UTC|newest] Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-10-10 19:23 [PATCH v3 0/3] dts: ARM: add Kobo Clara HD eBook reader Andreas Kemnade 2019-10-10 19:23 ` Andreas Kemnade 2019-10-10 19:23 ` Andreas Kemnade 2019-10-10 19:23 ` [PATCH v3 1/3] dt-bindings: arm: fsl: add compatible string for Kobo Clara HD Andreas Kemnade 2019-10-10 19:23 ` Andreas Kemnade 2019-10-10 19:23 ` Andreas Kemnade 2019-10-11 14:29 ` Rob Herring 2019-10-11 14:29 ` Rob Herring 2019-10-11 14:29 ` Rob Herring 2019-10-10 19:23 ` [PATCH v3 2/3] ARM: dts: add Netronix E60K02 board common file Andreas Kemnade 2019-10-10 19:23 ` Andreas Kemnade 2019-10-10 19:23 ` Andreas Kemnade 2019-10-11 6:56 ` Marco Felsch 2019-10-11 6:56 ` Marco Felsch 2019-10-11 6:56 ` Marco Felsch 2019-10-11 7:41 ` Andreas Kemnade 2019-10-11 7:41 ` Andreas Kemnade 2019-10-11 7:41 ` Andreas Kemnade 2019-10-11 14:29 ` Rob Herring 2019-10-11 14:29 ` Rob Herring 2019-10-11 14:29 ` Rob Herring 2019-10-11 15:05 ` Andreas Kemnade 2019-10-11 15:05 ` Andreas Kemnade 2019-10-11 15:05 ` Andreas Kemnade 2019-10-11 15:22 ` Marco Felsch 2019-10-11 15:22 ` Marco Felsch 2019-10-11 15:22 ` Marco Felsch 2019-10-11 16:19 ` Andreas Kemnade 2019-10-11 16:19 ` Andreas Kemnade 2019-10-11 16:19 ` Andreas Kemnade 2019-10-11 16:56 ` Marco Felsch 2019-10-11 16:56 ` Marco Felsch 2019-10-11 16:56 ` Marco Felsch 2019-10-13 15:56 ` Andreas Kemnade 2019-10-13 15:56 ` Andreas Kemnade 2019-10-13 15:56 ` Andreas Kemnade 2019-10-25 9:14 ` Shawn Guo 2019-10-25 9:14 ` Shawn Guo 2019-10-25 10:09 ` Andreas Kemnade 2019-10-25 10:09 ` Andreas Kemnade 2019-10-25 13:06 ` Shawn Guo 2019-10-25 13:06 ` Shawn Guo 2019-10-10 19:23 ` [PATCH v3 3/3] ARM: dts: imx: add devicetree for Kobo Clara HD Andreas Kemnade 2019-10-10 19:23 ` Andreas Kemnade 2019-10-10 19:23 ` Andreas Kemnade 2019-10-25 13:46 ` Shawn Guo 2019-10-25 13:46 ` Shawn Guo 2019-10-25 18:07 ` Andreas Kemnade [this message] 2019-10-25 18:07 ` Andreas Kemnade 2019-10-26 8:12 ` Shawn Guo 2019-10-26 8:12 ` Shawn Guo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191025200743.48455cc9@aktux \ --to=andreas@kemnade.info \ --cc=andrew.smirnov@gmail.com \ --cc=angus@akkea.ca \ --cc=devicetree@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=j.neuschaefer@gmx.net \ --cc=kernel@pengutronix.de \ --cc=letux-kernel@openphoenux.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=m.felsch@pengutronix.de \ --cc=manivannan.sadhasivam@linaro.org \ --cc=marex@denx.de \ --cc=mark.rutland@arm.com \ --cc=robh+dt@kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.