* [PATCH] drm/scdc: Fix typo in bit definition of SCDC_STATUS_FLAGS @ 2019-10-16 12:33 Patrik Jakobsson 2019-10-22 8:16 ` Jani Nikula 2019-10-22 8:41 ` Thierry Reding 0 siblings, 2 replies; 10+ messages in thread From: Patrik Jakobsson @ 2019-10-16 12:33 UTC (permalink / raw) To: dri-devel Cc: Patrik Jakobsson, Maarten Lankhorst, Maxime Ripard, Sean Paul, David Airlie, Daniel Vetter, linux-kernel Fix typo where bits got compared (x < y) instead of shifted (x << y). Signed-off-by: Patrik Jakobsson <patrik.r.jakobsson@gmail.com> --- include/drm/drm_scdc_helper.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/drm/drm_scdc_helper.h b/include/drm/drm_scdc_helper.h index f92eb2094d6b..6a483533aae4 100644 --- a/include/drm/drm_scdc_helper.h +++ b/include/drm/drm_scdc_helper.h @@ -50,9 +50,9 @@ #define SCDC_READ_REQUEST_ENABLE (1 << 0) #define SCDC_STATUS_FLAGS_0 0x40 -#define SCDC_CH2_LOCK (1 < 3) -#define SCDC_CH1_LOCK (1 < 2) -#define SCDC_CH0_LOCK (1 < 1) +#define SCDC_CH2_LOCK (1 << 3) +#define SCDC_CH1_LOCK (1 << 2) +#define SCDC_CH0_LOCK (1 << 1) #define SCDC_CH_LOCK_MASK (SCDC_CH2_LOCK | SCDC_CH1_LOCK | SCDC_CH0_LOCK) #define SCDC_CLOCK_DETECT (1 << 0) -- 2.23.0 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] drm/scdc: Fix typo in bit definition of SCDC_STATUS_FLAGS 2019-10-16 12:33 [PATCH] drm/scdc: Fix typo in bit definition of SCDC_STATUS_FLAGS Patrik Jakobsson @ 2019-10-22 8:16 ` Jani Nikula 2019-10-22 8:44 ` Thierry Reding 2019-10-22 8:41 ` Thierry Reding 1 sibling, 1 reply; 10+ messages in thread From: Jani Nikula @ 2019-10-22 8:16 UTC (permalink / raw) To: Patrik Jakobsson, dri-devel, Thierry Reding Cc: David Airlie, linux-kernel, Sean Paul On Wed, 16 Oct 2019, Patrik Jakobsson <patrik.r.jakobsson@gmail.com> wrote: > Fix typo where bits got compared (x < y) instead of shifted (x << y). Fixes: 3ad33ae2bc80 ("drm: Add SCDC helpers") Cc: Thierry Reding <treding@nvidia.com> > Signed-off-by: Patrik Jakobsson <patrik.r.jakobsson@gmail.com> > --- > include/drm/drm_scdc_helper.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/include/drm/drm_scdc_helper.h b/include/drm/drm_scdc_helper.h > index f92eb2094d6b..6a483533aae4 100644 > --- a/include/drm/drm_scdc_helper.h > +++ b/include/drm/drm_scdc_helper.h > @@ -50,9 +50,9 @@ > #define SCDC_READ_REQUEST_ENABLE (1 << 0) > > #define SCDC_STATUS_FLAGS_0 0x40 > -#define SCDC_CH2_LOCK (1 < 3) > -#define SCDC_CH1_LOCK (1 < 2) > -#define SCDC_CH0_LOCK (1 < 1) > +#define SCDC_CH2_LOCK (1 << 3) > +#define SCDC_CH1_LOCK (1 << 2) > +#define SCDC_CH0_LOCK (1 << 1) > #define SCDC_CH_LOCK_MASK (SCDC_CH2_LOCK | SCDC_CH1_LOCK | SCDC_CH0_LOCK) > #define SCDC_CLOCK_DETECT (1 << 0) -- Jani Nikula, Intel Open Source Graphics Center ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] drm/scdc: Fix typo in bit definition of SCDC_STATUS_FLAGS 2019-10-22 8:16 ` Jani Nikula @ 2019-10-22 8:44 ` Thierry Reding 0 siblings, 0 replies; 10+ messages in thread From: Thierry Reding @ 2019-10-22 8:44 UTC (permalink / raw) To: Jani Nikula Cc: Patrik Jakobsson, dri-devel, Thierry Reding, David Airlie, Sean Paul, linux-kernel [-- Attachment #1: Type: text/plain, Size: 1538 bytes --] On Tue, Oct 22, 2019 at 11:16:51AM +0300, Jani Nikula wrote: > On Wed, 16 Oct 2019, Patrik Jakobsson <patrik.r.jakobsson@gmail.com> wrote: > > Fix typo where bits got compared (x < y) instead of shifted (x << y). > > Fixes: 3ad33ae2bc80 ("drm: Add SCDC helpers") > Cc: Thierry Reding <treding@nvidia.com> I'm not sure we really need the Fixes: tag here. These defines aren't used anywhere, so technically there's no bug. Thierry > > > Signed-off-by: Patrik Jakobsson <patrik.r.jakobsson@gmail.com> > > --- > > include/drm/drm_scdc_helper.h | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/include/drm/drm_scdc_helper.h b/include/drm/drm_scdc_helper.h > > index f92eb2094d6b..6a483533aae4 100644 > > --- a/include/drm/drm_scdc_helper.h > > +++ b/include/drm/drm_scdc_helper.h > > @@ -50,9 +50,9 @@ > > #define SCDC_READ_REQUEST_ENABLE (1 << 0) > > > > #define SCDC_STATUS_FLAGS_0 0x40 > > -#define SCDC_CH2_LOCK (1 < 3) > > -#define SCDC_CH1_LOCK (1 < 2) > > -#define SCDC_CH0_LOCK (1 < 1) > > +#define SCDC_CH2_LOCK (1 << 3) > > +#define SCDC_CH1_LOCK (1 << 2) > > +#define SCDC_CH0_LOCK (1 << 1) > > #define SCDC_CH_LOCK_MASK (SCDC_CH2_LOCK | SCDC_CH1_LOCK | SCDC_CH0_LOCK) > > #define SCDC_CLOCK_DETECT (1 << 0) > > -- > Jani Nikula, Intel Open Source Graphics Center > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] drm/scdc: Fix typo in bit definition of SCDC_STATUS_FLAGS @ 2019-10-22 8:44 ` Thierry Reding 0 siblings, 0 replies; 10+ messages in thread From: Thierry Reding @ 2019-10-22 8:44 UTC (permalink / raw) To: Jani Nikula Cc: David Airlie, linux-kernel, dri-devel, Thierry Reding, Sean Paul [-- Attachment #1.1: Type: text/plain, Size: 1538 bytes --] On Tue, Oct 22, 2019 at 11:16:51AM +0300, Jani Nikula wrote: > On Wed, 16 Oct 2019, Patrik Jakobsson <patrik.r.jakobsson@gmail.com> wrote: > > Fix typo where bits got compared (x < y) instead of shifted (x << y). > > Fixes: 3ad33ae2bc80 ("drm: Add SCDC helpers") > Cc: Thierry Reding <treding@nvidia.com> I'm not sure we really need the Fixes: tag here. These defines aren't used anywhere, so technically there's no bug. Thierry > > > Signed-off-by: Patrik Jakobsson <patrik.r.jakobsson@gmail.com> > > --- > > include/drm/drm_scdc_helper.h | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/include/drm/drm_scdc_helper.h b/include/drm/drm_scdc_helper.h > > index f92eb2094d6b..6a483533aae4 100644 > > --- a/include/drm/drm_scdc_helper.h > > +++ b/include/drm/drm_scdc_helper.h > > @@ -50,9 +50,9 @@ > > #define SCDC_READ_REQUEST_ENABLE (1 << 0) > > > > #define SCDC_STATUS_FLAGS_0 0x40 > > -#define SCDC_CH2_LOCK (1 < 3) > > -#define SCDC_CH1_LOCK (1 < 2) > > -#define SCDC_CH0_LOCK (1 < 1) > > +#define SCDC_CH2_LOCK (1 << 3) > > +#define SCDC_CH1_LOCK (1 << 2) > > +#define SCDC_CH0_LOCK (1 << 1) > > #define SCDC_CH_LOCK_MASK (SCDC_CH2_LOCK | SCDC_CH1_LOCK | SCDC_CH0_LOCK) > > #define SCDC_CLOCK_DETECT (1 << 0) > > -- > Jani Nikula, Intel Open Source Graphics Center > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] [-- Attachment #2: Type: text/plain, Size: 159 bytes --] _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] drm/scdc: Fix typo in bit definition of SCDC_STATUS_FLAGS 2019-10-22 8:44 ` Thierry Reding (?) @ 2019-10-22 9:51 ` Jani Nikula 2019-10-22 15:53 ` Patrik Jakobsson -1 siblings, 1 reply; 10+ messages in thread From: Jani Nikula @ 2019-10-22 9:51 UTC (permalink / raw) To: Thierry Reding Cc: Patrik Jakobsson, dri-devel, Thierry Reding, David Airlie, Sean Paul, linux-kernel On Tue, 22 Oct 2019, Thierry Reding <thierry.reding@gmail.com> wrote: > On Tue, Oct 22, 2019 at 11:16:51AM +0300, Jani Nikula wrote: >> On Wed, 16 Oct 2019, Patrik Jakobsson <patrik.r.jakobsson@gmail.com> wrote: >> > Fix typo where bits got compared (x < y) instead of shifted (x << y). >> >> Fixes: 3ad33ae2bc80 ("drm: Add SCDC helpers") >> Cc: Thierry Reding <treding@nvidia.com> > > I'm not sure we really need the Fixes: tag here. These defines aren't > used anywhere, so technically there's no bug. Yeah well, I just logged it here as I happened to do the drive-by git blame. BR, Jani. > > Thierry > >> >> > Signed-off-by: Patrik Jakobsson <patrik.r.jakobsson@gmail.com> >> > --- >> > include/drm/drm_scdc_helper.h | 6 +++--- >> > 1 file changed, 3 insertions(+), 3 deletions(-) >> > >> > diff --git a/include/drm/drm_scdc_helper.h b/include/drm/drm_scdc_helper.h >> > index f92eb2094d6b..6a483533aae4 100644 >> > --- a/include/drm/drm_scdc_helper.h >> > +++ b/include/drm/drm_scdc_helper.h >> > @@ -50,9 +50,9 @@ >> > #define SCDC_READ_REQUEST_ENABLE (1 << 0) >> > >> > #define SCDC_STATUS_FLAGS_0 0x40 >> > -#define SCDC_CH2_LOCK (1 < 3) >> > -#define SCDC_CH1_LOCK (1 < 2) >> > -#define SCDC_CH0_LOCK (1 < 1) >> > +#define SCDC_CH2_LOCK (1 << 3) >> > +#define SCDC_CH1_LOCK (1 << 2) >> > +#define SCDC_CH0_LOCK (1 << 1) >> > #define SCDC_CH_LOCK_MASK (SCDC_CH2_LOCK | SCDC_CH1_LOCK | SCDC_CH0_LOCK) >> > #define SCDC_CLOCK_DETECT (1 << 0) >> >> -- >> Jani Nikula, Intel Open Source Graphics Center >> _______________________________________________ >> dri-devel mailing list >> dri-devel@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Jani Nikula, Intel Open Source Graphics Center ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] drm/scdc: Fix typo in bit definition of SCDC_STATUS_FLAGS 2019-10-22 9:51 ` Jani Nikula @ 2019-10-22 15:53 ` Patrik Jakobsson 0 siblings, 0 replies; 10+ messages in thread From: Patrik Jakobsson @ 2019-10-22 15:53 UTC (permalink / raw) To: Jani Nikula Cc: Thierry Reding, dri-devel, Thierry Reding, David Airlie, Sean Paul, linux-kernel On Tue, Oct 22, 2019 at 11:51 AM Jani Nikula <jani.nikula@linux.intel.com> wrote: > > On Tue, 22 Oct 2019, Thierry Reding <thierry.reding@gmail.com> wrote: > > On Tue, Oct 22, 2019 at 11:16:51AM +0300, Jani Nikula wrote: > >> On Wed, 16 Oct 2019, Patrik Jakobsson <patrik.r.jakobsson@gmail.com> wrote: > >> > Fix typo where bits got compared (x < y) instead of shifted (x << y). > >> > >> Fixes: 3ad33ae2bc80 ("drm: Add SCDC helpers") > >> Cc: Thierry Reding <treding@nvidia.com> > > > > I'm not sure we really need the Fixes: tag here. These defines aren't > > used anywhere, so technically there's no bug. > > Yeah well, I just logged it here as I happened to do the drive-by git > blame. I think we can skip the fixes tag here. Thanks for review! Did anyone apply this or can I take it through drm-misc-next? -Patrik > > BR, > Jani. > > > > > > > Thierry > > > >> > >> > Signed-off-by: Patrik Jakobsson <patrik.r.jakobsson@gmail.com> > >> > --- > >> > include/drm/drm_scdc_helper.h | 6 +++--- > >> > 1 file changed, 3 insertions(+), 3 deletions(-) > >> > > >> > diff --git a/include/drm/drm_scdc_helper.h b/include/drm/drm_scdc_helper.h > >> > index f92eb2094d6b..6a483533aae4 100644 > >> > --- a/include/drm/drm_scdc_helper.h > >> > +++ b/include/drm/drm_scdc_helper.h > >> > @@ -50,9 +50,9 @@ > >> > #define SCDC_READ_REQUEST_ENABLE (1 << 0) > >> > > >> > #define SCDC_STATUS_FLAGS_0 0x40 > >> > -#define SCDC_CH2_LOCK (1 < 3) > >> > -#define SCDC_CH1_LOCK (1 < 2) > >> > -#define SCDC_CH0_LOCK (1 < 1) > >> > +#define SCDC_CH2_LOCK (1 << 3) > >> > +#define SCDC_CH1_LOCK (1 << 2) > >> > +#define SCDC_CH0_LOCK (1 << 1) > >> > #define SCDC_CH_LOCK_MASK (SCDC_CH2_LOCK | SCDC_CH1_LOCK | SCDC_CH0_LOCK) > >> > #define SCDC_CLOCK_DETECT (1 << 0) > >> > >> -- > >> Jani Nikula, Intel Open Source Graphics Center > >> _______________________________________________ > >> dri-devel mailing list > >> dri-devel@lists.freedesktop.org > >> https://lists.freedesktop.org/mailman/listinfo/dri-devel > > -- > Jani Nikula, Intel Open Source Graphics Center ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] drm/scdc: Fix typo in bit definition of SCDC_STATUS_FLAGS @ 2019-10-22 15:53 ` Patrik Jakobsson 0 siblings, 0 replies; 10+ messages in thread From: Patrik Jakobsson @ 2019-10-22 15:53 UTC (permalink / raw) To: Jani Nikula Cc: David Airlie, linux-kernel, dri-devel, Thierry Reding, Thierry Reding, Sean Paul On Tue, Oct 22, 2019 at 11:51 AM Jani Nikula <jani.nikula@linux.intel.com> wrote: > > On Tue, 22 Oct 2019, Thierry Reding <thierry.reding@gmail.com> wrote: > > On Tue, Oct 22, 2019 at 11:16:51AM +0300, Jani Nikula wrote: > >> On Wed, 16 Oct 2019, Patrik Jakobsson <patrik.r.jakobsson@gmail.com> wrote: > >> > Fix typo where bits got compared (x < y) instead of shifted (x << y). > >> > >> Fixes: 3ad33ae2bc80 ("drm: Add SCDC helpers") > >> Cc: Thierry Reding <treding@nvidia.com> > > > > I'm not sure we really need the Fixes: tag here. These defines aren't > > used anywhere, so technically there's no bug. > > Yeah well, I just logged it here as I happened to do the drive-by git > blame. I think we can skip the fixes tag here. Thanks for review! Did anyone apply this or can I take it through drm-misc-next? -Patrik > > BR, > Jani. > > > > > > > Thierry > > > >> > >> > Signed-off-by: Patrik Jakobsson <patrik.r.jakobsson@gmail.com> > >> > --- > >> > include/drm/drm_scdc_helper.h | 6 +++--- > >> > 1 file changed, 3 insertions(+), 3 deletions(-) > >> > > >> > diff --git a/include/drm/drm_scdc_helper.h b/include/drm/drm_scdc_helper.h > >> > index f92eb2094d6b..6a483533aae4 100644 > >> > --- a/include/drm/drm_scdc_helper.h > >> > +++ b/include/drm/drm_scdc_helper.h > >> > @@ -50,9 +50,9 @@ > >> > #define SCDC_READ_REQUEST_ENABLE (1 << 0) > >> > > >> > #define SCDC_STATUS_FLAGS_0 0x40 > >> > -#define SCDC_CH2_LOCK (1 < 3) > >> > -#define SCDC_CH1_LOCK (1 < 2) > >> > -#define SCDC_CH0_LOCK (1 < 1) > >> > +#define SCDC_CH2_LOCK (1 << 3) > >> > +#define SCDC_CH1_LOCK (1 << 2) > >> > +#define SCDC_CH0_LOCK (1 << 1) > >> > #define SCDC_CH_LOCK_MASK (SCDC_CH2_LOCK | SCDC_CH1_LOCK | SCDC_CH0_LOCK) > >> > #define SCDC_CLOCK_DETECT (1 << 0) > >> > >> -- > >> Jani Nikula, Intel Open Source Graphics Center > >> _______________________________________________ > >> dri-devel mailing list > >> dri-devel@lists.freedesktop.org > >> https://lists.freedesktop.org/mailman/listinfo/dri-devel > > -- > Jani Nikula, Intel Open Source Graphics Center _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] drm/scdc: Fix typo in bit definition of SCDC_STATUS_FLAGS @ 2019-11-04 17:05 ` Patrik Jakobsson 0 siblings, 0 replies; 10+ messages in thread From: Patrik Jakobsson @ 2019-11-04 17:05 UTC (permalink / raw) To: Jani Nikula Cc: Thierry Reding, dri-devel, Thierry Reding, David Airlie, Sean Paul, linux-kernel On Tue, Oct 22, 2019 at 5:53 PM Patrik Jakobsson <patrik.r.jakobsson@gmail.com> wrote: > > On Tue, Oct 22, 2019 at 11:51 AM Jani Nikula > <jani.nikula@linux.intel.com> wrote: > > > > On Tue, 22 Oct 2019, Thierry Reding <thierry.reding@gmail.com> wrote: > > > On Tue, Oct 22, 2019 at 11:16:51AM +0300, Jani Nikula wrote: > > >> On Wed, 16 Oct 2019, Patrik Jakobsson <patrik.r.jakobsson@gmail.com> wrote: > > >> > Fix typo where bits got compared (x < y) instead of shifted (x << y). > > >> > > >> Fixes: 3ad33ae2bc80 ("drm: Add SCDC helpers") > > >> Cc: Thierry Reding <treding@nvidia.com> > > > > > > I'm not sure we really need the Fixes: tag here. These defines aren't > > > used anywhere, so technically there's no bug. > > > > Yeah well, I just logged it here as I happened to do the drive-by git > > blame. > > I think we can skip the fixes tag here. Thanks for review! > > Did anyone apply this or can I take it through drm-misc-next? > > -Patrik Applied to drm-misc-next > > > > > BR, > > Jani. > > > > > > > > > > > > Thierry > > > > > >> > > >> > Signed-off-by: Patrik Jakobsson <patrik.r.jakobsson@gmail.com> > > >> > --- > > >> > include/drm/drm_scdc_helper.h | 6 +++--- > > >> > 1 file changed, 3 insertions(+), 3 deletions(-) > > >> > > > >> > diff --git a/include/drm/drm_scdc_helper.h b/include/drm/drm_scdc_helper.h > > >> > index f92eb2094d6b..6a483533aae4 100644 > > >> > --- a/include/drm/drm_scdc_helper.h > > >> > +++ b/include/drm/drm_scdc_helper.h > > >> > @@ -50,9 +50,9 @@ > > >> > #define SCDC_READ_REQUEST_ENABLE (1 << 0) > > >> > > > >> > #define SCDC_STATUS_FLAGS_0 0x40 > > >> > -#define SCDC_CH2_LOCK (1 < 3) > > >> > -#define SCDC_CH1_LOCK (1 < 2) > > >> > -#define SCDC_CH0_LOCK (1 < 1) > > >> > +#define SCDC_CH2_LOCK (1 << 3) > > >> > +#define SCDC_CH1_LOCK (1 << 2) > > >> > +#define SCDC_CH0_LOCK (1 << 1) > > >> > #define SCDC_CH_LOCK_MASK (SCDC_CH2_LOCK | SCDC_CH1_LOCK | SCDC_CH0_LOCK) > > >> > #define SCDC_CLOCK_DETECT (1 << 0) > > >> > > >> -- > > >> Jani Nikula, Intel Open Source Graphics Center > > >> _______________________________________________ > > >> dri-devel mailing list > > >> dri-devel@lists.freedesktop.org > > >> https://lists.freedesktop.org/mailman/listinfo/dri-devel > > > > -- > > Jani Nikula, Intel Open Source Graphics Center ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] drm/scdc: Fix typo in bit definition of SCDC_STATUS_FLAGS @ 2019-11-04 17:05 ` Patrik Jakobsson 0 siblings, 0 replies; 10+ messages in thread From: Patrik Jakobsson @ 2019-11-04 17:05 UTC (permalink / raw) To: Jani Nikula Cc: David Airlie, linux-kernel, dri-devel, Thierry Reding, Thierry Reding, Sean Paul On Tue, Oct 22, 2019 at 5:53 PM Patrik Jakobsson <patrik.r.jakobsson@gmail.com> wrote: > > On Tue, Oct 22, 2019 at 11:51 AM Jani Nikula > <jani.nikula@linux.intel.com> wrote: > > > > On Tue, 22 Oct 2019, Thierry Reding <thierry.reding@gmail.com> wrote: > > > On Tue, Oct 22, 2019 at 11:16:51AM +0300, Jani Nikula wrote: > > >> On Wed, 16 Oct 2019, Patrik Jakobsson <patrik.r.jakobsson@gmail.com> wrote: > > >> > Fix typo where bits got compared (x < y) instead of shifted (x << y). > > >> > > >> Fixes: 3ad33ae2bc80 ("drm: Add SCDC helpers") > > >> Cc: Thierry Reding <treding@nvidia.com> > > > > > > I'm not sure we really need the Fixes: tag here. These defines aren't > > > used anywhere, so technically there's no bug. > > > > Yeah well, I just logged it here as I happened to do the drive-by git > > blame. > > I think we can skip the fixes tag here. Thanks for review! > > Did anyone apply this or can I take it through drm-misc-next? > > -Patrik Applied to drm-misc-next > > > > > BR, > > Jani. > > > > > > > > > > > > Thierry > > > > > >> > > >> > Signed-off-by: Patrik Jakobsson <patrik.r.jakobsson@gmail.com> > > >> > --- > > >> > include/drm/drm_scdc_helper.h | 6 +++--- > > >> > 1 file changed, 3 insertions(+), 3 deletions(-) > > >> > > > >> > diff --git a/include/drm/drm_scdc_helper.h b/include/drm/drm_scdc_helper.h > > >> > index f92eb2094d6b..6a483533aae4 100644 > > >> > --- a/include/drm/drm_scdc_helper.h > > >> > +++ b/include/drm/drm_scdc_helper.h > > >> > @@ -50,9 +50,9 @@ > > >> > #define SCDC_READ_REQUEST_ENABLE (1 << 0) > > >> > > > >> > #define SCDC_STATUS_FLAGS_0 0x40 > > >> > -#define SCDC_CH2_LOCK (1 < 3) > > >> > -#define SCDC_CH1_LOCK (1 < 2) > > >> > -#define SCDC_CH0_LOCK (1 < 1) > > >> > +#define SCDC_CH2_LOCK (1 << 3) > > >> > +#define SCDC_CH1_LOCK (1 << 2) > > >> > +#define SCDC_CH0_LOCK (1 << 1) > > >> > #define SCDC_CH_LOCK_MASK (SCDC_CH2_LOCK | SCDC_CH1_LOCK | SCDC_CH0_LOCK) > > >> > #define SCDC_CLOCK_DETECT (1 << 0) > > >> > > >> -- > > >> Jani Nikula, Intel Open Source Graphics Center > > >> _______________________________________________ > > >> dri-devel mailing list > > >> dri-devel@lists.freedesktop.org > > >> https://lists.freedesktop.org/mailman/listinfo/dri-devel > > > > -- > > Jani Nikula, Intel Open Source Graphics Center _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] drm/scdc: Fix typo in bit definition of SCDC_STATUS_FLAGS 2019-10-16 12:33 [PATCH] drm/scdc: Fix typo in bit definition of SCDC_STATUS_FLAGS Patrik Jakobsson 2019-10-22 8:16 ` Jani Nikula @ 2019-10-22 8:41 ` Thierry Reding 1 sibling, 0 replies; 10+ messages in thread From: Thierry Reding @ 2019-10-22 8:41 UTC (permalink / raw) To: Patrik Jakobsson; +Cc: dri-devel, David Airlie, linux-kernel, Sean Paul [-- Attachment #1: Type: text/plain, Size: 378 bytes --] On Wed, Oct 16, 2019 at 02:33:42PM +0200, Patrik Jakobsson wrote: > Fix typo where bits got compared (x < y) instead of shifted (x << y). > > Signed-off-by: Patrik Jakobsson <patrik.r.jakobsson@gmail.com> > --- > include/drm/drm_scdc_helper.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Oh my... Reviewed-by: Thierry Reding <treding@nvidia.com> [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2019-11-04 17:05 UTC | newest] Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-10-16 12:33 [PATCH] drm/scdc: Fix typo in bit definition of SCDC_STATUS_FLAGS Patrik Jakobsson 2019-10-22 8:16 ` Jani Nikula 2019-10-22 8:44 ` Thierry Reding 2019-10-22 8:44 ` Thierry Reding 2019-10-22 9:51 ` Jani Nikula 2019-10-22 15:53 ` Patrik Jakobsson 2019-10-22 15:53 ` Patrik Jakobsson 2019-11-04 17:05 ` Patrik Jakobsson 2019-11-04 17:05 ` Patrik Jakobsson 2019-10-22 8:41 ` Thierry Reding
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.