[PATCH] net: phy: smsc: LAN8740: add PHY_RST_AFTER_CLK_EN flag

[PATCH] net: phy: smsc: LAN8740: add PHY_RST_AFTER_CLK_EN flag

[Martin Fuzzey]

The LAN8740, like the 8720, also requires a reset after enabling clock.
The datasheet [1] 3.8.5.1 says:
	"During a Hardware reset, an external clock must be supplied
	to the XTAL1/CLKIN signal."

I have observed this issue on a custom i.MX6 based board with
the LAN8740A.

[1] http://ww1.microchip.com/downloads/en/DeviceDoc/8740a.pdf

Signed-off-by: Martin Fuzzey <martin.fuzzey@flowbird.group>
---
 drivers/net/phy/smsc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/phy/smsc.c b/drivers/net/phy/smsc.c
index dc3d92d..b732982 100644
--- a/drivers/net/phy/smsc.c
+++ b/drivers/net/phy/smsc.c
@@ -327,6 +327,7 @@ static int smsc_phy_probe(struct phy_device *phydev)
 	.name		= "SMSC LAN8740",
 
 	/* PHY_BASIC_FEATURES */
+	.flags		= PHY_RST_AFTER_CLK_EN,
 
 	.probe		= smsc_phy_probe,
 
-- 
1.9.1

Re: [PATCH] net: phy: smsc: LAN8740: add PHY_RST_AFTER_CLK_EN flag

[Andrew Lunn]

On Wed, Oct 23, 2019 at 11:44:24AM +0200, Martin Fuzzey wrote:
> The LAN8740, like the 8720, also requires a reset after enabling clock.
> The datasheet [1] 3.8.5.1 says:
> 	"During a Hardware reset, an external clock must be supplied
> 	to the XTAL1/CLKIN signal."
> 
> I have observed this issue on a custom i.MX6 based board with
> the LAN8740A.
> 
> [1] http://ww1.microchip.com/downloads/en/DeviceDoc/8740a.pdf
> 
> Signed-off-by: Martin Fuzzey <martin.fuzzey@flowbird.group>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

Re: [PATCH] net: phy: smsc: LAN8740: add PHY_RST_AFTER_CLK_EN flag

[David Miller]

From: Martin Fuzzey <martin.fuzzey@flowbird.group>
Date: Wed, 23 Oct 2019 11:44:24 +0200

> The LAN8740, like the 8720, also requires a reset after enabling clock.
> The datasheet [1] 3.8.5.1 says:
> 	"During a Hardware reset, an external clock must be supplied
> 	to the XTAL1/CLKIN signal."
> 
> I have observed this issue on a custom i.MX6 based board with
> the LAN8740A.
> 
> [1] http://ww1.microchip.com/downloads/en/DeviceDoc/8740a.pdf
> 
> Signed-off-by: Martin Fuzzey <martin.fuzzey@flowbird.group>

Applied, thanks.