From: Sergey Matyukevich <geomatsi@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 06/10] boot/arm-trusted-firmware: Add RCW support
Date: Fri, 22 Nov 2019 12:19:51 +0300 [thread overview]
Message-ID: <20191122091951.vrznpltgrwkdmeyx@bars> (raw)
In-Reply-To: <20191121102324.35225-7-jerry.huang@nxp.com>
> diff --git a/boot/arm-trusted-firmware/arm-trusted-firmware.mk b/boot/arm-trusted-firmware/arm-trusted-firmware.mk
> index 2133d39e6d..2bca8109f1 100644
> --- a/boot/arm-trusted-firmware/arm-trusted-firmware.mk
> +++ b/boot/arm-trusted-firmware/arm-trusted-firmware.mk
> @@ -92,6 +92,15 @@ endif
>
> ARM_TRUSTED_FIRMWARE_MAKE_TARGETS = all
>
> +ifeq ($(BR2_PACKAGE_HOST_RCW_ATF),y)
> +RCW_BOOT_MODE = $(call qstrip,$(BR2_PACKAGE_HOST_RCW_BOOT_MODE))
> +RCW_PATH = $(call qstrip,$(BR2_PACKAGE_HOST_RCW_BIN))
> +RCW_FILE = $(lastword $(subst /, ,$(RCW_PATH)))
> +ARM_TRUSTED_FIRMWARE_MAKE_OPTS += BOOT_MODE=$(RCW_BOOT_MODE) RCW=$(BINARIES_DIR)/$(RCW_FILE)
> +ARM_TRUSTED_FIRMWARE_MAKE_TARGETS += pbl
> +ARM_TRUSTED_FIRMWARE_DEPENDENCIES += host-fsl-qoriq-rcw
> +endif
> +
> ifeq ($(BR2_TARGET_ARM_TRUSTED_FIRMWARE_FIP),y)
> ARM_TRUSTED_FIRMWARE_MAKE_TARGETS += fip
> ARM_TRUSTED_FIRMWARE_DEPENDENCIES += host-openssl
Hi Jerry, Thomas, and all
This approach looks reasonable to me: if we enable RCW_ATF in board config,
then arm-trusted-firmware build process is modified in accordance
with that choice.
However I am slightly worried about naming. There was a discussion around the
first version of the patch set regarding too generic name for RCW package.
IIUC here we have the same issue here. Option BR2_PACKAGE_HOST_RCW_ATF
looks fairly generic, but it selects fsl-qoriq specific dependencies.
Thoughts ? Comments ?
Regards,
Sergey
next prev parent reply other threads:[~2019-11-22 9:19 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-21 10:23 [Buildroot] [PATCH v2 0/9] new board ls1028ardb introduced Changming Huang
2019-11-21 10:23 ` [Buildroot] [PATCH v2 01/10] package/freescale-qoriq: new package directory Changming Huang
2019-11-25 21:13 ` Thomas Petazzoni
2019-11-26 2:49 ` [Buildroot] [EXT] " Jerry Huang
2019-11-21 10:23 ` [Buildroot] [PATCH v2 02/10] package/freescale-qoriq/fsl-qoriq-rcw: move rcw into freescale-qoriq and rename it Changming Huang
2019-11-21 10:34 ` Michael Walle
2019-11-21 10:42 ` [Buildroot] [EXT] " Jerry Huang
2019-11-25 21:15 ` [Buildroot] " Thomas Petazzoni
2019-11-26 3:25 ` [Buildroot] [EXT] " Jerry Huang
2019-11-21 10:23 ` [Buildroot] [PATCH v2 03/10] package/freescale-qoriq/fsl-qoriq-rcw: upgrade the rcw version to LSDK-19.09 Changming Huang
2019-11-25 21:17 ` Thomas Petazzoni
2019-11-26 3:51 ` [Buildroot] [EXT] " Jerry Huang
2019-11-21 10:23 ` [Buildroot] [PATCH v2 04/10] package/freescale-qoriq/fsl-qoriq-rcw: add target rcw binary support Changming Huang
2019-11-25 21:23 ` Thomas Petazzoni
2019-11-26 4:33 ` [Buildroot] [EXT] " Jerry Huang
2019-11-21 10:23 ` [Buildroot] [PATCH v2 05/10] boot/arm-trusted-firmware: Add option BR2_TARGET_ARM_TRUSTED_FIRMWARE_UBOOT_BL33_IMAGE Changming Huang
2019-11-22 9:11 ` Sergey Matyukevich
2019-11-22 9:24 ` [Buildroot] [EXT] " Jerry Huang
2019-11-25 21:59 ` [Buildroot] " Thomas Petazzoni
2019-11-21 10:23 ` [Buildroot] [PATCH v2 06/10] boot/arm-trusted-firmware: Add RCW support Changming Huang
2019-11-22 9:19 ` Sergey Matyukevich [this message]
2019-11-22 9:31 ` [Buildroot] [EXT] " Jerry Huang
2019-11-25 22:09 ` [Buildroot] " Thomas Petazzoni
2019-11-26 7:06 ` [Buildroot] [EXT] " Jerry Huang
2019-11-26 7:34 ` Jerry Huang
2019-11-21 10:23 ` [Buildroot] [PATCH v2 07/10] package/freescale-qoriq/fsl-qoriq-cadence-dp-fw: new package Changming Huang
2019-11-21 10:42 ` Michael Walle
2019-11-21 11:04 ` [Buildroot] [EXT] " Jerry Huang
2019-11-22 10:41 ` Jerry Huang
2019-11-21 10:51 ` [Buildroot] " Michael Walle
2019-11-21 11:09 ` [Buildroot] [EXT] " Jerry Huang
2019-11-22 10:40 ` Jerry Huang
2019-11-22 11:00 ` Michael Walle
2019-11-25 2:40 ` Jerry Huang
2019-11-22 11:05 ` Thomas Petazzoni
2019-11-25 6:25 ` Jerry Huang
2019-11-25 22:12 ` [Buildroot] " Thomas Petazzoni
2019-11-26 8:09 ` [Buildroot] [EXT] " Jerry Huang
2019-11-26 9:21 ` Michael Walle
2019-11-26 10:13 ` Jerry Huang
2019-11-26 9:29 ` Michael Walle
2019-11-26 10:12 ` Thomas Petazzoni
2019-11-26 10:31 ` Michael Walle
2019-11-26 12:10 ` Jerry Huang
2019-11-21 10:23 ` [Buildroot] [PATCH v2 08/10] package/freescale-qoriq/fsl-qoriq-rcw:Enable IIC5_PMUX and CLK_OUT_PMUX for GPIO Changming Huang
2019-11-25 22:13 ` Thomas Petazzoni
2019-11-26 8:15 ` [Buildroot] [EXT] " Jerry Huang
2019-11-21 10:23 ` [Buildroot] [PATCH v2 09/10] board/freescale/common/ls: Add standard post image script for Layerscape processors Changming Huang
2019-11-21 10:23 ` [Buildroot] [PATCH v2 10/10] configs/freescale_ls1028ardb*: new board Changming Huang
2019-11-25 22:17 ` Thomas Petazzoni
2019-11-26 12:02 ` [Buildroot] [EXT] " Jerry Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191122091951.vrznpltgrwkdmeyx@bars \
--to=geomatsi@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.