All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: "Clément Péron" <peron.clem@gmail.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
	Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
	Philipp Zabel <pza@pengutronix.de>,
	linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com,
	Jernej Skrabec <jernej.skrabec@siol.net>
Subject: Re: [PATCH v9 5/6] pwm: sun4i: Add support to output source clock directly
Date: Sun, 24 Nov 2019 20:18:16 +0100	[thread overview]
Message-ID: <20191124191816.w5saunvwfhoauj56@pengutronix.de> (raw)
In-Reply-To: <20191124172908.10804-6-peron.clem@gmail.com>

Hello Clément,

On Sun, Nov 24, 2019 at 06:29:07PM +0100, Clément Péron wrote:
> From: Jernej Skrabec <jernej.skrabec@siol.net>
> 
> PWM core has an option to bypass whole logic and output unchanged source
> clock as PWM output. This is achieved by enabling bypass bit.
> 
> Note that when bypass is enabled, no other setting has any meaning, not
> even enable bit.
> 
> This mode of operation is needed to achieve high enough frequency to
> serve as clock source for AC200 chip which is integrated into same
> package as H6 SoC.
> 
> Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
> Signed-off-by: Clément Péron <peron.clem@gmail.com>

This looks fine now,

Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Thanks
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

WARNING: multiple messages have this Message-ID (diff)
From: "Uwe Kleine-König" <u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
To: "Clément Péron" <peron.clem-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Thierry Reding
	<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Maxime Ripard <mripard-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
	Philipp Zabel <pza-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
	linux-pwm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
	Jernej Skrabec <jernej.skrabec-gGgVlfcn5nU@public.gmane.org>
Subject: Re: [PATCH v9 5/6] pwm: sun4i: Add support to output source clock directly
Date: Sun, 24 Nov 2019 20:18:16 +0100	[thread overview]
Message-ID: <20191124191816.w5saunvwfhoauj56@pengutronix.de> (raw)
In-Reply-To: <20191124172908.10804-6-peron.clem-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

Hello Clément,

On Sun, Nov 24, 2019 at 06:29:07PM +0100, Clément Péron wrote:
> From: Jernej Skrabec <jernej.skrabec-gGgVlfcn5nU@public.gmane.org>
> 
> PWM core has an option to bypass whole logic and output unchanged source
> clock as PWM output. This is achieved by enabling bypass bit.
> 
> Note that when bypass is enabled, no other setting has any meaning, not
> even enable bit.
> 
> This mode of operation is needed to achieve high enough frequency to
> serve as clock source for AC200 chip which is integrated into same
> package as H6 SoC.
> 
> Signed-off-by: Jernej Skrabec <jernej.skrabec-gGgVlfcn5nU@public.gmane.org>
> Signed-off-by: Clément Péron <peron.clem-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

This looks fine now,

Reviewed-by: Uwe Kleine-König <u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>

Thanks
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

-- 
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
To view this discussion on the web, visit https://groups.google.com/d/msgid/linux-sunxi/20191124191816.w5saunvwfhoauj56%40pengutronix.de.

WARNING: multiple messages have this Message-ID (diff)
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: "Clément Péron" <peron.clem@gmail.com>
Cc: linux-pwm@vger.kernel.org,
	Jernej Skrabec <jernej.skrabec@siol.net>,
	linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org,
	Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	Philipp Zabel <pza@pengutronix.de>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v9 5/6] pwm: sun4i: Add support to output source clock directly
Date: Sun, 24 Nov 2019 20:18:16 +0100	[thread overview]
Message-ID: <20191124191816.w5saunvwfhoauj56@pengutronix.de> (raw)
In-Reply-To: <20191124172908.10804-6-peron.clem@gmail.com>

Hello Clément,

On Sun, Nov 24, 2019 at 06:29:07PM +0100, Clément Péron wrote:
> From: Jernej Skrabec <jernej.skrabec@siol.net>
> 
> PWM core has an option to bypass whole logic and output unchanged source
> clock as PWM output. This is achieved by enabling bypass bit.
> 
> Note that when bypass is enabled, no other setting has any meaning, not
> even enable bit.
> 
> This mode of operation is needed to achieve high enough frequency to
> serve as clock source for AC200 chip which is integrated into same
> package as H6 SoC.
> 
> Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
> Signed-off-by: Clément Péron <peron.clem@gmail.com>

This looks fine now,

Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Thanks
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-11-24 19:18 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-24 17:29 [PATCH v9 0/6] Add support for H6 PWM Clément Péron
2019-11-24 17:29 ` Clément Péron
2019-11-24 17:29 ` Clément Péron
2019-11-24 17:29 ` [PATCH v9 1/6] pwm: sun4i: Add an optional probe for reset line Clément Péron
2019-11-24 17:29   ` Clément Péron
2019-11-24 17:29   ` Clément Péron
2019-11-24 17:29 ` [PATCH v9 2/6] pwm: sun4i: Prefer "mod" clock to unnamed Clément Péron
2019-11-24 17:29   ` Clément Péron
2019-11-24 17:29   ` Clément Péron
2019-11-24 17:29 ` [PATCH v9 3/6] pwm: sun4i: Add an optional probe for bus clock Clément Péron
2019-11-24 17:29   ` Clément Péron
2019-11-24 17:29   ` Clément Péron
2019-11-24 19:16   ` Uwe Kleine-König
2019-11-24 19:16     ` Uwe Kleine-König
2019-11-24 19:16     ` Uwe Kleine-König
2019-11-24 17:29 ` [PATCH v9 4/6] pwm: sun4i: Always calculate params when applying new parameters Clément Péron
2019-11-24 17:29   ` Clément Péron
2019-11-24 17:29   ` Clément Péron
2019-11-24 17:29 ` [PATCH v9 5/6] pwm: sun4i: Add support to output source clock directly Clément Péron
2019-11-24 17:29   ` Clément Péron
2019-11-24 17:29   ` Clément Péron
2019-11-24 19:18   ` Uwe Kleine-König [this message]
2019-11-24 19:18     ` Uwe Kleine-König
2019-11-24 19:18     ` Uwe Kleine-König
2019-11-24 17:29 ` [PATCH v9 6/6] pwm: sun4i: Add support for H6 PWM Clément Péron
2019-11-24 17:29   ` Clément Péron
2019-11-24 17:29   ` Clément Péron
2020-01-08 10:40 ` [PATCH v9 0/6] " Clément Péron
2020-01-08 10:40   ` Clément Péron
2020-01-08 12:42 ` Thierry Reding
2020-01-08 12:42   ` Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191124191816.w5saunvwfhoauj56@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=jernej.skrabec@siol.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=mripard@kernel.org \
    --cc=peron.clem@gmail.com \
    --cc=pza@pengutronix.de \
    --cc=thierry.reding@gmail.com \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.