[PATCH] sstate.bbclass: use tabs for indentation

[PATCH] sstate.bbclass: use tabs for indentation

[Martin Jansa]

* it's terrible, but this is what oe-core wants and it's better than mixing tabs and spaces in the same function

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 meta/classes/sstate.bbclass | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/meta/classes/sstate.bbclass b/meta/classes/sstate.bbclass
index 14de791c81..18e3492674 100644
--- a/meta/classes/sstate.bbclass
+++ b/meta/classes/sstate.bbclass
@@ -753,13 +753,13 @@ sstate_create_package () {
 		return
 	fi
 
-        mkdir -p `dirname ${SSTATE_PKG}`
+	mkdir -p `dirname ${SSTATE_PKG}`
 	TFILE=`mktemp ${SSTATE_PKG}.XXXXXXXX`
 
-        # Use pigz if available
-        OPT="-czS"
-        if [ -x "$(command -v pigz)" ]; then
-            OPT="-I pigz -cS"
+	# Use pigz if available
+	OPT="-czS"
+	if [ -x "$(command -v pigz)" ]; then
+		OPT="-I pigz -cS"
         fi
 
 	# Need to handle empty directories
-- 
2.20.1

Re: [PATCH] sstate.bbclass: use tabs for indentation

[Jacob Kroon]

On 12/16/19 10:56 AM, Martin Jansa wrote:
> * it's terrible, but this is what oe-core wants and it's better than mixing tabs and spaces in the same function
> 
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> ---
>   meta/classes/sstate.bbclass | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/meta/classes/sstate.bbclass b/meta/classes/sstate.bbclass
> index 14de791c81..18e3492674 100644
> --- a/meta/classes/sstate.bbclass
> +++ b/meta/classes/sstate.bbclass
> @@ -753,13 +753,13 @@ sstate_create_package () {
>   		return
>   	fi
>   
> -        mkdir -p `dirname ${SSTATE_PKG}`
> +	mkdir -p `dirname ${SSTATE_PKG}`
>   	TFILE=`mktemp ${SSTATE_PKG}.XXXXXXXX`
>   
> -        # Use pigz if available
> -        OPT="-czS"
> -        if [ -x "$(command -v pigz)" ]; then
> -            OPT="-I pigz -cS"
> +	# Use pigz if available
> +	OPT="-czS"
> +	if [ -x "$(command -v pigz)" ]; then
> +		OPT="-I pigz -cS"
>           fi
>   

Nice cleanup. Doesn't this final 'fi' still look funky though ?

>   	# Need to handle empty directories
> 

[PATCHv2] sstate.bbclass: use tabs for indentation

[Martin Jansa]

* it's terrible, but this is what oe-core wants and it's better than mixing tabs and spaces in the same function

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 meta/classes/sstate.bbclass | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/meta/classes/sstate.bbclass b/meta/classes/sstate.bbclass
index 14de791c81..6603c6e926 100644
--- a/meta/classes/sstate.bbclass
+++ b/meta/classes/sstate.bbclass
@@ -753,14 +753,14 @@ sstate_create_package () {
 		return
 	fi
 
-        mkdir -p `dirname ${SSTATE_PKG}`
+	mkdir -p `dirname ${SSTATE_PKG}`
 	TFILE=`mktemp ${SSTATE_PKG}.XXXXXXXX`
 
-        # Use pigz if available
-        OPT="-czS"
-        if [ -x "$(command -v pigz)" ]; then
-            OPT="-I pigz -cS"
-        fi
+	# Use pigz if available
+	OPT="-czS"
+	if [ -x "$(command -v pigz)" ]; then
+		OPT="-I pigz -cS"
+	fi
 
 	# Need to handle empty directories
 	if [ "$(ls -A)" ]; then
-- 
2.20.1

Re: [PATCH] sstate.bbclass: use tabs for indentation

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1462 bytes --]

On Mon, Dec 16, 2019 at 11:41:53AM +0100, Jacob Kroon wrote:
> On 12/16/19 10:56 AM, Martin Jansa wrote:
> > * it's terrible, but this is what oe-core wants and it's better than mixing tabs and spaces in the same function
> > 
> > Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> > ---
> >   meta/classes/sstate.bbclass | 10 +++++-----
> >   1 file changed, 5 insertions(+), 5 deletions(-)
> > 
> > diff --git a/meta/classes/sstate.bbclass b/meta/classes/sstate.bbclass
> > index 14de791c81..18e3492674 100644
> > --- a/meta/classes/sstate.bbclass
> > +++ b/meta/classes/sstate.bbclass
> > @@ -753,13 +753,13 @@ sstate_create_package () {
> >   		return
> >   	fi
> > -        mkdir -p `dirname ${SSTATE_PKG}`
> > +	mkdir -p `dirname ${SSTATE_PKG}`
> >   	TFILE=`mktemp ${SSTATE_PKG}.XXXXXXXX`
> > -        # Use pigz if available
> > -        OPT="-czS"
> > -        if [ -x "$(command -v pigz)" ]; then
> > -            OPT="-I pigz -cS"
> > +	# Use pigz if available
> > +	OPT="-czS"
> > +	if [ -x "$(command -v pigz)" ]; then
> > +		OPT="-I pigz -cS"
> >           fi
> 
> Nice cleanup. Doesn't this final 'fi' still look funky though ?

Yes, you're right, it was still using 8 spaces as well. Hard to notice
when the other half of the file commonly uses 8 spaces and the git diff
with mixed tabs and spaces is always a bit ugly.

Sent v2. Thanks for noticing.

> 
> >   	# Need to handle empty directories
> > 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 201 bytes --]